Re: [pve-devel] [PATCH pve-docs v5] update the PCI(e) docs

2023-04-17 Thread Thomas Lamprecht
Am 17/04/2023 um 14:45 schrieb Noel Ullreich: > Sorry for the borked v4's. Those can be ignored. This is the (hopefully) > correctly formatted patch please reply to the series/patch mail that should be ignored due to $problems, not the one fixing it. That way, one that has marked the thread with

Re: [pve-devel] [PATCH pve-manager 1/1] adding missing gettext

2023-04-17 Thread Daniel Koć
Sure: Signed-off-by: Daniel Koć W dniu 17.04.2023 o 14:43, Thomas Lamprecht pisze: Am 16/04/2023 um 05:29 schrieb Daniel Koć: Ok, but is missing your Signed-off-by developer certificate of origin, you can either reply here with the S-o-b line, or resend the patch with it amended to the

Re: [pve-devel] [PATCH pve-docs v5] update the PCI(e) docs

2023-04-17 Thread Noel Ullreich
Sorry for the borked v4's. Those can be ignored. This is the (hopefully) correctly formatted patch On 17-04-2023 14:45, Noel Ullreich wrote: A little update to the PCI(e) docs with the plan of reworking the PCI wiki as well. Along some minor grammar fixes added: * how to check if

[pve-devel] [PATCH pve-docs v5] update the PCI(e) docs

2023-04-17 Thread Noel Ullreich
A little update to the PCI(e) docs with the plan of reworking the PCI wiki as well. Along some minor grammar fixes added: * how to check if kernelmodules are being loaded * how to check which drivers to blacklist * how to add softdeps for module loading * where to find kernel params

Re: [pve-devel] [PATCH pve-manager 1/1] adding missing gettext

2023-04-17 Thread Thomas Lamprecht
Am 16/04/2023 um 05:29 schrieb Daniel Koć: Ok, but is missing your Signed-off-by developer certificate of origin, you can either reply here with the S-o-b line, or resend the patch with it amended to the commit message (in that case please also change the commit subject to start with "ui: "),

[pve-devel] [PATCH pve-docs v4] update the PCI(e) docs

2023-04-17 Thread Noel Ullreich
A little update to the PCI(e) docs with the plan of reworking the PCI wiki as well. Along some minor grammar fixes added: * how to check if kernelmodules are being loaded * how to check which drivers to blacklist * how to add softdeps for module loading * where to find kernel params

[pve-devel] [PATCH pve-docs v4] update the PCI(e) docs

2023-04-17 Thread Noel Ullreich
A little update to the PCI(e) docs with the plan of reworking the PCI wiki as well. Along some minor grammar fixes added: * how to check if kernelmodules are being loaded * how to check which drivers to blacklist * how to add softdeps for module loading * where to find kernel params

[pve-devel] [PATCH manager 2/2] ui: backup restore: validate name

2023-04-17 Thread Fiona Ebner
Use the same validation as the guest creation wizards do to catch errors early, before sending the API request. Signed-off-by: Fiona Ebner --- www/manager6/window/Restore.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js index

[pve-devel] [PATCH manager 1/2] ui: clone: validate name

2023-04-17 Thread Fiona Ebner
As reported in the community forum[0], as opposed to VM/LXC creation, there is no validation for the name in the clone dialog. Use the same validation as the guest creation wizards do to catch errors early, before sending the API request. [0]: https://forum.proxmox.com/threads/125883/#post-549304

[pve-devel] [PATCH manager] fix #4605: drop rsyncable from zstd invocation

2023-04-17 Thread Fabian Grünbichler
it causes severe slow downs on fast disks, and we still have other rsyncable compressors available. it was originally added based on wrong documentation that made the performance impact look a lot smaller than it actually is. Signed-off-by: Fabian Grünbichler --- Notes: IMHO, we can always