Re: [pve-devel] [PATCH v3 manager 1/2] ui: qga: Add option to turn off QGA fs-freeze/-thaw on backup

2023-05-04 Thread Lukas Wagner
Gave this a quick test and reviewed the changes - looks good to me. Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner On 3/23/23 12:02, Christoph Heiss wrote: Adds a default-on checkbox to the QEMU Guest Agent feature selector controlling the 'fs-freeze-on-backup' option. If unchecked, an

[pve-devel] [PATCH qemu-server] fix #3428: cloudinit: add parameter for upgrade on boot

2023-05-04 Thread Leo Nunner
up until now, we did an automatic upgrade after the first boot in our standard cloud-init config. This has been requested to be toggleable several times [1][2]. With this patch, "package_upgrade" is disabled by default, and needs to be enabled manually, diverging from the previous behaviour. [1]

[pve-devel] [PATCH manager] fix #3428: cloud-init: add toggle for automatic upgrades

2023-05-04 Thread Leo Nunner
to control the newly introduced "ciupgrade" config parameter. Signed-off-by: Leo Nunner --- www/manager6/qemu/CloudInit.js | 18 ++ 1 file changed, 18 insertions(+) diff --git a/www/manager6/qemu/CloudInit.js b/www/manager6/qemu/CloudInit.js index 77ff93d4..c9065a84 100644 ---

[pve-devel] [PATCH qemu-server manager] cloudinit: make automatic upgrades toggleable

2023-05-04 Thread Leo Nunner
Until now, we explicitly enabled "package_upgrade" in our generated cloud-init configuration. This has been requested to be changed several times, and it seems like making it toggleable will be the best choice. qemu-server: Leo Nunner (1): fix #3428: cloudinit: add parameter for upgrade on

Re: [pve-devel] [PATCH manager v4 3/6] added Config for Shared Filesystem Directories

2023-05-04 Thread Thomas Lamprecht
Am 04/05/2023 um 10:57 schrieb Dominik Csapak: > On 5/4/23 10:42, Thomas Lamprecht wrote: >> Am 04/05/2023 um 10:31 schrieb Dominik Csapak: >>> On 5/4/23 10:13, Thomas Lamprecht wrote: Am 03/05/2023 um 13:26 schrieb Dominik Csapak: > just a short comment since this series overlaps a bit

Re: [pve-devel] [PATCH manager v4 3/6] added Config for Shared Filesystem Directories

2023-05-04 Thread Dominik Csapak
On 5/4/23 10:42, Thomas Lamprecht wrote: Am 04/05/2023 um 10:31 schrieb Dominik Csapak: On 5/4/23 10:13, Thomas Lamprecht wrote: Am 03/05/2023 um 13:26 schrieb Dominik Csapak: just a short comment since this series overlaps a bit with my cluster resource mapping series (i plan on sending a v4

Re: [pve-devel] [PATCH manager v4 3/6] added Config for Shared Filesystem Directories

2023-05-04 Thread Thomas Lamprecht
Am 04/05/2023 um 10:31 schrieb Dominik Csapak: > On 5/4/23 10:13, Thomas Lamprecht wrote: >> Am 03/05/2023 um 13:26 schrieb Dominik Csapak: >>> just a short comment since this series overlaps a bit with my >>> cluster resource mapping series (i plan on sending a v4 soon). >>> >>> i'd prefer to

Re: [pve-devel] [PATCH qemu-server v4 6/6] feature #1027: virtio-9p & virtio-fs support

2023-05-04 Thread Fabian Grünbichler
On April 25, 2023 12:21 pm, Markus Frank wrote: > adds support for sharing directorys with a guest vm > > virtio-9p can be simply started with qemu 9p is not really maintained anymore upstream AFAIK (only "Odd Fixes"), and had security issues in the past. Is there a good reason for supporting it

Re: [pve-devel] [PATCH manager v4 3/6] added Config for Shared Filesystem Directories

2023-05-04 Thread Dominik Csapak
On 5/4/23 10:13, Thomas Lamprecht wrote: Am 03/05/2023 um 13:26 schrieb Dominik Csapak: just a short comment since this series overlaps a bit with my cluster resource mapping series (i plan on sending a v4 soon). i'd prefer to have the configuration endpoints for mapping bundled in a

Re: [pve-devel] [PATCH access-control v4 2/6] added acls for Shared Files Directories

2023-05-04 Thread Fabian Grünbichler
On April 25, 2023 12:21 pm, Markus Frank wrote: > Signed-off-by: Markus Frank > --- > src/PVE/API2/Directory.pm | 68 +++ this parts seems to be included by accident? ;) > src/PVE/AccessControl.pm | 16 + > src/PVE/RPCEnvironment.pm | 12 ++- >

Re: [pve-devel] [PATCH manager v4 3/6] added Config for Shared Filesystem Directories

2023-05-04 Thread Fabian Grünbichler
see cover letter for high level aspects! On April 25, 2023 12:21 pm, Markus Frank wrote: > and made an API Endpoint for getting, adding and removing > directories to the config. > > Signed-off-by: Markus Frank > --- > PVE/API2/DirConfig.pm | 129 +++ >

Re: [pve-devel] [PATCH docs v4 0/6] feature #1027 virtio-9p/virtio-fs

2023-05-04 Thread Fabian Grünbichler
thanks for working on this! it's a long-standing feature request and implementing it will make quite a few people happy. also sorry for not getting back at you in v2/3 already. there's some high level stuff that I'll reply with here, and then some more concrete feedback on individual patches.

Re: [pve-devel] [PATCH manager v4 3/6] added Config for Shared Filesystem Directories

2023-05-04 Thread Thomas Lamprecht
Am 03/05/2023 um 13:26 schrieb Dominik Csapak: > just a short comment since this series overlaps a bit with my > cluster resource mapping series (i plan on sending a v4 soon). > > i'd prefer to have the configuration endpoints for mapping bundled in a > subdirectory > so instead of /nodes//dirs/

Re: [pve-devel] [PATCH v3 manager 1/2] ui: qga: Add option to turn off QGA fs-freeze/-thaw on backup

2023-05-04 Thread Christoph Heiss
Ping - the API part has been merged before release 7.4 and was thus part of it. This is just the missing puzzle piece so that users can toggle it via the GUI :^) On Thu, Mar 23, 2023 at 12:02:47PM +0100, Christoph Heiss wrote: > Adds a default-on checkbox to the QEMU Guest Agent feature selector