Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

2023-06-01 Thread DERUMIER, Alexandre
Hi, I found an interesting thread on the forum about kvm_pv_unhalt https://forum.proxmox.com/threads/live-migration-between-intel-xeon-and-amd-epyc2-linux-guests.68663/ Sounds good. Please also take a look at the default flag "kvm_pv_unhalt". As I mentioned, it would cause a kernel crash in

[pve-devel] [PATCH proxmox 4/4] apt: tests: add tests for Ceph Quincy repository detection on Bookworm

2023-06-01 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- proxmox-apt/tests/repositories.rs | 30 +++ .../ceph-quincy-bookworm.list | 6 .../ceph-quincy-nosub-bookworm.list | 2 ++ .../sources.list.d/ceph-quincy-bookworm.list | 4 +++

[pve-devel] [PATCH proxmox 1/4] apt: drop older Ceph standard repositories

2023-06-01 Thread Fiona Ebner
On Proxmox VE 8, only Quincy and newer will be supported. Signed-off-by: Fiona Ebner --- proxmox-apt/src/repositories/mod.rs | 4 -- proxmox-apt/src/repositories/standard.rs | 58 proxmox-apt/tests/repositories.rs| 4 -- 3 files changed, 66 deletions(-)

[pve-devel] [PATCH proxmox 3/4] apt: tests: code cleanup to avoid useless vector

2023-06-01 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- proxmox-apt/tests/repositories.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/proxmox-apt/tests/repositories.rs b/proxmox-apt/tests/repositories.rs index 4b3c9de..710e2f7 100644 --- a/proxmox-apt/tests/repositories.rs +++

[pve-devel] [PATCH proxmox 2/4] apt: split Ceph main repository into no-subscription and enterprise

2023-06-01 Thread Fiona Ebner
The old 'main' component stays valid, pointing to no-subscription, which means the is_referenced_repository() check needs a special case for it. It will eventually go away, together with the handles for Quincy. Alternatively, the standard repository's info() could've been changed to return

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

2023-06-01 Thread Fiona Ebner
Am 01.06.23 um 14:02 schrieb Eneko Lacunza: > Hi, > > We have Ryzen 1700, 2600X, 3700 and 5950X machines here, I can test on > them if that helps (please detail tests to perform). > > Thanks > Hi, thank you for the offer. It would be interesting to see if you have any issues with the

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

2023-06-01 Thread Fiona Ebner
Am 01.06.23 um 15:53 schrieb DERUMIER, Alexandre: >>> >>> What AMD CPUs did you try it on? >>> >> epyc v2/v3 with last microcodes >> >> >> does it work with x86-64-v3 ?  (because the other patch of the series >> could autofind the best new model if it's working) > > Looking at linux kernel code,

Re: [pve-devel] [PATCH widget-toolkit 3/3] fix #3892: NetworkEdit: add bridge vids field for bridge_vids

2023-06-01 Thread Thomas Lamprecht
Don't we reuse that on PBS/PMG too, and if is it working there? The commit message isn't excactly telling... ;-) Am 13/04/2023 um 17:10 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > src/node/NetworkEdit.js | 16 > 1 file changed, 16 insertions(+) > > diff

Re: [pve-devel] [PATCH widget-toolkit 2/2] utils: format_size: show negative size as NA

2023-06-01 Thread Thomas Lamprecht
Am 19/04/2023 um 12:34 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > > AFAIK we do not have negative sizes anywhere, and if, it is an > indication that something is wrong. above belongs in the commit message, additionaly some background for why doing this now (i.e., did you

[pve-devel] applied: [PATCH proxmox-widget-toolkit v2 1/1] fix 4551: ui: translate byte unit in `format_size`

2023-06-01 Thread Thomas Lamprecht
Am 06/04/2023 um 13:38 schrieb Noel Ullreich: > Some languages translate byte units like 'GiB' or write them in their > own script. > > By `gettext`ing the units in the `format_size` function, we can > translate the units for (almost) all of the web interface. > > Signed-off-by: Noel Ullreich >

Re: [pve-devel] [PATCH proxmox-widget-toolkit v2 1/1] fix #4551: ui: use gettext on hardcoded byte units

2023-06-01 Thread Thomas Lamprecht
Used wrong tag, this is for manager, not widget-toolkit... Am 06/04/2023 um 13:38 schrieb Noel Ullreich: > Since some languages translate byte units like 'GiB' or write them in their > own script, this patch wraps units in the `gettext` function. > > While most occurrences of byte strings can

[pve-devel] [PATCH v3 container 5/7] migration: only migrate volumes used by the guest

2023-06-01 Thread Aaron Lauterer
When scanning all configured storages for volumes belonging to the container, the migration could easily fail if a storage is not available, but enabled. That storage might not even be used by the container at all. By not doing that and only looking at the disk images referenced in the config, we

[pve-devel] [PATCH v3 container 6/7] migration: fail when aliased volume is detected

2023-06-01 Thread Aaron Lauterer
Aliased volumes (referencing the same volume multiple times) can lead to unexpected behavior in a migration. Therefore, stop the migration in such a case. The check works by comparing the path returned by the storage plugin. This means that we should be able to catch the common situations where

[pve-devel] [PATCH v3 qemu-server 1/7] migration: only migrate disks used by the guest

2023-06-01 Thread Aaron Lauterer
When scanning all configured storages for disk images belonging to the VM, the migration could easily fail if a storage is not available, but enabled. That storage might not even be used by the VM at all. By not doing that and only looking at the disk images referenced in the VM config, we can

[pve-devel] [PATCH v3 qemu-server 2/7] tests: add migration test for pending disk

2023-06-01 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- changes since v2: removed autovivified 'snapshots => {}' test/run_qemu_migrate_tests.pl | 64 ++ 1 file changed, 64 insertions(+) diff --git a/test/run_qemu_migrate_tests.pl b/test/run_qemu_migrate_tests.pl index

[pve-devel] [PATCH v3 qemu-server 4/7] tests: add migration alias check

2023-06-01 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- changes since v2: - changed mock storages and disk images, now there is 'alias-zfs' and 'alias-zfs-2' with the same disk image present to mimick an aliased storage config. test/run_qemu_migrate_tests.pl | 81 -- 1 file changed,

[pve-devel] [PATCH v3 docs 7/7] storage: add hint to avoid storage aliasing

2023-06-01 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- I am happy for suggestions on how to improve the phrasing if it is not clear enough. pvesm.adoc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pvesm.adoc b/pvesm.adoc index 6ade1a4..7e91c50 100644 --- a/pvesm.adoc +++ b/pvesm.adoc @@ -174,6 +174,9 @@

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

2023-06-01 Thread DERUMIER, Alexandre
> > > > What AMD CPUs did you try it on? > > > epyc v2/v3 with last microcodes > > > does it work with x86-64-v3 ?  (because the other patch of the series > could autofind the best new model if it's working) Looking at linux kernel code, they have some quirks based on cpu model number &&

[pve-devel] [PATCH v3 qemu-server 3/7] migration: fail when aliased volume is detected

2023-06-01 Thread Aaron Lauterer
Aliased volids can lead to unexpected behavior in a migration. An aliased volid can happen if we have two storage configurations, pointing to the same place. The resulting 'path' for a disk image will be the same. Therefore, stop the migration in such a case. The check works by comparing the

[pve-devel] [PATCH v3 qemu-server, container, docs 0/7] migration: don't scan all storages, fail on aliases

2023-06-01 Thread Aaron Lauterer
This patch series changes the behavior during guest migrations: Don't scan all storages for potential images belonging to the guest. Only migrate images referenced in the config. This made it necessary to handle pending changes explicitly which had been covered by the storage scan. We also added

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

2023-06-01 Thread Eneko Lacunza via pve-devel
--- Begin Message --- Hi, We have Ryzen 1700, 2600X, 3700 and 5950X machines here, I can test on them if that helps (please detail tests to perform). Thanks El 1/6/23 a las 13:37, DERUMIER, Alexandre escribió: Le jeudi 01 juin 2023 à 11:34 +0200, Fiona Ebner a écrit : Am 22.05.23 um 12:25

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

2023-06-01 Thread DERUMIER, Alexandre
Le jeudi 01 juin 2023 à 11:34 +0200, Fiona Ebner a écrit : > Am 22.05.23 um 12:25 schrieb Alexandre Derumier:> Nahelemn is a 2008 > cpu, so I think it's ok, we are in 2013 ;) > > (and user can disable aes flag in gui too) > > > > That mean than the minimum compatible cpu for v2 is Intel Westmere

Re: [pve-devel] [PATCH v3 qemu-server 1/7] cpuconfig: add new x86-64-vX models

2023-06-01 Thread DERUMIER, Alexandre
Le jeudi 01 juin 2023 à 11:17 +0200, Fiona Ebner a écrit : > Am 31.05.23 um 17:08 schrieb DERUMIER, Alexandre: > > > >   > > > > +my $builtin_models = { > > > > +    'x86-64-v1' => { > > > > +   'reported-model' => 'Opteron_G1', > > > > > > It's unfortunate that we'll report this model and

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

2023-06-01 Thread Fiona Ebner
Am 22.05.23 um 12:25 schrieb Alexandre Derumier:> Nahelemn is a 2008 cpu, so I think it's ok, we are in 2013 ;) > (and user can disable aes flag in gui too) > > That mean than the minimum compatible cpu for v2 is Intel Westmere (2010) > and Amd Bulldozer (2011). > Unfortunately, it doesn't seem

Re: [pve-devel] [PATCH v3 qemu-server 1/7] cpuconfig: add new x86-64-vX models

2023-06-01 Thread Fiona Ebner
Am 31.05.23 um 17:08 schrieb DERUMIER, Alexandre: >>>   >>> +my $builtin_models = { >>> +    'x86-64-v1' => { >>> +   'reported-model' => 'Opteron_G1', >> >> It's unfortunate that we'll report this model and hence also AMD as >> vendor even on Intel hosts and vice versa for the other models.

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

2023-06-01 Thread DERUMIER, Alexandre
Le jeudi 01 juin 2023 à 10:34 +0200, Fiona Ebner a écrit : > Am 31.05.23 um 16:34 schrieb DERUMIER, Alexandre: > > Le mercredi 31 mai 2023 à 13:36 +0200, Fiona Ebner a écrit : > > > Am 22.05.23 um 12:25 schrieb Alexandre Derumier: > > > > In addition to theses model, I have enabled aes too. > > >

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

2023-06-01 Thread Fiona Ebner
Am 31.05.23 um 16:34 schrieb DERUMIER, Alexandre: > Le mercredi 31 mai 2023 à 13:36 +0200, Fiona Ebner a écrit : >> Am 22.05.23 um 12:25 schrieb Alexandre Derumier: >>> In addition to theses model, I have enabled aes too. >>> I think it's really important, because a lot of users use default >>>

[pve-devel] [PATCH pve-manager 1/2] api2: add /guests path

2023-06-01 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2.pm| 6 + PVE/API2/Guests.pm | 55 ++ PVE/API2/Makefile | 1 + 3 files changed, 62 insertions(+) create mode 100644 PVE/API2/Guests.pm diff --git a/PVE/API2.pm b/PVE/API2.pm index

[pve-devel] [PATCH qemu-server 1/1] api2: qemu: add proxyto_callback to find node if not defined

2023-06-01 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.pm | 157 --- 1 file changed, 109 insertions(+), 48 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 587bb22..53df317 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -59,6

[pve-devel] [PATCH-SERIES v2 pve-manager/qemu-server] fix#4689 autofind node with proxyto_callback

2023-06-01 Thread Alexandre Derumier
Hi, Currently, to manage qemu && lxc vms, we always need to specify nodename in uri. This is a problem with automation tools like terraform, where is node is registered in the state of terraform. (That mean, than if we move the vm on another node, terraform don't known it, and try to create

[pve-devel] [PATCH pve-manager 2/2] pvesh: send params to check_proxyto like httpserver

2023-06-01 Thread Alexandre Derumier
Currently only url_params are send to check_proxyto, the behaviour is different than httpserver. for example, so we can't retreive "pvesh create ... --node" param in proxyto_callback Signed-off-by: Alexandre Derumier --- PVE/CLI/pvesh.pm | 13 - 1 file changed, 8 insertions(+), 5