Re: [pve-devel] [PATCH http-server v3 2/2] use proper arrays for array parameter

2023-06-06 Thread Dominik Csapak
for the record (since i forgot to mention it in the commit message): this patch breaks pve-common without the common 1/3 applied since the gui sends arrays when the api expects a '-list' and the api treats '-list' and '-alist' the same with the parameter conversion in common 1/3 this is worked

[pve-devel] applied-series: [PATCH-SERIES qemu-server/storage] improve RBD resize

2023-06-06 Thread Thomas Lamprecht
Am 28/04/2023 um 14:32 schrieb Fiona Ebner: > Make the way the block_resize QMP command is used consistent with > what other block device backed storages like ZFS and LVM(thin) do. > > Avoid the --allow-shrink flag that should never be required in our > code and avoid passing floating point

Re: [pve-devel] [PATCH storage 2/2] rbd: volume resize: avoid passing floating point value to rbd

2023-06-06 Thread Thomas Lamprecht
Am 28/04/2023 um 14:32 schrieb Fiona Ebner: > which causes an error "the argument for option '--size' is invalid". > Just round up to the nearest integer to have at least the requested > size. This is similar to what is done for ZFS with d3e3e5d ("When > resizing a ZFS volume, align size to 1M")

[pve-devel] applied-series: [PATCH manager v2 1/2] ui: storage: backup: refactor extraColumns assignment

2023-06-06 Thread Thomas Lamprecht
Am 25/04/2023 um 09:21 schrieb Dominik Csapak: > makes it easier to add columns, and uses less indentation > > Signed-off-by: Dominik Csapak > --- > new in v2 > www/manager6/storage/BackupView.js | 40 +++--- > 1 file changed, 20 insertions(+), 20 deletions(-) > >

[pve-devel] applied: [PATCH manager] fix #4605: drop rsyncable from zstd invocation

2023-06-06 Thread Thomas Lamprecht
Am 17/04/2023 um 09:04 schrieb Fabian Grünbichler: > it causes severe slow downs on fast disks, and we still have other rsyncable > compressors available. > > it was originally added based on wrong documentation that made the performance > impact look a lot smaller than it actually is. > >

[pve-devel] applied: [PATCH-SERIES ha-manager] avoid rebalance-on-start for newly added already running service

2023-06-06 Thread Thomas Lamprecht
Am 14/04/2023 um 14:38 schrieb Fiona Ebner: > As reported in the community forum[0], the current behavior when > adding an already running service to HA is wrong. If rebalance > selected a different node, the service would be stopped, offline > migrated and started again. Since the

[pve-devel] applied: [PATCH qemu-server] net: Skip and warn of interfaces without bridge

2023-06-06 Thread Thomas Lamprecht
Am 12/04/2023 um 10:45 schrieb Christian Ebner: > Handle and warn about network interfaces which are not attached to > any bridge because the user actively removed it from the VM config. > > Signed-off-by: Christian Ebner > --- > PVE/QemuServer.pm | 4 > 1 file changed, 4 insertions(+) >

[pve-devel] applied-series: [PATCH proxmox-apt 1/2] fallback to Release file for Origin retrieval

2023-06-06 Thread Thomas Lamprecht
Am 12/04/2023 um 09:17 schrieb Fabian Grünbichler: > APT will not store the InRelease file in some cases, and some repositories > might not even have one in the first place. > > Signed-off-by: Fabian Grünbichler > --- > src/repositories/repository.rs | 19 --- > 1 file changed,

[pve-devel] applied: [RFC manager] pveceph: add osd details command

2023-06-06 Thread Thomas Lamprecht
Am 19/12/2022 um 15:46 schrieb Aaron Lauterer: > To provide similar output on the CLI as is possible in the GUI/API > regaring OSD details. > > By default (output-format=text) a more concise output is shown. Using > json or yaml as output format will print all the available data. > > The

[pve-devel] applied: [PATCH pve-container] fix #4457: use bridge mtu if no mtu is defined

2023-06-06 Thread Thomas Lamprecht
Am 11/04/2023 um 14:44 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > src/PVE/LXC.pm | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH qemu 2/2] update reentrancy patches to version in upstream git

2023-06-06 Thread Thomas Lamprecht
Am 06/06/2023 um 10:58 schrieb Fiona Ebner: > The previous version was picked from the mailing list and still had > an object_dynamic_cast call in a hot path, which is avoided with the > version that landed in git. > > Also adds a few more exceptions for devices that need reentrancy. > >

[pve-devel] applied: [PATCH qemu 1/2] update submodule and patches to QEMU 8.0.2

2023-06-06 Thread Thomas Lamprecht
Am 06/06/2023 um 10:58 schrieb Fiona Ebner: > Signed-off-by: Fiona Ebner > --- > ...le-reentrancy-detection-for-script-R.patch | 4 +- > ...39-fix-large_send_mss-divide-by-zero.patch | 72 > ...en-getting-cursor-without-a-console.patch} | 2 +- >

[pve-devel] applied: [PATCH v2 docs] pvesm: mark ZFS level as both

2023-06-06 Thread Thomas Lamprecht
Am 11/04/2023 um 13:04 schrieb Aaron Lauterer: > ZFS can do both, and we do use both, block and file level functionality. > > Signed-off-by: Aaron Lauterer > --- > changes since v1: rephrased the footnote for ZFS > > pvesm.adoc | 39 +-- > 1 file changed, 21

[pve-devel] applied-series: [PATCH-SERIES storage/docs/guest-common/qemu-server/common] Improve and unify documentation of bwlimit parameter

2023-06-06 Thread Thomas Lamprecht
Am 29/03/2023 um 14:34 schrieb Stefan Hanreich: > While looking through our documentation for the bwlimit parameter > I noticed that the descriptions are inconsistent and sometimes > wrong / unclear about the actual unit used for the parameter. This > patch series fixes some inconsistencies and

[pve-devel] applied: [RFC storage] content-dirs: check that all content dirs are pairwise inequal

2023-06-06 Thread Thomas Lamprecht
Am 21/03/2023 um 18:03 schrieb Friedrich Weber: > This prevents strange interactions in case the same content directory > is used for multiple content types. > > Signed-off-by: Friedrich Weber > --- > I guess technically this is a breaking change, as users may have an > iso+vztmpl storage that

Re: [pve-devel] [PATCH manager] close #4513: ui: backup job: add performance tab

2023-06-06 Thread Thomas Lamprecht
stumbled upon this again when checking out old(er) patches without comments, some higher level comments inline. Am 15/03/2023 um 14:24 schrieb Fiona Ebner: > pigz is not exposed, because it only works after manually installing > the pigz package. > > ionice is not exposed, because it only works

[pve-devel] applied-series: [PATCH widget-toolkit/http-server/apiclient 0/4] Set SameSite=Strict on Auth Cookies

2023-06-06 Thread Thomas Lamprecht
Am 15/03/2023 um 17:26 schrieb Max Carrara: > This series sets the `SameSite` attribute of authentication cookies > to `Strict` as per RFC 6265[1]. This prevents browsers from nagging; > for example, FireFox 102.8.0esr would complain in the following manner: > >> Cookie “PVEAuthCookie” does not

[pve-devel] applied: [PATCH manager] ui: fix duplicate references when using multiple DiskStorageSelectors

2023-06-06 Thread Thomas Lamprecht
Am 21/03/2023 um 14:27 schrieb Dominik Csapak: > by removing the references and change the one place where we used > one of the references. > > Signed-off-by: Dominik Csapak > --- > while i tested all places where we have a disk selector > (wizard, clone, efidisk, add hd) i am not super sure i

[pve-devel] applied: [PATCH v2 manager] fix #2641: expose CIFS subdir parameter through GUI

2023-06-06 Thread Thomas Lamprecht
Am 08/02/2023 um 10:05 schrieb Leo Nunner: > makes it possible to optionally set the 'subdir' parameter when adding a > new CIFS storage. > > Signed-off-by: Leo Nunner > --- > Changes from v1: > - use gettext for the Subdirectory label > > www/manager6/storage/CIFSEdit.js | 11 +++

[pve-devel] applied: [PATCH manager] api: nodes: add 'migrateall' to index

2023-06-06 Thread Thomas Lamprecht
Am 29/03/2023 um 13:36 schrieb Fiona Ebner: > Signed-off-by: Fiona Ebner > --- > PVE/API2/Nodes.pm | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] [PATCH v3 pve-manager 1/1] qemu: processor : set x86-64-v2-AES as default cputype for create wizard

2023-06-06 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/qemu/OSDefaults.js | 1 + www/manager6/qemu/OSTypeEdit.js | 1 + 2 files changed, 2 insertions(+) diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js index 5e588a58..58bc76ff 100644 ---

[pve-devel] [PATCH-SERIES v5 qemu-server/manager] add and set x86-64-v2-AES as default model for new vms

2023-06-06 Thread Alexandre Derumier
Hi, we used kvm64 as default cpumodel since the begin of proxmox. (basically, it's like a pentium4 cpu flags). New distros like rhel9 are compiled to use more modern cpu flags. (and windows already use new flags since year, and we already add some extra cpu flags) " In 2020, AMD, Intel, Red

Re: [pve-devel] [PATCH v3 manager] gui: expose content-dirs property in storage edit/create

2023-06-06 Thread Thomas Lamprecht
Am 24/03/2023 um 17:12 schrieb Leo Nunner: > Add a separate tab for the storage edit/create panels to set the > recently introduced "content-dirs" property which overrides the > default directory locations. Analogous to the API implementation, > the tab was added for Directory, CIFS and NFS

[pve-devel] [PATCH v5 qemu-server 1/1] cpuconfig: add new x86-64-vX models

2023-06-06 Thread Alexandre Derumier
https://gitlab.com/x86-psABIs/x86-64-ABI/ https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg01592.html " In 2020, AMD, Intel, Red Hat, and SUSE worked together to define three microarchitecture levels on top of the historical x86-64 baseline: * x86-64:original x86_64 baseline

[pve-devel] applied: [PATCH docs] tree-wide: properly use {pve} instead of PVE

2023-06-06 Thread Thomas Lamprecht
Am 28/03/2023 um 14:03 schrieb Fabian Grünbichler: > where applicable, or expand/replace where it's not a good fit or automatic > expansion doesn't work. > > there are a few more in generated files, those need to be cleaned up > separately. > > Signed-off-by: Fabian Grünbichler > --- > >

[pve-devel] applied: [PATCH docs] network: rephrase corosync and bonds recommendations

2023-06-06 Thread Thomas Lamprecht
Am 24/03/2023 um 14:03 schrieb Aaron Lauterer: > I suspect that the old one seems to be related to multicast traffic and > LACP bonds. > > The link in the comment is dead by now. It seems this is one occasion > where the internet actually forgets as I cannot find the actual message > of that

[pve-devel] applied: [PATCH widget-toolkit 2/3] DateTimeField: Extend and refactor to make field value bindable

2023-06-06 Thread Thomas Lamprecht
Am 23/03/2023 um 15:42 schrieb Christian Ebner: > Extends the date time field so that bindings are updated on value changes. > Also adds a config to disable child components and avoid modification of > current values by cloning the referenced object for min/max value calculation. > >

[pve-devel] applied: [PATCH widget-toolkit 1/3] DateTimeField: fix typo in xtype

2023-06-06 Thread Thomas Lamprecht
Am 23/03/2023 um 15:42 schrieb Christian Ebner: > Signed-off-by: Christian Ebner > --- > src/form/DateTimeField.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, but added the misspelled variant back as alias in a follow-up, that allows us to upgrade the use sites later,

[pve-devel] applied: [PATCH edk2-firmware] add patch to work around older guest kernel bug

2023-06-06 Thread Thomas Lamprecht
nit: a slightly more telling subject could have been something like: backport limiting the phys-bits to 46 for bug in old guest kernel Am 05/06/2023 um 09:43 schrieb Fiona Ebner: > by limiting the phys-bits to 46 instead of 47. On Ubuntu 18.04 with > kernel 4.15, using 47 leads to a strange

[pve-devel] [PATCH v5 09/15] ui: form: add MultiPCISelector

2023-06-06 Thread Dominik Csapak
this is a grid field for selecting multiple pci devices at once, like we need for the mapped pci ui. There we want to be able to select multiple devices such that one gets selected automatically we can select a whole slot here, but that disables selecting the individual functions of that device.

[pve-devel] [PATCH v5 15/15] ui: improve permission handling for hardware

2023-06-06 Thread Dominik Csapak
qemu/HardwareView: with the new Hardware privileges, we want to adapt a few places where we now allow to show the add/edit window with those permissions. form/{PCI,USB}Selector: increase the minHeight property of the PCI/USBSelector, so that the user can see the error message if he has not

[pve-devel] [PATCH v5 07/15] ui: qemu/PCIEdit: rework panel to add a mapped configuration

2023-06-06 Thread Dominik Csapak
reworks the panel to use a controller, so that we can easily add the selector for mapped pci devices shows now a selection between 'raw' and 'mapped' devices, where 'raw' ones work like before, and 'mapped' ones take the values form the hardware map config Signed-off-by: Dominik Csapak ---

[pve-devel] [PATCH qemu-server v5 2/6] enable cluster mapped PCI devices for guests

2023-06-06 Thread Dominik Csapak
this patch allows configuring pci devices that are mapped via cluster resource mapping when the user has 'Resource.Use' on the ACL path '/resource/pci/{ID}' (in addition to the usual required vm config privileges) When given multiple mappings in the config, we use them as alternatives for the

[pve-devel] [PATCH v5 12/15] ui: add ResourceMapTree

2023-06-06 Thread Dominik Csapak
this will be the base class for trees for the individual mapping types, e.g. pci and usb mapping. there are a few things to configure, but the overall code sharing is still significant, and should work out fine for future mapping types Signed-off-by: Dominik Csapak --- www/manager6/Makefile

[pve-devel] [PATCH v5 10/15] ui: add edit window for pci mappings

2023-06-06 Thread Dominik Csapak
This contains the window to edit a PCI mapping for a single host. It is designed to work in 3 modes: * without an id and a nodename: for new mappings * with an id but without nodename: for adding new host mappings to an existing one * with id and nodename: when editing an existing host mapping

[pve-devel] [PATCH qemu-server v5 6/6] add test for mapped pci devices

2023-06-06 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- test/cfg2cmd/q35-linux-hostpci-mapping.conf | 17 .../q35-linux-hostpci-mapping.conf.cmd| 36 test/run_config2command_tests.pl | 82 +++ 3 files changed, 135 insertions(+) create mode 100644

[pve-devel] [PATCH v5 14/15] ui: window/Migrate: allow mapped devices

2023-06-06 Thread Dominik Csapak
if the migration is an offline migration and when the mapping on the target node exists, otherwise not this does not change the behaviour for 'raw' devices in the config those can still be forced to be migrated, like before Signed-off-by: Dominik Csapak --- www/manager6/window/Migrate.js | 50

[pve-devel] [PATCH v5 06/15] ui: form: add USBMapSelector

2023-06-06 Thread Dominik Csapak
similar to PCIMapSelector Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 + www/manager6/form/USBMapSelector.js | 98 + 2 files changed, 99 insertions(+) create mode 100644 www/manager6/form/USBMapSelector.js diff --git

[pve-devel] [PATCH v5 08/15] ui: qemu/USBEdit: add 'mapped' device case

2023-06-06 Thread Dominik Csapak
to be able to select 'mapped' usb devices Signed-off-by: Dominik Csapak --- www/manager6/qemu/USBEdit.js | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/USBEdit.js b/www/manager6/qemu/USBEdit.js index fe51d186..cfcdd31f

[pve-devel] [PATCH v5 01/15] pvesh: fix parameters for proxyto_callback

2023-06-06 Thread Dominik Csapak
in pve-http-server the proxyto_callback always has a complete list of parameters, not only the ones in the url, so adapt the implementation here to do the same Signed-off-by: Dominik Csapak --- PVE/CLI/pvesh.pm | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[pve-devel] [PATCH v5 03/15] ui: parser: add helpers for lists of property strings

2023-06-06 Thread Dominik Csapak
namely the filtering while preserving the original string and general parsing Signed-off-by: Dominik Csapak --- www/manager6/Parser.js | 14 ++ 1 file changed, 14 insertions(+) diff --git a/www/manager6/Parser.js b/www/manager6/Parser.js index c3772d3b..21a12311 100644 ---

[pve-devel] [PATCH v5 04/15] ui: form/USBSelector: make it more flexible with nodename

2023-06-06 Thread Dominik Csapak
similar to the pciselector, make it accept a plain nodename, or no node at all and provide a setNodename function to keep backwards compatibility, also check pveSelNode for the nodename Signed-off-by: Dominik Csapak --- www/manager6/form/USBSelector.js | 32 +++- 1

[pve-devel] [PATCH guest-common v5 1/1] add PCI/USB Mapping configs

2023-06-06 Thread Dominik Csapak
adds a config file for each type of resource (usb/pci) by using a 'map' array propertystring for each node mapping in each mapping we save the path(s) and some other information to detect hardware changes (if possible) like the vendor/device id both configs have custom header parser/formatter to

[pve-devel] [PATCH qemu-server v5 5/6] migration: check for mapped resources

2023-06-06 Thread Dominik Csapak
they can only be migrated to nodes where there exists a mapping and if the migration is done offline Signed-off-by: Dominik Csapak --- PVE/QemuMigrate.pm | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index

[pve-devel] [PATCH v5 13/15] ui: allow configuring pci and usb mapping

2023-06-06 Thread Dominik Csapak
uses the new ResourceMapTree to add the CRUD interfaces for the mappings. We add both of them into a single panel, since the datacenter menu already has many entries, and without a proper summary for the group, we cannot really put them in a category Signed-off-by: Dominik Csapak ---

[pve-devel] [PATCH v5 02/15] api: add resource map api endpoints for PCI and USB

2023-06-06 Thread Dominik Csapak
this adds the typical section config crud API calls for USB and PCI resource mapping to /cluster/resource/{TYPE} the only special thing that this series does is the list call for both has a special 'check-node' parameter that uses the 'proxyto_callback' to reroute the api call to the given node

[pve-devel] [PATCH v5 11/15] ui: add edit window for usb mappings

2023-06-06 Thread Dominik Csapak
very similar to the PCIMapEdit window, but we only ever allow one mapping per host Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 3 +- www/manager6/window/USBMapEdit.js | 216 ++ 2 files changed, 218 insertions(+), 1 deletion(-) create mode

[pve-devel] [PATCH v5 05/15] ui: form: add PCIMapSelector

2023-06-06 Thread Dominik Csapak
akin to the PCISelector, but uses the api for mapped devices Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 + www/manager6/form/PCIMapSelector.js | 112 2 files changed, 113 insertions(+) create mode 100644

[pve-devel] [PATCH access-control v5 1/1] add privileges and paths for cluster resource mapping

2023-06-06 Thread Dominik Csapak
uses the privileges: Mapping.Use Mapping.Modify Mapping.Audit on /mapping/{TYPE}/{id} so that we can assign privileges on resource level this will generate new roles (PVEMappingUser, PVEMappingAdmin, PVEMappingAuditor) note that every user with Permissions.Modify on '/' and propagate can add

[pve-devel] [PATCH qemu-server v5 3/6] check_local_resources: extend for mapped resources

2023-06-06 Thread Dominik Csapak
by adding them to their own list, saving the nodes where they are not allowed, and return those on 'wantarray' so we don't break existing callers that don't expect it. Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm| 43 ++--

[pve-devel] [PATCH access-control/guest-common/qemu-server/manager v5] cluster mapping

2023-06-06 Thread Dominik Csapak
this series aims to add a cluster-wide device mapping for pci and usb devices. so that an admin can configure a device to be availble for migration and configuring for uses that are non-root (the existing pattern can be copied easily for other types, e.g. markus upcoming folder sharing) note that

[pve-devel] [PATCH qemu-server v5 4/6] api: migrate preconditions: use new check_local_resources info

2023-06-06 Thread Dominik Csapak
for offline migration, limit the allowed nodes to the ones where the mapped resources are available Signed-off-by: Dominik Csapak --- PVE/API2/Qemu.pm | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index

[pve-devel] [PATCH qemu-server v5 1/6] enable cluster mapped USB devices for guests

2023-06-06 Thread Dominik Csapak
this patch allows configuring usb devices that are mapped via cluster resource mapping when the user has 'Resource.Use' on the ACL path '/resource/usb/{ID}' (in addition to the usual required vm config privileges) for now, this is only valid if there is exactly one mapping for the host, since we

Re: [pve-devel] [PATCH v4 qemu-server 1/1] cpuconfig: add new x86-64-vX models

2023-06-06 Thread DERUMIER, Alexandre
Le mardi 06 juin 2023 à 14:09 +0200, Fiona Ebner a écrit : > Am 02.06.23 um 12:05 schrieb Alexandre Derumier: > > > > " > > In 2020, AMD, Intel, Red Hat, and SUSE worked together to define > > three microarchitecture levels on top of the historical x86-64 > > baseline: > > > >   * x86-64:   

[pve-devel] [PATCH v3 pve-manager 1/4] api2: network: check permissions for local bridges

2023-06-06 Thread Alexandre Derumier
always check permissions, also when not filtered Signed-off-by: Alexandre Derumier --- PVE/API2/Network.pm | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm index a43579fa..8dc56482 100644 ---

[pve-devel] [PATCH-SERIE pve-access-control/pve-manager/pve-guest-common/qemu-server/pve-network] check permissions on local bridge

2023-06-06 Thread Alexandre Derumier
add vnet/localbridge permissions management Hi, as we has discuted some weeks ago, this patche serie introduce management of acl for vnets && local bridges The permission path is: /sdn/zones// where the local vmbr are in a virtual "localnetwork" zone /sdn/zones/localnetwork/ Vlans

[pve-devel] [PATCH v3 pve-manager 3/4] ui: add vnet permissions panel

2023-06-06 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile| 2 + www/manager6/sdn/Browser.js | 17 +- www/manager6/sdn/VnetACLView.js | 289 +++ www/manager6/sdn/ZoneContentPanel.js | 41 www/manager6/sdn/ZoneContentView.js | 25

[pve-devel] [PATCH v3 qemu-server 1/1] api2: add check_bridge_access for create/update/clone vm

2023-06-06 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.pm | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 587bb22..c290c81 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -23,7 +23,7 @@ use

[pve-devel] [PATCH v2 pve-access-control 3/3] add new SDN.use privilege in PVESDNUser role

2023-06-06 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/AccessControl.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index 6a3d203..326ed5c 100644 --- a/src/PVE/AccessControl.pm +++ b/src/PVE/AccessControl.pm @@ -1131,6 +1131,9 @@ my

[pve-devel] [PATCH pve-guest-common 1/1] helpers : add check_vnet_access

2023-06-06 Thread Alexandre Derumier
if a tag is defined, test if user have a specific access to the vlan (or propagate from full bridge acl or zone) if no tag, test if user have access to full bridge. (if trunks are defined, it need also access to full bridge) Signed-off-by: Alexandre Derumier --- src/PVE/GuestHelpers.pm | 25

[pve-devel] [PATCH pve-network 1/1] get_local_vnets: fix permission path && perm

2023-06-06 Thread Alexandre Derumier
new path is /zones// Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/Network/SDN.pm b/PVE/Network/SDN.pm index b95dd5b..1ad85e5 100644 --- a/PVE/Network/SDN.pm +++ b/PVE/Network/SDN.pm @@ -190,10 +190,10 @@ sub

[pve-devel] [PATCH v3 pve-manager 4/4] ui: add permissions management for "localnetwork" zone

2023-06-06 Thread Alexandre Derumier
add a default virtual zone called 'localnetwork' in the ressource tree, and handle permissions like a true sdn zone (no conflict with true sdn zone is possible, as they have 8 characters max) Signed-off-by: Alexandre Derumier --- www/manager6/sdn/ZoneContentView.js | 27

[pve-devel] [PATCH v2 pve-access-control 2/3] rpcenvironnment: add check_sdn_bridge

2023-06-06 Thread Alexandre Derumier
check if user have access to 1 vlan of the bridge or the bridge itself Signed-off-by: Alexandre Derumier --- src/PVE/RPCEnvironment.pm | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/PVE/RPCEnvironment.pm b/src/PVE/RPCEnvironment.pm index 8586938..e0a101f 100644 ---

[pve-devel] [PATCH v3 pve-manager 2/4] api2: cluster: ressources: add "localnetwork" zone

2023-06-06 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Cluster.pm | 14 ++ 1 file changed, 14 insertions(+) diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm index 2e942368..a7224d7f 100644 --- a/PVE/API2/Cluster.pm +++ b/PVE/API2/Cluster.pm @@ -474,6 +474,20 @@

[pve-devel] [PATCH v2 pve-access-control 1/3] access control: add /sdn/zones/// path

2023-06-06 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/AccessControl.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index 89b7d90..6a3d203 100644 --- a/src/PVE/AccessControl.pm +++ b/src/PVE/AccessControl.pm @@ -1283,7 +1283,8

[pve-devel] [PATCH qemu-server v3 1/1] api: switch agent api call to 'array' type

2023-06-06 Thread Dominik Csapak
we don't want to use the '-alist' formats anymore in favor of real arrays Acked-by: Wolfgang Bumiller Signed-off-by: Dominik Csapak --- PVE/API2/Qemu/Agent.pm | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/PVE/API2/Qemu/Agent.pm b/PVE/API2/Qemu/Agent.pm

[pve-devel] [PATCH guest-common v3 1/1] vzdump: change 'exclude-path' from alist to an array format

2023-06-06 Thread Dominik Csapak
to get rid of the '-alist' format Acked-by: Wolfgang Bumiller Signed-off-by: Dominik Csapak --- src/PVE/VZDump/Common.pm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm index 4b0e8e0..7d3c311 100644 ---

[pve-devel] [PATCH common/http/guest-common/qemu-server v3] schema/config array support

2023-06-06 Thread Dominik Csapak
and removal of the '-alist' format This series aims to implement array support for the api and (section)config and remove the support for the (rarely used) '-alist' formats. currently sending arrays over the api (by sending a parameter multiple times with form-urlencoded) results in the api call

[pve-devel] [PATCH http-server v3 2/2] use proper arrays for array parameter

2023-06-06 Thread Dominik Csapak
since there is no other way to get an array parameter when using x-www-form-urlencoded content type the previous format with \0 separated strings (known as '-alist' format) should not be used anymore (in favor of the now supported arrays) Acked-by: Wolfgang Bumiller Signed-off-by: Dominik

[pve-devel] [PATCH common v3 1/3] JSONSchema: add support for array parameter in api calls, cli and config

2023-06-06 Thread Dominik Csapak
a few things were missing for it to work: * on the cli, we have to get the option as an array if the type is an array * the untainting must be done recursively, otherwise, the regex matching converts an array hash into the string 'ARRAY(0x123412341234)' * JSONSchema::parse_config did not

[pve-devel] [PATCH common v3 2/3] section config: implement array support

2023-06-06 Thread Dominik Csapak
enables section configs in the style of: type: id property value property value2 property value3 can be combined with property strings the provided create and update schema just pass through the array type to the api, so the api call must always contain the complete array

[pve-devel] [PATCH common v3 3/3] JSONSchema: disable '-alist' format

2023-06-06 Thread Dominik Csapak
this should not be needed anymore since we can now use a simple array in the api instead Acked-by: Wolfgang Bumiller Signed-off-by: Dominik Csapak --- src/PVE/JSONSchema.pm | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/PVE/JSONSchema.pm

[pve-devel] [PATCH http-server v3 1/2] proxy request: forward json content type and parameters

2023-06-06 Thread Dominik Csapak
instead of always trying to encode them as x-www-form-urlencoded Acked-by: Wolfgang Bumiller Signed-off-by: Dominik Csapak --- src/PVE/APIServer/AnyEvent.pm | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/PVE/APIServer/AnyEvent.pm

Re: [pve-devel] [PATCH v2 pve-manager 1/1] qemu: processor : set x86-64-v2-AES as default cputype for create wizard

2023-06-06 Thread Fiona Ebner
Am 02.06.23 um 12:05 schrieb Alexandre Derumier: > --- Missing your Signed-off-by > www/manager6/qemu/OSDefaults.js| 1 + > www/manager6/qemu/ProcessorEdit.js | 13 + > 2 files changed, 14 insertions(+) > > diff --git a/www/manager6/qemu/OSDefaults.js

Re: [pve-devel] [PATCH pve-access-control 2/2] rpcenvironnment: add check_sdn_bridge

2023-06-06 Thread Fabian Grünbichler
On June 6, 2023 2:15 pm, DERUMIER, Alexandre wrote: >> > +   # check propagate on bridge itself >> > +   return 1 if $self->check_any($username, $path, $privs, >> > $noerr); >> >> this doesn't actually check propagation though? for that you could >> either: >> - use $self->permissions (it

Re: [pve-devel] [PATCH pve-access-control 2/2] rpcenvironnment: add check_sdn_bridge

2023-06-06 Thread DERUMIER, Alexandre
> > +   # check propagate on bridge itself > > +   return 1 if $self->check_any($username, $path, $privs, > > $noerr); > > this doesn't actually check propagation though? for that you could > either: > - use $self->permissions (it returns the propagate bit) > - query a non-existing vlan

Re: [pve-devel] [PATCH v4 qemu-server 1/1] cpuconfig: add new x86-64-vX models

2023-06-06 Thread Fiona Ebner
Am 02.06.23 um 12:05 schrieb Alexandre Derumier: > https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg01592.html > " > In 2020, AMD, Intel, Red Hat, and SUSE worked together to define > three microarchitecture levels on top of the historical x86-64 > baseline: > > * x86-64:original

Re: [pve-devel] [PATCH common v2 1/3] JSONSchema: add support for array parameter in api calls, cli and config

2023-06-06 Thread Wolfgang Bumiller
On Tue, Jun 06, 2023 at 12:45:57PM +0200, Thomas Lamprecht wrote: > Am 06/06/2023 um 11:41 schrieb Dominik Csapak: > >>>   +my $untaint_recursive; > >> > >> I got flash backs w.r.t. refcount cycles here keeping all variables, and  > >> thus memory > >> inside the body alive forever, don't we need 

Re: [pve-devel] [PATCH common v2 1/3] JSONSchema: add support for array parameter in api calls, cli and config

2023-06-06 Thread Thomas Lamprecht
Am 06/06/2023 um 13:19 schrieb Dominik Csapak: > ---8<--- > use Storable qw(dclone); > > my $normalize; > $normalize = sub {...}; > > my $data = /* create large hash here, with nested data */; > > while(1) { >     my $newdata = dclone($data); >     $newdata = $normalize->($newdata); > } >

Re: [pve-devel] [PATCH common v2 1/3] JSONSchema: add support for array parameter in api calls, cli and config

2023-06-06 Thread Dominik Csapak
On 6/6/23 12:45, Thomas Lamprecht wrote: Am 06/06/2023 um 11:41 schrieb Dominik Csapak:   +my $untaint_recursive; I got flash backs w.r.t. refcount cycles here keeping all variables, and thus  memory inside the body alive forever, don't we need a weaken? E.g., like we had to do in 

Re: [pve-devel] [PATCH common v2 1/3] JSONSchema: add support for array parameter in api calls, cli and config

2023-06-06 Thread Thomas Lamprecht
Am 06/06/2023 um 11:41 schrieb Dominik Csapak: >>>   +my $untaint_recursive; >> >> I got flash backs w.r.t. refcount cycles here keeping all variables, and  >> thus memory >> inside the body alive forever, don't we need a weaken? >> >> E.g., like we had to do in PVE::Status::Graphite's assemble. >

Re: [pve-devel] MooseFS plugin for Proxmox - further work and request for help

2023-06-06 Thread Fabian Grünbichler
> Benjamin via pve-devel hat am 06.06.2023 09:55 > CEST geschrieben: > Hey there! > > So, a while ago I emailed about my MooseFS plugin for Proxmox - > https://github.com/Zorlin/pve-moosefs > > It was in pretty rough shape and didn't work yet. It works now, and allows > you to mount MooseFS

[pve-devel] [PATCH manager 1/2] ui: user view: show tfa lock status

2023-06-06 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- www/manager6/dc/UserView.js | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/www/manager6/dc/UserView.js b/www/manager6/dc/UserView.js index bbfc4f7c..e46ed13e 100644 --- a/www/manager6/dc/UserView.js +++

[pve-devel] [PATCH manager 2/2] ui: user view: add 'Unlock TFA' button

2023-06-06 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- www/manager6/dc/UserView.js | 31 +++ 1 file changed, 31 insertions(+) diff --git a/www/manager6/dc/UserView.js b/www/manager6/dc/UserView.js index e46ed13e..fec45deb 100644 --- a/www/manager6/dc/UserView.js +++

[pve-devel] [PATCH widget-toolkit 2/2] tfa: show 'Locked' in 'Enabled' column if tfa is locked

2023-06-06 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- This one's new. src/panel/TfaView.js | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/panel/TfaView.js b/src/panel/TfaView.js index e7a09a9..58b8a3a 100644 --- a/src/panel/TfaView.js +++ b/src/panel/TfaView.js @@ -67,8

[pve-devel] [PATCH v3 widget-toolkit 1/2] tfa: improve UX for recovery keys and when none are left

2023-06-06 Thread Wolfgang Bumiller
If we get an empty challenge, tell the user to contact an administrator as it means no 2nd factors and no recovery keys are available. Currently if only 1 key was available and it had a high ID, we'd show something like: "Recovery keys available: 9, Warning, less than 4 keys available." Let's

Re: [pve-devel] [PATCH common v2 1/3] JSONSchema: add support for array parameter in api calls, cli and config

2023-06-06 Thread Dominik Csapak
On 6/6/23 11:12, Thomas Lamprecht wrote: Am 06/06/2023 um 10:39 schrieb Dominik Csapak: a few things were missing for it to work: * on the cli, we have to get the option as an array if the type is an array * the untainting must be done recursively, otherwise, the regex matching converts

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

2023-06-06 Thread Fiona Ebner
Am 05.06.23 um 17:20 schrieb Eneko Lacunza: > Hi, > > I'm sorry I could only test for Ryzen 1700, 2600X and 5950X - our 3700X > is offline, pending some upgrades. I hope it will be back again in some > days. > > Tested installation of Debian 11.1.0 ISO with GUI installer upto first > boot to GUI

Re: [pve-devel] [PATCH common v2 1/3] JSONSchema: add support for array parameter in api calls, cli and config

2023-06-06 Thread Thomas Lamprecht
Am 06/06/2023 um 10:39 schrieb Dominik Csapak: > a few things were missing for it to work: > * on the cli, we have to get the option as an array if the type is an > array > * the untainting must be done recursively, otherwise, the regex matching > converts an array hash into the string

[pve-devel] [PATCH qemu 1/2] update submodule and patches to QEMU 8.0.2

2023-06-06 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- ...le-reentrancy-detection-for-script-R.patch | 4 +- ...39-fix-large_send_mss-divide-by-zero.patch | 72 ...en-getting-cursor-without-a-console.patch} | 2 +- ...-Fix-crash-when-executing-HMP-commit.patch | 48 ---

[pve-devel] [PATCH qemu 2/2] update reentrancy patches to version in upstream git

2023-06-06 Thread Fiona Ebner
The previous version was picked from the mailing list and still had an object_dynamic_cast call in a hot path, which is avoided with the version that landed in git. Also adds a few more exceptions for devices that need reentrancy. Signed-off-by: Fiona Ebner ---

[pve-devel] applied: [PATCH pve-network 0/6] sdn multiples fixes

2023-06-06 Thread Thomas Lamprecht
Am 20/04/2023 um 23:36 schrieb Alexandre Derumier: > This is a resend of the 4 last patches for pve-network > + 2 new patches > > > Alexandre Derumier (6): > fix #4657 : evpn: fix exit-node with multiple vrf > fix #4425: vxlan|evpn: add vxlan-port option > fix #4662 : frr: fix config

[pve-devel] applied: [PATCH frr 0/4] update to 8.5.1

2023-06-06 Thread Thomas Lamprecht
Am 23/05/2023 um 08:08 schrieb Alexandre Derumier: > Hi, > > This patch serie update frr to 8.5.1. > (mirror need to be update to 8.5.1 tag > https://github.com/FRRouting/frr/tree/frr-8.5.1) > > I have removed old upstreamed patches, and added 2 importants evpn > patches released just after

[pve-devel] applied: [PATCH pve-network 1/1] evpn: update config to frr 8.5.1

2023-06-06 Thread Thomas Lamprecht
Am 23/05/2023 um 08:47 schrieb Alexandre Derumier: > add default values: > "no bgp hard-administrative-reset" > "no bgp graceful-restart notification" > > to avoid frr-reload warning > > Signed-off-by: Alexandre Derumier > --- > PVE/Network/SDN/Controllers/EvpnPlugin.pm | 7

[pve-devel] applied: [PATCH frr] fix #4040 : patch : ospf6d: fix infinite loop when adding ASBR route

2023-06-06 Thread Thomas Lamprecht
Am 13/04/2023 um 13:48 schrieb Alexandre Derumier: > --- > .../frr/ospf6d-fix-infinite-loop.patch| 76 +++ > debian/patches/series | 1 + > 2 files changed, 77 insertions(+) > create mode 100644 debian/patches/frr/ospf6d-fix-infinite-loop.patch >

[pve-devel] [PATCH common v2 1/3] JSONSchema: add support for array parameter in api calls, cli and config

2023-06-06 Thread Dominik Csapak
a few things were missing for it to work: * on the cli, we have to get the option as an array if the type is an array * the untainting must be done recursively, otherwise, the regex matching converts an array hash into the string 'ARRAY(0x123412341234)' * JSONSchema::parse_config did not

[pve-devel] [PATCH qemu-server v2 1/1] api: switch agent api call to 'array' type

2023-06-06 Thread Dominik Csapak
we don't want to use the '-alist' formats anymore in favor of real arrays Signed-off-by: Dominik Csapak --- PVE/API2/Qemu/Agent.pm | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/PVE/API2/Qemu/Agent.pm b/PVE/API2/Qemu/Agent.pm index 5ff1fa9d..dceee770 100644

[pve-devel] [PATCH common v2 3/3] JSONSchema: disable '-alist' format

2023-06-06 Thread Dominik Csapak
this should not be needed anymore since we can now use a simple array in the api instead Signed-off-by: Dominik Csapak --- src/PVE/JSONSchema.pm | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index

[pve-devel] [PATCH http-server v2 1/2] proxy request: forward json content type and parameters

2023-06-06 Thread Dominik Csapak
instead of always trying to encode them as x-www-form-urlencoded Signed-off-by: Dominik Csapak --- src/PVE/APIServer/AnyEvent.pm | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm index

[pve-devel] [PATCH guest-common v2 1/1] vzdump: change 'exclude-path' from alist to an array format

2023-06-06 Thread Dominik Csapak
to get rid of the '-alist' format Signed-off-by: Dominik Csapak --- src/PVE/VZDump/Common.pm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm index 4b0e8e0..7d3c311 100644 --- a/src/PVE/VZDump/Common.pm +++

  1   2   >