Re: [pve-devel] [PVE-User] Proxmox VE 8.1 released!

2023-11-23 Thread Daniel Plominski via pve-devel
--- Begin Message --- Hi, We are currently using: Proxmox 8.0.4 (Enterprise Sub) root@assg32:~# dpkg -l | grep zfs ii libzfs4linux 2.1.12-pve1 amd64OpenZFS filesystem library for Linux - general support ii zfs-initramfs

Re: [pve-devel] [PVE-User] Proxmox VE 8.1 released!

2023-11-23 Thread Fabian Grünbichler
> Jan Vlach hat am 23.11.2023 23:35 CET geschrieben: > > > Hello Martin, > > I'm sorry for stupid question, but I don't quite follow what the OpenZFS > 2.2.0 with "the most important bugfixes from 2.2.1" means. > > there is issue 15526 (https://github.com/openzfs/zfs/issues/15526 >

[pve-devel] seem than ifupdown2 is installed by default on upgrade (a friend reported me an ipv6 slaac bug)

2023-11-23 Thread DERUMIER, Alexandre
Hi, I have a friend who's reported my than ifupdown2 had been installed by default on pve 8.1 upgrade. I think it's because pve-network have "Recommends: ifupdown2". This proxmox server was installed with debian iso, with default ipv6 on interface (auto eth0 inet6 ..). Seem that it have

Re: [pve-devel] [PATCH v2 pve-network] sdn: require mac in IPAM API calls

2023-11-23 Thread Stefan Lendl
sorry, I sent this twice. ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 pve-network] sdn: require mac in IPAM API calls

2023-11-23 Thread Stefan Lendl
standard_option for 'mac-addr' is declared in EVPN where mac-addr is optional. The DELETE endpoint did actually delete from IPAM without a MAC but it would remain in macs.db which brings ends up in a bad state. Signed-off-by: Stefan Lendl --- Changes v2: * removed the if($mac) because we

Re: [pve-devel] [PATCH pve-network] sdn: require mac in IPAM API calls

2023-11-23 Thread Stefan Lendl
sent v2 ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 pve-network] sdn: require mac in IPAM API calls

2023-11-23 Thread Stefan Lendl
standard_option for 'mac-addr' is declared in EVPN where mac-addr is optional. The DELETE endpoint did actually delete from IPAM without a MAC but it would remain in macs.db which brings ends up in a bad state. Signed-off-by: Stefan Lendl --- Changes v2: * removed the if($mac) because we

[pve-devel] [PATCH manager] sdn: add model based validation to dhcp ranges

2023-11-23 Thread Stefan Sterz
this patch re-works the validation the in the subnit edit panel to also validate whether the ip address version in a range match each other. Signed-off-by: Stefan Sterz --- not super proud of this, but couldn't really find another way to properly validate accross two columns and also have the

[pve-devel] [PATCH manager] capitalize Ceph on translatable strings

2023-11-23 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- www/manager6/ceph/CephInstallWizard.js | 6 +++--- www/manager6/storage/RBDEdit.js| 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js index

[pve-devel] [PATCH manager 2/2] ui: one-off backup: show hint if notification-system is used

2023-11-23 Thread Lukas Wagner
When mode is 'auto' and 'mailto' is empty, show hint that the notification system will be used. Signed-off-by: Lukas Wagner --- www/manager6/window/Backup.js | 37 +++ 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/www/manager6/window/Backup.js

[pve-devel] [PATCH manager 1/2] ui: dc: backup: improve UX for the different 'notification-mode's

2023-11-23 Thread Lukas Wagner
- Switch order of 'mailto' and 'mailnotification' field - When mode is 'auto', disable 'mailtnotification' field - When mode is 'auto' and 'mailto' is empty, show hint that the notification system will be used Signed-off-by: Lukas Wagner --- www/manager6/dc/Backup.js | 37

[pve-devel] [PATCH manager] install-wizzard: Fix typo in eligible

2023-11-23 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- www/manager6/ceph/CephInstallWizard.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js index f33ae868..3342a80f 100644 ---

[pve-devel] [PATCH pve-network] sdn: require mac in IPAM API calls

2023-11-23 Thread Stefan Lendl
standard_option for 'mac-addr' is declared in EVPN where mac-addr is optional. The DELETE endpoint did actually delete from IPAM without a MAC but it would remain in macs.db which brings ends up in a bad state. Signed-off-by: Stefan Lendl --- src/PVE/API2/Network/SDN/Ips.pm | 18

[pve-devel] Proxmox VE 8.1 released!

2023-11-23 Thread Martin Maurer
We're very excited to announce the release 8.1 of Proxmox Virtual Environment! It's based on Debian 12.2 "Bookworm" but uses a newer Linux kernel 6.5, QEMU 8.1.2, and OpenZFS 2.2.0 ((with stable fixes backported) Here is a selection of the highlights of Proxmox VE 8.1 - Debian 12.2

[pve-devel] [PATCH pve-network] sdn: Avoid warning of uninitialized variable on VM start

2023-11-23 Thread Stefan Lendl
Signed-off-by: Stefan Lendl --- src/PVE/Network/SDN/Vnets.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/Network/SDN/Vnets.pm b/src/PVE/Network/SDN/Vnets.pm index 0dfdfd7..4f313e3 100644 --- a/src/PVE/Network/SDN/Vnets.pm +++ b/src/PVE/Network/SDN/Vnets.pm @@ -200,6 +200,8 @@

Re: [pve-devel] [PATCH v2 many] fix #4995: Include symlinks in zip file restore

2023-11-23 Thread Filip Schauer
Please ignore On 23/11/2023 14:05, Filip Schauer wrote: Include symlinks when restoring files from a backup as a zip file. Changes since v1: * Use P instead of * Fix compile error due to misplaced comma * Check content before symlink_target, since regular files are more common than

[pve-devel] [PATCH v2 many] fix #4995: Include symlinks in zip file restore

2023-11-23 Thread Filip Schauer
Include symlinks when restoring files from a backup as a zip file. Changes since v1: * Use P instead of * Fix compile error due to misplaced comma * Check content before symlink_target, since regular files are more common than symlinks proxmox: Filip Schauer (1): fix #4995: compression:

[pve-devel] [PATCH manager] ui: iso selector: correctly disable itself

2023-11-23 Thread Dominik Csapak
we overwrote the 'setDisabled' method to disable the child elements, but forgot to give the arguments to callParent, which means it never disabled the IsoSelector. This fixes an issue where when disabling the virtio iso selector in the wizard again, the wizard would get invalid data from it.

[pve-devel] applied: [PATCH manager] ui: pool view: fix editing nested pools

2023-11-23 Thread Thomas Lamprecht
Am 23/11/2023 um 11:07 schrieb Dominik Csapak: > for nested pools we have to provide the pool id via a get parameter > instead of in the path, and also we have to extract the data from the > returned array. > > To do this, changet the cbind url handler, remove the autoLoad one, > and handle the

[pve-devel] applied: [PATCH docs] secure boot: add subsection for DKMS/MOK

2023-11-23 Thread Thomas Lamprecht
Am 23/11/2023 um 10:45 schrieb Fabian Grünbichler: > similar, but a bit more beginner friendly compared to the wiki article. > > Signed-off-by: Fabian Grünbichler > --- > system-booting.adoc | 43 +++ > 1 file changed, 43 insertions(+) > > applied,

[pve-devel] [PATCH manager] ui: pool view: fix editing nested pools

2023-11-23 Thread Dominik Csapak
for nested pools we have to provide the pool id via a get parameter instead of in the path, and also we have to extract the data from the returned array. To do this, changet the cbind url handler, remove the autoLoad one, and handle the load ourselves. Signed-off-by: Dominik Csapak ---

[pve-devel] applied: [PATCH manager] ui: perm paths: change /mapping/notification to /mapping/notifications

2023-11-23 Thread Thomas Lamprecht
Am 23/11/2023 um 10:54 schrieb Lukas Wagner: > The ACL path was changed during the notification system rework. > This change adapts the list of predefined ACL paths in the > 'Add {User,Group,API Token} Permission' dialog window to reflect > this change. > > Signed-off-by: Lukas Wagner > --- >

[pve-devel] [PATCH manager] ui: perm paths: change /mapping/notification to /mapping/notifications

2023-11-23 Thread Lukas Wagner
The ACL path was changed during the notification system rework. This change adapts the list of predefined ACL paths in the 'Add {User,Group,API Token} Permission' dialog window to reflect this change. Signed-off-by: Lukas Wagner --- www/manager6/data/PermPathStore.js | 2 +- 1 file changed, 1

Re: [pve-devel] [PATCH manager] pveceph: install: set default to reef

2023-11-23 Thread Thomas Lamprecht
Am 23/11/2023 um 10:33 schrieb Aaron Lauterer: > to align it with the default in the web UI the default in the web UI is actually dynamic and depends if anything is already installed on the cluster. This is still lacking here, IIRC there is an open enhancement request about that (did not find it

[pve-devel] [PATCH docs] secure boot: add subsection for DKMS/MOK

2023-11-23 Thread Fabian Grünbichler
similar, but a bit more beginner friendly compared to the wiki article. Signed-off-by: Fabian Grünbichler --- system-booting.adoc | 43 +++ 1 file changed, 43 insertions(+) diff --git a/system-booting.adoc b/system-booting.adoc index 0cc9c13..511eddf

[pve-devel] [PATCH manager] pveceph: install: set default to reef

2023-11-23 Thread Aaron Lauterer
to align it with the default in the web UI Signed-off-by: Aaron Lauterer --- PVE/CLI/pveceph.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm index 5f45610b..68b93b89 100755 --- a/PVE/CLI/pveceph.pm +++ b/PVE/CLI/pveceph.pm @@ -115,7

[pve-devel] [PATCH manager v2 1/2] ui: resource tree: optimize change detection

2023-11-23 Thread Dominik Csapak
the 'text' property comes from the ResourceStore, but we often replace it here before rendering, so this will trigger every time for tree elements where we make use of 'setText'. Instead, check for the 'name' property. To ensure the tags get updated with the correct colors, listen to the

[pve-devel] [PATCH manager v2 2/2] ui: resource tree: always show node tooltip

2023-11-23 Thread Dominik Csapak
not only when we're in the folder view Signed-off-by: Dominik Csapak --- changes from v1: * split out the node logic * removed the unnecessary 'setText' calls (they did not do anything in those cases anyway) requires the previous patch, otherwise the text for nodes in the server view will be

[pve-devel] [PATCH widget-toolkit 2/2] notification ui: display yellow warning triangle instead of red icon

2023-11-23 Thread Lukas Wagner
Instead of coloring the entire icon red, show a yellow warning triangle containing an exclamation mark in case of validation errors. Signed-off-by: Lukas Wagner --- src/window/NotificationMatcherEdit.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[pve-devel] [PATCH widget-toolkit 1/2] notification ui: change icon for for match-field tree nodes

2023-11-23 Thread Lukas Wagner
The old icon was slightly ambiguous since we also use it for LXC containers. Signed-off-by: Lukas Wagner --- src/window/NotificationMatcherEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/window/NotificationMatcherEdit.js b/src/window/NotificationMatcherEdit.js

[pve-devel] applied: [PATCH manager 3/3] ui: resource tree: remove wrong comment

2023-11-23 Thread Thomas Lamprecht
Am 23/11/2023 um 09:25 schrieb Dominik Csapak: > that function is not only there for the storage indicators, but > generally for adding additional information, such as tags, and for > wrapping in a span for making tooltip selection easier. > > Signed-off-by: Dominik Csapak > --- >

[pve-devel] applied: [PATCH manager 1/3] ui: resource tree: fix nodes text moving in tree on update

2023-11-23 Thread Thomas Lamprecht
Am 23/11/2023 um 09:25 schrieb Dominik Csapak: > when a node element was updated, it was put through the 'setText' method > which accidentally added a space before it's name. > > Fix this by putting the space into the status variable > > This could be observed when one node had guests on it but

[pve-devel] applied: [PATCH docs] system-booting: fix typo

2023-11-23 Thread Thomas Lamprecht
Am 23/11/2023 um 09:38 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss > --- > system-booting.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] [PATCH docs] system-booting: fix typo

2023-11-23 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- system-booting.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system-booting.adoc b/system-booting.adoc index cd0..0cc9c13 100644 --- a/system-booting.adoc +++ b/system-booting.adoc @@ -395,7 +395,7 @@ available in

[pve-devel] [PATCH manager 3/3] ui: resource tree: remove wrong comment

2023-11-23 Thread Dominik Csapak
that function is not only there for the storage indicators, but generally for adding additional information, such as tags, and for wrapping in a span for making tooltip selection easier. Signed-off-by: Dominik Csapak --- www/manager6/tree/ResourceTree.js | 1 - 1 file changed, 1 deletion(-)

[pve-devel] [PATCH manager 0/3] ui: small tree fixes

2023-11-23 Thread Dominik Csapak
the first patch fixes the jumping node text. the second patch makes tooltips and the generated markup text more consistent (and should also avoid calling 'setText' in various circumstances). the third patch is just a comment cleanup Dominik Csapak (3): ui: resource tree: fix nodes text moving

[pve-devel] [PATCH manager 2/3] ui: resource tree: consistently apply the tooltip and 'setText' method

2023-11-23 Thread Dominik Csapak
'setText' is meant to augment the content of the tree node with additional information and add markup so that the tooltips work properly. Previously this was overwritten for grouping types (e.g. nodes when in the server view), but we want to put the elements through every time the text gets set

[pve-devel] [PATCH manager 1/3] ui: resource tree: fix nodes text moving in tree on update

2023-11-23 Thread Dominik Csapak
when a node element was updated, it was put through the 'setText' method which accidentally added a space before it's name. Fix this by putting the space into the status variable This could be observed when one node had guests on it but others had not. The nodes would then be misaligned.