Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Thomas Lamprecht
Am 28/11/2023 um 16:29 schrieb Dietmar Maurer: >> I'm taking on a lot of contributions to translations and the common complaint >> I hear is that not all can be translated correctly due to such tricks (or >> just >> missing gettext), most translators care much more about a correct translation >>

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Dietmar Maurer
> I'm taking on a lot of contributions to translations and the common complaint > I hear is that not all can be translated correctly due to such tricks (or just > missing gettext), most translators care much more about a correct translation > than some over-optimized ones than then break depending

[pve-devel] applied: [PATCH docs 1/2] secure boot: fix typos, add inline code formatting

2023-11-28 Thread Thomas Lamprecht
Am 28/11/2023 um 14:56 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > system-booting.adoc | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > applied series, thanks! ___ pve-devel mailing list

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Thomas Lamprecht
Am 28/11/2023 um 15:39 schrieb Dietmar Maurer: > Well, this also duplicates the number of things to translate! I'm taking on a lot of contributions to translations and the common complaint I hear is that not all can be translated correctly due to such tricks (or just missing gettext), most

[pve-devel] [PATCH] update kernel to 6.5.11 and ZFS to 2.2.1, refresh patches

2023-11-28 Thread Stoiko Ivanov
* for the kernel-patch this includes a rename from 0003+0004 to 0001+0002 * for ZFS there was a change in upstream's autotools-setup - I referenced the commit in the actual patch-file minimally tested with a VM with a zfs-pool and an ext4 disk * restore of a directory on ext4 containing 160MB

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Dietmar Maurer
To be more clear, I would use: proxmox.Utils.defaultText + ' (' + gettext('Free') + ')' > On 28.11.2023 15:39 CET Dietmar Maurer wrote: > > > > The string `proxmox.Utils.defaultText + ' (free)'` was inlined as > > `Default (Free)` cutting translatable strings makes them harder or even > >

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Dietmar Maurer
> The string `proxmox.Utils.defaultText + ' (free)'` was inlined as > `Default (Free)` cutting translatable strings makes them harder or even > impossible to translate in certain languages. Well, this also duplicates the number of things to translate! So what languages are the problem exactly?

[pve-devel] [PATCH docs 1/2] secure boot: fix typos, add inline code formatting

2023-11-28 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- system-booting.adoc | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/system-booting.adoc b/system-booting.adoc index c8761a4..af56225 100644 --- a/system-booting.adoc +++ b/system-booting.adoc @@ -380,10 +380,11 @@ and

[pve-devel] [PATCH docs 2/2] installation: be more specific about current secure boot state

2023-11-28 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- pve-installation.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pve-installation.adoc b/pve-installation.adoc index 44b59c0..1e909e2 100644 --- a/pve-installation.adoc +++ b/pve-installation.adoc @@ -60,7 +60,8 @@ Please insert the

Re: [pve-devel] [PATCH pve-network] validation: add support for arrays to change tracking

2023-11-28 Thread Hannes Dürr
Tested-by: Hannes Duerr On 11/22/23 13:28, Stefan Hanreich wrote: This is needed so dhcp-ranges are properly displayed as changed in the web UI. Also took the chance to properly indent the encode_value function with our indentation scheme. Signed-off-by: Stefan Hanreich ---

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > + { flag: 'ssbd', desc: gettext('Protection for "Speculative Store > Bypass" for Intel models') }, > + { flag: 'ibpb', desc: gettext('Allows improved Spectre mitigation > with AMD CPUs') }, > + { flag: 'virt-ssbd', desc: gettext('Basis

[pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Maximiliano Sandoval
The string `proxmox.Utils.defaultText + ' (free)'` was inlined as `Default (Free)` cutting translatable strings makes them harder or even impossible to translate in certain languages. Signed-off-by: Maximiliano Sandoval --- www/manager6/dc/UserTagAccessEdit.js | 10 +-

[pve-devel] applied: [PATCH manager] node: add guard for missing secure-boot efi var

2023-11-28 Thread Thomas Lamprecht
Am 28/11/2023 um 07:58 schrieb Fabian Grünbichler: > some (old) systems might have efivars, but don't have the SecureBoot one. > > Signed-off-by: Fabian Grünbichler > --- > > Notes: > reported on the forum for a Dell server from 2009(!): > >

Re: [pve-devel] [PVE-User] Proxmox VE 8.1 released!

2023-11-28 Thread Jan Vlach via pve-devel
--- Begin Message --- https://www.reddit.com/r/zfs/comments/1826lgs/psa_its_not_block_cloning_its_a_data_corruption/ found this one in meantime, no idea what's the current state of affairs in

Re: [pve-devel] [PVE-User] Proxmox VE 8.1 released!

2023-11-28 Thread Jan Vlach via pve-devel
--- Begin Message --- Hello Martin, I'm sorry for stupid question, but I don't quite follow what the OpenZFS 2.2.0 with "the most important bugfixes from 2.2.1" means. there is issue 15526 (https://github.com/openzfs/zfs/issues/15526 ) in openzfs

Re: [pve-devel] [PATCH pve-manager] sdn: ipam: fix ipam grouping identical subnets in different vnets

2023-11-28 Thread Hannes Dürr
Tested-by: Hannes Duerr On 11/28/23 09:58, Stefan Hanreich wrote: When SDN is configured with the same subnet in two different VNets the IPAM tree would render them wrongly. Reported-By: Hannes Duerr Signed-off-by: Stefan Hanreich --- www/manager6/tree/DhcpTree.js | 10 +++--- 1 file

[pve-devel] [PATCH pve-network] dhcp: dnsmasq: Use dir_glob_foreach for deleting configuration files

2023-11-28 Thread Stefan Hanreich
The current invocation is quite unsafe and triggers the taint mode of Perl. Replacing it with dir_glob_foreach solves those issues. Reported-By: Friedrich Weber Signed-off-by: Stefan Hanreich --- I wasn't sure whether directly unlinking the files in the callback would influence the iteration,

[pve-devel] [PATCH pve-manager] sdn: ipam: fix ipam grouping identical subnets in different vnets

2023-11-28 Thread Stefan Hanreich
When SDN is configured with the same subnet in two different VNets the IPAM tree would render them wrongly. Reported-By: Hannes Duerr Signed-off-by: Stefan Hanreich --- www/manager6/tree/DhcpTree.js | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git