Am 06/12/2023 um 15:26 schrieb Dominik Csapak:
> honestly i don't want to argue/bikeshed about such a small detail,
> but i don't see a good reason to translate names and established
> (technical) words.
>
> I'm ready to change my mind, but i did not see a good example
> of when it would be good
> Do note the following examples:
>
> #: pve-manager/www/manager6/qemu/IPConfigEdit.js:97
> #: pve-manager/www/manager6/qemu/IPConfigEdit.js:155
> msgid "DHCP"
> msgstr "بروتوكول التهيئة الآلية للمضيفين (DHCP)"
>
> #: pve-manager/www/manager6/qemu/IPConfigEdit.js:163
>
On 12/6/23 15:04, Maximiliano Sandoval wrote:
Dominik Csapak writes:
it's more like DHCP, SLAAC or IPv4. those are names of protocols (like ACME)
that shouldn't change across translations
and we removed those gettexts (mostly) a while ago
e.g. see lxc/Network.js in pve-manager:
---8<---
Dominik Csapak writes:
> it's more like DHCP, SLAAC or IPv4. those are names of protocols (like ACME)
> that shouldn't change across translations
>
> and we removed those gettexts (mostly) a while ago
> e.g. see lxc/Network.js in pve-manager:
>
> ---8<---
> boxLabel: 'DHCP', // do not localize
>
Signed-off-by: Christoph Heiss
---
test/Makefile | 6 ++-
test/ui2-stdio.pl | 96 +++
2 files changed, 101 insertions(+), 1 deletion(-)
create mode 100755 test/ui2-stdio.pl
diff --git a/test/Makefile b/test/Makefile
index fb80fc4..eef8830 100644
Signed-off-by: Christoph Heiss
---
Proxmox/UI/StdIO.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Proxmox/UI/StdIO.pm b/Proxmox/UI/StdIO.pm
index 75ddbeb..a97245c 100644
--- a/Proxmox/UI/StdIO.pm
+++ b/Proxmox/UI/StdIO.pm
@@ -49,7 +49,7 @@ sub prompt {
sub display_html
The other case uses "Installation finished [..]", thus use the same
wording here too.
Signed-off-by: Christoph Heiss
---
proxmox-low-level-installer | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-low-level-installer b/proxmox-low-level-installer
index
This switches the stdio-protocol for the low-level installer from
simple, line-based messages to JSON.
This solves a number of problems, most prominently that messages can now
contain multiline text (or for that matter, any kind of data), as JSON
handles that transparently.
The actual "meaty"
Signed-off-by: Christoph Heiss
---
Proxmox/UI/StdIO.pm | 41 --
.../src/views/install_progress.rs | 117 --
2 files changed, 83 insertions(+), 75 deletions(-)
diff --git a/Proxmox/UI/StdIO.pm b/Proxmox/UI/StdIO.pm
index a97245c..25d1c82
Signed-off-by: Christoph Heiss
---
.../src/views/install_progress.rs | 94 +++
1 file changed, 94 insertions(+)
diff --git a/proxmox-tui-installer/src/views/install_progress.rs
b/proxmox-tui-installer/src/views/install_progress.rs
index 741529f..4626fe4 100644
---
Some test to come will need a proper environment.
`prepare-test-env` can also be generally useful while developing to
quickly set up a new test environment as needed.
Signed-off-by: Christoph Heiss
---
Makefile | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git
On 12/6/23 12:20, Fiona Ebner wrote:
Am 06.12.23 um 12:00 schrieb Dominik Csapak:
On 12/6/23 11:21, Maximiliano Sandoval wrote:
Dominik Csapak writes:
translating ACME does not make sense to me since it's
the name of the protocol and stands for
Automatic Certificate Management
Am 06.12.23 um 12:00 schrieb Dominik Csapak:
> On 12/6/23 11:21, Maximiliano Sandoval wrote:
>>
>> Dominik Csapak writes:
>>
>>> translating ACME does not make sense to me since it's
>>> the name of the protocol and stands for
>>> Automatic Certificate Management Environment
>>>
>>> i don't
On 12/6/23 12:13, Maximiliano Sandoval wrote:
Dominik Csapak writes:
the translator must make sure the terms are consistent anyway...
This is the heart of the issue. The translator cannot know there are
more uses of the string if it is not marked as translatable.
yes he can, because
Dominik Csapak writes:
> the translator must make sure the terms are consistent anyway...
This is the heart of the issue. The translator cannot know there are
more uses of the string if it is not marked as translatable.
--
Maximiliano
___
On 12/6/23 11:21, Maximiliano Sandoval wrote:
Dominik Csapak writes:
translating ACME does not make sense to me since it's
the name of the protocol and stands for
Automatic Certificate Management Environment
i don't think/believe this should be translated
into other languages as a
On 12/6/23 10:25, Dominik Csapak wrote:
> high level, i think i'd find it better to put the button next to the
> remove button (as you suggested in the cover letter)
>
> my rationale is that the place where the add button is, is a 'neutral' place
> without connection to an existing disk, but the
Dominik Csapak writes:
> translating ACME does not make sense to me since it's
> the name of the protocol and stands for
> Automatic Certificate Management Environment
>
> i don't think/believe this should be translated
> into other languages as a standalone word
"ACME" appears in four
On 12/6/23 10:13, Dominik Csapak wrote:
> hi, some comment inline
>
> On 12/5/23 16:44, Max Carrara wrote:
>> This parameter may be used to circumvent calls to `onGetValues`.
>>
>> Also adds a docstring for the function.
>>
>> Signed-off-by: Max Carrara
>> ---
>> src/panel/InputPanel.js | 15
translating ACME does not make sense to me since it's
the name of the protocol and stands for
Automatic Certificate Management Environment
i don't think/believe this should be translated
into other languages as a standalone word
rest looks fine to me though
On 11/29/23 14:21, Maximiliano
high level, i think i'd find it better to put the button next to the
remove button (as you suggested in the cover letter)
my rationale is that the place where the add button is, is a 'neutral'
place without connection to an existing disk, but the copy is an
action related to a specific disk so
hi, some comment inline
On 12/5/23 16:44, Max Carrara wrote:
This parameter may be used to circumvent calls to `onGetValues`.
Also adds a docstring for the function.
Signed-off-by: Max Carrara
---
src/panel/InputPanel.js | 15 ++-
1 file changed, 14 insertions(+), 1
22 matches
Mail list logo
