[pve-devel] [RFC manager/docs] lvm: better expose/explain saferemove option

2023-12-07 Thread Fiona Ebner
Users might not even know that the option or the issue it addresses exist. Expose the option in the UI and expand on the "why" in the documentation. Motivated by a recent forum post: https://forum.proxmox.com/threads/137734/ manager: Fiona Ebner (1): ui: lvm: expose saferemove setting

[pve-devel] [RFC manager 1/1] ui: lvm: expose saferemove setting

2023-12-07 Thread Fiona Ebner
It can be security-relevant in some environments. The LVM storage documentation can be reached via the "Help" button and contains a few more details. Signed-off-by: Fiona Ebner --- www/manager6/storage/LVMEdit.js | 10 ++ 1 file changed, 10 insertions(+) diff --git

[pve-devel] [PATCH docs 1/1] storage: lvm: expand on description of saferemove option

2023-12-07 Thread Fiona Ebner
mentioning why zeroing-out might be necessary. Signed-off-by: Fiona Ebner --- pve-storage-lvm.adoc | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pve-storage-lvm.adoc b/pve-storage-lvm.adoc index 917d8fb..cff5d3e 100644 --- a/pve-storage-lvm.adoc +++

[pve-devel] [PATCH manager v2] fix #5106: ui: ceph status: make column wrap the summary text on expand

2023-12-07 Thread Dominik Csapak
with this the title is now completely visible when the column is expanded, even if it's originally too narrow. Suggested-by: Thomas Lamprecht Signed-off-by: Dominik Csapak --- changes from v1: * wrap the text in the column, instead of duplicating it in the expanded body thanks @thomas for

[pve-devel] [PATCH widget-toolkit] ui: repo status: Simplify logic for adding warnings

2023-12-07 Thread Maximiliano Sandoval
The strings were hard to translate and required some tricks like passing 'Ceph ' as an argument. The `/main` part was also removed to simplify the flow and UX. Suggested-by: Dietmar Maurer Signed-off-by: Maximiliano Sandoval --- src/node/APTRepositories.js | 20 +--- 1 file

Re: [pve-devel] [PATCH manager] fix #5106: ui: ceph status: add error title to expandable body

2023-12-07 Thread Thomas Lamprecht
Am 07/12/2023 um 12:01 schrieb Dominik Csapak: > this has the advantage that the title is now completely visible when the > column is too narrow when expanded, although it is duplicated (since > it's already contained in the non expanded row) even if the original > value may be cutoff. > >

[pve-devel] [PATCH manager] fix #5106: ui: ceph status: add error title to expandable body

2023-12-07 Thread Dominik Csapak
this has the advantage that the title is now completely visible when the column is too narrow when expanded, although it is duplicated (since it's already contained in the non expanded row) even if the original value may be cutoff. Signed-off-by: Dominik Csapak --- not sure about this, because

[pve-devel] [PATCH v2 qemu-server pve-storage 2/2] fix #1611: implement import of base-images for LVM-thin Storage

2023-12-07 Thread Hannes Duerr
for base images we call the volume_import of the parent plugin and pass it as vm-image instead of base-image, then convert it back as base-image Signed-off-by: Hannes Duerr --- src/PVE/Storage/LvmThinPlugin.pm | 60 1 file changed, 60 insertions(+) diff --git

[pve-devel] [PATCH v2 qemu-server pve-storage 1/2] migration: secure and use source volume names for cleanup

2023-12-07 Thread Hannes Duerr
During migration, the volume names may change if the name is already in use at the target location. We therefore want to save the original names before the migration so that we can clean up the original volumes afterwards. Signed-off-by: Hannes Duerr --- PVE/QemuMigrate.pm | 5 +++-- 1 file

[pve-devel] [PATCH v2 qemu-server pve-storage 0/2] fix #1611: implement import of base-images for LVM-thin Storage

2023-12-07 Thread Hannes Duerr
if a base-image is to be migrated to a lvm-thin storage, a new vm-image is allocated on the target side, then the data is written and afterwards the image is converted to a base-image qemu-server: Hannes Duerr (1): migration: secure and use source volume names for cleanup

[pve-devel] [PATCH proxmox-i18n v2] use xgettext to extract translatable strings

2023-12-07 Thread Maximiliano Sandoval
xgettext is a robust tool to extract translatable strings from source code. Using msgcat for concatenating pot files is not recommended, hence we also switch to xgettext. It also added garbage when there were comments. What do we get for free: - It de-escapes strings. there are 3 cases in our

[pve-devel] [PATCH widget-toolkit v2] i18n: mark strings as translatable

2023-12-07 Thread Maximiliano Sandoval
Note that N/A is already translatable in other places. Signed-off-by: Maximiliano Sandoval --- Differences from v2: - Translate the invalid subscription key message, this string is also in two more places in pve-manager. This will be the content of a following patch. - Do not translate