Re: [pve-devel] [PATCH qemu] fix #4507: add patch to automatically increase NOFILE soft limit

2023-12-12 Thread Fiona Ebner
Am 12.12.23 um 14:42 schrieb Fiona Ebner: > In many configurations, e.g. multiple vNICs with multiple queues or > with many Ceph OSDs, the default soft limit of 1024 is not enough. > QEMU is supposed to work fine with file descriptors >= 1024 and does > not use select() on POSIX. Bump the soft

[pve-devel] [PATCH qemu] fix #4507: add patch to automatically increase NOFILE soft limit

2023-12-12 Thread Fiona Ebner
In many configurations, e.g. multiple vNICs with multiple queues or with many Ceph OSDs, the default soft limit of 1024 is not enough. QEMU is supposed to work fine with file descriptors >= 1024 and does not use select() on POSIX. Bump the soft limit to the allowed hard limit to avoid issues with

Re: [pve-devel] [PATCH qemu-server 1/1] fix #4507 : increase qemu max openfiles limit

2023-12-12 Thread Fiona Ebner
Am 12.12.23 um 12:55 schrieb Thomas Lamprecht: > Meh, I think the application that actually can use many FDs, which are not > *that* many, should just raise it to the highest limit possible, so I'd > rather do this inside QEMU. > Doing such stuff from the outside is almost always a bit more

Re: [pve-devel] [PATCH qemu-server 1/1] fix #4507 : increase qemu max openfiles limit

2023-12-12 Thread Thomas Lamprecht
Am 12/12/2023 um 10:21 schrieb Fiona Ebner: > Am 11.12.23 um 17:29 schrieb DERUMIER, Alexandre: So not sure if that's really nicer. This suggests QEMU should raise the limit itself. >> >> Yes, but it don't raise the limit :/ But it's really working with more >> than 1024 file

Re: [pve-devel] [PATCH qemu-server] Properly identify the CPU architecture of 32-bit VMs

2023-12-12 Thread Fiona Ebner
Am 12.12.23 um 11:39 schrieb Filip Schauer: > It's actually not a different binary. qemu-system-i386 is a symlink that > points to qemu-system-x86_64. But still this does indeed break migration > between a node that has this patch applied and another node without the > patch. > Oh, okay. But

Re: [pve-devel] [PATCH v3 qemu-server] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS

2023-12-12 Thread Fiona Ebner
Am 12.12.23 um 11:58 schrieb Filip Schauer: > Instead of starting a VM with a 32-bit CPU type and a 64-bit OVMF image, > throw an error before starting the VM telling the user that OVMF is not > supported on 32-bit CPU types. > > Signed-off-by: Filip Schauer > --- > Changes since v2: > *

Re: [pve-devel] [PATCH qemu-server 1/1] fix #4507 : increase qemu max openfiles limit

2023-12-12 Thread DERUMIER, Alexandre
> >>From a quick look, I didn't find an option to pass along QEMU for >>this, >>so it would likely need to be implemented first/discussed with >>upstream. >>But thinking about it a bit, it feels wrong for each application to >>be >>responsible for raising the limit itself. Sure the application

Re: [pve-devel] [PATCH v2 qemu-server] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS

2023-12-12 Thread Filip Schauer
A much simpler patch v3 is available: https://lists.proxmox.com/pipermail/pve-devel/2023-December/061036.html On 12/12/2023 11:37, Filip Schauer wrote: Instead of starting a VM with a 32-bit CPU type and a 64-bit OVMF image, throw an error before starting the VM telling the user that OVMF is

[pve-devel] [PATCH v3 qemu-server] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS

2023-12-12 Thread Filip Schauer
Instead of starting a VM with a 32-bit CPU type and a 64-bit OVMF image, throw an error before starting the VM telling the user that OVMF is not supported on 32-bit CPU types. Signed-off-by: Filip Schauer --- Changes since v2: * Simplify the check whether a 32-bit CPU type is used in combination

Re: [pve-devel] [PATCH qemu-server] Properly identify the CPU architecture of 32-bit VMs

2023-12-12 Thread Filip Schauer
It's actually not a different binary. qemu-system-i386 is a symlink that points to qemu-system-x86_64. But still this does indeed break migration between a node that has this patch applied and another node without the patch. A patch v2 that only adds the check is available here:

[pve-devel] [PATCH v2 qemu-server] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS

2023-12-12 Thread Filip Schauer
Instead of starting a VM with a 32-bit CPU type and a 64-bit OVMF image, throw an error before starting the VM telling the user that OVMF is not supported on 32-bit CPU types. Signed-off-by: Filip Schauer --- PVE/API2/Qemu.pm | 2 +- PVE/QemuServer.pm | 27 --- 2 files

[pve-devel] applied: [PATCH qemu-server] add qemu 8.1 cpu models

2023-12-12 Thread Fiona Ebner
Am 11.12.23 um 16:17 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer/CPUConfig.pm | 7 +++ > 1 file changed, 7 insertions(+) > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

Re: [pve-devel] [PATCH qemu-server 1/1] fix #4507 : increase qemu max openfiles limit

2023-12-12 Thread Fiona Ebner
Am 11.12.23 um 17:29 schrieb DERUMIER, Alexandre: >>> So not sure if that's really nicer. This suggests QEMU should raise >>> the >>> limit itself. > > Yes, but it don't raise the limit :/ But it's really working with more > than 1024 file descriptor. > From a quick look, I didn't find an

[pve-devel] [PATCH widget-toolkit v2] notify: sendmail: smtp: fix mailto/mailto-user parameter deletion

2023-12-12 Thread Lukas Wagner
In the GUI, when a sendmail/smtp target is edited and either 'Additional Recipients' or 'Recipients' is completely removed (only possible if the other field contains a value), parameter deletion did not work properly. After applying the changes, the old value would still be in place. The changes

Re: [pve-devel] [PATCH widget-toolkit] notify: sendmail: smtp: fix mailto/mailto-user parameter deletion

2023-12-12 Thread Lukas Wagner
On 12/11/23 16:55, Maximiliano Sandoval wrote: The commit message was not immediately clear for me. I'll send a v2 with a clearer commit message and include your T-b trailer. Thanks for testing! -- - Lukas ___ pve-devel mailing list