Re: [pve-devel] [RFC cluster 0/2] fix #4886: improve SSH handling

2024-01-08 Thread Esi Y via pve-devel
--- Begin Message --- On Thu, Dec 21, 2023 at 10:53:11AM +0100, Fabian Grünbichler wrote: > RFC since this would be a bigger change in how we approach intra-cluster > SSH access. > > there are still a few parts that currently don't use SSHInfo, but > would need to be switched over if we want to

[pve-devel] Unveiling Digitology: The Pinnacle of Digital Marketing Excellence in Egypt

2024-01-08 Thread seo 2023 via pve-devel
--- Begin Message --- In the rapidly evolving digital world, the quest for a premier [SEO agency in Egypt](https://digitology.co) has become more crucial than ever. Among the myriad of options, one name stands out for its innovation and results-driven approach: [Digitology](https://digitology.co),

[pve-devel] [PATCH container] fix #5160: fix move_mount regression for mount point hotplug

2024-01-08 Thread Filip Schauer
Set up an Apparmor profile to allow moving mounts for mount point hotplug. This fixes a regression caused by kernel commit 157a3537d6 ("apparmor: Fix regression in mount mediation") The commit introduced move_mount mediation, which now requires move_mount to be allowed in the Apparmor profile.

[pve-devel] applied-series: [PATCH proxmox v2 0/5] sys: email: always format 'Date' header with C locale

2024-01-08 Thread Wolfgang Bumiller
applied series, thanks not 100% sure about the `C` const - might be nice to instead have a static Lazy C to get via `Locale::c()` but that can happen later... ___ pve-devel mailing list pve-devel@lists.proxmox.com

Re: [pve-devel] [PATCH installer v2 0/7] gui: use gtk grids when possible

2024-01-08 Thread Maximiliano Sandoval
ping Maximiliano Sandoval writes: > We replace the use of nested boxes with grids when possible to ensure correct > margins and alignment of widgets. > > At the end we also remove trailing spaces and colons from labels preceding an > input widget, e.g. we replace `DNS Server: ` with `DNS

Re: [pve-devel] [PATCH manager 1/2] fix #5067: vzdump: include total backup size in notification

2024-01-08 Thread Lukas Wagner
ping On 12/14/23 15:11, Lukas Wagner wrote: The old backup job notification mails from before the notification system overhaul included the total time as well as the total size. The total size was missing from the new, template-based backup report, thus we add it back in this commit.

Re: [pve-devel] [PATCH manager 1/2] ui: dc: backup: improve UX for the different 'notification-mode's

2024-01-08 Thread Lukas Wagner
ping On 11/23/23 17:09, Lukas Wagner wrote: - Switch order of 'mailto' and 'mailnotification' field - When mode is 'auto', disable 'mailtnotification' field - When mode is 'auto' and 'mailto' is empty, show hint that the notification system will be used Signed-off-by: Lukas

Re: [pve-devel] [PATCH proxmox 1/2] notify: api: allow resetting built-in targets when they are referenced

2024-01-08 Thread Lukas Wagner
ping On 12/14/23 13:42, Lukas Wagner wrote: by a matcher. In the 'delete'-handler targets, we check if a target is still referenced by a matcher - if it is, we return an error. For built-in targets, this is actually not necessary, since 'deleting' a built-in only resets it to its default

Re: [pve-devel] [PATCH widget-toolkit 0/2] notification: set 'Remove' button text to 'Reset to default' for built-ins

2024-01-08 Thread Lukas Wagner
ping On 12/14/23 10:48, Lukas Wagner wrote: Deleting a built-in target/matcher does not remove it, but resets it to its default settings. This was not really obvious from the UI. This patch changes the 'Remove' button text based on the selected target/matcher. If it is a built-in, the button

Re: [pve-devel] [PATCH proxmox 1/2] notify: smtp: forward original message instead nesting

2024-01-08 Thread Lukas Wagner
ping On 12/13/23 17:42, Lukas Wagner wrote: For mails forwarded by `proxmox-mail-forward` to an SMTP target, the original message was nested as a 'message/rfc822' message part. Originally this approach was chosen to avoid having to rewrite message headers. Good email-clients, such as

Re: [pve-devel] [PATCH v2 many 00/22] notifications: notification metadata matching improvements

2024-01-08 Thread Lukas Wagner
Ping On 12/13/23 17:37, Lukas Wagner wrote: This patch series attempts to improve the user experience when creating notification matchers. Some of the noteworthy changes: - Fixup inconsistent 'hostname' field. Some notification events sent the hostname including a domain, while other did

Re: [pve-devel] [PATCH proxmox v2 0/5] sys: email: always format 'Date' header with C locale

2024-01-08 Thread Lukas Wagner
On 12/11/23 14:29, Lukas Wagner wrote: This patch series makes the formatting of the 'Date' header for sent emails independent of the system locale. Previously, strftime was used to generate the header, but since this function is locale-aware, invalid Date headers could be generated. As an

Re: [pve-devel] [PATCH access-control] fix #5136: ldap: Decode non-ASCII characters in attributes

2024-01-08 Thread Wolfgang Bumiller
On Wed, Dec 20, 2023 at 03:37:03PM +0100, Filip Schauer wrote: > Decode non-ASCII character when syncing user attributes, since those decode *how*? > will be encoded later on. Without this fix the attributes where encoded > twice, resulting in cases such as 'ü' turning into 'ü'. > >