Am 10/01/2024 um 10:12 schrieb Fiona Ebner:
> Am 09.01.24 um 18:02 schrieb DERUMIER, Alexandre:
> > Another way (maybe safer), is to build 2 binary in same package
> > (/usr/bin/kvm-tcmalloc && /usr/bin/kvm), and give option to user
> > to
> > choose it.
> >
>
> If we go for this route, I'd
Am 10/01/2024 um 14:50 schrieb Christian Ebner:
> Signed-off-by: Christian Ebner
> ---
> changes since v1:
> - fix an additional typo spotted Lukas
>
> notifications.adoc | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>
applied, thanks!
Am 10/01/2024 um 10:38 schrieb DERUMIER, Alexandre:
>>> Unfortunately, the QEMU patch seems rather hacky and I'd prefer to
>>> not
>>> include and maintain it. If tcmalloc would just provide malloc_trim()
>>> (e.g. as a no-op), there would be no need for the ugly
>>> at-runtime-detection at all.
>
Signed-off-by: Christian Ebner
---
changes since v1:
- fix an additional typo spotted Lukas
notifications.adoc | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/notifications.adoc b/notifications.adoc
index cddb8ca..46aff6a 100644
--- a/notifications.adoc
+++
> On 10.01.2024 14:37 CET Lukas Wagner wrote:
>
>
> On 1/10/24 14:14, Christian Ebner wrote:
> > Signed-off-by: Christian Ebner
> > ---
> > notifications.adoc | 10 +-
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/notifications.adoc b/notifications.adoc
On 1/10/24 14:14, Christian Ebner wrote:
Signed-off-by: Christian Ebner
---
notifications.adoc | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/notifications.adoc b/notifications.adoc
index cddb8ca..9be23f8 100644
--- a/notifications.adoc
+++
Signed-off-by: Christian Ebner
---
notifications.adoc | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/notifications.adoc b/notifications.adoc
index cddb8ca..9be23f8 100644
--- a/notifications.adoc
+++ b/notifications.adoc
@@ -172,11 +172,11 @@ Notification Matchers
adds vendor and product information for SCSI devices to the json schema
and checks in the VM create/update API call if it is possible to add
these to QEMU as a device option
Signed-off-by: Hannes Duerr
---
PVE/API2/Qemu.pm| 39 +++
PVE/QemuServer.pm
changes in v2:
- when calling the API to create/update a VM, check whether the devices
are "scsi-hd" or "scsi-cd" devices,where there is the option to add
vendor and product information, if not error out
- change the format in product_fmt and vendor_fmt to a pattern that only allows
40 characters
applied all 3 proxmox-notify patches, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied both patches, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied both patches, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On Wed, 2024-01-10 at 10:41 +0100, Thomas Lamprecht wrote:
> Am 09/01/2024 um 15:23 schrieb Alexander Zeidler:
> > and point users to proxmox-offline-mirror-helper
>
> the change is fine, but having any background/reason/why here could be
> still nice,
Thanks! Since a customer was used to
On Wed, 2024-01-10 at 10:29 +0100, Thomas Lamprecht wrote:
> any reason this is relevant you might want to add to the commit
> message here?
to avoid a failing null check and its error message. This confused
users since the activation was successful anyway.
> simple
>
> return;
>
> is slightly
Am 10/01/2024 um 10:12 schrieb Fiona Ebner:
> Am 09.01.24 um 18:02 schrieb DERUMIER, Alexandre:
>> Another way (maybe safer), is to build 2 binary in same package
>> (/usr/bin/kvm-tcmalloc && /usr/bin/kvm), and give option to user to
>> choose it.
>>
>
> If we go for this route, I'd rather have
Am 09/01/2024 um 15:23 schrieb Alexander Zeidler:
> and point users to proxmox-offline-mirror-helper
>
> Signed-off-by: Alexander Zeidler
> ---
> PVE/CLI/pvesubscription.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, thanks!
Am 09/01/2024 um 15:23 schrieb Alexander Zeidler:
> Signed-off-by: Alexander Zeidler
> ---
> PVE/Report.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied this one, thanks!
It could have been a standalone patch though, as it's not really
related to the other ones.
For mails forwarded by `proxmox-mail-forward` to an SMTP target, the
original message was nested as a 'message/rfc822' message part.
Originally this approach was chosen to avoid having to rewrite
message headers.
Good email-clients, such as Thunderbird can display these inline.
Other, more limited
`Auto-Submitted` is defined in the rfc 5436 [1] and describes how
an automatic response (f.e. ooo replies, etc.) should behave on the
emails. When using `Auto-Submitted: auto-generated` (or any value
other than `none`) automatic replies won't be triggered.
[1]:
Am 09/01/2024 um 15:23 schrieb Alexander Zeidler:
> and point users to proxmox-offline-mirror-helper
the change is fine, but having any background/reason/why here could be
still nice, I never saw a commit with to much references or reasons
state for why a change was done, and having those can
Hi Fiona, (and happy new year)
> Currently, In production, I compile qemu with tcmalloc at build.
>
> This patch serie, allow to do use LD_PRELOAD + disable malloc_trim()
> call in qemu.
>
> I'm not expert in C (I re-used code from haproxy, which is doing
> exactly the same thing with
In the 'delete'-handler targets, we check if a
target is still referenced by a matcher - if it is, we return an
error. For built-in targets, this is actually not necessary, since
'deleting' a built-in only resets it to its default settings - it will
continue to exist after that.
The user could
... as using PVEContext for tests is brittle and annoying for some
tests.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/context/mod.rs | 10 +-
proxmox-notify/src/context/test.rs | 26 ++
2 files changed, 31 insertions(+), 5 deletions(-)
create mode 100644
any reason this is relevant you might want to add to the commit
message here?
Am 09/01/2024 um 15:23 schrieb Alexander Zeidler:
> Signed-off-by: Alexander Zeidler
> ---
> PVE/CLI/pvesubscription.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/PVE/CLI/pvesubscription.pm
On January 9, 2024 3:50 pm, Alexandre Derumier wrote:
> source: https://github.com/ceph/ceph/pull/54891
this was not merged upstream, and I don't think it's needed as per the
discussions in both PRs if the other patch is pulled in.
> build packages with 'RelWithDebInfo' to avoid to build rocksdb
Am 09.01.24 um 18:02 schrieb DERUMIER, Alexandre:
> Hi,
>
> I still have this last year patch pending
>
> https://lists.proxmox.com/pipermail/pve-devel/2023-May/056815.html
>
> to enabled conditionnaly tcmalloc in qemu
>
> It's still required for performance with librbd with last qemu /lirbd
On 1/9/24 14:18, Wolfgang Bumiller wrote:
On Thu, Dec 14, 2023 at 01:42:07PM +0100, Lukas Wagner wrote:
by a matcher.
^ this line should be part of the subject
In the 'delete'-handler targets, we check if a
target is still referenced by a matcher - if it is, we return an
error. For
Thanks for the review!
On 1/9/24 14:26, Wolfgang Bumiller wrote:
On Wed, Dec 13, 2023 at 05:42:00PM +0100, Lukas Wagner wrote:
For mails forwarded by `proxmox-mail-forward` to an SMTP target, the
original message was nested as a 'message/rfc822' message part.
Originally this approach was
28 matches
Mail list logo
