Re: [pve-devel] [PATCH pve-manager] qemu: bump max cores to 256 by socket

2024-01-16 Thread Fiona Ebner
Am 16.01.24 um 15:08 schrieb DERUMIER, Alexandre: > >>> Is the QEMU error message understandable? If yes, I don't see much >>> value > > Well, indeed, the message is pretty clear. > maybe just add documentation about limit for q35 && i440fx ? > > (I have a customer with a new epyc v4, asking me

Re: [pve-devel] [PATCH docs] ballooning example: improve wording

2024-01-16 Thread Alexander Zeidler
On Tue, 2024-01-16 at 14:36 +0100, Alexander Zeidler wrote: > On Tue, 2024-01-16 at 14:28 +0100, Hannes Dürr wrote: > > I don't think this is an improvement of the wording, liked the previous > > version more. > > Are there people who have not understood the wording? > It's not an extra

[pve-devel] [PATCH docs] ballooning: precise example

2024-01-16 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- qm.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qm.adoc b/qm.adoc index 4ff5014..86762d3 100644 --- a/qm.adoc +++ b/qm.adoc @@ -698,9 +698,9 @@ database blocks in the database server RAM, you would like to prioritize the

Re: [pve-devel] [PATCH pve-manager v2 2/2] firewall: properly detect changes when ip / cidr is used in rule

2024-01-16 Thread Mira Limbeck
On 1/16/24 15:30, Stefan Hanreich wrote: > With the current implementation using queryDelay, this means that the > change event for the input never completes. This in turn leads to > the input panel never changing its dirty status. By using the > beforequery event we can simply cancel the query

Re: [pve-devel] [PATCH pve-manager v2 1/2] fix #4963: firewall: fix editing firewall rules using ips / cidrs

2024-01-16 Thread Mira Limbeck
On 1/16/24 15:30, Stefan Hanreich wrote: > fall back to using v.ref as value when we do not have an alias or ipset > since scope and name are not set for ips / cidrs > > Signed-off-by: Stefan Hanreich > --- > > Changes from v1: > * Added fix for an additional bug causing changes to IPs not

Re: [pve-devel] [PATCH manager 0/2] fix #5093 add custom directory and eab to ui

2024-01-16 Thread Folke Gleumes
For testing, I have used pebble [0] in a separate lxc container. 1. Download and compile the project 2. Start pebble with the included eab config: pebble -c test/config/pebble-config-external-account-bindings.json 3. Import the certificates from the test/certs folder into the pve instance 4. Add

[pve-devel] [PATCH manager 2/2] webui: acme: add eab fields

2024-01-16 Thread Folke Gleumes
Adds fields for eab credentials. By default eab is optional, but if the directory should report that eab is required, the eab credential fields are marked as mandatory and prevent the form from being submittable until credentials are provided. Signed-off-by: Folke Gleumes ---

[pve-devel] [PATCH manager 1/2] fix #5093: webui: acme: custom directory option

2024-01-16 Thread Folke Gleumes
This patch allows the user to set a custom ACME directory by providing a 'Custom' option in the directory dropdown. This in turn reveals an input for the url. When using a custom directory the directory has to be manually queried via button press to prevent from spamming the directory on every

[pve-devel] [PATCH manager 0/2] fix #5093 add custom directory and eab to ui

2024-01-16 Thread Folke Gleumes
This patch series adds the option to set a custom directory for ACME and enables the user to use external account binding, which is required by some providers. Folke Gleumes (2): fix #5093: webui: acme: custom directory option webui: acme: add eab fields www/manager6/node/ACME.js | 168

Re: [pve-devel] [PATCH pve-manager] fix #4963: firewall: fix editing firewall rules using cidrs

2024-01-16 Thread Stefan Hanreich
On 1/16/24 11:33, Mira Limbeck wrote: > This removes the error reported in the bug tracker, but new changes to > the IP are not recognized. > E.g.: > original IP range: 10.0.0.0/8 > new IP range: 192.168.0.0/24 > > The `ok` button is still disabled unless you change anything else, > change to

[pve-devel] [PATCH pve-manager v2 1/2] fix #4963: firewall: fix editing firewall rules using ips / cidrs

2024-01-16 Thread Stefan Hanreich
fall back to using v.ref as value when we do not have an alias or ipset since scope and name are not set for ips / cidrs Signed-off-by: Stefan Hanreich --- Changes from v1: * Added fix for an additional bug causing changes to IPs not being picked up by the input panel

[pve-devel] [PATCH pve-manager v2 2/2] firewall: properly detect changes when ip / cidr is used in rule

2024-01-16 Thread Stefan Hanreich
With the current implementation using queryDelay, this means that the change event for the input never completes. This in turn leads to the input panel never changing its dirty status. By using the beforequery event we can simply cancel the query without resorting to the queryDelay hack.

Re: [pve-devel] [PATCH pve-manager] qemu: bump max cores to 256 by socket

2024-01-16 Thread DERUMIER, Alexandre
>>Is the QEMU error message understandable? If yes, I don't see much >>value Well, indeed, the message is pretty clear. maybe just add documentation about limit for q35 && i440fx ? (I have a customer with a new epyc v4, asking me about this, and I had no idea that they was a different limit

Re: [pve-devel] [PATCH cluster 2/4] fix #4886: SSH: pin node's host key if available

2024-01-16 Thread Esi Y via pve-devel
--- Begin Message --- Thank you for the responses below, I just want to explain all the fuss in my reasoning, i.e. why I am bringing it up before this goes into a release. The original way of handling SSH was meant to be pretty transparent to the user: A. If they ran plain ssh, without any

Re: [pve-devel] [PATCH docs] ballooning example: improve wording

2024-01-16 Thread Alexander Zeidler
On Tue, 2024-01-16 at 14:28 +0100, Hannes Dürr wrote: > I don't think this is an improvement of the wording, liked the previous > version more. > Are there people who have not understood the wording? It's not an extra (additional) amount of memory for this VM, but its total. Therefore, using the

Re: [pve-devel] [PATCH docs] ballooning example: improve wording

2024-01-16 Thread Hannes Dürr
I don't think this is an improvement of the wording, liked the previous version more. Are there people who have not understood the wording? On 1/16/24 14:11, Alexander Zeidler wrote: Signed-off-by: Alexander Zeidler --- qm.adoc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[pve-devel] [PATCH docs 3/3] qm: resource limits: revise section affinity

2024-01-16 Thread Alexander Zeidler
* mention side effects * increase compactness w/o complexity * improve section-formatting Signed-off-by: Alexander Zeidler --- qm.adoc | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/qm.adoc b/qm.adoc index 15aa0fc..d92db75 100644 ---

[pve-devel] [PATCH docs 2/3] qm: resource limits: revise section cpuunits

2024-01-16 Thread Alexander Zeidler
* restructure sentences minimally * improve section-formatting Signed-off-by: Alexander Zeidler --- qm.adoc | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/qm.adoc b/qm.adoc index 268a635..15aa0fc 100644 --- a/qm.adoc +++ b/qm.adoc @@ -364,17 +364,21

[pve-devel] [PATCH docs 1/3] qm: resource limits: revise section cpulimit

2024-01-16 Thread Alexander Zeidler
* precise statements * increase compactness w/o complexity * improve section-formatting Signed-off-by: Alexander Zeidler --- qm.adoc | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/qm.adoc b/qm.adoc index c2392f3..268a635 100644 ---

[pve-devel] [PATCH docs] ballooning example: improve wording

2024-01-16 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- qm.adoc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index fa6a772..c2392f3 100644 --- a/qm.adoc +++ b/qm.adoc @@ -689,8 +689,7 @@ database VM when spare RAM is available. For this you assign a Shares property of

[pve-devel] [PATCH docs] pvecm: correct network address

2024-01-16 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- pvecm.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvecm.adoc b/pvecm.adoc index 14556c2..48d86bc 100644 --- a/pvecm.adoc +++ b/pvecm.adoc @@ -661,7 +661,7 @@ hostnames, ensure that they are resolvable from all nodes (see also

Re: [pve-devel] [PATCH qemu-server] qmeventd: also treat 'prelaunch' and 'suspended' states as active

2024-01-16 Thread Fiona Ebner
Am 10.10.23 um 10:57 schrieb Fiona Ebner: > Otherwise, a VM in those states would be terminated after a backup > in handle_qmp_return() with QMP 'quit', which is pretty bad in case > of the 'suspended' state. > > Does not change the fact that a VM started in prelaunch mode for > backup is

Re: [pve-devel] [PATCH storage 1/2] plugin schema: improve description of 'shared' property

2024-01-16 Thread Fiona Ebner
Am 04.10.23 um 09:35 schrieb Fiona Ebner: > It's not clear to users what this property does otherwise. Latest > report from the community forum: > > https://forum.proxmox.com/threads/134393 > > Signed-off-by: Fiona Ebner Ping ___ pve-devel mailing

Re: [pve-devel] [PATCH cluster/manager/storage/docs 0/9] fix #4886: improve SSH handling

2024-01-16 Thread Hannes Dürr
On 1/16/24 11:34, Thomas Lamprecht wrote: Am 15/01/2024 um 16:53 schrieb Hannes Dürr: Tested cluster creation with three new nodes on 8.1 and the patches Cluster creation and further ssh communication (eq. migration) worked flawless Tested-by: Hannes Duerr What about the reinstallation of

Re: [pve-devel] [PATCH cluster/manager/storage/docs 0/9] fix #4886: improve SSH handling

2024-01-16 Thread Thomas Lamprecht
Am 16/01/2024 um 11:40 schrieb Fabian Grünbichler: > >> Thomas Lamprecht hat am 16.01.2024 11:34 CET >> geschrieben: >> >> >> Am 15/01/2024 um 16:53 schrieb Hannes Dürr: >>> Tested cluster creation with three new nodes on 8.1 and the patches >>> Cluster creation and further ssh communication

Re: [pve-devel] [PATCH cluster/manager/storage/docs 0/9] fix #4886: improve SSH handling

2024-01-16 Thread Fabian Grünbichler
> Thomas Lamprecht hat am 16.01.2024 11:34 CET > geschrieben: > > > Am 15/01/2024 um 16:53 schrieb Hannes Dürr: > > Tested cluster creation with three new nodes on 8.1 and the patches > > Cluster creation and further ssh communication (eq. migration) worked > > flawless > > > > Tested-by:

Re: [pve-devel] [PATCH cluster/manager/storage/docs 0/9] fix #4886: improve SSH handling

2024-01-16 Thread Thomas Lamprecht
Am 15/01/2024 um 16:53 schrieb Hannes Dürr: > Tested cluster creation with three new nodes on 8.1 and the patches > Cluster creation and further ssh communication (eq. migration) worked > flawless > > Tested-by: Hannes Duerr What about the reinstallation of an existing node, or replacing one,

Re: [pve-devel] [PATCH pve-manager] fix #4963: firewall: fix editing firewall rules using cidrs

2024-01-16 Thread Mira Limbeck
On 1/15/24 17:28, Stefan Hanreich wrote: > Fallback to v.ref when we do not use an alias or ipset in order to be > able to use normal CIDRs as source / destination address again > > Signed-off-by: Stefan Hanreich > --- > www/manager6/form/IPRefSelector.js | 4 +++- > 1 file changed, 3

[pve-devel] applied: [PATCH cluster] cfs_write_file: fix accidental UTF-8 re-encoding

2024-01-16 Thread Fabian Grünbichler
with Filip's T-B, thanks! On January 9, 2024 12:55 pm, Fiona Ebner wrote: > by correclty passing the $force_utf8 flag to > PVE::Tools::file_set_contents(). The idea was that only callers that > are ready will opt-in to the behavior. > > When reading files with PVE::Tools::file_get_contents() or

Re: [pve-devel] [PATCH cluster 2/4] fix #4886: SSH: pin node's host key if available

2024-01-16 Thread Fabian Grünbichler
> Esi Y via pve-devel hat am 15.01.2024 15:31 CET > geschrieben: > On Mon, Jan 15, 2024 at 12:51:48PM +0100, Fabian Grünbichler wrote: > > > On Thu, Jan 11, 2024 at 11:51:16AM +0100, Fabian Grünbichler wrote: > > > > if the target node has already stored their SSH host key on pmxcfs, pin > > >