Re: [pve-devel] [PATCH manager 1/3] fix #5255: node: wol: add optional bind interface

2024-03-21 Thread Thomas Lamprecht
On 05/03/2024 13:54, Christian Ebner wrote: > Allows to optionally configure a local interface name to which to > bind to when sending a wake on lan packet to wake a remote node. > > Default behaviour remains to send the packet via the interface for > the default gateway. > > Signed-off-by:

[pve-devel] applied: [PATCH v2 pve-manager 1/2] fix #5198: ceph: mon: fix mon existence check in mon removal assertion

2024-03-21 Thread Thomas Lamprecht
Am 14/03/2024 um 11:19 schrieb Max Carrara: > The Ceph monitor removal assertion contains a condition that checks > whether the given mon ID actually exists and thus may be removed. > > The first part of the condition checks whether the hash returned by > `get_services_info` [0] contains the key

Re: [pve-devel] [PATCH manager] ui: storage: esxi: check 'skip certificate verification' by default

2024-03-21 Thread Thomas Lamprecht
On 20/03/2024 16:39, Dominik Csapak wrote: > needing one less step when adding the storage, assuming most esxi > certificates are self-signed. Well this makes it insecure by default though? Which is not something I'd just not mention in such a commit message... As that was the original reason I

[pve-devel] applied: [PATCH manager] ui: agentipview: make text in grid selectable

2024-03-21 Thread Thomas Lamprecht
On 21/03/2024 10:25, Aaron Lauterer wrote: > This makes it possible to select any of the IP addresses listed in the > full view window to copy & paste it. > > Signed-off-by: Aaron Lauterer > --- > Becaue @Folke made a remark that this was a nuisance ;) > > www/manager6/qemu/AgentIPView.js | 3

[pve-devel] applied: [PATCH docs 1/2] qm: multiqueue specify that it needs to be vCPUs not cores

2024-03-21 Thread Aaron Lauterer
On 2024-03-21 16:50, Stefan Sterz wrote: total number of cores != vCPUs if there is more than one socket configured. according to the redhat docs it should be vCPUs not cores: Multi-queue virtio-net provides the greatest performance benefit when: [..] - The number of queues is equal to

[pve-devel] [PATCH docs 2/2] qm: add documentation on configuring multiqueue for windows guests

2024-03-21 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- qm.adoc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/qm.adoc b/qm.adoc index 8630419..711fa3f 100644 --- a/qm.adoc +++ b/qm.adoc @@ -780,6 +780,16 @@ ethtool command: where X is the number of the number of vCPUs of the VM. +To configure a

[pve-devel] [PATCH docs 1/2] qm: multiqueue specify that it needs to be vCPUs not cores

2024-03-21 Thread Stefan Sterz
total number of cores != vCPUs if there is more than one socket configured. according to the redhat docs it should be vCPUs not cores: > Multi-queue virtio-net provides the greatest performance benefit when: > [..] > - The number of queues is equal to the number of vCPUs.

[pve-devel] [PATCH docs v3 1/5] package-repos: improve wording partly based on pmg-docs

2024-03-21 Thread Christoph Heiss
Some sentences are phrased better and more expansive in pmg-docs, so take them from there and adapt them as needed. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * deduplicate email/changelog paragraph, move to top * deduplicate enterprise repo introduction sentence * very slightly

[pve-devel] [PATCH docs v3 4/5] installation: zfs-options: improve & align wording with pmg-docs

2024-03-21 Thread Christoph Heiss
These changes are the result of basically "diffing" both documentations, choosing the better prased/sounding sections. Some wording were also slightly changed as necessary to further improve them. The equivalent changes will be done for pmg-docs too, to ensure they are really the same in the end.

Re: [pve-devel] [PATCH docs v2 0/5] improve & unify installation(-related) documentation

2024-03-21 Thread Christoph Heiss
v3: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062314.html On Mon, Mar 11, 2024 at 01:29:06PM +0100, Christoph Heiss wrote: > This series in short tries to bring the documentation for the > ISO installation flow and anything related to it in line the with > respective documentation

[pve-devel] [PATCH docs v3 2/5] installation: iso: improve & align wording with pmg-docs

2024-03-21 Thread Christoph Heiss
New paragraphs were taken from pmg-docs and adapted. Most changes here are the result of basically "diffing" both documentations, choosing the better prased/sounding sections. Some wording were slightly changed as necessary to further improve them. The equivalent changes will be done for pmg-docs

[pve-devel] [PATCH docs v3 5/5] installation: iso: reflow location and password dialog screenshots

2024-03-21 Thread Christoph Heiss
The same changes were done in commit 4c35e536b ("installation: reword/expand/reflow and fix login thumbnail") in pmg-docs to improve the layout as good as possible. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * none Changes v2 -> v3: * none pve-installation.adoc | 4 ++-- 1

[pve-devel] [PATCH docs v3 0/5] improve & unify installation(-related) documentation

2024-03-21 Thread Christoph Heiss
This series in short tries to bring the documentation for the ISO installation flow and anything related to it in line the with respective documentation for PMG. As both products use the same installer (minus small differences such as LVM options and BTRFS support) and overall same basic system

[pve-devel] [PATCH docs v3 3/5] installation: lvm-options: improve & align wording with pmg-docs

2024-03-21 Thread Christoph Heiss
These changes are the result of basically "diffing" both documentations, choosing the better prased/sounding sections. Some wording were also slightly changed as necessary to further improve them. The equivalent changes will be done for pmg-docs too, to ensure they are really the same in the end.

[pve-devel] [PATCH stable-7 qemu] fix #2258: select correct device when removing drive snapshot via QEMU

2024-03-21 Thread Maximiliano Sandoval
The QMP command needs to be issued for the device where the disk is currently attached, not for the device where the disk was attached at the time the snapshot was taken. Fixes the following scenario with a disk image for which do_snapshots_with_qemu() is true (i.e. qcow2 or RBD+krbd=0): 1. Take

Re: [pve-devel] [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-21 Thread Aaron Lauterer
v2 is on the list https://lists.proxmox.com/pipermail/pve-devel/2024-March/062296.html On 2024-03-20 09:56, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- pve-system-requirements.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pve-system-requirements.adoc

Re: [pve-devel] [PATCH access-control] jobs: realm sync: fix scheduled LDAP syncs not applying attributes correctly

2024-03-21 Thread Christoph Heiss
On Tue, Mar 19, 2024 at 03:57:34PM +0100, Fiona Ebner wrote: > Am 19.03.24 um 14:48 schrieb Christoph Heiss: > > This was reported by a user in the forum [0]. > > > > The cause was that the user-* standard options were not registered when > > the sync was called from the scheduler, resulting in

[pve-devel] [PATCH manager] ui: agentipview: make text in grid selectable

2024-03-21 Thread Aaron Lauterer
This makes it possible to select any of the IP addresses listed in the full view window to copy & paste it. Signed-off-by: Aaron Lauterer --- Becaue @Folke made a remark that this was a nuisance ;) www/manager6/qemu/AgentIPView.js | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [pve-devel] [PATCH storage] esxi: detect correct os type in 'other' family

2024-03-21 Thread Gabriel Goller
On Thu Mar 21, 2024 at 10:04 AM CET, Stefan Sterz wrote: > talked off list with gabriel already this file was added accidentally. Thanks for the heads up! submitted a v2. ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] [PATCH storage v2] esxi: detect correct os type in 'other' family

2024-03-21 Thread Gabriel Goller
This patch introduces the conversion table for all possible OS Types that are in the VMWare 'other' family and sets the pve counterpart. Our default OS Type is 'linux', so including mappings to 'other' makes sense. Signed-off-by: Gabriel Goller --- v2, thanks @sterzy: - removed perltidy output

Re: [pve-devel] [PATCH storage] esxi: detect correct os type in 'other' family

2024-03-21 Thread Stefan Sterz
-->8 snip 8<-- > diff --git a/src/PVE/Storage/ESXiPlugin.pm.tdy > b/src/PVE/Storage/ESXiPlugin.pm.tdy > new file mode 100644 > index 000..2a08986 > --- /dev/null > +++ b/src/PVE/Storage/ESXiPlugin.pm.tdy > @@ -0,0 +1,1216 @@ > +package PVE::Storage::ESXiPlugin; > + talked off list with

[pve-devel] release a new pve-network package ? (evpn fix)

2024-03-21 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Hi, a critical bug in evpn with multiple nodes is fixed in git, https://git.proxmox.com/?p=pve-network.git;a=commit;h=e614da43f13e3c61f9b78ee9984364495eff91b6 but package is still not released I see a lot of user bug report since 4 months about this, like this recent one:

Re: [pve-devel] [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-21 Thread Thomas Lamprecht
(missed reply-all, so resending) On 20/03/2024 10:30, Fiona Ebner wrote: > Am 20.03.24 um 09:56 schrieb Aaron Lauterer: >> Signed-off-by: Aaron Lauterer >> --- >> pve-system-requirements.adoc | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/pve-system-requirements.adoc