[pve-devel] [PATCH installer] run env: use default error message if country detection failed with empty string

2024-03-26 Thread Christoph Heiss
Bit of perl fun again. $err from detect_country_tracing_to() can be empty string under certain circumstances (according to a forum post [0]). The // operator evaluates an empty as true, thus `warn` receives an empty string to and just prints Warning: something wrong at

[pve-devel] [PATCH manager] ui: guest import: allow setting mac addresses to unique

2024-03-26 Thread Aaron Lauterer
by adding a new checkbox and render the grid accordingly. If unique MAC addresses are enabled, set them to undefined when getting the values from the grid. Signed-off-by: Aaron Lauterer --- not sure if setting `uniqueMac` directly on the component is okay. Though we do that dynamically for the

Re: [pve-devel] [PATCH storage] esxi: use mac address when static, generated and vpx

2024-03-26 Thread Aaron Lauterer
sent a v2, unfortunately also one a bit too quickly (with no changes). please ignore that one :) On 2024-03-26 12:36, Thomas Lamprecht wrote: Am 26/03/2024 um 12:03 schrieb Aaron Lauterer: static -> defined manually generated -> by ESXi vpx -> generated by vCenter nice! Signed-off-by:

Re: [pve-devel] [PATCH storage v2] esxi: use mac address when static, generated and vpx

2024-03-26 Thread Aaron Lauterer
please ignore this one On 2024-03-26 13:04, Aaron Lauterer wrote: static -> defined manually generated -> by ESXi vpx -> generated by vCenter Signed-off-by: Aaron Lauterer --- src/PVE/Storage/ESXiPlugin.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[pve-devel] [PATCH storage v2] esxi: use mac address when static, generated and vpx

2024-03-26 Thread Aaron Lauterer
static -> defined manually generated -> by ESXi vpx -> generated by vCenter Signed-off-by: Aaron Lauterer --- src/PVE/Storage/ESXiPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm index 77fb6c0..9c9f680

[pve-devel] [PATCH storage v2] esxi: use mac address when static, generated and vpx

2024-03-26 Thread Aaron Lauterer
static -> defined manually generated -> by ESXi vpx -> generated by vCenter Signed-off-by: Aaron Lauterer --- src/PVE/Storage/ESXiPlugin.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm index

Re: [pve-devel] [PATCH storage] esxi: use mac address when static, generated and vpx

2024-03-26 Thread Thomas Lamprecht
Am 26/03/2024 um 12:03 schrieb Aaron Lauterer: > static -> defined manually > generated -> by ESXi > vpx -> generated by vCenter nice! > Signed-off-by: Aaron Lauterer > --- > src/PVE/Storage/ESXiPlugin.pm | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

[pve-devel] [PATCH storage] esxi: use mac address when static, generated and vpx

2024-03-26 Thread Aaron Lauterer
static -> defined manually generated -> by ESXi vpx -> generated by vCenter Signed-off-by: Aaron Lauterer --- src/PVE/Storage/ESXiPlugin.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm index

Re: [pve-devel] [PATCH manager 1/3] fix #5255: node: wol: add optional bind interface

2024-03-26 Thread Christian Ebner
> On 22.03.2024 15:37 CET Christian Ebner wrote: > > Agreed, will send a new version with the suggested changes to the format > string. Version 2 of the patches: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062397.html ___ pve-devel

[pve-devel] [PATCH v2 pve-manager 3/4] fix #5255: node: wol: configurable broadcast address

2024-03-26 Thread Christian Ebner
Allows to configure a custom broadcast address to use when sending a wake on lan packet to wake a remote node. Default behaviour remains to fallback to 255.255.255.255. Signed-off-by: Christian Ebner --- changes since version 1: - Adapted to use property string PVE/API2/Nodes.pm | 3 ++-

[pve-devel] [PATCH v2 pve-docs 4/4] pvenode/wake-on-lan: mention optional config options

2024-03-26 Thread Christian Ebner
Show how to configure the optional bind interface and broadcast address options via `pvenode`. Signed-off-by: Christian Ebner --- pvenode.adoc | 14 ++ 1 file changed, 14 insertions(+) diff --git a/pvenode.adoc b/pvenode.adoc index 59eeecb..6cf5bc9 100644 --- a/pvenode.adoc +++

[pve-devel] [PATCH v2 pve-manager 2/4] fix #5255: node: wol: add optional bind interface

2024-03-26 Thread Christian Ebner
Allows to optionally configure a local interface name to which to bind to when sending a wake on lan packet to wake a remote node. Default behaviour remains to send the packet via the interface for the default gateway. Signed-off-by: Christian Ebner --- changes since version 1: - Adapted to use

[pve-devel] [PATCH v2 pve-manager pve-docs 0/4] add optional WoL config options

2024-03-26 Thread Christian Ebner
For certain network setups the default values currently used to send a wake on lan magic packet are not correct, e.g. it will get send via the interface for which the default gateway is configured. This patches add optional configuration options to set a bind interface, over which to send the WoL

[pve-devel] [PATCH v2 pve-manager 1/4] node: config: make wakeonlan a property string

2024-03-26 Thread Christian Ebner
Moves the wakeonlan property to be a property string, with current mac address as default key. This allows to later add further optional properties such as bind-interface and broadcast-address. Adds the `get_wakeonlan_config` helper function to parse the string when read from the node config.