[pve-devel] applied: [PATCH installer] run env: use default error message if country detection failed with empty string

2024-04-08 Thread Thomas Lamprecht
Am 26/03/2024 um 14:29 schrieb Christoph Heiss: > Bit of perl fun again. > $err from detect_country_tracing_to() can be empty string under certain > circumstances (according to a forum post [0]). The // operator > evaluates an empty as true, thus `warn` receives an empty string to and > just

[pve-devel] applied: [PATCH common] docs: add missing prefix

2024-04-08 Thread Thomas Lamprecht
Am 27/03/2024 um 14:09 schrieb Folke Gleumes: > include 'PVEAPIToken=' prefix in the example for target-endpoint which > is mainly used for remote migrations. > > Signed-off-by: Folke Gleumes > --- > src/PVE/JSONSchema.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied,

[pve-devel] applied: [PATCH pve-manager v2] sdn: evpn: allow empty primary exit node in zone form

2024-04-08 Thread Thomas Lamprecht
Am 22/02/2024 um 17:40 schrieb Stefan Hanreich: > its broken since the change in semantics of the PUT endpoint [1] > > [1] > https://git.proxmox.com/?p=pve-network.git;a=commit;h=3e3cafabaf955d53c4c2d4e346bf5c3a5c6d1852 > > Signed-off-by: Stefan Hanreich > Originally-by: Alexandre Derumier >

[pve-devel] applied: [PATCH v3 pve-network 00/12] SDN: Testing VNets as a blackbox and fixing found bugs

2024-04-08 Thread Thomas Lamprecht
Am 05/04/2024 um 15:17 schrieb Stefan Lendl: > This add several tests for SDN VNets. > State setup as well as testing results is done only via the API to test on the > API boundaries and not against the internal state. Internal state and config > files are mocked to avoid requiring access to

[pve-devel] applied: [PATCH] fix #4835: order zfs-import@ before -cache/-scan

2024-04-08 Thread Thomas Lamprecht
Am 28/03/2024 um 10:41 schrieb Fabian Grünbichler: > this should fix failures of the template instances because either of the two > other import services picked up the pool in question first. > > Signed-off-by: Fabian Grünbichler > --- > ...dd-systemd-unit-for-importing-specific-pools.patch |

[pve-devel] applied: [PATCH ksm-control-daemon] ksmtuned: use PSS instead of RSZ for caluculating memory usage

2024-04-08 Thread Thomas Lamprecht
Am 08/04/2024 um 15:25 schrieb Stefan Lendl: > PSS properly accounts for memory usage of shared libraries and is > therefore better suited when summing up memory usage of multiple > processes. > > Signed-off-by: Stefan Lendl > --- > debian/patches/series | 1 + >

Re: [pve-devel] [PATCH qemu-server v3] QEMU AMD SEV enable

2024-04-08 Thread Thomas Lamprecht
Am 09/12/2022 um 15:25 schrieb Markus Frank: > This Patch is for enabling AMD SEV (Secure Encrypted > Virtualization) support in QEMU > > VM-Config-Examples: > amd_sev: type=std,nodbg=1,noks=1 > amd_sev: es,nodbg=1,kernel-hashes=1 > > Node-Config-Example (gets generated automatically): >

[pve-devel] [PATCH ksm-control-daemon] ksmtuned: use PSS instead of RSZ for caluculating memory usage

2024-04-08 Thread Stefan Lendl
PSS properly accounts for memory usage of shared libraries and is therefore better suited when summing up memory usage of multiple processes. Signed-off-by: Stefan Lendl --- debian/patches/series | 1 + debian/patches/use-pss-instead-of-rsz.diff | 11 +++ 2 files

Re: [pve-devel] [PATCH ksm-control-daemon] ksmtuned: fix large number processing

2024-04-08 Thread Stefan Lendl
Thomas Lamprecht writes: > Am 08/04/2024 um 14:04 schrieb Stefan Lendl: >> I agree summing up processes it would make sense to use PSS. >> Unfortunately, ps does not report the PSS. > > The `ps` from the Debian Bookworm version of the `procps` package does report > it here if I use something

Re: [pve-devel] [PATCH qemu v2 07/21] PVE backup: add fleecing option

2024-04-08 Thread Wolfgang Bumiller
On Fri, Mar 15, 2024 at 11:24:48AM +0100, Fiona Ebner wrote: > When a fleecing option is given, it is expected that each device has > a corresponding "-fleecing" block device already attached, except for > EFI disk and TPM state, where fleecing is never used. > > The following graph was adapted

[pve-devel] applied: [PATCH v2 ksm-control-daemon 1/2] ksmtuned: revert to use rsz instead of vsz to compute memory usage

2024-04-08 Thread Thomas Lamprecht
Am 08/04/2024 um 14:17 schrieb Stefan Lendl: > For summing up actual memory usage of precesses rsz is more suitable > then vsz. > > This reverts commit cd5cf20cc8af53427dcb9b08486c68f376ce8743. > > Signed-off-by: Stefan Lendl > --- > debian/patches/series | 1 - >

Re: [pve-devel] [PATCH widget-toolkit v3] window: edit: avoid sharing custom config objects between subclasses

2024-04-08 Thread Thomas Lamprecht
Am 08/04/2024 um 12:36 schrieb Stefan Sterz: > On Mon Apr 8, 2024 at 11:30 AM CEST, Friedrich Weber wrote: >> +constructor: function(conf) { >> +let me = this; >> +// make copies in order to prevent subclasses from accidentally writing >> +// to objects that are shared with other

Re: [pve-devel] [PATCH ksm-control-daemon] ksmtuned: fix large number processing

2024-04-08 Thread Thomas Lamprecht
Am 08/04/2024 um 14:04 schrieb Stefan Lendl: > I agree summing up processes it would make sense to use PSS. > Unfortunately, ps does not report the PSS. The `ps` from the Debian Bookworm version of the `procps` package does report it here if I use something like `ps -C kvm -o pss` though, FWICT

[pve-devel] [PATCH v2 ksm-control-daemon 1/2] ksmtuned: revert to use rsz instead of vsz to compute memory usage

2024-04-08 Thread Stefan Lendl
For summing up actual memory usage of precesses rsz is more suitable then vsz. This reverts commit cd5cf20cc8af53427dcb9b08486c68f376ce8743. Signed-off-by: Stefan Lendl --- debian/patches/series | 1 - debian/patches/use-vsz-instead-of-rsz.diff | 13 - 2 files

[pve-devel] [PATCH v2 ksm-control-daemon 2/2] ksmtuned: fix formatting when summing up large numbers

2024-04-08 Thread Stefan Lendl
awk internally uses float for every calculation, printing a large float with awk results in 1.233e+09 format which causes the script to fail afterwards. Instead I am printing the float without decimals. Signed-off-by: Stefan Lendl --- debian/patches/awk-printf.diff | 16

Re: [pve-devel] [PATCH ksm-control-daemon] ksmtuned: fix large number processing

2024-04-08 Thread Stefan Lendl
Thomas Lamprecht writes: > Hi, > > Am 28/02/2024 um 23:47 schrieb Roland: >> any reason why this did not get a response ?  (i do not see rejection of >> this  ,nor did it appear in >> https://git.proxmox.com/?p=ksm-control-daemon.git;a=summary ) > > No reason, but even if this looks pretty

Re: [pve-devel] [PATCH v3 pve-network 00/12] SDN: Testing VNets as a blackbox and fixing found bugs

2024-04-08 Thread Stefan Hanreich
Already mentioned in the commits, but gave this another spin today on my test VM and everything seems to work as intended: * Rollbacking on failure * Allocating an IPv6 IP on start, if there is already an IPv4 allocated * Ignoring subnets without any configured DHCP-Range Also, the pre-existing

Re: [pve-devel] [PATCH widget-toolkit v3] window: edit: avoid sharing custom config objects between subclasses

2024-04-08 Thread Stefan Sterz
On Mon Apr 8, 2024 at 11:30 AM CEST, Friedrich Weber wrote: > Currently, `Proxmox.window.Edit` initializes `extraRequestParams` and > `submitOptions` to two objects that, if not overwritten, are shared > between all instances of subclasses. This bears the danger of > modifying the shared object in

[pve-devel] [PATCH manager v16 1/2] ui: qemu: change DisplayEdit logic to use ViewModel instead of listener function

2024-04-08 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/qemu/DisplayEdit.js | 57 ++-- 1 file changed, 33 insertions(+), 24 deletions(-) diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js index 9bb1763e..17b02ee4 100644 ---

[pve-devel] [PATCH manager v16 2/2] ui: qemu: add clipboard ComboBox as a advanced option in DisplayEdit

2024-04-08 Thread Markus Frank
For SPICE and VNC, a different message is displayed. The backend code for the clipboard option can be found in the 'config: enable vnc clipboard parameter in vga_fmt'-commit in qemu-server. Signed-off-by: Markus Frank --- www/manager6/qemu/DisplayEdit.js | 41

[pve-devel] [PATCH widget-toolkit v3] window: edit: avoid sharing custom config objects between subclasses

2024-04-08 Thread Friedrich Weber
Currently, `Proxmox.window.Edit` initializes `extraRequestParams` and `submitOptions` to two objects that, if not overwritten, are shared between all instances of subclasses. This bears the danger of modifying the shared object in a subclass instead of overwriting it, which affects all edit

Re: [pve-devel] [PATCH container v2 3/6] fix #4474: lxc api: add overrule-shutdown parameter to stop endpoint

2024-04-08 Thread Friedrich Weber
On 06/04/2024 17:07, Thomas Lamprecht wrote: > Am 30/01/2024 um 18:10 schrieb Friedrich Weber: > [...] >> +raise_param_exc({ 'overrule-shutdown' => "Not applicable for HA >> resources." }) >> +if $overrule_shutdown; > > This probably could be implemented through a CRM command

Re: [pve-devel] [PATCH manager v2 13/21] api: backup/vzdump: add permission check for fleecing storage

2024-04-08 Thread Wolfgang Bumiller
On Fri, Mar 15, 2024 at 11:24:54AM +0100, Fiona Ebner wrote: > Similar to how Datastore.AllocateSpace is required for the backup > storage, it should also be required for the fleecing storage. > > Removing a fleecing storage from a job does not require more > permissions than for modifying the

Re: [pve-devel] [PATCH guest-common v2 1/6] guest helpers: add helper to overrule active tasks of a specific type

2024-04-08 Thread Friedrich Weber
On 06/04/2024 10:37, Thomas Lamprecht wrote: >> Still, right now I think the primary motivation for this overruling >> feature is to save GUI users some frustration and/or clicks. In this >> scenario, a user will overrule only their own tasks, which is possible >> with the current check. What do