both STDOUT and STDERR are written into `$info` which is then parsed for
IP and port of the target socket listening.
when the ports file can't be locked immediately `trying to acquire
lock...` is printed on STDERR and in turn written into `$info`.
trying to parse the IP then fails, resulting in a
Am 05.12.23 um 15:36 schrieb Christian Ebner:
> Allow to filter firewall logs analogous to node and VM firewall logs.
>
> Signed-off-by: Christian Ebner
> ---
> www/manager6/lxc/Config.js | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/www/manager6/lxc/Config.js
On February 23, 2024 1:03 pm, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer
> ---
>
> came up in enterprise support, and I don't think there is a reason to
> not have it in the UI, while having it in the API
>
> v2:
> - use Aaron's improved help text
>
> www/manager6/storage/DirEdit.js
Am 15.04.24 um 15:17 schrieb Filip Schauer:
> The get_device_stat subroutine gets a device path, validates it, and
> returns the file mode and the device identifier.
>
> Signed-off-by: Filip Schauer
> ---
> src/PVE/Tools.pm | 18 +-
> 1 file changed, 17 insertions(+), 1
v3: https://lists.proxmox.com/pipermail/pve-devel/2024-April/062976.html
On Wed, Feb 07, 2024 at 03:28:11PM +0100, Christoph Heiss wrote:
> As suggested by Thomas, leaves the ZFS default if the user never touches
> the setting in the installer (i.e. not writing a modprobe file).
> See also the
Enables to add an optional placeholder value to `NumericEditView`, which
will be displayed in a different (darker) color and not returned by
`.get_content*()`.
Can be used for having default values in the TUI, but with different
handling in the back.
Signed-off-by: Christoph Heiss
---
Changes
For non-PVE products, simply use the ZFS defaults (aka. 50%) and leave
unset, if the user never touches that setting.
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 -> v2:
* use new placeholder functionality for non-PVE products
For non-PVE products, simply use the ZFS defaults (aka. 50%) and leave
unset, if the user never touches that setting.
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* rework based on Maximilano's suggestion using Gtk3::Adjustment
Changes v1 -> v2:
* add some more explanatory comments
As suggested by Thomas, leaves the ZFS default if the user never touches
the setting in the installer (i.e. not writing a modprobe file).
See also the discussion in v1 [0].
[0] https://lists.proxmox.com/pipermail/pve-devel/2024-February/061659.html
Testing
---
Tested the installation of PVE
On 11/04/2024 14:18, Fiona Ebner wrote:
-
my $absolute_path = $device->{path};
my ($mode, $rdev) = (stat($absolute_path))[2, 6];
- die "Device $absolute_path does not exist\n" if $! == ENOENT;
-
die "Error accessing device $absolute_path\n"
if
Fix a bug that allows a device passthrough entry to be added to the
config despite the device path not pointing to a device. Previously,
adding an invalid device passthrough entry would throw an error, but the
entry would still be added to the config. This is fixed by moving the
respective checks
Fix a bug that allows a device passthrough entry to be added to the
config despite the device path not pointing to a device. Previously,
adding an invalid device passthrough entry would throw an error, but the
entry would still be added to the config. This is fixed by moving the
respective checks
The get_device_stat subroutine gets a device path, validates it, and
returns the file mode and the device identifier.
Signed-off-by: Filip Schauer
---
src/PVE/Tools.pm | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
Am 23.02.24 um 13:03 schrieb Hannes Laimer:
> Signed-off-by: Hannes Laimer
Reviewed-by: Fiona Ebner
> ---
>
> came up in enterprise support, and I don't think there is a reason to
> not have it in the UI, while having it in the API
>
This rationale could/should become the commit message,
The original fix disabled the xsaves feature for zen1/2. The issue has
since been fixed in the cpus microcode and this patch keeps the feature enabled
if the microcode version is recent enough to contain the fix.
The patch had to be altered slightly to apply cleanly on 6.5, but no
changes
The original fix disabled the xsaves feature for zen1/2. The issue has
since been fixed in the cpus microcode and this patch keeps the feature enabled
if the microcode version is recent enough to contain the fix.
Signed-off-by: Folke Gleumes
---
Tested this on an AMD Epyc 7302P v2.
Signed-off-by: Fiona Ebner
---
pve-storage-pbs.adoc | 4
1 file changed, 4 insertions(+)
diff --git a/pve-storage-pbs.adoc b/pve-storage-pbs.adoc
index c33ee40..84d598f 100644
--- a/pve-storage-pbs.adoc
+++ b/pve-storage-pbs.adoc
@@ -24,6 +24,10 @@ server::
Server IP or DNS name.
Commit 7020491 ("esxi: add 'port' config parameter") started using
the 'port' option in a second plugin, but the definition stayed in the
PBS plugin. Avoid the hidden dependency and move the definition to the
base plugin instead.
It is necessary to mark it as optional or it would be required
On April 11, 2024 11:32 am, Wolfgang Bumiller wrote:
> On Wed, Apr 10, 2024 at 03:13:08PM +0200, Fabian Grünbichler wrote:
>> so that other nodes can query it and both block changes that would violate
>> the
>> limits, and mark pools which are violating it currently accordingly.
>>
>>
Am 31.01.24 um 16:03 schrieb Filip Schauer:
> diff --git a/www/manager6/lxc/DeviceEdit.js b/www/manager6/lxc/DeviceEdit.js
> new file mode 100644
> index ..445f8607
> --- /dev/null
> +++ b/www/manager6/lxc/DeviceEdit.js
> @@ -0,0 +1,190 @@
> +Ext.define('PVE.lxc.DeviceInputPanel', {
> +
Am 31.01.24 um 16:03 schrieb Filip Schauer:
> Clarify the naming of mount point utils to clearly indicate their
> relation to LXC containers.
>
> Signed-off-by: Filip Schauer
Reviewed-by: Fiona Ebner
___
pve-devel mailing list
> Daniel Krambrock via pve-devel hat am
> 11.04.2024 10:09 CEST geschrieben:
Hi!
for both this and the access-control patch, please add
- *some* commit message (e.g., something like "stable sorting in XX config file
allows tracking changes by checking into git or when using automation like
same as the guests use for that.
Signed-off-by: Dominik Csapak
---
lib/widgets/pve_node_overview.dart | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lib/widgets/pve_node_overview.dart
b/lib/widgets/pve_node_overview.dart
index 020eeba..219d498 100644
---
in those cases, we sometimes get ugly stack traces/exceptions, so
instead of just showing that and aborting, show a custom dialog with
the basic info that we could not save the password (+details box with
the original error) and continue instead.
Signed-off-by: Dominik Csapak
---
so one can return to the previous view without having to use the back
button of the device.
Signed-off-by: Dominik Csapak
---
lib/widgets/pve_console_menu_widget.dart | 107 ---
1 file changed, 57 insertions(+), 50 deletions(-)
diff --git
similar to how it works for qemu
Signed-off-by: Dominik Csapak
---
this depends on the dart-api-client patch, otherwise the url is wrong
lib/bloc/pve_node_overview_bloc.dart | 11
lib/widgets/pve_node_overview.dart| 24
.../pve_node_power_settings_widget.dart
instead of flutter webview. This new dependency does not have the
limitations of the "official" flutter webview. We now can ignore
https errors and even get some info on the certificate.
We use that to now show a 'do you want to trust this cert' dialog with
the fingerprint of the server, which
by using 'SystemNavigator.pop()' on the top level page when pressing the
back button. On Android this minimizes/closes the app an presents
whatever was shown before.
This fixes an issue where we would show a blank screen when pressing the
back button on the dashboard.
Signed-off-by: Dominik
some improvements:
* better error handling for saving the password
* adding node power actions (shutdown/restart)
* change webview so we can show it without a trusted certificate
* improve back button behavior
flutter-frontend patch 1 depends on login-manager patch 2
flutter-frontend patch 4
using '?' in the url will be escaped and not used for the get
parameters. Instead add the command to the parameters map.
Signed-off-by: Dominik Csapak
---
lib/src/client.dart | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/src/client.dart b/lib/src/client.dart
index
where we can save the fingerprints the user wants to trust
Signed-off-by: Dominik Csapak
---
lib/proxmox_general_settings_model.dart | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/proxmox_general_settings_model.dart
b/lib/proxmox_general_settings_model.dart
index
When mode is 'auto' and 'mailto' is empty, show hint that the
notification system will be used.
Signed-off-by: Lukas Wagner
Tested-by: Maximiliano Sandoval
---
www/manager6/window/Backup.js | 37 +++
1 file changed, 33 insertions(+), 4 deletions(-)
diff --git
- Switch order of 'mailto' and 'mailnotification' field
- When mode is 'auto', disable 'mailtnotification' field
- When mode is 'auto' and 'mailto' is empty, show
hint that the notification system will be used
Signed-off-by: Lukas Wagner
Tested-by: Maximiliano Sandoval
---
Notes:
On April 11, 2024 11:17 am, Wolfgang Bumiller wrote:
> On Wed, Apr 10, 2024 at 03:13:06PM +0200, Fabian Grünbichler wrote:
>> one for combining the per-node broadcasted values, one for checking a pool's
>> limit, and one specific helper for checking guest-related actions such as
>> starting a VM.
On April 11, 2024 12:03 pm, Wolfgang Bumiller wrote:
> On Thu, Apr 11, 2024 at 09:23:53AM +0200, Fabian Grünbichler wrote:
>> On April 10, 2024 3:13 pm, Fabian Grünbichler wrote:
>> > Signed-off-by: Fabian Grünbichler
>> > ---
>> > src/PVE/API2/LXC/Config.pm | 21 +
>> > 1
On April 11, 2024 11:28 am, Wolfgang Bumiller wrote:
> On Wed, Apr 10, 2024 at 03:13:00PM +0200, Fabian Grünbichler wrote:
>> these are similar to existing ones, but with slightly different semantics.
>>
>> Signed-off-by: Fabian Grünbichler
>> ---
>> src/PVE/LXC.pm | 29
On 2024-04-11 09:44, Thomas Lamprecht wrote:
>> Tested both commits, they do what they promise.
>>
>>> + let notificationSystemHint = Ext.create({
>>> + xtype: 'displayfield',
>>> + padding: '0 0 0 5',
>>> + userCls: 'pmx-hint',
>>> + hidden: true,
>>> + value:
Am 12/04/2024 um 15:25 schrieb Fabian Grünbichler:
> Signed-off-by: Fabian Grünbichler
> ---
> test-built 6.8, but I assume 6.5 works as well since the patch applies cleanly
> there (build hasn't finished yet ;))
>
> I also assume this will be picked up fairly fast by stable point releases, but
---
www/manager6/qemu/MachineEdit.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/qemu/MachineEdit.js b/www/manager6/qemu/MachineEdit.js
index 48c72c1d..ee2b2dac 100644
--- a/www/manager6/qemu/MachineEdit.js
+++ b/www/manager6/qemu/MachineEdit.js
@@ -1,6 +1,7 @@
Added a proxmoxKVComboBox for selecting a vIOMMU implementation for a VM.
If i440fx is selected, another ComboBox will be enabled/visible that does not
have the Intel option, as Intel-vIOMMU is not compatible with i440fx.
Uses the new machine property-string from the qemu-server's "config: define
On April 12, 2024 3:25 pm, Fabian Grünbichler wrote:
> Signed-off-by: Fabian Grünbichler
> ---
> test-built 6.8, but I assume 6.5 works as well since the patch applies cleanly
> there (build hasn't finished yet ;))
FWIW, the 6.5 build worked as well
This should make the code more cohesive and easier to follow.
No functional changes.
Signed-off-by: Lukas Wagner
Tested-by: Maximiliano Sandoval
---
src/window/NotificationMatcherEdit.js | 186 +-
1 file changed, 92 insertions(+), 94 deletions(-)
diff --git
Also introduce a local viewModel that is linked to a parent viewModel,
allowing us to move the formulas to the panel.
This should make the code more cohesive and easier to follow.
No functional changes.
Signed-off-by: Lukas Wagner
Tested-by: Maximiliano Sandoval
---
This new API route returns known notification metadata fields and
a list of known possible values. This will be used by the UI to
provide suggestions when adding/modifying match rules.
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 152 ++
1 file
Signed-off-by: Lukas Wagner
---
notifications.adoc | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/notifications.adoc b/notifications.adoc
index 57053c8..0eeed6a 100644
--- a/notifications.adoc
+++ b/notifications.adoc
@@ -289,19 +289,22 @@ Notification
Signed-off-by: Lukas Wagner
---
www/manager6/Utils.js | 12
1 file changed, 12 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index d4b5f3e6..c46ec4df 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -2052,6 +2052,18 @@
- The man page warns about the usage of `hostname -f`, since a host
may have multiple domains (or none at all)
- The fallback PVE::INotify::nodename() already only returned the
hostname without the domain part
- Fencing notifications didn't include the domain part anyway
This may result
This was a bit inconsistent between the different notification types:
- APT/VZDump included the domain part
- fence notifications did not
A decision has been made to unify this by removing the domain part
from APT/VZDump notifications.
Signed-off-by: Lukas Wagner
---
notifications.adoc | 2
These changes introduce combogrid pickers for the 'field' and 'value'
form elements for 'match-field' match rules. The 'field' picker shows
a list of all known metadata fields, while the 'value' picker shows a
list of all known values, filtered depending on the current value of
'field'.
The list
Also introduce a local viewModel that is linked to a parent viewModel,
allowing us to move the formulas to the panel.
This should make the code more cohesive and easier to follow.
No functional changes.
Signed-off-by: Lukas Wagner
Tested-by: Maximiliano Sandoval
---
Signed-off-by: Lukas Wagner
---
notifications.adoc | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/notifications.adoc b/notifications.adoc
index 0eeed6a..912b048 100644
--- a/notifications.adoc
+++ b/notifications.adoc
@@ -221,11 +221,16 @@ configurable
The field contains the hostname of the host (without any domain part)
which sends the notification. This field can be used in match-field
match rules.
Signed-off-by: Lukas Wagner
---
PVE/API2/Replication.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/API2/Replication.pm
Signed-off-by: Lukas Wagner
---
www/manager6/dc/Backup.js | 1 -
1 file changed, 1 deletion(-)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 70903bdc..4beb84c0 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -569,7 +569,6 @@
This allows us to access us the backup job id in the send_notification
function, where we can set it as metadata for the notification.
Signed-off-by: Lukas Wagner
---
PVE/API2/VZDump.pm | 8
PVE/Jobs/VZDump.pm | 4 +++-
PVE/VZDump.pm | 6 +++---
3 files changed, 14 insertions(+),
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index 7047f0b1..68fdda2a 100644
--- a/PVE/API2/Cluster/Notifications.pm
+++
This allows users to create notification match rules for specific
replication jobs, if they so desire.
Signed-off-by: Lukas Wagner
---
PVE/API2/Replication.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm
index
This might be useful if somebody wants to match on the new
'backup-job' field in a notification match rule.
Signed-off-by: Lukas Wagner
---
www/manager6/Utils.js | 4
www/manager6/dc/Backup.js | 11 +++
2 files changed, 15 insertions(+)
diff --git a/www/manager6/Utils.js
This patch series attempts to improve the user experience when creating
notification matchers.
Some of the noteworthy changes:
- Fixup inconsistent 'hostname' field. Some notification events sent
the hostname including a domain, while other did not.
This series unifies the behavior, now the
58 matches
Mail list logo
