On May 23, 2024 12:40 pm, Dominik Csapak wrote:
> On 5/22/24 12:08, Fabian Grünbichler wrote:
>> On April 29, 2024 1:21 pm, Dominik Csapak wrote:
>>> since we want to handle ova files (which are only ovf+images bundled in
>>> a tar file) for import, add code that handles
Signed-off-by: Fabian Grünbichler
---
6.8/master only, patch straight from the linked LKML thread
affected user confirmed it fixes the issue, patch is very small and
straight-forward.
...-devices-which-return-an-unusually-l.patch | 51 +++
1 file changed, 51 insertions
one nit below, otherwise very nice to have this!
On May 3, 2024 10:34 am, Fiona Ebner wrote:
> There is a possibility that the drive-mirror job is not yet done when
> the migration wants to inactivate the source's blockdrives:
>
>> bdrv_co_write_req_prepare: Assertion `!(bs->open_flags &
but slight follow-up question below
On May 3, 2024 10:34 am, Fiona Ebner wrote:
> There's functions from all of those being used, but without importing
> first.
>
> Signed-off-by: Fiona Ebner
> ---
> PVE/QemuMigrate.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git
On April 29, 2024 1:21 pm, Dominik Csapak wrote:
> diff --git a/src/PVE/GuestImport.pm b/src/PVE/GuestImport.pm
> new file mode 100644
> index 000..d405e30
> --- /dev/null
> +++ b/src/PVE/GuestImport.pm
> @@ -0,0 +1,100 @@
> +package PVE::GuestImport;
> +
> +use strict;
> +use warnings;
> +
>
On April 29, 2024 1:21 pm, Dominik Csapak wrote:
> when 'import-from' contains a disk image that needs extraction
> (currently only from an 'ova' archive), do that in 'create_disks'
> and overwrite the '$source' volid.
>
> Collect the names into a 'delete_sources' list, that we use later
> to
On April 29, 2024 1:21 pm, Dominik Csapak wrote:
> this is to override the target extraction storage for the option disk
> extraction for 'import-from'. This way if the storage does not
> supports the content type 'images', one can give an alternative one.
>
> Signed-off-by: Dominik Csapak
>
On May 22, 2024 12:25 pm, Fabian Grünbichler wrote:
> On April 29, 2024 1:21 pm, Dominik Csapak wrote:
>> the api part was never in use by anything
>>
>> Signed-off-by: Dominik Csapak
>> ---
>> PVE/API2/Qemu/Makefile | 2 +
On April 29, 2024 1:21 pm, Dominik Csapak wrote:
> the api part was never in use by anything
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/API2/Qemu/Makefile | 2 +-
> PVE/API2/Qemu/OVF.pm | 53 --
as noted in the pve-storage patch, this should also
On April 29, 2024 1:21 pm, Dominik Csapak wrote:
> introducing a separate regex that only contains ova, since
> upload/downloading ovfs does not make sense (since the disks are then
> missing).
>
> Signed-off-by: Dominik Csapak
> ---
> src/PVE/API2/Storage/Status.pm | 18 ++
>
On April 29, 2024 1:21 pm, Dominik Csapak wrote:
> since we want to handle ova files (which are only ovf+images bundled in
> a tar file) for import, add code that handles that.
>
> we introduce a valid volname for files contained in ovas like this:
>
> storage:import/archive.ova/disk-1.vmdk
>
On April 29, 2024 1:21 pm, Dominik Csapak wrote:
> copies the OVF.pm and relevant ovf tests from qemu-server.
> We need it here, and it uses PVE::Storage already, and since there is no
> intermediary package/repository we could put it, it seems fitting in
> here.
>
> Put it in a new GuestImport
On April 29, 2024 1:21 pm, Dominik Csapak wrote:
> in DirPlugin and not Plugin (because of cyclic dependency of
> Plugin -> OVF -> Storage -> Plugin otherwise)
>
> only ovf is currently supported (though ova will be shown in import
> listing), expects the files to not be in a subdir, and adjacent
On April 29, 2024 1:21 pm, Dominik Csapak wrote:
> copies the OVF.pm and relevant ovf tests from qemu-server.
> We need it here, and it uses PVE::Storage already, and since there is no
> intermediary package/repository we could put it, it seems fitting in
> here.
>
> Put it in a new GuestImport
On May 16, 2024 2:08 pm, Aaron Lauterer wrote:
> because otherwise the SSH calls to other nodes in the cluster will fail
> on newer clusters that only have the ssh host keys located in the
> pmxcfs.
>
> With ssh_info_to_command we get all the needed SSH options that set the
> alias and point to
On May 15, 2024 12:32 pm, Aaron Lauterer wrote:
> because otherwise the SSH calls to other nodes in the cluster will fail
> on newer clusters that only have the ssh known host keys located in the
> pmxcfs.
>
> By utilizing SSHInfo::ssh_info_to_ssh_opts we can add the needed options
> to the SSH
On May 15, 2024 12:32 pm, Aaron Lauterer wrote:
> The first instance had the line break mid array. It now is a bit over
> the limit, but follows the style guide closely: putting each argument to
> the function in a newline.
>
> Signed-off-by: Aaron Lauterer
> ---
> src/PVE/CLI/pvecm.pm | 18
'utf-' is a typo, and can trip up some servers that do strict
checking/matching.
Signed-off-by: Fabian Grünbichler
---
Notes:
see
https://forum.proxmox.com/threads/invalid-charset-on-automated-install-answer-http-fetch.145856/
proxmox-fetch-answer/src/fetch_plugins/http.rs | 4 ++--
1
while some people write percentages as 0.XX , putting a % next to that is just
confusing. also, combined with the format modifier this would be rather lossy,
and also not match regular `df` output..
Signed-off-by: Fabian Grünbichler
---
src/PVE/CLI/pct.pm | 2 +-
1 file changed, 1 insertion
while it doesn't hurt to be installed, it also doesn't help in any fashion on
such systems.
Signed-off-by: Fabian Grünbichler
---
Notes:
only makes sense if proxmox-secure-boot-support is on the ISO
Proxmox/Install.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/Proxmox/Install.pm
as preparation for using it in more than one place.
Signed-off-by: Fabian Grünbichler
---
Proxmox/Install.pm| 18 +-
Proxmox/Install/RunEnv.pm | 12 +++-
2 files changed, 16 insertions(+), 14 deletions(-)
diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
On April 19, 2024 12:09 pm, Fiona Ebner wrote:
> Am 09.04.24 um 15:25 schrieb Lukas Wagner:
>> Bumps/dependencies:
>> - proxmox_notify
>> - libproxmox-rs-perl/libpve-rs-perl (needs bumped proxmox_notify)
>> - libpve-notify-perl (needs bumped
>>
On April 19, 2024 8:51 am, Dominik Csapak wrote:
> since commit
> 1f743141 (fix #1905: Allow moving unused disks)
>
> we want to check the source drive name for 'unused', but in case of
> importing a volume from the 'import' content type (e.g. from esxi),
> there is no source drive name. So we
with a small style follow-up, thanks!
create_base prints a warning (before this patch as well):
> WARNING: Combining activation change with other commands is not advised.
maybe we could get rid of that one? I guess it doesn't like `-an`
combined with other stuff..
On December 19, 2023 3:03 pm,
On April 18, 2024 12:35 pm, Fiona Ebner wrote:
> Am 18.04.24 um 11:27 schrieb Dominik Csapak:
>> ok after a bit of thinking and discussing off-list
>> the plan to go forward from my side is this:
>>
>> (please tell if there is something obviously wrong with it or you'd
>> strongly prefer
On April 18, 2024 9:22 am, Fiona Ebner wrote:
> Am 17.04.24 um 15:07 schrieb Dominik Csapak:
>> On 4/17/24 12:52, Fiona Ebner wrote:
>>> Am 16.04.24 um 15:18 schrieb Dominik Csapak:
we currently extract into the import storage in a directory named:
`.tmp__` which should not
On April 18, 2024 10:17 am, Thomas Lamprecht wrote:
> Am 11/04/2024 um 15:44 schrieb Fabian Grünbichler:
>> if $storage && $format eq 'raw' => no noacl ?
>
> shouldn't this branch be taken if the format is _not_ raw, as only in that
> case it might not use ext4?
>
On April 17, 2024 4:35 pm, Filip Schauer wrote:
> Do not use the 'noacl' mount option when mounting a container disk with
> an ext4 file system. The option was removed from the kernel in commit
> 2d544ec923db
>
> Signed-off-by: Filip Schauer
> ---
> Changes since v3:
> * Simplify ext4 detection
> Dominik Csapak hat am 17.04.2024 16:07 CEST
> geschrieben:
> On 4/17/24 15:52, Fabian Grünbichler wrote:
> > On April 17, 2024 3:10 pm, Dominik Csapak wrote:
> >> On 4/17/24 14:45, Fabian Grünbichler wrote:
> >>> On April 16, 2024 3:18 p
> Dominik Csapak hat am 17.04.2024 15:19 CEST
> geschrieben:
> On 4/17/24 15:11, Fabian Grünbichler wrote:
> > On April 16, 2024 3:18 pm, Dominik Csapak wrote:
> >> This series enables importing ova/ovf from directory based storages,
> >> inclusive upload
On April 17, 2024 3:10 pm, Dominik Csapak wrote:
> On 4/17/24 14:45, Fabian Grünbichler wrote:
>> On April 16, 2024 3:18 pm, Dominik Csapak wrote:
>>> +sub cleanup_extracted_image {
>>
>> same for this?
>>
>>> +my ($source) = @_;
>>&g
On April 17, 2024 3:07 pm, Dominik Csapak wrote:
> On 4/17/24 12:52, Fiona Ebner wrote:
>> Am 16.04.24 um 15:18 schrieb Dominik Csapak:
>>> since we want to handle ova files (which are only ovf+vmdks bundled in a
>>> tar file) for import, add code that handles that.
>>>
>>> we introduce a valid
On April 16, 2024 3:18 pm, Dominik Csapak wrote:
> This series enables importing ova/ovf from directory based storages,
> inclusive upload/download via the webui (ova only).
>
> It also improves the ovf importer by parsing the ostype, nics, bootorder
> (and firmware from vmware exported files).
>
On April 16, 2024 3:18 pm, Dominik Csapak wrote:
> since we want to handle ova files (which are only ovf+vmdks bundled in a
> tar file) for import, add code that handles that.
>
> we introduce a valid volname for files contained in ovas like this:
>
> storage:import/archive.ova/disk-1.vmdk
>
>
On April 16, 2024 3:18 pm, Dominik Csapak wrote:
> in DirPlugin and not Plugin (because of cyclic dependency of
> Plugin -> OVF -> Storage -> Plugin otherwise)
>
> only ovf is currently supported (though ova will be shown in import
> listing), expects the files to not be in a subdir, and adjacent
On April 16, 2024 3:19 pm, Dominik Csapak wrote:
> but only for non esxi ones, since that does not allow
> uploading/downloading there
what about a remove button? :)
>
> Signed-off-by: Dominik Csapak
> ---
> www/manager6/storage/Browser.js| 7 ++-
>
and (re-)enable on install. adapted from apt-listbugs/apt-listchanges, which
solve the issue of removing (instead of purging) the conffile and hook binary
providing package in the same fashion.
Suggested-by: Fiona Ebner
Signed-off-by: Fabian Grünbichler
Reviewed-by: Fiona Ebner
---
v2:
- add
applied this one as well, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
with T-B added, thanks!
PVE::AccessControl would benefit from a code style cleanup in general,
it's one of the more older modules with lots of "old style" code around..
On April 16, 2024 12:53 pm, Folke Gleumes wrote:
> Hi,
>
> thanks for your contribution!
>
> Looks fine to me. The saving
by checking the snapshot conf values as if the VM was newly created.
Signed-off-by: Fabian Grünbichler
---
PVE/API2/Qemu.pm | 8
1 file changed, 8 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index adbc6557..eca0ab79 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2
if the new value is higher than the old one, check against limits. if the old
one is higher, then the change is always okay, to support reducing the usage in
steps spread over multiple guests..
Signed-off-by: Fabian Grünbichler
---
PVE/API2/Qemu.pm | 22 ++
PVE
as early as possible, to avoid having to undo expensive work or allowing a
window for limit exhaustion..
Signed-off-by: Fabian Grünbichler
---
PVE/API2/Qemu.pm | 24
1 file changed, 24 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 78f2236c
determining the usage values for the current config. pending values are taken
into account if they are higher than the current value only, else it would be
possible to easily circumvent config limits by setting non-hotpluggable pending
values.
Signed-off-by: Fabian Grünbichler
---
PVE
allow to set/update limits, and return them when querying individual pools.
Signed-off-by: Fabian Grünbichler
---
Notes:
requires bumped pve-access-control
v2:
- unify run vs config limit checks into helper
- avoid hard-coding resource kinds
PVE/API2/Pool.pm | 50
by checking the snapshot conf values as if the CT was newly created.
Signed-off-by: Fabian Grünbichler
---
src/PVE/API2/LXC/Snapshot.pm | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/PVE/API2/LXC/Snapshot.pm b/src/PVE/API2/LXC/Snapshot.pm
index 0999fbc..37a02a6 100644
--- a/src
these are similar to existing ones, but with slightly different semantics.
Signed-off-by: Fabian Grünbichler
---
src/PVE/LXC.pm | 29 +
1 file changed, 29 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index e688ea6..9b03a97 100644
--- a/src/PVE/LXC.pm
and handle them when parsing/writing user.cfg
Signed-off-by: Fabian Grünbichler
---
Notes:
- make limit schema public for pve-guest-common usage
src/PVE/AccessControl.pm | 42 +--
src/test/parser_writer.pl | 14 ++---
2 files changed, 47
if the start is not part of an incoming migration, check the VM against its
pool's run limit.
Signed-off-by: Fabian Grünbichler
---
PVE/QemuServer.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index be937ec1..78b6ff96 100644
to the regular ones.
Signed-off-by: Fabian Grünbichler
---
PVE/QemuServer.pm | 29 +
1 file changed, 29 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 661613df..93eaaec5 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -2755,6 +2755,18 @@ our
Signed-off-by: Fabian Grünbichler
---
Notes:
this is very "bare", obviously we'd want
- a nicer grid/.. display of usage
- a way to edit the limits
I am not yet sure how to integrate this nicely, and wanted to get feedback
on the rest first.
v2:
Signed-off-by: Fabian Grünbichler
---
PVE/API2/Pool.pm | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Pool.pm b/PVE/API2/Pool.pm
index 031f0160f..2d83ccc67 100644
--- a/PVE/API2/Pool.pm
+++ b/PVE/API2/Pool.pm
@@ -6,6 +6,7 @@ use warnings;
use
so that other nodes can query it and both block changes that would violate the
limits, and mark pools which are violating it currently accordingly.
Signed-off-by: Fabian Grünbichler
---
PVE/Service/pvestatd.pm | 59 ++---
1 file changed, 55 insertions(+), 4
one for combining the per-node broadcasted values, one for checking a pool's
limit, and one specific helper for checking guest-related actions such as
starting a VM.
Signed-off-by: Fabian Grünbichler
---
Notes:
v2:
- style
- introduce new helper for mapping limit key to usage hash
Signed-off-by: Fabian Grünbichler
---
Notes:
v2:
- don't multiply mem+swap, but add them up (thanks Dominik)
src/PVE/API2/LXC/Config.pm | 21 +
1 file changed, 21 insertions(+)
diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm
index e6c0980
by checking the new values against the running limits.
Signed-off-by: Fabian Grünbichler
---
src/PVE/LXC/Config.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index a6baccd..248100e 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src
Signed-off-by: Fabian Grünbichler
---
src/PVE/LXC.pm | 8
1 file changed, 8 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 9b03a97..1856b6a 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -2577,6 +2577,14 @@ sub vm_start {
update_lxc_config($vmid, $conf
early if possible, to avoid big cleanups cause of limit exhaustion.
Signed-off-by: Fabian Grünbichler
---
src/PVE/API2/LXC.pm | 25 +
1 file changed, 25 insertions(+)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index fd42ccf..80bac3d 100644
--- a/src/PVE/API2
to avoid repeating those calculations all over the place.
Signed-off-by: Fabian Grünbichler
---
src/PVE/LXC/Config.pm | 35 +++
1 file changed, 35 insertions(+)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 1664a35..a6baccd 100644
--- a/src
pve-access-control:
Fabian Grünbichler (1):
pools: define resource limits
src/PVE/AccessControl.pm | 42 +--
src/test/parser_writer.pl | 14 ++---
2 files changed, 47 insertions(+), 9 deletions(-)
pve-container:
Fabian Grünbichler (7):
config: add
On February 23, 2024 1:03 pm, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer
> ---
>
> came up in enterprise support, and I don't think there is a reason to
> not have it in the UI, while having it in the API
>
> v2:
> - use Aaron's improved help text
>
> www/manager6/storage/DirEdit.js
On April 11, 2024 11:32 am, Wolfgang Bumiller wrote:
> On Wed, Apr 10, 2024 at 03:13:08PM +0200, Fabian Grünbichler wrote:
>> so that other nodes can query it and both block changes that would violate
>> the
>> limits, and mark pools which are violating it currently according
> Daniel Krambrock via pve-devel hat am
> 11.04.2024 10:09 CEST geschrieben:
Hi!
for both this and the access-control patch, please add
- *some* commit message (e.g., something like "stable sorting in XX config file
allows tracking changes by checking into git or when using automation like
On April 11, 2024 11:17 am, Wolfgang Bumiller wrote:
> On Wed, Apr 10, 2024 at 03:13:06PM +0200, Fabian Grünbichler wrote:
>> one for combining the per-node broadcasted values, one for checking a pool's
>> limit, and one specific helper for checking guest-related actions such as
&
On April 11, 2024 12:03 pm, Wolfgang Bumiller wrote:
> On Thu, Apr 11, 2024 at 09:23:53AM +0200, Fabian Grünbichler wrote:
>> On April 10, 2024 3:13 pm, Fabian Grünbichler wrote:
>> > Signed-off-by: Fabian Grünbichler
>> > ---
>> > src/PVE/API2/LXC/Config.p
On April 11, 2024 11:28 am, Wolfgang Bumiller wrote:
> On Wed, Apr 10, 2024 at 03:13:00PM +0200, Fabian Grünbichler wrote:
>> these are similar to existing ones, but with slightly different semantics.
>>
>> Signed-off-by: Fabian Grünbichler
>>
On April 12, 2024 3:25 pm, Fabian Grünbichler wrote:
> Signed-off-by: Fabian Grünbichler
> ---
> test-built 6.8, but I assume 6.5 works as well since the patch applies cleanly
> there (build hasn't finished yet ;))
FWIW, the 6.5 build wo
Signed-off-by: Fabian Grünbichler
---
test-built 6.8, but I assume 6.5 works as well since the patch applies cleanly
there (build hasn't finished yet ;))
I also assume this will be picked up fairly fast by stable point releases, but
not sure how fast those will be folded atm on the Ubuntu side
with T-B/R-B as provided, thanks!
On January 16, 2024 3:30 pm, Stefan Hanreich wrote:
> fall back to using v.ref as value when we do not have an alias or ipset
> since scope and name are not set for ips / cidrs
>
> Signed-off-by: Stefan Hanreich
> ---
>
> Changes from v1:
> * Added fix for an
thanks!
On April 12, 2024 1:08 pm, Fiona Ebner wrote:
> Changes in v2:
> * specify snapname when activating volume for hotplug
> * add missing activation call for fsck too
>
> Otherwise those operations would be problematic with certain storages
> like LVM after shutting down a container
with the re-worded commit message for qemu-server (although I dropped
the still redundant first line of the commit message ;))
On February 19, 2024 12:11 pm, Filip Schauer wrote:
> Allow moving unused/detached disks to another storage.
>
> qemu-server:
>
> Filip Schauer (1):
> fix #1905:
On March 19, 2024 4:08 pm, Hannes Duerr wrote:
> When a snapshot is created with RAM, qemu attempts to save not only the
> RAM content, but also the internal state of the PCI devices.
>
> However, as not all drivers support this, this can lead to the device
> drivers in the VM not being able to
Reviewed-by: Fabian Grünbichler
with some small nits for the docs patch, see comment there.
the pve-common patch should probably get the bug number (545) in the
subject as well.
some hint about the inter-dependencies of the patches would be nice, AFAIU:
- pve-manager requires proxmox-widget
On February 29, 2024 11:41 am, Stefan Hanreich wrote:
> Signed-off-by: Stefan Hanreich
> ---
> pve-network.adoc | 15 +--
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/pve-network.adoc b/pve-network.adoc
> index d1ec64b..a5ad9b4 100644
> --- a/pve-network.adoc
>
On February 23, 2024 11:48 am, Filip Schauer wrote:
> Do not use the 'noacl' mount option when mounting a container disk with
> an ext4 file system. The option was removed from the kernel in commit
> 2d544ec923db
>
> The ext4 detection is based on $do_format in alloc_disk.
>
> Signed-off-by:
On March 25, 2024 12:00 pm, Fiona Ebner wrote:
> Otherwise it was not possible to hotplug a volume that was previously
> deactivated and requires activation, e.g. an LVM LV that was detached
> after shutting down the container couldn't be hotplugged anymore
> later.
>
> Signed-off-by: Fiona Ebner
On December 5, 2023 12:35 pm, Fiona Ebner wrote:
> The schema declares it to be an integer. Done in the config_list()
> helper, to ensure consistency for the following existing code in
> vmstatus():
>
>> my $list = $opt_vmid ? { $opt_vmid => { type => 'lxc', vmid =>
>> int($opt_vmid) }} :
with a few small follow-ups in pve-manager
On April 2, 2024 4:55 pm, Max Carrara wrote:
> Fix #4759: Configure Permissions for ceph-crash.service - Version 5
> ===
>
> Notable changes since v4
>
>
> * The
On February 6, 2024 10:40 am, Thomas Lamprecht wrote:
> Am 05/02/2024 um 12:45 schrieb Fabian Grünbichler:
>> On February 2, 2024 7:23 pm, Thomas Lamprecht wrote:
>>> seems OK w.r.t. change, but do we want this to be either part of the shim,
>>> or a separate repo? So
else this can break an upgrade for unrelated reasons.
this also mimics debhelper behaviour more (which we only not use here because
of lack of reload support) - restructured the snippet to be more similar with
an explicit `if` as well.
Signed-off-by: Fabian Grünbichler
---
debian/pve-ha
else this can break an upgrade for unrelated reasons (regular debhelper also
constructs the restart invocations like this, it even redirects output to
/dev/null)
Signed-off-by: Fabian Grünbichler
---
debian/postinst | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
aborting apt invocations because of service failures like that is always
painful, and lxcfs is in a lot of our build-dep chains, and build environments
might not run systemd as init.
Signed-off-by: Fabian Grünbichler
---
debian/lxcfs.postinst | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On April 10, 2024 3:13 pm, Fabian Grünbichler wrote:
> Signed-off-by: Fabian Grünbichler
> ---
> src/PVE/API2/LXC/Config.pm | 21 +
> 1 file changed, 21 insertions(+)
>
> diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm
> index e6
if the start is not part of an incoming migration, check the VM against its
pool's run limit.
Signed-off-by: Fabian Grünbichler
---
PVE/QemuServer.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 4acf2fe1..de566502 100644
if the new value is higher than the old one, check against limits. if the old
one is higher, then the change is always okay, to support reducing the usage in
steps spread over multiple guests..
Signed-off-by: Fabian Grünbichler
---
PVE/API2/Qemu.pm | 22 ++
PVE
determining the usage values for the current config. pending values are taken
into account if they are higher than the current value only, else it would be
possible to easily circumvent config limits by setting non-hotpluggable pending
values.
Signed-off-by: Fabian Grünbichler
---
PVE
allow to set/update limits, and return them when querying individual pools.
Signed-off-by: Fabian Grünbichler
---
Notes:
requires bumped pve-access-control
PVE/API2/Pool.pm | 36
1 file changed, 32 insertions(+), 4 deletions(-)
diff --git a/PVE/API2
one for combining the per-node broadcasted values, one for checking a pool's
limit, and one specific helper for checking guest-related actions such as
starting a VM.
Signed-off-by: Fabian Grünbichler
---
src/PVE/GuestHelpers.pm | 190
1 file changed, 190
by checking the snapshot conf values as if the CT was newly created.
Signed-off-by: Fabian Grünbichler
---
src/PVE/API2/LXC/Snapshot.pm | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/PVE/API2/LXC/Snapshot.pm b/src/PVE/API2/LXC/Snapshot.pm
index 0999fbc..37a02a6 100644
--- a/src
these are similar to existing ones, but with slightly different semantics.
Signed-off-by: Fabian Grünbichler
---
src/PVE/LXC.pm | 29 +
1 file changed, 29 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 88a9d6f..78c0e18 100644
--- a/src/PVE/LXC.pm
and handle them when parsing/writing user.cfg
Signed-off-by: Fabian Grünbichler
---
src/PVE/AccessControl.pm | 42 +--
src/test/parser_writer.pl | 14 ++---
2 files changed, 47 insertions(+), 9 deletions(-)
diff --git a/src/PVE/AccessControl.pm b
pve-guest-common
pve-access-control:
Fabian Grünbichler (1):
pools: define resource limits
src/PVE/AccessControl.pm | 42 +--
src/test/parser_writer.pl | 14 ++---
2 files changed, 47 insertions(+), 9 deletions(-)
pve-guest-common:
Fabian Grün
by checking teh snapshot conf values as if the VM was newly created.
Signed-off-by: Fabian Grünbichler
---
PVE/API2/Qemu.pm | 8
1 file changed, 8 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 6f104faa..657c9cb8 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2
as early as possible, to avoid having to undo expensive work or allowing a
window for limit exhaustion..
Signed-off-by: Fabian Grünbichler
---
PVE/API2/Qemu.pm | 24
1 file changed, 24 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 497987ff
to the regular ones.
Signed-off-by: Fabian Grünbichler
---
PVE/QemuServer.pm | 29 +
1 file changed, 29 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 6e2c8052..96652abe 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -2762,6 +2762,18 @@ our
Signed-off-by: Fabian Grünbichler
---
Notes:
this is very "bare", obviously we'd want
- a nicer grid/.. display of usage
- a way to edit the limits
I am not yet sure how to integrate this nicely, and wanted to get feedback
on the rest first.
www/man
Signed-off-by: Fabian Grünbichler
---
PVE/API2/Pool.pm | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Pool.pm b/PVE/API2/Pool.pm
index 26ff7742e..9c232a971 100644
--- a/PVE/API2/Pool.pm
+++ b/PVE/API2/Pool.pm
@@ -6,6 +6,7 @@ use warnings;
use
so that other nodes can query it and both block changes that would violate the
limits, and mark pools which are violating it currently accordingly.
Signed-off-by: Fabian Grünbichler
---
PVE/Service/pvestatd.pm | 59 ++---
1 file changed, 55 insertions(+), 4
Signed-off-by: Fabian Grünbichler
---
src/PVE/API2/LXC/Config.pm | 21 +
1 file changed, 21 insertions(+)
diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm
index e6c0980..3fb3885 100644
--- a/src/PVE/API2/LXC/Config.pm
+++ b/src/PVE/API2/LXC/Config.pm
by checking the new values against the running limits.
Signed-off-by: Fabian Grünbichler
---
src/PVE/LXC/Config.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 908d64a..787bcf2 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src
Signed-off-by: Fabian Grünbichler
---
src/PVE/LXC.pm | 8
1 file changed, 8 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 78c0e18..08f4425 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -2586,6 +2586,14 @@ sub vm_start {
update_lxc_config($vmid, $conf
1 - 100 of 1143 matches
Mail list logo