ping.
Its not possible to build proxmox-perl-rs at the moment without this
patch series.
Lukas Wagner writes:
> These changes adapts the PVE notification stack to the changes introduced
> in proxmox-notify 0.4.
>
> The notification system uses handlebar templates to render the subject
> and
Adds the ability to change the owner of a guest image.
Btrfs does not need special commands to rename a subvolume and this can
be achieved the same as in Storage/plugin.pm's rename_volume taking
special care of how the directory structure used by Btrfs.
Signed-off-by: Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval
---
www/manager6/window/GuestImport.js | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/www/manager6/window/GuestImport.js
b/www/manager6/window/GuestImport.js
index 69e7c9bb..636fd721 100644
--- a/www/manager6/window/GuestImport.js
+++ b
Signed-off-by: Maximiliano Sandoval
---
www/manager6/panel/BackupAdvancedOptions.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/panel/BackupAdvancedOptions.js
b/www/manager6/panel/BackupAdvancedOptions.js
index b9e5304e..4b31f403 100644
--- a/www/manager6
See [1, 2] for their spelling.
[1] https://en.wikipedia.org/wiki/Zstd
[2] https://en.wikipedia.org/wiki/SCSI
Signed-off-by: Maximiliano Sandoval
---
www/manager6/form/BackupCompressionSelector.js | 2 +-
www/manager6/panel/BackupAdvancedOptions.js| 2 +-
www/manager6/window
This provides translators context of what kind of noun goes before
'Threads'. The word Zstd is already in other translations.
Signed-off-by: Maximiliano Sandoval
---
www/manager6/panel/BackupAdvancedOptions.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6
Signed-off-by: Maximiliano Sandoval
---
es.po | 211 +++---
1 file changed, 98 insertions(+), 113 deletions(-)
diff --git a/es.po b/es.po
index 476bdba..fc93eb2 100644
--- a/es.po
+++ b/es.po
@@ -8,7 +8,7 @@ msgstr ""
"Pro
is listed as one of the encodings in the
`Accept-Encoding` header and the data should be compressed.
[RFC9110] https://www.rfc-editor.org/rfc/rfc9110#name-deflate-coding
[RFC1950] https://www.rfc-editor.org/rfc/rfc1950
Suggested-by: Lukas Wagner
Tested-by: Folke Gleumes
Signed-off-by: Maximilian
is listed as one of the encodings in the
`Accept-Encoding` header and the data should be compressed.
[RFC9110] https://www.rfc-editor.org/rfc/rfc9110#name-deflate-coding
[RFC1950] https://www.rfc-editor.org/rfc/rfc1950
Suggested-by: Lukas Wagner
Signed-off-by: Maximiliano Sandoval
---
Differenc
://www.rfc-editor.org/rfc/rfc1950
Signed-off-by: Maximiliano Sandoval
---
src/PVE/APIServer/AnyEvent.pm | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm
index b60b825..a43d6bb 100644
--- a/src/PVE
Maximiliano Sandoval writes:
> Max Carrara writes:
>
>> Fix #4759: Configure Permissions for ceph-crash.service - Version 5
>> ===
>
> I tested this patch series on a testing cluster updated to
> no-
Max Carrara writes:
> Fix #4759: Configure Permissions for ceph-crash.service - Version 5
> ===
I tested this patch series on a testing cluster updated to
no-subscription with ceph-base 18.2.2-pve1. For the purposes of testing
I
Lukas Wagner writes:
> - Switch order of 'mailto' and 'mailnotification' field
> - When mode is 'auto', disable 'mailtnotification' field
> - When mode is 'auto' and 'mailto' is empty, show
> hint that the notification system will be used
>
> Signed-off-by: Lukas Wagner
> ---
ping
l used at the time the snapshot was taken. Thus, and because
some exotic third party plugin might be using it for whatever reason,
it's necessary to keep passing the same value as before.
Signed-off-by: Fiona Ebner
Signed-off-by: Maximiliano Sandoval
---
This is a backport for Proxmox VE 7 of
Fiona Ebner writes:
> IMHO, it's still succinct enough. But you could also go for "avoid
> consumer grade SSDs, whose use is discouraged."
Neither consumer or enterprise grade disks are super well defined, why
not just discourage disks without PLP.
--
Maximiliano
Fiona Ebner writes:
> It might be cleaner to just use
> emptyValue: 0,
> in the field declaration like is already done for the "Target Size"
> field. And the same issue is also present for the "Min. # of PGs" field,
> right?
Thanks for the emptyValue tip, I didn't know about it. Unfortunately,
using
$ ceph osd pool get target_size_ratio
after setting the valut to 0 through the API it will output
Error ENOENT: option 'target_size_ratio' is not set on pool
'cephfs-test_data'
Signed-off-by: Maximiliano Sandoval
---
www/manager6/ceph/Pool.js | 6 +-
1 file changed, 5
Signed-off-by: Maximiliano Sandoval
---
es.po | 36 ++--
1 file changed, 14 insertions(+), 22 deletions(-)
diff --git a/es.po b/es.po
index e874206..52f47e9 100644
--- a/es.po
+++ b/es.po
@@ -8,7 +8,7 @@ msgstr ""
"Project-Id-Version: proxmox
Some comments bellow.
Christoph Heiss writes:
> For non-PVE products, simply use the ZFS defaults (aka. 50%) and leave
> unset, if the user never touches that setting.
>
> Signed-off-by: Christoph Heiss
> ---
> ...
> ...
> +
> +# GTKs SpinButton does not support a placeholder value,
ping, still applies.
Maximiliano Sandoval writes:
> ping
>
> Maximiliano Sandoval writes:
>
>> ping
>>
>> Maximiliano Sandoval writes:
--
Maximiliano
___
pve-devel mailing list
pve-devel@lists.proxmox.com
htt
ttribute_and_login_fields
Signed-off-by: Maximiliano Sandoval
---
Differences from v1:
- Learn how to send emails
- Fix 'fix #5251' prefix in commit titles
www/manager6/window/LoginWindow.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/manager6/window/LoginWindow.js
b/www/manag
Signed-off-by: Maximiliano Sandoval
---
js/LoginView.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/js/LoginView.js b/js/LoginView.js
index 63f4099..b5da19a 100644
--- a/js/LoginView.js
+++ b/js/LoginView.js
@@ -249,6 +249,7 @@ Ext.define('PMG.LoginView
Signed-off-by: Maximiliano Sandoval
---
www/LoginView.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/LoginView.js b/www/LoginView.js
index 33734f6c..d4d8e73e 100644
--- a/www/LoginView.js
+++ b/www/LoginView.js
@@ -274,6 +274,7 @@ Ext.define('PBS.LoginView
Signed-off-by: Maximiliano Sandoval
---
src/window/TfaWindow.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/window/TfaWindow.js b/src/window/TfaWindow.js
index 3646e0e..7c6f2ee 100644
--- a/src/window/TfaWindow.js
+++ b/src/window/TfaWindow.js
@@ -374,6 +374,7 @@ Ext.define
I sent this twice by mistake and the commit titles are wrong. Will send
a v2.
Maximiliano Sandoval writes:
> By default they have 'autocomplete=off'. From [1]:
>
> > In most modern browsers, setting autocomplete to "off" will not
> > prevent a password
Signed-off-by: Maximiliano Sandoval
---
www/LoginView.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/LoginView.js b/www/LoginView.js
index 33734f6c..d4d8e73e 100644
--- a/www/LoginView.js
+++ b/www/LoginView.js
@@ -274,6 +274,7 @@ Ext.define('PBS.LoginView
Signed-off-by: Maximiliano Sandoval
---
src/window/TfaWindow.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/window/TfaWindow.js b/src/window/TfaWindow.js
index 3646e0e..7c6f2ee 100644
--- a/src/window/TfaWindow.js
+++ b/src/window/TfaWindow.js
@@ -374,6 +374,7 @@ Ext.define
ttribute_and_login_fields
Signed-off-by: Maximiliano Sandoval
---
www/manager6/window/LoginWindow.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/manager6/window/LoginWindow.js
b/www/manager6/window/LoginWindow.js
index a79f5a2a..aaeca355 100644
--- a/www/manager6/window/LoginWin
Signed-off-by: Maximiliano Sandoval
---
js/LoginView.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/js/LoginView.js b/js/LoginView.js
index 63f4099..b5da19a 100644
--- a/js/LoginView.js
+++ b/js/LoginView.js
@@ -249,6 +249,7 @@ Ext.define('PMG.LoginView
ping
Maximiliano Sandoval writes:
> ping
>
> Maximiliano Sandoval writes:
--
Maximiliano
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Signed-off-by: Maximiliano Sandoval
---
es.po | 48 +++-
1 file changed, 19 insertions(+), 29 deletions(-)
diff --git a/es.po b/es.po
index 806f2a6..1b2d7d2 100644
--- a/es.po
+++ b/es.po
@@ -8,7 +8,7 @@ msgstr ""
"Project-Id-V
The default certificate does not have a name.
Reported-by: Dietmar Maurer
Signed-off-by: Maximiliano Sandoval
---
src/panel/Certificates.js | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/panel/Certificates.js b/src/panel/Certificates.js
index a522ab6
ping
Maximiliano Sandoval writes:
> We replace the use of nested boxes with grids when possible to ensure correct
> margins and alignment of widgets.
>
> At the end we also remove trailing spaces and colons from labels preceding an
> input widget, e.g. we replace `DNS Server: ` w
Fiona Ebner writes:
> Is there a user request for this feature or other common use cases? If
> it's just for testing multipath, it's a rather niche use case and fine
> to be CLI only.
Yeah, its mostly for debugging. Probably it is niche enough to not have
it in the web UI.
--
Maximiliano
Hello Eneko Lacunza,
You are right, I found that [1] contains a document with guidelines for
translating to Spanish, capitalization is specifically mentioned at
section 8.4.1.1.
I will study the document for more venues for improvement and submit a
patch.
Thanks.
[1]
if we reach the
branch where `operation.error.statusText` matches:
binary not installed: /usr/bin/ceph-mon
This allow us to configure this node and run `init` in the API.
Suggested-by: Mira Limbeck
Signed-off-by: Maximiliano Sandoval
---
This was found on a ticker from the support portal.
www
Christoph Heiss writes:
> On Tue, Nov 21, 2023 at 04:10:20PM +0100, Maximiliano Sandoval wrote:
>>
>> This accounts for the different layout set in the previous commit.
>
> What commit is meant here exactly? The previous patch in this series
> (aka. the first) do
This is useful to test multipath devices which need a wwn.
We use 'e.g.' rather than 'Example', otherwise the 18 characters of the
example do not fit in the field.
Suggested-by: Friedrich Weber
Signed-off-by: Maximiliano Sandoval
---
Differences from v1:
- Use WWN rather than WWID, the reason
This is useful to test multipath devices which need a wwid.
We use 'e.g.' rather than 'Example', otherwise the 18 characters of the
example do not fit in the field.
Suggested-by: Friedrich Weber
Signed-off-by: Maximiliano Sandoval
---
www/manager6/qemu/HDEdit.js | 18 ++
1
Bump :)
--
Maximiliano
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
configured, the notification system will
> be used'),
> + viewModel,
> + bind: {
> + hidden: '{!hintTextVisible}',
I think the `pmx-hint` being displayed as yellow suggests it is a
warning/error rather than a hint. I wonder if there is a better
approach, as this is
Tweak some string, improve others.
Signed-off-by: Maximiliano Sandoval
---
es.po | 52 +---
1 file changed, 25 insertions(+), 27 deletions(-)
diff --git a/es.po b/es.po
index 132f82a..98eb007 100644
--- a/es.po
+++ b/es.po
@@ -8,7 +8,7 @@ msgstr
ain the old values instead of removing the corresponding line:
sendmail: test
mailto Y
mailto-user X
Tested setting both mailto and mailto-user to `` from non-nil values and
switching their values around. The patch fixes this as far as my testing
went.
Tested-by:
Lukas Wagner writes:
> This patch series attempts to improve the user experience when creating
> notification matchers.
I gave the web UI side of things a test, it substantially improves the
UX when setting Match Rules.
In my brief testing everything worked correctly.
Tested-by: Maxim
The strings were hard to translate and required some tricks like passing
'Ceph ' as an argument. The `/main` part was also removed to simplify
the flow and UX.
Suggested-by: Dietmar Maurer
Signed-off-by: Maximiliano Sandoval
---
src/node/APTRepositories.js | 20 +---
1 file
"POT-Creation-Date: 2023-12-01 11:25+0100\n"
"PO-Revision-Date: 2023-11-27 16:43+0100\n"
"Last-Translator: Maximiliano Sandoval \n"
"Language-Team: Spanish\n"
```
- Extraction of strings using ngettext, pgettext, etc. Even if we don't
have js wr
Note that N/A is already translatable in other places.
Signed-off-by: Maximiliano Sandoval
---
Differences from v2:
- Translate the invalid subscription key message, this string is also in two
more places in pve-manager. This will be the content of a following patch.
- Do not translate
Dominik Csapak writes:
> it's more like DHCP, SLAAC or IPv4. those are names of protocols (like ACME)
> that shouldn't change across translations
>
> and we removed those gettexts (mostly) a while ago
> e.g. see lxc/Network.js in pve-manager:
>
> ---8<---
> boxLabel: 'DHCP', // do not localize
>
Dominik Csapak writes:
> the translator must make sure the terms are consistent anyway...
This is the heart of the issue. The translator cannot know there are
more uses of the string if it is not marked as translatable.
--
Maximiliano
___
Dominik Csapak writes:
> translating ACME does not make sense to me since it's
> the name of the protocol and stands for
> Automatic Certificate Management Environment
>
> i don't think/believe this should be translated
> into other languages as a standalone word
"ACME" appears in four
"POT-Creation-Date: 2023-12-01 11:25+0100\n"
"PO-Revision-Date: 2023-11-27 16:43+0100\n"
"Last-Translator: Maximiliano Sandoval \n"
"Language-Team: Spanish\n"
```
- Extraction of strings using ngettext, pgettext, etc. Even if we don't
have js wr
Signed-off-by: Maximiliano Sandoval
---
Improvements made after going through the three web UIs.
es.po | 62 +--
sl.po | 2 +-
2 files changed, 32 insertions(+), 32 deletions(-)
diff --git a/es.po b/es.po
index 262e86c..132f82a 100644
Note that ACME is already in 3 translatable strings, a similar remark
applies to N/A which is already translated in many languages.
Signed-off-by: Maximiliano Sandoval
---
src/node/DNSView.js | 2 +-
src/panel/ACMEDomains.js | 2 +-
src/panel/DiskList.js
The string `proxmox.Utils.defaultText + ' (free)'` was inlined as `Default
(Unrestricted)` cutting translatable strings makes them harder or even
impossible to translate in certain languages. Additionally the extra context
makes the work of translators easier.
Signed-off-by: Maximiliano Sandoval
> btw. @Maximiliano: "Free" is rather a bad original text for the
Noted. Will send a v2 in a bit.
>> If its only right-to-left languages, we could just add another helper
>> to assemble lists in the correct order?
The GNOME l10n guidelines at least have an entry about not splitting
strings.
Maximiliano Sandoval writes:
> + { flag: 'ssbd', desc: gettext('Protection for "Speculative Store
> Bypass" for Intel models') },
> + { flag: 'ibpb', desc: gettext('Allows improved Spectre mitigation
> with AMD CPUs') },
> + { flag: 'virt-ss
The string `proxmox.Utils.defaultText + ' (free)'` was inlined as
`Default (Free)` cutting translatable strings makes them harder or even
impossible to translate in certain languages.
Signed-off-by: Maximiliano Sandoval
---
www/manager6/dc/UserTagAccessEdit.js | 10 +-
www/manager6
It would be preferable to use "won't" but I would rather err on the safe
side when it comes to escapes in gettext.
Signed-off-by: Maximiliano Sandoval
---
src/node/APTRepositories.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/node/APTRepositories.js
The autoscaler is well-known Ceph concept. A translation might prefer to
use "Autoscaler" as-is in a translation.
Signed-off-by: Maximiliano Sandoval
---
www/manager6/ceph/Pool.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/ceph/Pool.js b/www/man
The autoscaler is well-known Ceph concept. A translation might prefer to use
"Autoscaler" as-is in a translation, which in turn lends itself better to a
search online.
The patch series is split into three commits since each one can be a bit more
controvertial than the last one.
M
Signed-off-by: Maximiliano Sandoval
---
www/manager6/ceph/Pool.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index c61d4f71..e514518c 100644
--- a/www/manager6/ceph/Pool.js
+++ b/www/manager6/ceph/Pool.js
@@ -88,7
The autoscaler is well-known Ceph concept. A translation might prefer to
use "Autoscaler" as-is in a translation.
Signed-off-by: Maximiliano Sandoval
---
www/manager6/ceph/Pool.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/ceph/Pool.js b/www/man
Signed-off-by: Maximiliano Sandoval
---
www/manager6/ceph/CephInstallWizard.js | 6 +++---
www/manager6/storage/RBDEdit.js| 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/www/manager6/ceph/CephInstallWizard.js
b/www/manager6/ceph/CephInstallWizard.js
index f33ae868
Signed-off-by: Maximiliano Sandoval
---
www/manager6/ceph/CephInstallWizard.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/ceph/CephInstallWizard.js
b/www/manager6/ceph/CephInstallWizard.js
index f33ae868..3342a80f 100644
--- a/www/manager6/ceph
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 34 --
1 file changed, 12 insertions(+), 22 deletions(-)
diff --git a/proxinstall b/proxinstall
index 69c48b4..bdff22d 100755
--- a/proxinstall
+++ b/proxinstall
@@ -648,12 +648,12 @@ sub update_layout {
my
For consistency sake, all colons and trailing spaces in labels that were
followed with an entry were removed, this matches other panels such as
the password and country/timezone panels.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 12 ++--
1 file changed, 6 insertions(+), 6
The extra 10px margin on the email row was added to account for the
removed line:
$vbox->pack_start($hbox3, 0, 0, 15);
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 29 +++--
1 file changed, 11 insertions(+), 18 deletions(-)
diff --git a/proxinstal
This accounts for the different layout set in the previous commit.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index 8f40234..a5de06c 100755
--- a/proxinstall
+++ b/proxinstall
@@ -308,7 +308,7
Using boxes causes the labels to not align correctly in certain
circumstances. In the following commits we replace the use of boxes with
grids and set the margins and spacing directly on the respective grid.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 52
a grid.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/proxinstall b/proxinstall
index bdff22d..87e81fd 100755
--- a/proxinstall
+++ b/proxinstall
@@ -332,10 +332,10 @@ my $create_basic_grid = sub {
$grid
This will be used in future commits to create grids so we need it to be defined.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/proxinstall b/proxinstall
index 01d4cfe..8f40234 100755
of master
Maximiliano Sandoval (7):
gui: move create_basic_grid subroutine definition up
gui: expand ip address Gtk3::Entry
gui: use basic grid in password panel
gui: use basic grid in country/timezone panel
gui: change margins in create_basic_grid
gui: use basic grid in the network panel
config set X value`. The values in ceph.conf indeed take
priority as per the commit message. When the values are not present in
ceph.conf, the values from the config DB take preference over the 3/2
default as expected.
Tested-by: Maximiliano Sandoval
Aaron Lauterer writes:
> The main g
Tested on a new Proxmox VE 8 cluster. The mclock scheduler settings do
not appear in `ceph config dump` after removing the OSD using the web
UI. Removing a OSD without this setting being set does not cause any
issue either.
Tested-by: Maximiliano Sandoval
Aaron Lauterer writes:
> Ceph d
The latest change made the MACs monospaced, hence they do require more
space now. A multiple of 17 was chosen to match the number of
characters.
Signed-off-by: Maximiliano Sandoval R
---
www/manager6/qemu/AgentIPView.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www
It becomes easier to read when you have multiple rows showing MACs when
they have the same size.
Signed-off-by: Maximiliano Sandoval R
---
www/manager6/qemu/AgentIPView.js | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/AgentIPView.js b/www/manager6
Is there anything else missing on my end? The patch still applies.
Maximiliano Sandoval writes:
> Continuation of ab70343982f36a5343d3fcf4a1a6489bd3f52a66. Discussion at
> https://lists.proxmox.com/pipermail/pve-devel/2023-September/059013.html.
>
--
Ma
Signed-off-by: Maximiliano Sandoval R
---
ha-manager.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ha-manager.adoc b/ha-manager.adoc
index 6bbd267..7f1ba3d 100644
--- a/ha-manager.adoc
+++ b/ha-manager.adoc
@@ -854,7 +854,7 @@ Maintenance Mode
See
https://git.proxmox.com/?p=pve-installer.git;a=commit;h=124ca33f9fb3780a76f0b5fd57952e69823852c8.
Signed-off-by: Maximiliano Sandoval R
---
pve-installation.adoc | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/pve-installation.adoc b/pve-installation.adoc
index
From: Maximiliano Sandoval
This is a continuation of
https://lists.proxmox.com/pipermail/pve-devel/2023-August/058639.html.
Signed-off-by: Maximiliano Sandoval R
---
v3 was tested only with `make check-pve`. v2 was properly tested by Filip
Schauer in a VM.
Differences from v2:
- Use
From: Maximiliano Sandoval
This is a continuation of
https://lists.proxmox.com/pipermail/pve-devel/2023-August/058639.html.
Signed-off-by: Maximiliano Sandoval R
---
proxinstall | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/proxinstall b
We cache the hash of this file, it makes sense to first check if the
file changed via `stat` and recompute the hash if needed.
This is to be in sync with the changes made in
https://git.proxmox.com/?p=pmg-api.git;a=commit;h=16d2ff9f8e90db64114a66d78672f5a03f5ee990.
Signed-off-by: Maximiliano
Continuation of ab70343982f36a5343d3fcf4a1a6489bd3f52a66. Discussion at
https://lists.proxmox.com/pipermail/pve-devel/2023-September/059013.html.
Signed-off-by: Maximiliano Sandoval
---
PVE/API2/Ceph.pm | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/PVE
/e6acf2d1d528a2395947d446a57bec04a3a002dc
Signed-off-by: Maximiliano Sandoval
---
Since this an API call, its hard for clients to get a warning thats logged on
the server and I opted for just marking the API as deprecated in its
description.
Differences from v1:
- Instead of removing the api, mark
Thomas Lamprecht writes:
> @maximiliano: how does ceph react if one sets this currently?
> I.e., does it silently accepts unknown config keys, or does it break
> something?
Running
ceph config set global osd_pg_bits 42
results in
Error EINVAL: unrecognized config option
Continuation of ab70343982f36a5343d3fcf4a1a6489bd3f52a66. Discussion at
https://lists.proxmox.com/pipermail/pve-devel/2023-September/059013.html.
Signed-off-by: Maximiliano Sandoval
---
PVE/API2/Ceph.pm | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/PVE
This setting was removed in [1] as part of the v13.0.2 tag.
[1] https://github.com/ceph/ceph/commit/e6acf2d1d528a2395947d446a57bec04a3a002dc
Signed-off-by: Maximiliano Sandoval
---
I did a grep search across multiple projects and I was not able to find
more uses of this option. A second pair
and expose them in the API. This setting is documented in the Pacific docs [1],
but not in the Quincy docs [2]. I could not find much info about this. It is not
mentioned on the Quincy release notes [3] as far as I can tell.
Found a commit [1] as part of [2] which is on the v13.0.2 tag.
[1]
Also, did you checked for other such occurrences in our API?
I found another place where they are used in pve-manager's PVE/API2/Ceph module.
I will send a patch, but most interesting is that we set
$cfg->{global}->{'osd pg bits'} = $param->{pg_bits};
$cfg->{global}->{'osd pgp bits'} =
As suggested in [1], it is recommended to use `_` in all cases when
dealing with config files.
[1] https://docs.ceph.com/en/reef/rados/configuration/ceph-conf/#option-names
Signed-off-by: Maximiliano Sandoval
---
PVE/API2/Ceph/MDS.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
s
- Does not understand comments in the /* foo */ form
[1] https://www.gnu.org/software/gettext/manual/html_node/Contexts.html
Signed-off-by: Maximiliano Sandoval
---
jsgettext.pl | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/jsgettext.pl b/jsgettext.pl
index 7f758f
On 8/30/23 15:23, Thomas Lamprecht wrote:
Oh, and while at it, I pondered over adding a wrapper for the common
Ext.String.format(gettext(MSG), PARAMS)) combi, something like gettextf(MSG,
PARAMS) or even shorter i18n(MSG, PARAMS) (with params optional). This way we
might even parse the
on which msgid was
found first. Given that this is not using the pgettext method that takes into
account the to generate different translations, this seems fine to me, at least
as a first step into getting feature parity with (x)gettext.
On 8/30/23 15:23, Thomas Lamprecht wrote:
Am 30/08/2023 um 14:4
.
Caveats:
- Cannot extract multiline comments
- Does not understand comments in the /* comment */ form
[1] https://www.gnu.org/software/gettext/manual/html_node/Contexts.html
Signed-off-by: Maximiliano Sandoval
---
jsgettext.pl | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
Signed-off-by: Maximiliano Sandoval
---
xgettext supports extracting comments so I added a comment to make it future
proof. Note though our tooling (proxmox-i18n) strips them. I hope to send a
patch fixing
this soon.
Differences from v1:
- Use format instead of relying on a translator comment
Signed-off-by: Maximiliano Sandoval
---
www/manager6/ceph/OSD.js | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js
index d2caafa4..eda60f2f 100644
--- a/www/manager6/ceph/OSD.js
+++ b/www/manager6/ceph/OSD.js
@@ -233,7
Just as a reference, in GNOME editable entries, when in a context
where it is not clear they are editable, have a pencil symbolic icon as you
suggested, but there is no "Edit" tooltip. Another thing is that the icon
disappears if the user has the text cursor in the entry.
I have no strong
Lukas Wagner writes:
> Signed-off-by: Lukas Wagner
> ---
> Cargo.toml | 1 +
> proxmox-notify/Cargo.toml | 9 +
> proxmox-notify/src/config.rs| 51 +
> proxmox-notify/src/endpoints/mod.rs | 0
> proxmox-notify/src/lib.rs | 311
When running `pct status VMID` the variable
$last_proc_vmid_stat->{$vmid} is not set and pct reports no cpu usage.
For consistency with the qt command we do not print the cpu usage.
Signed-off-by: Maximiliano Sandoval
---
This is a different approach that the one tried at
ht
> On 27.06.2023 14:54 CEST Stefan Sterz wrote:
>
>
> previously the disk selection was reset if the advanced options
> dialogue was re-opened. this commit adapts the behavior to restore
> the previous selection.
>
> Signed-off-by: Stefan Sterz
> ---
> proxmox-tui-installer/src/options.rs
1 - 100 of 129 matches
Mail list logo
