[pve-devel] [PATCH zfsonlinux v2 1/2] update zfs submodule to 2.2.4 and refresh patches

2024-05-07 Thread Stoiko Ivanov
mostly - drop all patches we had queued up to get kernel 6.8 supported. Signed-off-by: Stoiko Ivanov --- ...md-unit-for-importing-specific-pools.patch | 4 +- ...-move-manpage-arcstat-1-to-arcstat-8.patch | 2 +- ...-guard-access-to-l2arc-MFU-MRU-stats.patch | 12 +- ...hten-bounds

[pve-devel] [PATCH zfsonlinux v2 2/2] update arc_summary arcstat patch with new introduced values

2024-05-07 Thread Stoiko Ivanov
-off-by: Stoiko Ivanov --- ...-guard-access-to-freshly-introduced-.patch | 438 ++ ...-guard-access-to-l2arc-MFU-MRU-stats.patch | 113 - debian/patches/series | 2 +- 3 files changed, 439 insertions(+), 114 deletions(-) create mode 100644 debian

[pve-devel] [PATCH zfsonlinux v2 0/2] Update to ZFS 2.2.4

2024-05-07 Thread Stoiko Ivanov
zfs/pull/16022 Stoiko Ivanov (2): update zfs submodule to 2.2.4 and refresh patches update arc_summary arcstat patch with new introduced values ...md-unit-for-importing-specific-pools.patch | 4 +- ...-move-manpage-arcstat-1-to-arcstat-8.patch | 2 +- ...-guard-access-to-freshly-introdu

Re: [pve-devel] [PATCH zfsonlinux 2/2] update arc_summary arcstat patch with new introduced values

2024-05-07 Thread Stoiko Ivanov
- and having that throw exceptions will probably cause some discomfort to our users...) On Tue, 7 May 2024 15:38:36 +0200 Stoiko Ivanov wrote: > ZFS 2.2.4 added new kstats for speculative prefetch in: > 026fe796465e3da7b27d06ef5338634ee6dd30d8 > > Adapt our patch introduced

[pve-devel] [PATCH zfsonlinux 1/2] update zfs submodule to 2.2.4 and refresh patches

2024-05-07 Thread Stoiko Ivanov
mostly - drop all patches we had queued up to get kernel 6.8 supported. Signed-off-by: Stoiko Ivanov --- ...md-unit-for-importing-specific-pools.patch | 4 +- ...-move-manpage-arcstat-1-to-arcstat-8.patch | 2 +- ...-guard-access-to-l2arc-MFU-MRU-stats.patch | 12 +- ...hten-bounds

[pve-devel] [PATCH zfsonlinux 2/2] update arc_summary arcstat patch with new introduced values

2024-05-07 Thread Stoiko Ivanov
-off-by: Stoiko Ivanov --- ...guard-access-to-freshly-introduced-.patch} | 79 --- debian/patches/series | 2 +- 2 files changed, 69 insertions(+), 12 deletions(-) rename debian/patches/{0009-arc-stat-summary-guard-access-to-l2arc-MFU-MRU-stats.patch

[pve-devel] [PATCH zfsonlinux 0/2] Update to ZFS 2.2.4

2024-05-07 Thread Stoiko Ivanov
/releases/tag/zfs-2.2.4 [1] https://github.com/openzfs/zfs/pull/15992 [2] https://github.com/openzfs/zfs/pull/15588 [3] https://github.com/openzfs/zfs/pull/16022 Stoiko Ivanov (2): update zfs submodule to 2.2.4 and refresh patches update arc_summary arcstat patch with new introduced values ...md

[pve-devel] [PATCH installer 0/2] fix 2 cosmetic glitches with the tests.

2024-04-30 Thread Stoiko Ivanov
). Stoiko Ivanov (2): d/control: add geoip-bin to Build-Depends tests: prevent uninitialized value warning with undef as fqdn debian/control | 1 + test/parse-fqdn.pl | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) -- 2.39.2 ___ pve

[pve-devel] [PATCH installer 2/2] tests: prevent uninitialized value warning with undef as fqdn

2024-04-30 Thread Stoiko Ivanov
cosmetic issue - but was distracting enough to make me look if there's an error. Signed-off-by: Stoiko Ivanov --- test/parse-fqdn.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/parse-fqdn.pl b/test/parse-fqdn.pl index 6638fbe..47e0e21 100755 --- a/test/parse

[pve-devel] [PATCH installer 1/2] d/control: add geoip-bin to Build-Depends

2024-04-30 Thread Stoiko Ivanov
else the tests running: `./proxmox-low-level-installer -t test.img dump-env` print quite a few warnings about the use of uninitialized values (though they still continue happily). This was a slight distraction for me. Signed-off-by: Stoiko Ivanov --- debian/control | 1 + 1 file changed, 1

Re: [pve-devel] [PATCH installer v3 0/2] assistant: keep prepared iso bootable on uefi with flash drives

2024-04-30 Thread Stoiko Ivanov
for completeness sake - gave the v3 a quick spin as well - so also from my side the: Reviewed-by: Stoiko Ivanov Tested-by: Stoiko Ivanov still applies :) On Tue, 30 Apr 2024 12:46:07 +0200 Aaron Lauterer wrote: > booting a prepared iso in UEFI mode from a blockdev (e.g. usb flash >

Re: [pve-devel] [PATCH 1/2] assistant: keep prepared iso bootable on uefi with flash drives

2024-04-30 Thread Stoiko Ivanov
patches: Reviewed-by: Stoiko Ivanov Tested-by: Stoiko Ivanov On Tue, 30 Apr 2024 10:54:33 +0200 Aaron Lauterer wrote: > By mapping files into the ISO, the UUID for the partitions change as > they depend on the timestamp. The result is, that grub cannot find its > partition anymore and

Re: [pve-devel] [PATCH pve-installer] answer: perform basic input validation for keyboard

2024-04-24 Thread Stoiko Ivanov
On Wed, 24 Apr 2024 10:48:50 +0200 Christian Ebner wrote: > Currently it is possible to validate and create an iso with an > invalid keyboad layout, only failing later during installation. > > Add a basic check for correct keyboard layout by defining an enum > with allowed variants. > >

[pve-devel] [PATCH installer] assistant: error out on set network config for dhcp

2024-04-23 Thread Stoiko Ivanov
for me) Signed-off-by: Stoiko Ivanov --- proxmox-auto-installer/src/answer.rs | 13 + 1 file changed, 13 insertions(+) diff --git a/proxmox-auto-installer/src/answer.rs b/proxmox-auto-installer/src/answer.rs index de8a360..df20db3 100644 --- a/proxmox-auto-installer/src/answer.rs

Re: [pve-devel] [PATCH manager] acme: ui: handle missing meta field in directory response

2024-04-22 Thread Stoiko Ivanov
Gave this patch a spin against a quickly setup step-ca container I had lying around - the issue of not being able to register an account without EAB is gone with it. Tested-by: Stoiko Ivanov On Mon, 22 Apr 2024 11:01:02 +0200 Folke Gleumes wrote: > When none of the meta fields is

[pve-devel] [PATCH docs] firmware: adapt to proxmox packaged fwupd

2024-04-19 Thread Stoiko Ivanov
their ESP mountpoint in the config file. Additionally a minor stylistic rephrasing (is an option vs. could be an option). Tested this today, while giving our fwupd package a spin. Suggested-by: Fabian Grünbichler Signed-off-by: Stoiko Ivanov --- firmware-updates.adoc | 21 +++-- 1

[pve-devel] [PATCH docs] secure boot: mention proxmox-secure-boot-support metapackage

2024-04-18 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- Just had the opportunity to try this on a testsystem - it worked flawlessly :) I did consider dropping the explicit list of packages and replace it by the metapackage only, but think that the additional explanation of how they interact is worth keeping. system

[pve-devel] [PATCH pve-kernel] revert 2 changes in thermal driver causing an early kernel Oops.

2024-04-05 Thread Stoiko Ivanov
hanges are based), and not a bug-fix in itself - simply dropping it seems sensible. Signed-off-by: Stoiko Ivanov --- ...rip-Drop-lockdep-assertion-from-ther.patch | 24 ++ ...ore-Store-trip-pointer-in-struct-the.patch | 343 ++ 2 files changed, 367 insertions(+) create mode

[pve-devel] [PATCH pve-kernel] revert cifs backport to 6.1 added between 6.5.13-1 and 6.5.13-2

2024-04-03 Thread Stoiko Ivanov
/linux/+bug/2055002 Reported-by: Daniela Häsler Signed-off-by: Stoiko Ivanov --- ...flushing-folio-regression-for-6.1-ba.patch | 23 +++ 1 file changed, 23 insertions(+) create mode 100644 patches/kernel/0014-Revert-cifs-fix-flushing-folio-regression-for-6.1-ba.patch diff --git

Re: [pve-devel] [PATCH zfsonlinux] fix #4835: order zfs-import@ before -cache/-scan

2024-03-28 Thread Stoiko Ivanov
zpool.cache not being empty :) Reviewed-by: Stoiko Ivanov Tested-by: Stoiko Ivanov On Thu, 28 Mar 2024 11:06:07 +0100 Fabian Grünbichler wrote: > missed the subjectprefix, this is for ZFS ;) thanks @Stoiko for pointing > it out off-list > > On March 28, 2024 10:41 am, Fabian Grünb

Re: [pve-devel] [PATCH manager 9/9] report: add microcode info to better assess possible system impacts

2024-03-22 Thread Stoiko Ivanov
On Fri, 22 Mar 2024 14:59:33 +0100 Alexander Zeidler wrote: > * list availability and installation status of `*microcode` packages > * grep for applied "Early OS Microcode Updates" > * grep for (un)patched CPU vulnerability messages > > Signed-off-by: Alexander Zeidler > --- > PVE/Report.pm |

[pve-devel] [PATCH zfsonlinux v2 0/2] update ZFS to 2.2.3 and include a fix for udev-links for partitions

2024-03-06 Thread Stoiko Ivanov
for 5288 indeed works with her reproducer Stoiko Ivanov (2): update zfs submodule to 2.2.3 and refresh patches fix #5288: cherry-pick fix for udev-partition links > 16 debian/patches/0005-Enable-zed-emails.patch | 2 +- ...hten-bounds-for-noalloc-stat-availab.patch | 4 +- ..

[pve-devel] [PATCH zfsonlinux v2 2/2] fix #5288: cherry-pick fix for udev-partition links > 16

2024-03-06 Thread Stoiko Ivanov
see: https://github.com/openzfs/zfs/pull/15970 https://github.com/openzfs/zfs/issues/15904 for some additional background. Signed-off-by: Stoiko Ivanov --- ...rectly-handle-partition-16-and-later.patch | 52 +++ debian/patches/series | 1 + 2 files

[pve-devel] [PATCH zfsonlinux v2 1/2] update zfs submodule to 2.2.3 and refresh patches

2024-03-06 Thread Stoiko Ivanov
for more details. One patch from Stefan Lendl was backported and is now in the ZFS 2.2 branch. Signed-off-by: Stoiko Ivanov --- debian/patches/0005-Enable-zed-emails.patch | 2 +- ...hten-bounds-for-noalloc-stat-availab.patch | 4 +- ...do-not-truncate-shares-not-zfs-mount.patch | 131

[pve-devel] [PATCH zfsonlinux] update zfs submodule to 2.2.3 and refresh patches

2024-03-04 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- upstream changelog[0] is quite long this time, but nothing stood out too much during my (very minimal) testing and skimming through the changlog. Block cloning had a few bugs fixed, but remains disabled by default. ZFS-2.1.15 also got release [1], with a shorter

[pve-devel] [PATCH dab-pve-appliances] fix #4858: install libsasl2-modules for pmg

2024-03-01 Thread Stoiko Ivanov
the issue was already resolved for installations from ISO (short time after PMG 8.0 was released), but I forgot to adapt the container-template. Signed-off-by: Stoiko Ivanov --- quickly tested by building a template and checking dpkg -l debian-12-bookworm-pmg-8-64/Makefile | 2 +- 1 file

[pve-devel] [PATCH dab-pve-appliances] pmg: update to 8.1

2024-02-29 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- tested with the packages from our internal repository yesterday evening all looked ok. debian-12-bookworm-pmg-8-64/dab.conf | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/debian-12-bookworm-pmg-8-64/dab.conf b/debian-12-bookworm-pmg-8

[pve-devel] applied: [PATCH pmg-docs] installation: fix codeblock rendering in zfs performance tips section

2024-02-28 Thread Stoiko Ivanov
Thanks for the catch and fix! applied it! (nit: pmg-de...@list.proxmox.com is preferred for pmg-docs patches) On Wed, 28 Feb 2024 19:08:21 +0100 Christoph Heiss wrote: > That slipped through, asciidoc uses 4 not 3 dashes for that. > > Fixes: c8be3f0 ("installation: align zfs performance tip

Re: [pve-devel] [PATCH v2 access-control] fix #5136: ldap: Decode non-ASCII characters in attributes

2024-02-28 Thread Stoiko Ivanov
On Wed, 28 Feb 2024 16:00:48 +0100 Fiona Ebner wrote: > Am 28.02.24 um 15:41 schrieb Thomas Lamprecht: > > Am 09/01/2024 um 14:35 schrieb Filip Schauer: > >> UTF8 decode non-ASCII characters when syncing user attributes, since > >> those will be encoded later on. Without this fix the

Re: [pve-devel] applied: [PATCH pmg_docs 1/1] Consistency of GB and GiB pmg

2024-02-13 Thread Stoiko Ivanov
Thanks for the catch! pushed a fix-up On Tue, 6 Feb 2024 13:20:51 +0100 Thomas Lamprecht wrote: > Am 22/01/2024 um 18:58 schrieb Stoiko Ivanov: > > applied this one to pmg-docs - huge thanks! > > > > > > On Mon, Jul 10, 2023 at 03:49:49PM +0200, Noel Ullreich wro

[pve-devel] applied: [PATCH pmg_docs 1/1] Consistency of GB and GiB pmg

2024-01-22 Thread Stoiko Ivanov
applied this one to pmg-docs - huge thanks! On Mon, Jul 10, 2023 at 03:49:49PM +0200, Noel Ullreich wrote: > Since the actual system-checks are done in GiB and to stay consistent > with the other docs, change all GB units to GiB > > Signed-off-by: Noel Ullreich > --- >

[pve-devel] applied: [PATCH pve-docs; pmg-docs 0/6] Fix consistency of some words

2024-01-22 Thread Stoiko Ivanov
Thanks for the patch @Noel, and thanks for the heads-up @Thomas! applied the pmg-docs parts as well (with one typo fixed up). On Fri, Nov 17, 2023 at 10:58:03AM +0100, Thomas Lamprecht wrote: > Am 03/07/2023 um 14:04 schrieb Noel Ullreich: > > In the docs for pve, pmg, and pbs, the consistency

[pve-devel] [PATCH zfsonlinux 1/2] update zfs submodule to 2.2.2 and refresh patches

2023-12-04 Thread Stoiko Ivanov
the removed patches were cherry-picks, which are included in 2.2.2 Signed-off-by: Stoiko Ivanov --- ...-move-manpage-arcstat-1-to-arcstat-8.patch | 2 +- ...-guard-access-to-l2arc-MFU-MRU-stats.patch | 2 +- ...uncate_shares-without-etc-exports.d.patch} | 0 ...ol-Remove-broken-blk-mq

[pve-devel] [PATCH zfsonlinux 0/2] update to 2.2.2

2023-12-04 Thread Stoiko Ivanov
://lists.proxmox.com/pipermail/pve-devel/2023-November/060751.html minimally tested on 2 VMs, with a few containers and storage-replication configured. Stoiko Ivanov (2): update zfs submodule to 2.2.2 and refresh patches d/zfsutils-linux.install: add zfs_prepare_disk and manpage ...-move-manpage-arcstat-1

[pve-devel] [PATCH zfsonlinux 2/2] d/zfsutils-linux.install: add zfs_prepare_disk and manpage

2023-12-04 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian/zfsutils-linux.install | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/zfsutils-linux.install b/debian/zfsutils-linux.install index e788e27c..2fd7aefe 100644 --- a/debian/zfsutils-linux.install +++ b/debian/zfsutils-linux.install @@ -35,6

[pve-devel] [PATCH docs] fix #5089: sdn: fix s/quest/guest/ typo

2023-11-29 Thread Stoiko Ivanov
additionally did a `git grep '\bquest'` for good measure Signed-off-by: Stoiko Ivanov --- pvesdn.adoc | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index fdc6ea7..53293b1 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -381,7 +381,7

[pve-devel] [PATCH] update kernel to 6.5.11 and ZFS to 2.2.1, refresh patches

2023-11-28 Thread Stoiko Ivanov
)` directories with 10 million files also still cause the restore-shim to run into OOM (but this is independent of the restore-image) Signed-off-by: Stoiko Ivanov --- ...ch => 0001-vsock-reduce-packet-size.patch} | 9 +++-- ...estore-halt-machine-on-kernel-panic.patch} | 9 +++-- .../0001-rem

[pve-devel] [PATCH zfsonlinux 1/2] update submodule and patches for 2.2.1

2023-11-22 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- ...-move-manpage-arcstat-1-to-arcstat-8.patch | 2 +- ...-guard-access-to-l2arc-MFU-MRU-stats.patch | 2 +- ...uncate_shares-without-etc-exports.d.patch} | 0 ...ol-Remove-broken-blk-mq-optimization.patch | 99 - ...evert-zvol-Temporally-disable

[pve-devel] [PATCH zfsonlinux 0/2] update to 2.2.1

2023-11-22 Thread Stoiko Ivanov
performance improvments are still missin in our current version. minimially tested on 2 VMs with a few containers with replication. Stoiko Ivanov (2): update submodule and patches for 2.2.1 d/zfsutils-linux.install: add zfs_prepare_disk and manpage ...-move-manpage-arcstat-1-to-arcstat-8

[pve-devel] [PATCH zfsonlinux 2/2] d/zfsutils-linux.install: add zfs_prepare_disk and manpage

2023-11-22 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian/zfsutils-linux.install | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/zfsutils-linux.install b/debian/zfsutils-linux.install index e788e27c..2fd7aefe 100644 --- a/debian/zfsutils-linux.install +++ b/debian/zfsutils-linux.install @@ -35,6

[pve-devel] [PATCH kernel-helper] add dedicated removable installation

2023-11-21 Thread Stoiko Ivanov
with this installed and an install with ZFS on / (RAID1). [0] https://git.savannah.gnu.org/cgit/grub.git/tree/util/grub-install.c#n1142 [1] https://git.proxmox.com/?p=pve-installer.git;a=blob;f=Proxmox/Install.pm;h=8825699416475b1934527531db4fbb40e9473ce8;hb=HEAD#l608 Signed-off-by: Stoiko Ivanov --- src

[pve-devel] [PATCH kernel-helper] grub-install: provide --removable to grub-install

2023-11-21 Thread Stoiko Ivanov
to proxmox products I don't think that this will cause many regressions For comparison - our installer has done the manual equivalent of the --removable option for installs on ext4 for quite a while. minimally tested on a VM during install. Reported-by: Thomas Lamprecht Signed-off-by: Stoiko

[pve-devel] [PATCH installer v2] zfs: create dataset var-lib-vz for /var/lib/vz

2023-11-21 Thread Stoiko Ivanov
with a refactoring of the lowlevel-installer code (setting the zfs-pool up under /target and getting rid of a few special cases) Fixes: dd19d40ceac179ba18652f1d6c3e4c23f246af00 Suggested-by: Fabian Grünbichler Signed-off-by: Stoiko Ivanov --- huge Thanks to Fabian - for the feedback and patiently walking

[pve-devel] [PATCH installer 1/2] zfs: set canmount=off on /var/lib

2023-11-21 Thread Stoiko Ivanov
: https://openzfs.github.io/openzfs-docs/Getting%20Started/Debian/Debian%20Bookworm%20Root%20on%20ZFS.html Fixes: dd19d40ceac179ba18652f1d6c3e4c23f246af00 Signed-off-by: Stoiko Ivanov --- Proxmox/Install.pm | 4 1 file changed, 4 insertions(+) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm

[pve-devel] [PATCH installer 0/2] fix 2 small issues with recent installer patches

2023-11-21 Thread Stoiko Ivanov
- following upstream's guide the second one fixes that grub did not show up on the serial console after installation. it follows the recommendations from the archwiki on the topic: https://wiki.archlinux.org/title/working_with_the_serial_console#GRUB minimally tested with a VM here. Stoiko Ivanov (2

[pve-devel] [PATCH installer 2/2] serial installer: add serial config for grub to target system

2023-11-21 Thread Stoiko Ivanov
Matching if a serial will be needed for grub is based on the target commandline - the speed is also read from there. The unit is based on the ttyS device - although I'd assume that this might not always match up. Signed-off-by: Stoiko Ivanov --- Proxmox/Install.pm | 8 +++- 1 file changed

[pve-devel] [PATCH installer] tui: fix interface sort order

2023-11-17 Thread Stoiko Ivanov
currently when multiple nics are present in a system the TUI sometimes selects the wrong interface (not the one that has the default gateway/dhcp lease) I assume this is due to HashMap's values yielding an iterator in arbitrary order Signed-off-by: Stoiko Ivanov --- sadly a bit difficult

[pve-devel] [PATCH zfsonlinux] pick bug-fixes staged for 2.2.1

2023-11-17 Thread Stoiko Ivanov
/zfs/pull/15529 finally: https://github.com/openzfs/zfs/commit/459c99ff2339a4a514abcf2255f9b3e5324ef09e should not hurt either the change to the UBSAN patch (0013) is unrelate, cosmetic only and happened by running export-patchqueue. Signed-off-by: Stoiko Ivanov --- minimally tested by building our

[pve-devel] [PATCH installer] run env: do not store emtpy hostname

2023-11-16 Thread Stoiko Ivanov
without this patch the hostname ends up as the empty string in run-env-info.json, which results in a parse-error in the TUI code (an empty string is not None, but still too short as hostname) Minimally tested on a VM. Fixes: bda1cdf699a3fcfc1cf3cfa446b1493689fc8eb8 Signed-off-by: Stoiko Ivanov

[pve-devel] [PATCH installer] zfs: create /var/lib/vz only for PVE

2023-11-16 Thread Stoiko Ivanov
: dd19d40ceac179ba18652f1d6c3e4c23f246af00 Signed-off-by: Stoiko Ivanov --- sending as separate patch in place of the v2 for the installer-glitches, because I forgot to pull before sending the v2 Proxmox/Install.pm | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/Proxmox/Install.pm b/Proxmox

[pve-devel] [PATCH installer v2 1/4] fix #4747: pass kernel cmdline parameters to target system

2023-11-16 Thread Stoiko Ivanov
as last entry. Signed-off-by: Stoiko Ivanov --- Proxmox/Install.pm| 11 +-- Proxmox/Install/Config.pm | 25 + 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 66adb2d..c868992 100644 --- a/Proxmox

[pve-devel] [PATCH installer v2 0/4] adaptation to kernel cmdline handling and 2 small ZFS related improvements

2023-11-16 Thread Stoiko Ivanov
oot (dmesg gets filled with journald-messages upon journal-rotation and user-logins) Tested the changes a bit (4/4 on my machine, 3/4 was straight-forward, 2/4 with a quick look, 1/4 with a few installer-options and net.ifnames=0) Stoiko Ivanov (4): fix #4747: pass kernel cmdline paramet

[pve-devel] [PATCH installer v2 3/4] fix #1410: zfs: create /var/lib/vz as separate dataset

2023-11-16 Thread Stoiko Ivanov
this enables the users to set reservations on / separate from /var/lib/vz - where backups, ISOs, and other data might fill the complete pool. moved the creation of the root-dataset above the creation of rpool/data, so that the pve-specifics can remain in one if block. Signed-off-by: Stoiko

[pve-devel] [PATCH installer v2 4/4] zfs: set acltype=posix for root-dataset

2023-11-16 Thread Stoiko Ivanov
guide for root on ZFS: https://openzfs.github.io/openzfs-docs/Getting%20Started/Debian/Debian%20Bookworm%20Root%20on%20ZFS.html Tested by setting this on a machine of mine, where this has been bugging for quite a while. Signed-off-by: Stoiko Ivanov --- Proxmox/Install.pm | 2 ++ 1 file changed

[pve-devel] [PATCH installer v2 2/4] unconfigured.sh: set serial to a number to prevent warning

2023-11-16 Thread Stoiko Ivanov
caught me off-guard while debugging other things - the message: ` [: : integer expression expected` made me look a bit too long at the wrong place. Fixes: a31259b1597447a0b431cd5c81a6db2bc80f1ddf Signed-off-by: Stoiko Ivanov --- unconfigured.sh | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [pve-devel] [PATCH installer 3/4] fix #1410: zfs: create /var/lib/vz as separate dataset

2023-11-16 Thread Stoiko Ivanov
this is wrong! the dataset is only needed for pve I'll resend a v2 sorry for the noise! On Thu, 16 Nov 2023 16:00:40 +0100 Stoiko Ivanov wrote: > this enables the users to set reservations on / separate from > /var/lib/vz - where backups, ISOs, and other data might fill the > comp

[pve-devel] [PATCH installer 2/4] unconfigured.sh: set serial to a number to prevent warning

2023-11-16 Thread Stoiko Ivanov
caught me off-guard while debugging other things - the message: ` [: : integer expression expected` made me look a bit too long at the wrong place. Fixes: a31259b1597447a0b431cd5c81a6db2bc80f1ddf Signed-off-by: Stoiko Ivanov --- unconfigured.sh | 1 + 1 file changed, 1 insertion(+) diff --git

[pve-devel] [PATCH installer 4/4] zfs: set acltype=posix for root-dataset

2023-11-16 Thread Stoiko Ivanov
guide for root on ZFS: https://openzfs.github.io/openzfs-docs/Getting%20Started/Debian/Debian%20Bookworm%20Root%20on%20ZFS.html Tested by setting this on a machine of mine, where this has been bugging for quite a while. Signed-off-by: Stoiko Ivanov --- Proxmox/Install.pm | 2 ++ 1 file changed

[pve-devel] [PATCH installer 0/4] adaptation to kernel cmdline handling and 2 small ZFS related improvements

2023-11-16 Thread Stoiko Ivanov
, 2/4 with a quick look, 1/4 with a few installer-options and net.ifnames=0) Stoiko Ivanov (4): fix #4747: pass kernel cmdline parameters to target system unconfigured.sh: set serial to a number to prevent warning fix #1410: zfs: create /var/lib/vz as separate dataset zfs: set acltype=posix

[pve-devel] [PATCH installer 1/4] fix #4747: pass kernel cmdline parameters to target system

2023-11-16 Thread Stoiko Ivanov
as last entry. Signed-off-by: Stoiko Ivanov --- Proxmox/Install.pm| 11 +-- Proxmox/Install/Config.pm | 25 + 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 66adb2d..c868992 100644 --- a/Proxmox

[pve-devel] [PATCH installer 3/4] fix #1410: zfs: create /var/lib/vz as separate dataset

2023-11-16 Thread Stoiko Ivanov
this enables the users to set reservations on / separate from /var/lib/vz - where backups, ISOs, and other data might fill the complete pool. Signed-off-by: Stoiko Ivanov --- Proxmox/Install.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index

[pve-devel] [PATCH installer 2/2] serial install: fix console parameter parsing

2023-11-14 Thread Stoiko Ivanov
The regex matching in Proxmox::Install::Config was blindly copied from above - so the other parameters are also likely to not get recognized if they are the last on the cmdline Signed-off-by: Stoiko Ivanov --- Proxmox/Install.pm| 2 +- Proxmox/Install/Config.pm | 2 +- 2 files changed

[pve-devel] [PATCH installer 0/2] minimal changes for a working serial installation

2023-11-14 Thread Stoiko Ivanov
general solution for what to add to the cmdline from the install environment) - I'll try to send a follow-up tomorrow Stoiko Ivanov (2): d/control: add libgtk3-perl to B-D serial install: fix console parameter parsing Proxmox/Install.pm| 2 +- Proxmox/Install/Config.pm | 2 +- debian

[pve-devel] [PATCH installer 1/2] d/control: add libgtk3-perl to B-D

2023-11-14 Thread Stoiko Ivanov
With the first tests entering the installer in 9a0d66cb36d395a1186904132aed1d5dc33a0937 we now need libgtk3-perl during package-building with `make deb` Signed-off-by: Stoiko Ivanov --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index

[pve-devel] [PATCH zfsonlinux] add patch for spurious warning on `zfs mount -a`

2023-11-02 Thread Stoiko Ivanov
reported in our community forum: https://forum.proxmox.com/threads/.135635/post-60036 the small fix was merged upstream: https://github.com/openzfs/zfs/pull/15468 minimally tested by building with this patch and running `zfs mount -a` on an affected system. Signed-off-by: Stoiko Ivanov

[pve-devel] [PATCH kernel-helper/manager v3] check for fitting grub-meta package on uefi systems

2023-10-11 Thread Stoiko Ivanov
with d/postinst as well) If the pve-manager patch gets applied - I'd push the equivalent change to pmg and provide one for pbs. Tested on legacy and uefi VMs installed with pve-8.0 iso and grub-efi-amd64 (and systemd-boot) removed vs. installed. proxmox-kernel-helper Stoiko Ivanov (2): proxmox-boo

[pve-devel] [PATCH manager v3 1/1] pve7to8: check for proper grub meta-package for bootmode

2023-10-11 Thread Stoiko Ivanov
-kernel-helper (warnings printed during regular package upgrades might be overlooked more easily than a yellow line in the major upgrade checkscript) The if/else order was chosen to limit the nesting level of the long messages. Signed-off-by: Stoiko Ivanov --- PVE/CLI/pve7to8.pm | 39

[pve-devel] [PATCH kernel-helper v3 1/2] proxmox-boot-tool: do not exit early in kernel-hook

2023-10-11 Thread Stoiko Ivanov
update_esps is called first in the actual execution below - exiting early does not work for systems that don't use proxmox-boot-tool if a check added later needs to work there too. Signed-off-by: Stoiko Ivanov --- src/proxmox-boot/zz-proxmox-boot | 2 +- 1 file changed, 1 insertion(+), 1

[pve-devel] [PATCH kernel-helper v3 2/2] proxmox-boot-tool: check if correct grub metapackage is installed

2023-10-11 Thread Stoiko Ivanov
). Suggested-by: Thomas Lamprecht Signed-off-by: Stoiko Ivanov --- src/proxmox-boot/zz-proxmox-boot | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/proxmox-boot/zz-proxmox-boot b/src/proxmox-boot/zz-proxmox-boot index 1adc1b1..4dfa765 100755 --- a/src/proxmox-boot/zz

[pve-devel] [PATCH kernel-helper v2 2/2] proxmox-boot-tool: check if correct grub metapackage is installed

2023-10-09 Thread Stoiko Ivanov
). Suggested-by: Thomas Lamprecht Signed-off-by: Stoiko Ivanov --- src/proxmox-boot/zz-proxmox-boot | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/proxmox-boot/zz-proxmox-boot b/src/proxmox-boot/zz-proxmox-boot index 1adc1b1..4dfa765 100755 --- a/src/proxmox-boot/zz

[pve-devel] [PATCH kernel-helper v2 1/2] proxmox-boot-tool: do not exit early in kernel-hook

2023-10-09 Thread Stoiko Ivanov
update_esps is called first in the actual execution below - exiting early does not work for systems that don't use proxmox-boot-tool if a check added later needs to work there too. Signed-off-by: Stoiko Ivanov --- src/proxmox-boot/zz-proxmox-boot | 2 +- 1 file changed, 1 insertion(+), 1

[pve-devel] [PATCH kernel-helper/manager v2] check for fitting grub-meta package on uefi systems

2023-10-09 Thread Stoiko Ivanov
iso and grub-efi-amd64 (and systemd-boot) removed vs. installed. proxmox-kernel-helper: Stoiko Ivanov (2): proxmox-boot-tool: do not exit early in kernel-hook proxmox-boot-tool: check if correct grub metapackage is installed src/proxmox-boot/zz-proxmox-boot | 21 - 1 file chan

[pve-devel] [PATCH manager v2 1/1] pve7to8: check for proper grub meta-package for bootmode

2023-10-09 Thread Stoiko Ivanov
-kernel-helper (warnings printed during regular package upgrades might be overlooked more easily than a yellow line in the major upgrade checkscript) The if/else order was chosen to limit the nesting level of the long messages. Signed-off-by: Stoiko Ivanov --- PVE/CLI/pve7to8.pm | 39

[pve-devel] [PATCH 1/1] pve7to8: check for proper grub meta-package for bootmode

2023-10-04 Thread Stoiko Ivanov
-kernel-helper (warnings printed during regular package upgrades might be overlooked more easily than a yellow line in the major upgrade checkscript) The if/else order was chosen to limit the nesting level of the long messages. Signed-off-by: Stoiko Ivanov --- PVE/CLI/pve7to8.pm | 39

[pve-devel] [PATCH 2/2] proxmox-boot-tool: check if correct grub metapackage is installed

2023-10-04 Thread Stoiko Ivanov
). Suggested-by: Thomas Lamprecht Signed-off-by: Stoiko Ivanov --- src/proxmox-boot/zz-proxmox-boot | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/proxmox-boot/zz-proxmox-boot b/src/proxmox-boot/zz-proxmox-boot index 1adc1b1..0d08dbf 100755 --- a/src/proxmox-boot/zz

[pve-devel] [PATCH 1/2] proxmox-boot-tool: do not exit early in kernel-hook

2023-10-04 Thread Stoiko Ivanov
update_esps is called first in the actual execution below - exiting early does not work for systems that don't use proxmox-boot-tool if a check added later needs to work there too. Signed-off-by: Stoiko Ivanov --- src/proxmox-boot/zz-proxmox-boot | 2 +- 1 file changed, 1 insertion(+), 1

[pve-devel] [PATCH kernel-helper/manager] check for fitting grub-meta package on uefi systems

2023-10-04 Thread Stoiko Ivanov
and provide one for pbs. Tested on legacy and uefi VMs installed with pve-8.0 iso and grub-efi-amd64 (and systemd-boot) removed vs. installed. proxmox-kernel-helper: Stoiko Ivanov (2): proxmox-boot-tool: do not exit early in kernel-hook proxmox-boot-tool: check if correct grub metapackage

Re: [pve-devel] [PATCH installer] install: install correct grub metapackage for the current boot-mode

2023-09-28 Thread Stoiko Ivanov
just realized while talking with Friedrich off-list - if this gets applied it probably would make sense to include it in the pve7to8 (same for pbs and pmg) checks (and also in the upgrade guides) (mostly meant as a note to myself) On Thu, 28 Sep 2023 16:05:33 +0200 Stoiko Ivanov wrote: > g

[pve-devel] [PATCH installer] install: install correct grub metapackage for the current boot-mode

2023-09-28 Thread Stoiko Ivanov
-by: Stoiko Ivanov --- quickly tested by building an ISO (with the necessary modifications to ship both packages as .deb) and installing in legacy mode and uefi mode once. Proxmox/Install.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 1117fc4

[pve-devel] [PATCH zfsonlinux] update zfs submodule to 2.1.13 and refresh patches

2023-09-28 Thread Stoiko Ivanov
Sugested-by: Thomas Lamprecht Signed-off-by: Stoiko Ivanov --- did some minimal testing (ztest for a while, containers with replication and a migration between 2 nodes) - looked ok The changelog also seems harmless from a quick glance. debian/patches/0005-Enable-zed-emails.patch| 2

[pve-devel] [PATCH pve-kernel] cherry-pick fix for new amd64 ucode

2023-09-25 Thread Stoiko Ivanov
debian.org/changelogs//non-free-firmware/a/amd64-microcode/amd64-microcode_3.20230808.1.1_changelog Signed-off-by: Stoiko Ivanov --- ...de-AMD-Load-late-on-both-threads-too.patch | 32 +++ 1 file changed, 32 insertions(+) create mode 100644 patches/kernel/0018-x86-microcode-AMD

[pve-devel] [PATCH pve-kernel 1/2] refresh patches after ./debian/scripts/export-patchqueue

2023-08-24 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- ...overrides-for-missing-ACS-capabilities-4..patch | 4 ++-- ...lator-smm-add-structs-for-KVM-s-smram-lay.patch | 4 ++-- ...lator-smm-use-smram-structs-in-the-common.patch | 14 +++--- ...lator-smm-use-smram-struct-for-32-bit-smr.patch | 8

[pve-devel] [PATCH pve-kernel 2/2] cherry-pick fix for uefi guests hanging upon guest-initialized reboot

2023-08-24 Thread Stoiko Ivanov
/ Suggested-by: Stefan Hanreich Signed-off-by: Stoiko Ivanov --- ...l-stage2-mapping-on-invalid-memory-s.patch | 122 ++ 1 file changed, 122 insertions(+) create mode 100644 patches/kernel/0025-KVM-Avoid-illegal-stage2-mapping-on-invalid-memory-s.patch diff --git a/patches/kernel/0025

[pve-devel] [PATCH pve-kernel 0/2] cherry-pick a patch from kernel.org stable 5.15 for guests hanging during reboot

2023-08-24 Thread Stoiko Ivanov
. Stoiko Ivanov (2): refresh patches after ./debian/scripts/export-patchqueue cherry-pick fix for uefi guests hanging upon guest-initialized reboot ...ides-for-missing-ACS-capabilities-4..patch | 4 +- ...-smm-add-structs-for-KVM-s-smram-lay.patch | 4 +- ...-smm-use-smram-structs

[pve-devel] [PATCH pve-kernel] d/rules: disable CONFIG_GDS_FORCE_MITIGATION

2023-08-18 Thread Stoiko Ivanov
when not having installed an intel-microcode version containing the mitigation, this options disables AVX instructions, which breaks quite a lot of software (e.g. firefox, electron apps) Reported-by: Stefan Hanreich Tested-by: Stefan Hanreich Signed-off-by: Stoiko Ivanov --- quickly build

[pve-devel] [PATCH pve-kernel] update sources to Ubuntu-5.15.0-82.91

2023-08-17 Thread Stoiko Ivanov
(generated with debian/scripts/import-upstream-tag) Signed-off-by: Stoiko Ivanov --- * This jammy release was just pushed today. * as opposed to the fixes I sent for kernel 6.2/PVE 8.0 Ubuntu disabled the forced mitigation for GDS_FORCE_MITIGATION - judging from internal feedback (about

Re: [pve-devel] [PATCH pve-kernel 0/2] cherry-picks and config-options for downfall

2023-08-11 Thread Stoiko Ivanov
On Fri, 11 Aug 2023 18:01:02 +0200 Stoiko Ivanov wrote: please ignore this - I accidentally sent a patch too many (which got removed in the moderation queue) the actual series is the next thread on the list > Changes taken from ubuntu's repository (at launchpad) > sending as individual

[pve-devel] [PATCH pve-kernel 2/2] d/rules: enable mitigation config-options

2023-08-11 Thread Stoiko Ivanov
CONFIG_ARCH_HAS_CPU_FINALIZE_INIT and CONFIG_GDS_FORCE_MITIGATION follows commit 3edbe24ed004516bd910f6e97fbd4b62cf589239 in ubuntu-upstream/master-next Signed-off-by: Stoiko Ivanov --- debian/rules | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/debian/rules b/debian

[pve-devel] [PATCH pve-kernel 1/2] add fixes for downfall

2023-08-11 Thread Stoiko Ivanov
/lunar Signed-off-by: Stoiko Ivanov --- ...-init-Provide-arch_cpu_finalize_init.patch | 85 +++ ...cpu-Switch-to-arch_cpu_finalize_init.patch | 235 +++ ...cpu-Switch-to-arch_cpu_finalize_init.patch | 82 +++ ...cpu-Switch-to-arch_cpu_finalize_init.patch | 80 +++ ...cpu-Switch

[pve-devel] [PATCH pve-kernel 0/2] cherry-picks and config-options for downfall

2023-08-11 Thread Stoiko Ivanov
be tested on an affected machine too! Stoiko Ivanov (2): add fixes for downfall d/rules: enable mitigation config-options debian/rules | 4 +- ...-init-Provide-arch_cpu_finalize_init.patch | 85 +++ ...cpu-Switch-to-arch_cpu_finalize_init.patch | 235

[pve-devel] [PATCH pve-kernel 0/2] cherry-picks and config-options for downfall

2023-08-11 Thread Stoiko Ivanov
be tested on an affected machine too! Stoiko Ivanov (2): add fixes for downfall d/rules: enable mitigation config-options debian/rules | 4 +- ...-init-Provide-arch_cpu_finalize_init.patch | 85 +++ ...cpu-Switch-to-arch_cpu_finalize_init.patch | 235

[pve-devel] [PATCH pve-kernel 2/2] d/rules: enable mitigation config-options

2023-08-11 Thread Stoiko Ivanov
CONFIG_ARCH_HAS_CPU_FINALIZE_INIT and CONFIG_GDS_FORCE_MITIGATION follows commit 3edbe24ed004516bd910f6e97fbd4b62cf589239 in ubuntu-upstream/master-next Signed-off-by: Stoiko Ivanov --- debian/rules | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/debian/rules b/debian

[pve-devel] [PATCH container] setup: fedora: fix wrong systemd-networkd preset

2023-06-23 Thread Stoiko Ivanov
off-by: Stoiko Ivanov --- src/PVE/LXC/Setup/Fedora.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Setup/Fedora.pm b/src/PVE/LXC/Setup/Fedora.pm index 80ee85f..1a487c6 100644 --- a/src/PVE/LXC/Setup/Fedora.pm +++ b/src/PVE/LXC/Setup/Fedora.pm @@ -39,7 +39,7 @@

[pve-devel] [PATCH docs] faq: fix typo in release names

2023-06-23 Thread Stoiko Ivanov
Reported-by: Daniela Häsler Signed-off-by: Stoiko Ivanov --- pve-faq.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-faq.adoc b/pve-faq.adoc index ce22ad5..a0b838d 100644 --- a/pve-faq.adoc +++ b/pve-faq.adoc @@ -89,7 +89,7 @@ recommended. [width="100%"

[pve-devel] [PATCH installer] fix space calculation for small disks for pve product

2023-06-22 Thread Stoiko Ivanov
, which overflows in the `& ~0xFFF` opration. Signed-off-by: Stoiko Ivanov --- tested in a VM with an 8GB disk Proxmox/Install.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 7970f83..28add10 100644 --- a/Proxmox/Instal

[pve-devel] [PATCH] pve7to8: add check for systemd-boot presence where needed

2023-06-21 Thread Stoiko Ivanov
comes from the API-modules, which limit it to the pve-relevant packages. tested in VMs with uefi and legacy mode, with existing proxmox-boot-uuids both with and w/o systemd-boot being installed Signed-off-by: Stoiko Ivanov --- PVE/CLI/pve7to8.pm | 29 + 1 file changed

[pve-devel] [PATCH 3/3] d/control: add Recommends on systemd-boot

2023-06-21 Thread Stoiko Ivanov
systemd-boot is a separate binary package, and proxmox-boot-tool needs it in the uefi-case as boot-loader for the ESPs Not adding as Depends, because it is not strictly necessary for proxmox-boot-tool (pinning is independent as is its use on legacy-boot systems) Signed-off-by: Stoiko Ivanov

[pve-devel] [PATCH 2/3] proxmox-boot: warn on missing systemd-boot package

2023-06-21 Thread Stoiko Ivanov
of bootctl in the boot-tool codebase Signed-off-by: Stoiko Ivanov --- src/bin/proxmox-boot-tool | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool index d41f921..913b0f6 100755 --- a/src/bin/proxmox-boot-tool +++ b/src/bin/proxmox-boot

[pve-devel] [PATCH 0/3] adapt to systemd-boot hooks in bookworm

2023-06-21 Thread Stoiko Ivanov
ool into it later (by partitioning accordingly) While I tested the patches - some review and consideration, especially about potential pitfalls regarding the in place editing of the hook-scripts would be very much appreciated! Stoiko Ivanov (3): boot-tool: disarm upstream systemd-boot hookscri

[pve-devel] [PATCH 1/3] boot-tool: disarm upstream systemd-boot hookscripts

2023-06-21 Thread Stoiko Ivanov
/8a38b62f37189b071a30f208530ce5dc278e521e/src/boot/bootctl.c#L90 [2] https://www.debian.org/doc/debian-policy/ap-pkg-diversions.html [3] https://www.debian.org/doc/debian-policy/ch-relationships.html Reported-by: Aaron Lauterer Signed-off-by: Stoiko Ivanov --- src/proxmox-boot/zz-proxmox-boot | 23

  1   2   3   4   5   6   >