Re: [pve-devel] [PATCH qemu-server 1/2] migration: avoid crash with heavy IO on local VM disk

2024-05-23 Thread Thomas Lamprecht
Am 23/05/2024 um 11:08 schrieb Fabian Grünbichler: >> +my $kvm_version = PVE::QemuServer::kvm_user_version(); > wouldn't this need to check the *running* qemu binary for the migrated > VM, not the *installed* qemu binary on the system? Yes, this would need to check the running QEMU version

[pve-devel] applied-series: [PATCH zfsonlinux v2 0/2] Update to ZFS 2.2.4

2024-05-21 Thread Thomas Lamprecht
Am 07/05/2024 um 17:02 schrieb Stoiko Ivanov: > v1->v2: > Patch 2/2 (adaptation of arc_summary/arcstat patch) modified: > * right after sending the v1 I saw a report where pinning kernel 6.2 (thus > ZFS 2.1) leads to a similar traceback - which I seem to have overlooked > when packaging 2.2.0

[pve-devel] applied: [PATCH docs] network: override device names: suggest running update-initramfs

2024-05-21 Thread Thomas Lamprecht
Am 21/05/2024 um 14:55 schrieb Friedrich Weber: > The initramfs-tools hook /usr/share/initramfs-tools/hooks/udev copies > link files from /etc/systemd/network to the initramfs, where they take > effect in early userspace. If the link files in the initramfs diverge > from the link files in the

[pve-devel] applied: [PATCH v2 manager] api: add proxmox-firewall to versions pkg list

2024-05-21 Thread Thomas Lamprecht
Am 24/04/2024 um 13:35 schrieb Mira Limbeck: > Signed-off-by: Mira Limbeck > --- > v2: > - add `api: ` prefix to commit msg > > PVE/API2/APT.pm | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied-series: [PATCH proxmox-firewall 1/2] firewall: improve handling of ARP traffic for guests

2024-05-21 Thread Thomas Lamprecht
Am 15/05/2024 um 15:37 schrieb Stefan Hanreich: > In order to be able to send outgoing ARP packets when the default > policy is set to drop or reject, we need to explicitly allow ARP > traffic in the outgoing chain of guests. We need to do this in the > guest chain itself in order to be able to

[pve-devel] applied: [PATCH proxmox-firewall v2 1/1] firewall: properly reject ipv6 traffic

2024-05-21 Thread Thomas Lamprecht
Am 13/05/2024 um 14:14 schrieb Stefan Hanreich: > ICMPv6 has different message types for rejecting traffic. With ICMP we > used host-prohibited as rejection type, which doesn't exist in ICMPv6. > Add an additional rule for IPv6, so it uses admin-prohibited. > > Additionally, add a terminal drop

Re: [pve-devel] [PATCH qemu-server v10 1/4] add C program to get hardware capabilities from CPUID

2024-05-21 Thread Thomas Lamprecht
Am 17/05/2024 um 13:21 schrieb Dominik Csapak: > one small nit inline: > > On 5/10/24 13:47, Markus Frank wrote: >> diff --git a/query-machine-capabilities/Makefile >> b/query-machine-capabilities/Makefile >> new file mode 100644 >> index 000..c5f6348 >> --- /dev/null >> +++

[pve-devel] applied: [PATCH qemu] fixes for QEMU 9.0

2024-05-17 Thread Thomas Lamprecht
Am 17/05/2024 um 10:44 schrieb Fiona Ebner: > Most importantly, fix forwards and backwards migration with VirtIO-GPU > display. > > Other fixes are for a regression in pflash device (introduced in 8.2) > and some fixes for x86(_64) TCG emulation. One of the patches needed > to be adapted, because

Re: [pve-devel] [RFC qemu] savevm-async: improve check for blockers

2024-05-17 Thread Thomas Lamprecht
subject might be improved by being less general/ambiguous, something like: savevm-async: improve coverage by also checking for migration blockers or savevm-async: block snapshot also if migration would fail or savevm-async: reuse migration blocker check for snapshots Would have helped me to

[pve-devel] applied: [PATCH qemu-server] suspend: continue cleanup even if savevm-end QMP command fails

2024-05-15 Thread Thomas Lamprecht
Am 14/05/2024 um 16:11 schrieb Fiona Ebner: > The savevm-end command also fails when no snapshot operation was > started before. In particular, this is the case when savevm-start > failed early, because of unmigratable devices. > > Avoid potentially leaving an orphaned volume and snasphot-related

Re: [pve-devel] [RFC PATCH manager] ui: make label for mediated device types more clear

2024-05-08 Thread Thomas Lamprecht
On 08/05/2024 14:54, Dominik Csapak wrote: > 'MDev' could be interpreted as either 'Mediated Device' or 'Mapped > Device', which can confuse users. > > At least one user was confused: > https://forum.proxmox.com/threads/146586/#post-662091 > > Fix that by writing out 'Mediated Device'. > >

Re: [pve-devel] [PATCH storage 1/1] esxi: improve error handling for fuse mount tool

2024-05-08 Thread Thomas Lamprecht
On 08/05/2024 14:41, Dominik Csapak wrote: > if the fuse tool encounters an error early, it prints it like: >Error: some error message > on stderr. > > We can capture that here by redirecting STDERR to $wr and die'ing with using just a variable name like $wr without context in a commit

Re: [pve-devel] [PATCH pve-esxi-import-tools 1/1] improve error handling before mounting

2024-05-08 Thread Thomas Lamprecht
On 08/05/2024 14:41, Dominik Csapak wrote: > when we fail early in the mount process, we did not log any error to the > syslog, but only the top most one to stderr. > > sadly we were not able to see them anywhere, so improve the log by > * log the complete error chain with log::error (so we also

[pve-devel] applied-series: [PATCH installer v3 0/2] assistant: keep prepared iso bootable on uefi with flash drives

2024-05-08 Thread Thomas Lamprecht
On 30/04/2024 12:46, Aaron Lauterer wrote: > booting a prepared iso in UEFI mode from a blockdev (e.g. usb flash > drive) did not work as grub could not find the partition. > > we now read the uuid / volume_date from the source iso and always set it > explictly to the same value when injecting

[pve-devel] applied: [PATCH qemu-server] schema: fix description of migrate_downtime parameter

2024-05-03 Thread Thomas Lamprecht
On 03/05/2024 14:01, Fiona Ebner wrote: > Since commit 865ef132 ("implement dynamic migration_downtime") the > migration downtime will be automatically increased when migration > cannot converge at the very end. Update the description to reflect > reality. > > Signed-off-by: Fiona Ebner > --- >

[pve-devel] applied-series: [PATCH v2 container 1/2] setup: support Ubuntu 24.04 Noble

2024-05-02 Thread Thomas Lamprecht
On 30/04/2024 16:42, Fiona Ebner wrote: > Minimally tested, that an upgrade from an existing 23.04 container > works, there still is network and no obviously bad messages in the > container's journal. > > Reported in the community forum: > https://forum.proxmox.com/threads/145848/ > >

Re: [pve-devel] [PATCH container] setup: support Ubuntu 24.04 Noble

2024-04-30 Thread Thomas Lamprecht
On 30/04/2024 10:43, Fiona Ebner wrote: > So this is not new (already present for Ubuntu 23.10) and stems from the > fact that these images from linuxcontainers.org contain: > >> root@CT113:~# cat /etc/netplan/10-lxc.yaml >> network: >> version: 2 >> ethernets: >> eth0: >> dhcp4:

[pve-devel] applied-series: [PATCH storage 1/2] don't bail on whitespaces in backing devices

2024-04-30 Thread Thomas Lamprecht
On 30/04/2024 09:53, Wolfgang Bumiller wrote: > This prevents importing from vmdks with whitespaces in file names. > Further, some operations that include file sizes (like listing disks) > would potentially fail entirely if a custom disk with a badly name > backing device exists in a VM images

[pve-devel] applied-series: [PATCH v3 qemu 1/2] fix #5409: backup: fix copy-before-write timeout

2024-04-30 Thread Thomas Lamprecht
On 29/04/2024 17:20, Fiona Ebner wrote: > The type for the copy-before-write timeout in nanoseconds was wrong. > By being just uint32_t, a maximum of slightly over 4 seconds was > possible. Larger values would overflow and thus the 45 seconds set by > Proxmox's backup with fleecing, resulted in

[pve-devel] applied: [PATCH v2 qemu 1/2] fix #5409: backup: fix copy-before-write timeout

2024-04-29 Thread Thomas Lamprecht
Am 29/04/2024 um 16:27 schrieb Fiona Ebner: > The type for the copy-before-write timeout in nanoseconds was wrong. > By being just uint32_t, a maximum of slightly over 4 seconds was > possible. Larger values would overflow and thus the 45 seconds set by > Proxmox's backup with fleecing, resulted

[pve-devel] applied: [PATCH docs v2] fix #5429: network: override device names: include Type=ether

2024-04-29 Thread Thomas Lamprecht
Am 29/04/2024 um 09:49 schrieb Friedrich Weber: > Mention that the systemd link file should contain `Type=ether` in most > setup, to make sure it only applies to Ethernet devices and does not > ever apply to e.g. bridges or bonds which inherit the MAC address of > the Ethernet device. Mention that

[pve-devel] applied: [PATCH-SERIES qemu] update to QEMU 9.0.0

2024-04-29 Thread Thomas Lamprecht
Am 25/04/2024 um 17:21 schrieb Fiona Ebner: > QEMU 8.2.2 required many changes, in particular to the alloc-track > block driver. It should be the same as [0] just with backup fleecing > patches added in. See the patch for details. > > The only bigger change in QEMU 9.0.0 is that the AioContext

Re: [pve-devel] [PATCH manager] ui: Remove pveACMEPluginView in favor of pmxACMEPluginView

2024-04-29 Thread Thomas Lamprecht
subject: ui: acme: switch plugin view over to the one from widget-toolkit (having internal xtypes in the subject already is not really that useful) Am 29/08/2023 um 13:00 schrieb Filip Schauer: > Remove pveACMEPluginView and use the ACMEPluginView from the > proxmox-widget-toolkit instead.

Re: [pve-devel] [PATCH container] setup: support Ubuntu 24.04 Noble

2024-04-29 Thread Thomas Lamprecht
Am 29/04/2024 um 11:56 schrieb Fiona Ebner: > Am 29.04.24 um 11:36 schrieb Fiona Ebner: >> Am 29.04.24 um 11:23 schrieb Fiona Ebner: >>> Reported in the community forum: >>> https://forum.proxmox.com/threads/145848/#post-658694 >>> >>> Signed-off-by: Fiona Ebner >>> --- >>> >>> Minimally tested,

[pve-devel] applied: [PATCH proxmox-firewall] config: macros: add SPICEproxy macro

2024-04-25 Thread Thomas Lamprecht
Am 25/04/2024 um 19:16 schrieb Stefan Hanreich: > Signed-off-by: Stefan Hanreich > --- > proxmox-ve-config/resources/macros.json | 9 + > 1 file changed, 9 insertions(+) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH proxmox-firewall] firewall: improve error handling of firewall

2024-04-25 Thread Thomas Lamprecht
Am 25/04/2024 um 19:23 schrieb Stefan Hanreich: > Error handling of the firewall binary should now be much more robust > on configuration errors. Instead of panicking in some cases it should > now log an error. > > Signed-off-by: Stefan Hanreich > --- >

[pve-devel] applied: [PATCH proxmox-firewall] config: nftables: add support for icmp-type any

2024-04-25 Thread Thomas Lamprecht
Am 25/04/2024 um 19:16 schrieb Stefan Hanreich: > We support any as wildcard for matching all icmp types. Implement > parsing logic for parsing the any value and support converting the any > value into an nftables expression. > > Signed-off-by: Stefan Hanreich > --- >

[pve-devel] applied: [PATCH container] fix #5414: use proper percentages in `pct df`

2024-04-25 Thread Thomas Lamprecht
Am 25/04/2024 um 09:40 schrieb Fabian Grünbichler: > while some people write percentages as 0.XX , putting a % next to that is just > confusing. also, combined with the format modifier this would be rather lossy, > and also not match regular `df` output.. > Fixes: c6b5965 ("added 'pct df'")

[pve-devel] applied-series: [PATCH installer] install module: getters: correctly use plural in error messages

2024-04-25 Thread Thomas Lamprecht
Am 25/04/2024 um 10:40 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > Proxmox/Install.pm | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > applied both patches, thanks! ___ pve-devel mailing list

Re: [pve-devel] [PATCH docs] network: override device names: include Type=ether in link file

2024-04-24 Thread Thomas Lamprecht
Am 24/04/2024 um 18:55 schrieb Friedrich Weber: > Mention that the systemd link file should contain `Type=ether`, to > make sure it only applies to Ethernet devices and does not ever apply > to e.g. bridges or bonds which inherit the MAC address of the Ethernet > device. Reported in the forum [0].

[pve-devel] applied: [PATCH proxmox-firewall] fix #5410: config: fix naming scheme for names in firewall config

2024-04-24 Thread Thomas Lamprecht
Am 24/04/2024 um 18:15 schrieb Stefan Hanreich: > This should bring the allowed names on par with the pve-firewall > naming scheme [1]. > > [1] >

[pve-devel] applied: [PATCH] auto install assistant: fix newline before ':'

2024-04-24 Thread Thomas Lamprecht
Am 24/04/2024 um 11:02 schrieb Dominik Csapak: > this belongs after the ':' otherwise the output looks weird: > > [..] can be > : * integrated into [..] > * needs to be [..] > > Signed-off-by: Dominik Csapak > --- > proxmox-auto-install-assistant/src/main.rs | 2 +- > 1 file changed, 1

[pve-devel] applied: [PATCH proxmox-i18n] update German translations

2024-04-24 Thread Thomas Lamprecht
Am 24/04/2024 um 11:14 schrieb Max Carrara: > Signed-off-by: Max Carrara > --- > de.po | 220 -- > 1 file changed, 107 insertions(+), 113 deletions(-) > > applied, thanks! ___ pve-devel

[pve-devel] applied: [PATCH pve-installer] answer: perform basic input validation for keyboard

2024-04-24 Thread Thomas Lamprecht
Am 24/04/2024 um 10:48 schrieb Christian Ebner: > Currently it is possible to validate and create an iso with an > invalid keyboad layout, only failing later during installation. > > Add a basic check for correct keyboard layout by defining an enum > with allowed variants. > > Signed-off-by:

[pve-devel] partially-applied-series: [PATCH many v2 00/20] notifications: move template strings to template files; PBS preparations

2024-04-23 Thread Thomas Lamprecht
Am 19/04/2024 um 16:17 schrieb Lukas Wagner: > proxmox: > > Lukas Wagner (12): > notify: switch to file-based templating system > notify: make api methods take config struct ownership > notify: convert Option> -> Vec in config structs > notify: don't make tests require pve-context >

[pve-devel] applied: [PATCH proxmox-firewall] firewall: properly handle REJECT rules

2024-04-23 Thread Thomas Lamprecht
Am 23/04/2024 um 18:02 schrieb Stefan Hanreich: > Currently we generated DROP statements for all rules involving REJECT. > We only need to generate DROP when in the postrouting chain of tables > with type bridge, since REJECT is disallowed there. Otherwise we jump > into the do-reject chain which

[pve-devel] applied: [PATCH installer] assistant: prepare iso: s/direct/included to match current naming

2024-04-23 Thread Thomas Lamprecht
Am 23/04/2024 um 11:00 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > proxmox-auto-install-assistant/src/main.rs | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH installer] assistant: error out on set network config for dhcp

2024-04-23 Thread Thomas Lamprecht
Am 23/04/2024 um 17:18 schrieb Stoiko Ivanov: > potentially will not happen too often in practice if the sample files > always contain the right source. Still having settings in an answer > file that get ignored does not seem right. > > tested with `validate-answer` on a file without `source` in

[pve-devel] applied: [PATCH installer] auto-installer: move ssh keys setup to low-level installer

2024-04-23 Thread Thomas Lamprecht
Am 23/04/2024 um 16:44 schrieb Christoph Heiss: > .. thereby, also fixing a accidental shell injection. > > Since run_cmd{,s}() is nowhere else used anymore, they can be removed > too. > > Also mostly reverts commit > > 5878dc4ae "auto-installer: handle auto-reboot info messages directly" >

[pve-devel] applied-series: [PATCH manager v2] fix #5251: login: set autocomplete on password and user

2024-04-23 Thread Thomas Lamprecht
Am 19/02/2024 um 11:37 schrieb Maximiliano Sandoval: > By default they have 'autocomplete=off'. From [1]: > > > In most modern browsers, setting autocomplete to "off" will not > > prevent a password manager from asking the user if they would like to > > save username and password information,

[pve-devel] applied: [PATCH manager 1/3] ui: user edit: protect user's TFA settings again

2024-04-23 Thread Thomas Lamprecht
Am 09/02/2024 um 14:08 schrieb Fiona Ebner: > Same rationale as in 5b25580d ("Protect the user's tfa key setting."): > it should not be possible to change the value when it's not an actual > secret but a reference to what TFA method is used or, in case of 'x', > whether TFA is used. > >

[pve-devel] applied: [PATCH manager] vzdump: also warn when hook script fails for backup-abort or log-end phase

2024-04-23 Thread Thomas Lamprecht
Am 22/01/2024 um 10:55 schrieb Fiona Ebner: > to make it more visible, also in task logs. > > Signed-off-by: Fiona Ebner > --- > PVE/VZDump.pm | 2 ++ > 1 file changed, 2 insertions(+) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH qemu-server] qmeventd: also treat 'prelaunch' and 'suspended' states as active

2024-04-23 Thread Thomas Lamprecht
Am 10/10/2023 um 10:57 schrieb Fiona Ebner: > Otherwise, a VM in those states would be terminated after a backup > in handle_qmp_return() with QMP 'quit', which is pretty bad in case > of the 'suspended' state. > > Does not change the fact that a VM started in prelaunch mode for > backup is

[pve-devel] applied: [RFC PATCH pve-manager 1/2] ui: mobile: fix totp login

2024-04-23 Thread Thomas Lamprecht
Am 14/12/2023 um 10:55 schrieb Dominik Csapak: > logging in with totp on mobile was broken with these two commits: > > pve-manager: > 509d7a20 ("mobile ui: implement dummy message box and scrip loader") > and > pve-access-control: > cb64967 ("api: drop old verify_tfa api call") > > the

[pve-devel] applied: [PATCH proxmox-firewall] firewall: properly cleanup tables when firewall is inactive

2024-04-23 Thread Thomas Lamprecht
Am 23/04/2024 um 11:21 schrieb Stefan Hanreich: > When executing multiple nft commands they are transactional, either > all get applied or none. When only the host or guest firewall is > active, only one table exists and this causes the delete commands to > fail. To fix this we need to send the

[pve-devel] applied: [PATCH common] interfaces: support stanzas without types/methods

2024-04-23 Thread Thomas Lamprecht
Am 23/04/2024 um 15:03 schrieb Wolfgang Bumiller: > This is allowed in ifupdown2 and previously interfaces named > 'vmbr\d+' were recognized as bridges even if they used this mode. > With commit e68ebda4f109 this is no longer the case. > > Fixes: e68ebda4f109 ("fix #545: interfaces: allow

[pve-devel] applied: [PATCH installer] auto-installer: support UTC as timezone

2024-04-23 Thread Thomas Lamprecht
Am 23/04/2024 um 13:29 schrieb Christoph Heiss: > Reported-by: Fiona Ebner > Signed-off-by: Christoph Heiss > --- > proxmox-auto-installer/src/utils.rs | 3 +++ > 1 file changed, 3 insertions(+) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied-series: [PATCH installer 1/2] move secure boot state to RunEnv

2024-04-23 Thread Thomas Lamprecht
Am 23/04/2024 um 14:27 schrieb Fabian Grünbichler: > as preparation for using it in more than one place. > > Signed-off-by: Fabian Grünbichler > --- > Proxmox/Install.pm| 18 +- > Proxmox/Install/RunEnv.pm | 12 +++- > 2 files changed, 16 insertions(+), 14

[pve-devel] applied: [PATCH manager 1/2] ui: backup jobs: fix fleecing parameters for 'run now' button

2024-04-23 Thread Thomas Lamprecht
Am 23/04/2024 um 14:14 schrieb Dominik Csapak: > we have to 'printPropertyString' the fleecing parameters, otherwise > we'll get api parameter errors for that > > Signed-off-by: Dominik Csapak > --- > www/manager6/dc/Backup.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[pve-devel] applied: [PATCH proxmox-i18n] es: update translation

2024-04-23 Thread Thomas Lamprecht
Am 23/04/2024 um 10:13 schrieb Maximiliano Sandoval: > Signed-off-by: Maximiliano Sandoval > --- > es.po | 211 +++--- > 1 file changed, 98 insertions(+), 113 deletions(-) > > applied, thanks! ___

[pve-devel] applied: [PATCH manager] ui: fix reset behavior of backup job editor

2024-04-23 Thread Thomas Lamprecht
Am 23/04/2024 um 09:30 schrieb Dominik Csapak: > when we `bind` we also have to set the initial value correctly, > otherwise the form dirty tracking is off (the initial bind set does not > reset the `originalValue`) > > also the bandwidth selector auto transformed the value `null` to `0` > when

Re: [pve-devel] [PATCH qemu-server v7 2/3] config: QEMU AMD SEV enable

2024-04-23 Thread Thomas Lamprecht
Am 22/04/2024 um 14:16 schrieb Markus Frank: > This patch is for enabling AMD SEV (Secure Encrypted > Virtualization) support in QEMU try to keep a somewhat unified line length over the whole commit message, most editors support re-flowing (parts of the) text to e.g. the for commit messages

[pve-devel] applied: [PATCH proxmox-i18n] update Italian translations

2024-04-23 Thread Thomas Lamprecht
Am 23/04/2024 um 08:29 schrieb Christian Ebner: > Signed-off-by: Christian Ebner > --- > it.po | 118 +++--- > 1 file changed, 39 insertions(+), 79 deletions(-) > > applied, thanks! ___ pve-devel

[pve-devel] applied: [PATCH pve-docs v4 5/5] firewall: add documentation for proxmox-firewall

2024-04-23 Thread Thomas Lamprecht
Am 19/04/2024 um 11:42 schrieb Stefan Hanreich: > Add a section that explains how to use the new nftables-based > proxmox-firewall. > > Signed-off-by: Stefan Hanreich > --- > pve-firewall.adoc | 181 ++ > 1 file changed, 181 insertions(+) > >

Re: [pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu ComboBox

2024-04-22 Thread Thomas Lamprecht
Am 22/04/2024 um 15:24 schrieb Fiona Ebner: > Am 22.04.24 um 15:16 schrieb Dominik Csapak: >> On 4/22/24 15:11, Fiona Ebner wrote: >>> Should we display some hint that Intel can/should also be used even if >>> you have an AMD? Maybe even just in the text we display, like "Intel >>> (also used for

[pve-devel] applied: [PATCH network v2 0/3] Advertise MTU via DHCP / RA

2024-04-22 Thread Thomas Lamprecht
Am 22/04/2024 um 15:15 schrieb Stefan Hanreich: > Changes from v1 -> v2: > * rebased branch, everything else unchanged > > pve-network: > > Stefan Hanreich (3): > dhcp: fix function signatures in abstract class > zones: add method for getting MTU > dhcp: dnsmasq: send mtu option via dhcp >

Re: [pve-devel] [PATCH manager v10 2/2] ui: machine: add link to documentation of the system settings

2024-04-22 Thread Thomas Lamprecht
Am 22/04/2024 um 15:18 schrieb Dominik Csapak: > On 4/22/24 15:13, Fiona Ebner wrote: >> Why not the more accurate 'qm_machine_type' (was introduced in pve-docs = >> 8.1.0)? > > you're right, would be even better (did not realize that existed), i/you can > send/push a follow up? > both of you

[pve-devel] applied: [PATCH pve-network] fix #5343 : isis: fix ipv6 && custom router config

2024-04-22 Thread Thomas Lamprecht
Am 16/04/2024 um 18:52 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > src/PVE/Network/SDN/Controllers/IsisPlugin.pm| 3 ++- > src/test/zones/evpn/isis/expected_controller_config | 2 ++ >

Re: [pve-devel] [PATCH pve-network 0/3] Advertise MTU via DHCP / RA

2024-04-22 Thread Thomas Lamprecht
Am 14/12/2023 um 17:46 schrieb Stefan Hanreich: > Stefan Hanreich (3): > dhcp: fix function signatures in abstract class > zones: add method for getting MTU > dhcp: dnsmasq: send mtu option via dhcp > > src/PVE/Network/SDN/Dhcp.pm | 2 +- >

[pve-devel] applied: [PATCH v2 pve-network] fix #5364: bgp|evpn: derivated router-id from mac address for ipv6 underlay

2024-04-22 Thread Thomas Lamprecht
Am 12/04/2024 um 14:57 schrieb Alexandre Derumier: > for ipv4, we use the iface ipv4 router-id as router-id need to 32bit. > > That's doesn't work for pure ipv6 underlay network. > > since https://www.rfc-editor.org/rfc/rfc6286, we can use any 32bit id, > it's just need to be unique in the ASN.

[pve-devel] applied: [PATCH pve-network] fix #5344: isis: add isis networkid parser

2024-04-22 Thread Thomas Lamprecht
Am 16/04/2024 um 18:24 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > src/PVE/Network/SDN/Controllers/IsisPlugin.pm | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > applied, thanks! this had some slight conflict with the other patches that git

[pve-devel] applied: [PATCH pve-network] fix #5319: frr.local: add support for bgp-community

2024-04-22 Thread Thomas Lamprecht
Am 16/04/2024 um 18:25 schrieb Alexandre Derumier: > Need to be inserted after ip prefix-list and before route map > > Signed-off-by: Alexandre Derumier > --- > src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > applied,

[pve-devel] applied: [PATCH pve-network 1/1] api: sdn: fix missing types for 'pending' fields.

2024-04-22 Thread Thomas Lamprecht
Am 18/04/2024 um 18:44 schrieb Johannes Cornelis Draaijer: > Signed-off-by: Johannes Cornelis Draaijer > --- > src/PVE/API2/Network/SDN/Controllers.pm | 2 +- > src/PVE/API2/Network/SDN/Zones.pm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > applied, thanks!

[pve-devel] applied: [PATCH container/docs/firewall/manager/qemu-server v4 0/5] proxmox firewall nftables

2024-04-22 Thread Thomas Lamprecht
Am 19/04/2024 um 11:42 schrieb Stefan Hanreich: > This patch series contains the remaining patches that are necessary for > proxmox-firewall to work. It adds documentation as well as changes how > firewall-bridges are created when proxmox-firewall is activated. It also > patches > pve-firewall to

[pve-devel] applied: [PATCH manager] acme: ui: handle missing meta field in directory response

2024-04-22 Thread Thomas Lamprecht
Am 22/04/2024 um 11:01 schrieb Folke Gleumes: > When none of the meta fields is set by the directory, the whole > dictionary is missing from the response, leading to an exception > when testing for fields inside it. > > Signed-off-by: Folke Gleumes > --- > www/manager6/node/ACME.js | 9

Re: [pve-devel] [PATCH manager 1/2] ui: form: add DescriptionFieldContainer

2024-04-22 Thread Thomas Lamprecht
Am 22/04/2024 um 09:43 schrieb Dominik Csapak: > this is a field container, showing a field on the left column and a > description on the right one, with a (default) flex ratio of 1:2 > > this is helpful when wanting a longer description on the right column > but still have the fields aligned. >

[pve-devel] applied: [PATCH manager v2 1/2] ui: form: add TwoColumnContainer

2024-04-22 Thread Thomas Lamprecht
Am 22/04/2024 um 10:16 schrieb Dominik Csapak: > this is a container, showing a widget on the left column and another one > on the right one, with a (default) flex ratio of 1:2 > > this is helpful when wanting fields to align vertically in an input > panel that have different height (e.g. because

Re: [pve-devel] [PATCH qemu-server v6 1/3] add C program to get AMD SEV hardware parameters from CPUID

2024-04-22 Thread Thomas Lamprecht
Am 19/04/2024 um 12:59 schrieb Markus Frank > diff --git a/amd-sev-support/amd-sev-support.c > b/amd-sev-support/amd-sev-support.c > new file mode 100644 > index 000..73a7bd8 > --- /dev/null > +++ b/amd-sev-support/amd-sev-support.c > @@ -0,0 +1,48 @@ > +#include > +#include > +#include >

Re: [pve-devel] [PATCH qemu-server v6 1/3] add C program to get AMD SEV hardware parameters from CPUID

2024-04-22 Thread Thomas Lamprecht
Am 19/04/2024 um 12:59 schrieb Markus Frank: > Implement a systemd service that runs a C program that extracts AMD SEV > hardware parameters such as reduced-phys-bios and cbitpos from CPUID at boot > time, looks if SEV, SEV-ES & SEV-SNP are enabled, and outputs these details > as JSON to

[pve-devel] applied-series: [PATCH common/docs/firewall/manager/proxmox-widget-toolkit v4 0/6] drop vmbr prefix for bridges

2024-04-21 Thread Thomas Lamprecht
Am 12/04/2024 um 10:07 schrieb Stefan Hanreich: > Original patch series by Jillian Morgan > > I've refrained from adding arbitrary bond names in this patch series, since > that would require a bigger amount of changes in the firewall simulator. I'll > look into adding that in a future patch

[pve-devel] partially-applied: [PATCH manager v2 1/2] ui: dc: backup: improve UX for the different 'notification-mode's

2024-04-21 Thread Thomas Lamprecht
Am 15/04/2024 um 11:51 schrieb Lukas Wagner: > - Switch order of 'mailto' and 'mailnotification' field > - When mode is 'auto', disable 'mailtnotification' field > - When mode is 'auto' and 'mailto' is empty, show > hint that the notification system will be used If one starts making

Re: [pve-devel] [PATCH manager v3 5/5] fix #4474: ui: guest stop: offer to overrule active shutdown tasks

2024-04-21 Thread Thomas Lamprecht
Am 19/04/2024 um 12:17 schrieb Dominik Csapak: > nit: imho a short high level description why we extend the messagebox instead > of e.g. our edit/safedestroy window would be nice > > also maybe we could rewrite this a bit more generic so that the safedestroy > window users could this instead?

[pve-devel] applied: [PATCH manager v3 5/5] fix #4474: ui: guest stop: offer to overrule active shutdown tasks

2024-04-20 Thread Thomas Lamprecht
Am 12/04/2024 um 16:15 schrieb Friedrich Weber: > Implement a new "guest stop" confirmation message box which first > checks if there is an active shutdown task for the same guest that is > visible to the logged-in user. If there is at least one, the dialog > displays an additional default-on

[pve-devel] applied-series: [PATCH proxmox-firewall 1/2] firewall: wait for nft process

2024-04-19 Thread Thomas Lamprecht
Am 19/04/2024 um 15:00 schrieb Stefan Hanreich: > NftClient never waits for the child process to terminate leading to > defunct leftover processes. > > Signed-off-by: Stefan Hanreich > --- > proxmox-nftables/src/client.rs | 38 -- > 1 file changed, 9

[pve-devel] applied: [PATCH manager] pveversion: fix whitespaces

2024-04-19 Thread Thomas Lamprecht
Am 19/04/2024 um 18:33 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > bin/pveversion | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied-series: [PATCH cluster/manager/storage/docs 0/9] fix #4886: improve SSH handling

2024-04-19 Thread Thomas Lamprecht
Am 11/01/2024 um 11:51 schrieb Fabian Grünbichler: > this series replaces the old mechanism that used a cluster-wide merged known > hosts file with distributing of each node's host key via pmxcfs, and pinning > the distributed key explicitly for internal SSH connections. > > the main changes in

[pve-devel] applied-series: [PATCH qemu-server/container/docs 0/4] overrule-shutdown: documentation fixes

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 15:46 schrieb Friedrich Weber: > All patches are optional: > > - 1/4 fixes spacing and punctuation in the qmshutdown/qmstop descriptions > - 2/4 rewords the overrule-shutdown description for VMs > - 3/4 is the same change for containers > - 4/4 adds a usage example for qm stop

Re: [pve-devel] [PATCH qemu-server v3 35/39] firewall: add handling for new nft firewall

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 18:14 schrieb Stefan Hanreich: > When the nftables firewall is enabled, we do not need to create > firewall bridges. > > Signed-off-by: Stefan Hanreich > --- > vm-network-scripts/pve-bridge | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git

Re: [pve-devel] [PATCH pve-firewall v2 37/39] add configuration option for new nftables firewall

2024-04-18 Thread Thomas Lamprecht
Am 17/04/2024 um 15:54 schrieb Stefan Hanreich: > Introduces new nftables configuration option that en/disables the new > nftables firewall. > > pve-firewall reads this option and only generates iptables rules when > nftables is set to `0`. Conversely proxmox-firewall only generates > nftables

[pve-devel] applied: [PATCH manager 3/7] report: add `apt-cache policy` to list recognized APT sources

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 11:16 schrieb Alexander Zeidler: > with their details as well as pinned packages. Omit the "origin" > lines, as their value is already visible in the URLs. > > # apt-cache policy ... > Package files: > 100 /var/lib/dpkg/status > release a=now > 500

[pve-devel] applied: [PATCH manager] report: fix regex of config filenames

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 09:44 schrieb Alexander Zeidler: > to only match those that are correct/accepted by their software > > Signed-off-by: Alexander Zeidler > --- > PVE/Report.pm | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > applied, thanks!

[pve-devel] applied: [PATCH manager 4/7] report: list held back packages

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 11:16 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > v2: > * newly added > > > PVE/Report.pm | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! ___ pve-devel mailing list

[pve-devel] applied: [PATCH manager 1/7] report: add kernel command line from current boot

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 11:16 schrieb Alexander Zeidler: > to get a first clue for debugging passthrough and similar issues, when > no dmesg output has been provided yet. > > Signed-off-by: Alexander Zeidler > --- > v2: > * move away from dmesg base > * only print kernel command line (boot times can be

[pve-devel] applied: [PATCH manager 2/7] report: create "jobs" section, add `jobs.cfg`

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 11:16 schrieb Alexander Zeidler: > to recognize temporal correlations with network/load/backup/etc issues > > Suggested-by: Friedrich Weber > Signed-off-by: Alexander Zeidler > --- > v2: > * move away from "general" section > > v1:

[pve-devel] applied: [PATCH manager] ui: acl: group selector: allow search

2024-04-18 Thread Thomas Lamprecht
Am 12/04/2024 um 11:16 schrieb Fiona Ebner: > Makes it consistent with the user selector and token selector. > > Requested in the community forum: > https://forum.proxmox.com/threads/144978/ > > Signed-off-by: Fiona Ebner > --- > www/manager6/form/GroupSelector.js | 4 > 1 file changed, 4

[pve-devel] applied: [PATCH qemu] Makefile: drop -j option from dpkg-buildpackage

2024-04-18 Thread Thomas Lamprecht
Am 12/04/2024 um 14:26 schrieb Fiona Ebner: > From man dpkg-buildpackage: > >> -j, --jobs[=jobs|auto] >> Specifies the number of jobs allowed to be run simultaneously (since >> dpkg 1.14.7, long option since dpkg 1.18.8). The number of jobs >> matching the number of online processors if auto is

[pve-devel] applied: [PATCH manager] api: apt versions: track optional amd64/intel-microcode packages

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 09:44 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > PVE/API2/APT.pm | 2 ++ > 1 file changed, 2 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] applied: [PATCH docs] secure boot: mention proxmox-secure-boot-support metapackage

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 16:24 schrieb Stoiko Ivanov: > Signed-off-by: Stoiko Ivanov > --- > Just had the opportunity to try this on a testsystem - it worked flawlessly :) > > I did consider dropping the explicit list of packages and replace it by the > metapackage only, but think that the additional

[pve-devel] partially-applied-series: [PATCH container/docs/firewall/manager/proxmox-firewall/qemu-server v3 00/39] proxmox firewall nftables implementation

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 18:13 schrieb Stefan Hanreich: > proxmox-firewall: > > Stefan Hanreich (34): > config: add proxmox-ve-config crate > config: firewall: add types for ip addresses > config: firewall: add types for ports > config: firewall: add types for log level and rate limit > config:

[pve-devel] applied: [PATCH v3 container] fix #4846: Avoid the outdated noacl mount option on ext4

2024-04-18 Thread Thomas Lamprecht
Am 17/04/2024 um 16:35 schrieb Filip Schauer: > Do not use the 'noacl' mount option when mounting a container disk with > an ext4 file system. The option was removed from the kernel in commit > 2d544ec923db > > Signed-off-by: Filip Schauer > --- > Changes since v3: > * Simplify ext4 detection >

Re: [pve-devel] [PATCH installer v6 36/36] autoinst-helper: add prepare-iso subcommand

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 10:48 schrieb Christoph Heiss: > Do we really need _yet another_ crate dependency for that? Below is a > check / bail! anyway when running the command proper. > > And if we really want a explicit check beforehand, I'd just do something > like > > fn which(name: ) -> Result<()>

[pve-devel] applied: [PATCH http-server v3] http: support Content-Encoding=deflate

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 11:16 schrieb Maximiliano Sandoval: > Add support for compressing the body of responses with > `Content-Encoding: deflate` following [RFC9110]. Note that in this > context `deflate` is actually a "zlib" data format as defined in > [RFC1950]. > > To preserve the current behavior

Re: [pve-devel] [PATCH qemu-server v4 1/2] config: QEMU AMD SEV enable

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 10:25 schrieb Markus Frank: > This patch is for enabling AMD SEV (Secure Encrypted > Virtualization) support in QEMU. > > VM-Config-Examples: > amd_sev: type=std,nodbg=1,noks=1 > amd_sev: es,nodbg=1,kernel-hashes=1 > > Node-Config-Example (gets generated automatically): >

Re: [pve-devel] [PATCH v2 container] fix #4846: Avoid the outdated noacl mount option on ext4

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 10:48 schrieb Fabian Grünbichler: > On April 18, 2024 10:17 am, Thomas Lamprecht wrote: >> Am 11/04/2024 um 15:44 schrieb Fabian Grünbichler: >>> if $storage && $format eq 'raw' => no noacl ? >> >> shouldn't this branch be taken if the for

[pve-devel] applied: [PATCH guest-common] replication: snapshot cleanup: only attempt to remove snapshots that exist

2024-04-18 Thread Thomas Lamprecht
heck. > > The $replicate_snapshots hash is only used for this, so the change > there is fine. > > Fixes: a6f5b35 ("replication: prepare: include volumes without snapshots in > the result") > Reported-by: Thomas Lamprecht > Signed-off-by: Fiona Ebner > --- >

Re: [pve-devel] [PATCH v2 container] fix #4846: Avoid the outdated noacl mount option on ext4

2024-04-18 Thread Thomas Lamprecht
Am 11/04/2024 um 15:44 schrieb Fabian Grünbichler: > if $storage && $format eq 'raw' => no noacl ? shouldn't this branch be taken if the format is _not_ raw, as only in that case it might not use ext4? ___ pve-devel mailing list

Re: [pve-devel] [PATCH storage] plugin: move definition for 'port' option to base plugin

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 09:38 schrieb Fiona Ebner: > I was thinking, users might stumble upon this e.g. with "man pvesm", and > then try it for storages like NFS and wonder why it doesn't work. With > the "options" option we also explicitly mention NFS/CIFS. I'll send a v2 > without mentioning PBS/ESXi

Re: [pve-devel] [PATCH manager] pve7to8: reword and fix typos in description

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 10:03 schrieb Stefan Sterz: >> + before, and during the upgrade of a Proxmox VE system.\n" >> $@.tmp > > i know this is pre-existing, but since you are touching this anyway: the > comma here is odd, if this was supposed to be an oxford comma (or serial > comma), please be

[pve-devel] applied: [PATCH manager v2 0/2] fix #5093 add custom directory and eab to ui

2024-04-17 Thread Thomas Lamprecht
Am 17/04/2024 um 17:55 schrieb Folke Gleumes: > This patch series adds the option to set a custom directory for ACME and > enables the user to use external account binding, which is required by > some providers. > > manager: > > Folke Gleumes (2): > fix #5093: webui: acme: custom directory

[pve-devel] applied: [PATCH manager v3 4/5] ui: fix typo to make pve-cluster-tasks store globally available

2024-04-17 Thread Thomas Lamprecht
Am 12/04/2024 um 16:15 schrieb Friedrich Weber: > This way, it can be used to retrieve the current list of tasks. > > Signed-off-by: Friedrich Weber > --- > > Notes: > changes v2 -> v3: > * no changes > > new in v2: > * moved fix for pve-cluster-tasks store into its own

  1   2   3   4   5   6   7   8   9   10   >