Re: [pve-devel] [PATCH guest-common v2 1/6] guest helpers: add helper to overrule active tasks of a specific type

2024-04-08 Thread Friedrich Weber
On 06/04/2024 10:37, Thomas Lamprecht wrote: >> Still, right now I think the primary motivation for this overruling >> feature is to save GUI users some frustration and/or clicks. In this >> scenario, a user will overrule only their own tasks, which is possible >> with the current check. What do

Re: [pve-devel] [PATCH guest-common v2 1/6] guest helpers: add helper to overrule active tasks of a specific type

2024-04-06 Thread Thomas Lamprecht
Am 05/04/2024 um 15:13 schrieb Friedrich Weber: > On 04/04/2024 17:20, Thomas Lamprecht wrote: >> Or does it even make sense to check this at all? >> As long as the user has the rights to execute a stop they probably >> should also be able to force it at any time, even for other users? > > The

Re: [pve-devel] [PATCH guest-common v2 1/6] guest helpers: add helper to overrule active tasks of a specific type

2024-04-05 Thread Friedrich Weber
Thanks for the review! On 04/04/2024 17:20, Thomas Lamprecht wrote: > Am 30/01/2024 um 18:10 schrieb Friedrich Weber: > > Maybe start of with "Add a helper to abort all tasks from a specific > (type, user, vmid) tuple. It will be used ... Will do. >> This helper is used to abort any active

Re: [pve-devel] [PATCH guest-common v2 1/6] guest helpers: add helper to overrule active tasks of a specific type

2024-04-04 Thread Thomas Lamprecht
Am 30/01/2024 um 18:10 schrieb Friedrich Weber: Maybe start of with "Add a helper to abort all tasks from a specific (type, user, vmid) tuple. It will be used ... > This helper is used to abort any active qmshutdown/vzshutdown tasks > before attempting to stop a VM/CT (if requested). > >

[pve-devel] [PATCH guest-common v2 1/6] guest helpers: add helper to overrule active tasks of a specific type

2024-01-30 Thread Friedrich Weber
This helper is used to abort any active qmshutdown/vzshutdown tasks before attempting to stop a VM/CT (if requested). Signed-off-by: Friedrich Weber --- Notes: no changes v1 -> v2 src/PVE/GuestHelpers.pm | 18 ++ 1 file changed, 18 insertions(+) diff --git