Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-29 Thread Fiona Ebner
Am 29.11.23 um 10:48 schrieb Dietmar Maurer: >>> So what languages are the problem exactly? Please can you >>> give me an example? >> >> Any right-to-left languages could be broken. > > This is not really true. RTL languages just render string in the other > direction, so string concatenation

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-29 Thread Dietmar Maurer
> > So what languages are the problem exactly? Please can you > > give me an example? > > Any right-to-left languages could be broken. This is not really true. RTL languages just render string in the other direction, so string concatenation still works as expected. > > Am 28/11/2023 um 15:46

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-29 Thread Thomas Lamprecht
Am 29/11/2023 um 09:08 schrieb Maximiliano Sandoval: >>> If its only right-to-left languages, we could just add another helper >>> to assemble lists in the correct order? > > The GNOME l10n guidelines at least have an entry about not splitting > strings. > > While it does not apply to this

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-29 Thread Maximiliano Sandoval
> btw. @Maximiliano: "Free" is rather a bad original text for the Noted. Will send a v2 in a bit. >> If its only right-to-left languages, we could just add another helper >> to assemble lists in the correct order? The GNOME l10n guidelines at least have an entry about not splitting strings.

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Thomas Lamprecht
Am 28/11/2023 um 16:29 schrieb Dietmar Maurer: >> I'm taking on a lot of contributions to translations and the common complaint >> I hear is that not all can be translated correctly due to such tricks (or >> just >> missing gettext), most translators care much more about a correct translation >>

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Dietmar Maurer
> I'm taking on a lot of contributions to translations and the common complaint > I hear is that not all can be translated correctly due to such tricks (or just > missing gettext), most translators care much more about a correct translation > than some over-optimized ones than then break depending

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Thomas Lamprecht
Am 28/11/2023 um 15:39 schrieb Dietmar Maurer: > Well, this also duplicates the number of things to translate! I'm taking on a lot of contributions to translations and the common complaint I hear is that not all can be translated correctly due to such tricks (or just missing gettext), most

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Dietmar Maurer
To be more clear, I would use: proxmox.Utils.defaultText + ' (' + gettext('Free') + ')' > On 28.11.2023 15:39 CET Dietmar Maurer wrote: > > > > The string `proxmox.Utils.defaultText + ' (free)'` was inlined as > > `Default (Free)` cutting translatable strings makes them harder or even > >

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Dietmar Maurer
> The string `proxmox.Utils.defaultText + ' (free)'` was inlined as > `Default (Free)` cutting translatable strings makes them harder or even > impossible to translate in certain languages. Well, this also duplicates the number of things to translate! So what languages are the problem exactly?

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > + { flag: 'ssbd', desc: gettext('Protection for "Speculative Store > Bypass" for Intel models') }, > + { flag: 'ibpb', desc: gettext('Allows improved Spectre mitigation > with AMD CPUs') }, > + { flag: 'virt-ssbd', desc: gettext('Basis

[pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-28 Thread Maximiliano Sandoval
The string `proxmox.Utils.defaultText + ' (free)'` was inlined as `Default (Free)` cutting translatable strings makes them harder or even impossible to translate in certain languages. Signed-off-by: Maximiliano Sandoval --- www/manager6/dc/UserTagAccessEdit.js | 10 +-