[pve-devel] [PATCH manager v3 4/5] ui: adapt migration window to precondition api change

[Dominik Csapak]

we now return the 'allowed_nodes'/'not_allowed_nodes' also if the vm is
running, when it has mapped resources. So do that checks independently
so that the user has instant feedback where those resources exist.

Signed-off-by: Dominik Csapak <d.csa...@proxmox.com>
---
 www/manager6/window/Migrate.js | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
index 5473821b..c553a1ee 100644
--- a/www/manager6/window/Migrate.js
+++ b/www/manager6/window/Migrate.js
@@ -104,7 +104,7 @@ Ext.define('PVE.window.Migrate', {
        onTargetChange: function(nodeSelector) {
            // Always display the storages of the currently seleceted migration 
target
            
this.lookup('pveDiskStorageSelector').setNodename(nodeSelector.value);
-           this.checkMigratePreconditions();
+           this.checkMigratePreconditions(true);
        },
 
        startMigration: function() {
@@ -214,12 +214,12 @@ Ext.define('PVE.window.Migrate', {
                migration.possible = true;
            }
            migration.preconditions = [];
+           let target = me.lookup('pveNodeSelector').value;
+           let disallowed = migrateStats.not_allowed_nodes?.[target] ?? {};
 
-           if (migrateStats.allowed_nodes) {
+           if (migrateStats.allowed_nodes && !vm.get('running')) {
                migration.allowedNodes = migrateStats.allowed_nodes;
-               let target = me.lookup('pveNodeSelector').value;
                if (target.length && 
!migrateStats.allowed_nodes.includes(target)) {
-                   let disallowed = migrateStats.not_allowed_nodes[target] ?? 
{};
                    if (disallowed.unavailable_storages !== undefined) {
                        let missingStorages = 
disallowed.unavailable_storages.join(', ');
 
@@ -230,17 +230,17 @@ Ext.define('PVE.window.Migrate', {
                            severity: 'error',
                        });
                    }
+               }
+           }
 
-                   if (disallowed['unavailable-resources'] !== undefined) {
-                       let unavailableResources = 
disallowed['unavailable-resources'].join(', ');
+           if (disallowed['unavailable-resources'] !== undefined) {
+               let unavailableResources = 
disallowed['unavailable-resources'].join(', ');
 
-                       migration.possible = false;
-                       migration.preconditions.push({
-                           text: 'Mapped Resources (' + unavailableResources + 
') not available on selected target. ',
-                           severity: 'error',
-                       });
-                   }
-               }
+               migration.possible = false;
+               migration.preconditions.push({
+                   text: 'Mapped Resources (' + unavailableResources + ') not 
available on selected target. ',
+                   severity: 'error',
+               });
            }
 
            let blockingResources = [];
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel