Re: [pve-devel] [PATCH qemu-server 1/1] fix #5365: drive: add drive_is_cloudinit check to get_scsi_devicetype

2024-04-10 Thread Hannes Dürr
On 4/10/24 11:34, Thomas Lamprecht wrote: This is not bug #5365 [0] (which is about a ceph device class UX improvement) but #5363 [0]. [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5365 [1]: https://bugzilla.proxmox.com/show_bug.cgi?id=5363 Good catch, thank you ! I mostly noticed

Re: [pve-devel] [PATCH qemu-server 1/1] fix #5365: drive: add drive_is_cloudinit check to get_scsi_devicetype

2024-04-10 Thread Thomas Lamprecht
This is not bug #5365 [0] (which is about a ceph device class UX improvement) but #5363 [0]. [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5365 [1]: https://bugzilla.proxmox.com/show_bug.cgi?id=5363 I mostly noticed because I had too loo what this is actually about, IMO the subject could be

[pve-devel] [PATCH qemu-server 1/1] fix #5365: drive: add drive_is_cloudinit check to get_scsi_devicetype

2024-04-09 Thread Hannes Duerr
When we obtain the devicetype, we check whether it is a CD drive. Cloudinit drives are always allocated CD drives, but if the drive has not yet been allocated, the test fails because the cd attribute has not yet been set. We therefore now explicitly check whether it is a cloudinit drive that has