Re: [pve-devel] [PATCH v2 storage] lvm: improve warning in case vgs output contains unexpected lines

2024-02-02 Thread Thomas Lamprecht
Am 01/02/2024 um 10:20 schrieb Fiona Ebner: > Am 31.01.24 um 12:55 schrieb Friedrich Weber: >> >> After changing `warn` to `log_warn` I noticed that pvestatd does not >> write the warning to the syslog every 10s anymore. Turns out `warn` >> triggers a custom __WARN__ handler we install for our

Re: [pve-devel] [PATCH v2 storage] lvm: improve warning in case vgs output contains unexpected lines

2024-02-01 Thread Fiona Ebner
Am 01.02.24 um 10:20 schrieb Fiona Ebner: > Am 31.01.24 um 12:55 schrieb Friedrich Weber: >> >> After changing `warn` to `log_warn` I noticed that pvestatd does not >> write the warning to the syslog every 10s anymore. Turns out `warn` >> triggers a custom __WARN__ handler we install for our

Re: [pve-devel] [PATCH v2 storage] lvm: improve warning in case vgs output contains unexpected lines

2024-02-01 Thread Fiona Ebner
Am 31.01.24 um 12:55 schrieb Friedrich Weber: > > After changing `warn` to `log_warn` I noticed that pvestatd does not > write the warning to the syslog every 10s anymore. Turns out `warn` > triggers a custom __WARN__ handler we install for our daemons which also > writes to syslog (e.g. pvestatd

Re: [pve-devel] [PATCH v2 storage] lvm: improve warning in case vgs output contains unexpected lines

2024-01-31 Thread Friedrich Weber
On 23/01/2024 11:01, Friedrich Weber wrote: > On 19/01/2024 12:31, Fiona Ebner wrote: >> Am 19.01.24 um 11:59 schrieb Fiona Ebner: [...] >>> Please use log_warn() from PVE::RESTEnvironment for new warnings, so >>> they also show up in task logs. >> >> Sorry, I mean "show up more visibly", because

Re: [pve-devel] [PATCH v2 storage] lvm: improve warning in case vgs output contains unexpected lines

2024-01-23 Thread Friedrich Weber
On 19/01/2024 12:31, Fiona Ebner wrote: > Am 19.01.24 um 11:59 schrieb Fiona Ebner: >> Am 18.01.24 um 12:11 schrieb Friedrich Weber: >>> diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm >>> index 4b951e7..5377823 100644 >>> --- a/src/PVE/Storage/LVMPlugin.pm >>> +++

Re: [pve-devel] [PATCH v2 storage] lvm: improve warning in case vgs output contains unexpected lines

2024-01-19 Thread Fiona Ebner
Am 19.01.24 um 11:59 schrieb Fiona Ebner: > Am 18.01.24 um 12:11 schrieb Friedrich Weber: >> diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm >> index 4b951e7..5377823 100644 >> --- a/src/PVE/Storage/LVMPlugin.pm >> +++ b/src/PVE/Storage/LVMPlugin.pm >> @@ -130,6 +130,11 @@

Re: [pve-devel] [PATCH v2 storage] lvm: improve warning in case vgs output contains unexpected lines

2024-01-19 Thread Fiona Ebner
Am 18.01.24 um 12:11 schrieb Friedrich Weber: > diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm > index 4b951e7..5377823 100644 > --- a/src/PVE/Storage/LVMPlugin.pm > +++ b/src/PVE/Storage/LVMPlugin.pm > @@ -130,6 +130,11 @@ sub lvm_vgs { > > my ($name, $size,

[pve-devel] [PATCH v2 storage] lvm: improve warning in case vgs output contains unexpected lines

2024-01-18 Thread Friedrich Weber
If the metadata archive under /etc/lvm/archive for a particular VG has a lot of files or is overly large, `vgs` occasionally prints a message to stdout [1]. Currently, the LVM plugin tries to parse this message and thus produces the following confusing warnings in the output of `pvesm status` or