Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable

2023-12-06 Thread Thomas Lamprecht
Am 06/12/2023 um 15:26 schrieb Dominik Csapak: > honestly i don't want to argue/bikeshed about such a small detail, > but i don't see a good reason to translate names and established > (technical) words. > > I'm ready to change my mind, but i did not see a good example > of when it would be good

Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable

2023-12-06 Thread Dietmar Maurer
> Do note the following examples: > > #: pve-manager/www/manager6/qemu/IPConfigEdit.js:97 > #: pve-manager/www/manager6/qemu/IPConfigEdit.js:155 > msgid "DHCP" > msgstr "بروتوكول التهيئة الآلية للمضيفين (DHCP)" > > #: pve-manager/www/manager6/qemu/IPConfigEdit.js:163 >

Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable

2023-12-06 Thread Dominik Csapak
On 12/6/23 15:04, Maximiliano Sandoval wrote: Dominik Csapak writes: it's more like DHCP, SLAAC or IPv4. those are names of protocols (like ACME) that shouldn't change across translations and we removed those gettexts (mostly) a while ago e.g. see lxc/Network.js in pve-manager: ---8<---

Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable

2023-12-06 Thread Maximiliano Sandoval
Dominik Csapak writes: > it's more like DHCP, SLAAC or IPv4. those are names of protocols (like ACME) > that shouldn't change across translations > > and we removed those gettexts (mostly) a while ago > e.g. see lxc/Network.js in pve-manager: > > ---8<--- > boxLabel: 'DHCP', // do not localize >

Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable

2023-12-06 Thread Dominik Csapak
On 12/6/23 12:20, Fiona Ebner wrote: Am 06.12.23 um 12:00 schrieb Dominik Csapak: On 12/6/23 11:21, Maximiliano Sandoval wrote: Dominik Csapak writes: translating ACME does not make sense to me since it's the name of the protocol and stands for   Automatic Certificate Management

Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable

2023-12-06 Thread Fiona Ebner
Am 06.12.23 um 12:00 schrieb Dominik Csapak: > On 12/6/23 11:21, Maximiliano Sandoval wrote: >> >> Dominik Csapak writes: >> >>> translating ACME does not make sense to me since it's >>> the name of the protocol and stands for >>>   Automatic Certificate Management Environment >>> >>> i don't

Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable

2023-12-06 Thread Dominik Csapak
On 12/6/23 12:13, Maximiliano Sandoval wrote: Dominik Csapak writes: the translator must make sure the terms are consistent anyway... This is the heart of the issue. The translator cannot know there are more uses of the string if it is not marked as translatable. yes he can, because

Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable

2023-12-06 Thread Maximiliano Sandoval
Dominik Csapak writes: > the translator must make sure the terms are consistent anyway... This is the heart of the issue. The translator cannot know there are more uses of the string if it is not marked as translatable. -- Maximiliano ___

Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable

2023-12-06 Thread Dominik Csapak
On 12/6/23 11:21, Maximiliano Sandoval wrote: Dominik Csapak writes: translating ACME does not make sense to me since it's the name of the protocol and stands for Automatic Certificate Management Environment i don't think/believe this should be translated into other languages as a

Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable

2023-12-06 Thread Maximiliano Sandoval
Dominik Csapak writes: > translating ACME does not make sense to me since it's > the name of the protocol and stands for > Automatic Certificate Management Environment > > i don't think/believe this should be translated > into other languages as a standalone word "ACME" appears in four

Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable

2023-12-06 Thread Dominik Csapak
translating ACME does not make sense to me since it's the name of the protocol and stands for Automatic Certificate Management Environment i don't think/believe this should be translated into other languages as a standalone word rest looks fine to me though On 11/29/23 14:21, Maximiliano

[pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable

2023-11-29 Thread Maximiliano Sandoval
Note that ACME is already in 3 translatable strings, a similar remark applies to N/A which is already translated in many languages. Signed-off-by: Maximiliano Sandoval --- src/node/DNSView.js | 2 +- src/panel/ACMEDomains.js | 2 +- src/panel/DiskList.js