Re: [pve-devel] [PATCH widget-toolkit v3] window: edit: avoid sharing custom config objects between subclasses

2024-04-09 Thread Friedrich Weber
On 08/04/2024 14:36, Thomas Lamprecht wrote: > Am 08/04/2024 um 12:36 schrieb Stefan Sterz: >> [...] >> so, this seems like a fix bug a) creates bug b) type of situation... >> this patch means that editing a pool allows changing the name suddenly, >> but since we don't support that in the backend,

Re: [pve-devel] [PATCH widget-toolkit v3] window: edit: avoid sharing custom config objects between subclasses

2024-04-08 Thread Thomas Lamprecht
Am 08/04/2024 um 12:36 schrieb Stefan Sterz: > On Mon Apr 8, 2024 at 11:30 AM CEST, Friedrich Weber wrote: >> +constructor: function(conf) { >> +let me = this; >> +// make copies in order to prevent subclasses from accidentally writing >> +// to objects that are shared with other

Re: [pve-devel] [PATCH widget-toolkit v3] window: edit: avoid sharing custom config objects between subclasses

2024-04-08 Thread Stefan Sterz
On Mon Apr 8, 2024 at 11:30 AM CEST, Friedrich Weber wrote: > Currently, `Proxmox.window.Edit` initializes `extraRequestParams` and > `submitOptions` to two objects that, if not overwritten, are shared > between all instances of subclasses. This bears the danger of > modifying the shared object in

[pve-devel] [PATCH widget-toolkit v3] window: edit: avoid sharing custom config objects between subclasses

2024-04-08 Thread Friedrich Weber
Currently, `Proxmox.window.Edit` initializes `extraRequestParams` and `submitOptions` to two objects that, if not overwritten, are shared between all instances of subclasses. This bears the danger of modifying the shared object in a subclass instead of overwriting it, which affects all edit