[issue14322] More test coverage for hmac

Change by Emmanuel Arias : -- nosy: +eamanu ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14322] More test coverage for hmac

Arjun added the comment: would the update invalid test belong in the TestVectorsTestCase class or should I make a new one? -- ___ Python tracker ___

[issue14322] More test coverage for hmac

Change by Arjun : -- pull_requests: +25222 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/26636 ___ Python tracker ___

[issue14322] More test coverage for hmac

Arjun added the comment: The only things I think we should add to the current hmac tests are test_update_error_handling and test_with_invalid_msg. For test_withnoncallable_digestmod(), hmac itself seems it can no longer be used: >>> hmac.HMAC(b"", None, "hmac") using new Traceback

[issue14322] More test coverage for hmac

Change by Irit Katriel : -- keywords: +easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14322] More test coverage for hmac

Irit Katriel added the comment: The patch is out of date and needs to be refreshed. -- components: +Library (Lib) nosy: +iritkatriel stage: patch review -> needs patch versions: +Python 3.10, Python 3.8, Python 3.9 -Python 2.7, Python 3.2, Python 3.3, Python 3.4

[issue14322] More test coverage for hmac

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14322] More test coverage for hmac

Mark Lawrence added the comment: If there isn't a signed contributor agreement I'll put up a new version of the patch. In msg156758 Antoine said 'don't use except: self.fail(), just let the exception pass through'. There are several of these in the existing code. Should they all be removed

[issue14322] More test coverage for hmac

Christian Heimes added the comment: IIRC we also need a signed contributor agreement in order to commit your patch. -- nosy: +christian.heimes versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14322

[issue14322] More test coverage for hmac

Changes by Vijay Majagaonkar vijay.majagaon...@gmail.com: -- nosy: +Vijay.Majagaonkar ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14322 ___ ___

[issue14322] More test coverage for hmac

Antoine Pitrou pit...@free.fr added the comment: Some style comments: - don't use except: self.fail(), just let the exception pass through - when monkeypatching hmac.new, use a try...finally block so that the mock doesn't stay in place if the test fails for whatever reason - it's a bit of a

[issue14322] More test coverage for hmac

Éric Araujo mer...@netwok.org added the comment: Thanks for the patch. Could you rewrite it using self.assert* methods instead of asserts? I’m not an hmac expert, so you may have to wait a bit for another core developer to see and commit the patch. -- nosy: +eric.araujo title: More

[issue14322] More test coverage for hmac

Brian Landers br...@packetslave.com added the comment: Updated to use the correct assert* methods. -- Added file: http://bugs.python.org/file24896/test_hmac.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14322