[issue29860] smtplib.py doesn't capitalize EHLO.

Irit Katriel added the comment: It's been 5 years, it's not really a bug, and nobody seems to be interested enough to submit a patch so I'm closing this. Feel free to reopen if you want to pursue this. -- nosy: +iritkatriel resolution: -> not a bug stage: -> resolved status: open

[issue29860] smtplib.py doesn't capitalize EHLO.

Change by Rahul Kumaresan : -- nosy: +rahul-kumi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29860] smtplib.py doesn't capitalize EHLO.

Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker ___ ___

[issue29860] smtplib.py doesn't capitalize EHLO.

Barry A. Warsaw added the comment: Is EHLO the only command sent in lower case? I think it might not be. I suppose I'm a solid ±0 on changing this (how's that for a completely neutral endorsement?). I won't do the change myself, but I'd review a pull request. --

[issue29860] smtplib.py doesn't capitalize EHLO.

R. David Murray added the comment: On the other hand, the current mixed case sending found a bug in your code, so it has some value. I'm neither in favor nor in objection to the change, at this point. -- ___ Python tracker

[issue29860] smtplib.py doesn't capitalize EHLO.

Lord Anton Hvornum added the comment: Seeing as I'm the one who built the server, it sure is out of spec :) I could also quickly correct for this "issue" server-side. So this is more of a "style guideline" change client-side - If no one opposes of keeping commands stylistically the same.

[issue29860] smtplib.py doesn't capitalize EHLO.

R. David Murray added the comment: It is interesting that in all the years smtplib has been in use, this is the first time (as far as I know) this has been reported as a problem. I don't see any reason to object to changing it to send the commands in upper case, but the server you are

[issue29860] smtplib.py doesn't capitalize EHLO.

Lord Anton Hvornum added the comment: Turns out, this goes for a lot more commands, such as: ``` Traceback (most recent call last): File "mail.py", line 12, in smtp_server.sendmail(fromaddr, toaddrs, msg) File "/usr/lib/python3.6/smtplib.py", line 866, in sendmail raise

[issue29860] smtplib.py doesn't capitalize EHLO.

New submission from Lord Anton Hvornum: ``` File "mail.py", line 9, in smtp_server.starttls(context) File "/usr/lib/python3.6/smtplib.py", line 748, in starttls self.ehlo_or_helo_if_needed() File "/usr/lib/python3.6/smtplib.py", line 600, in ehlo_or_helo_if_needed (code, resp)