[issue31718] some methods of uninitialized io.IncrementalNewlineDecoder objects raise SystemError

Change by Zackery Spytz : -- nosy: +ZackerySpytz nosy_count: 5.0 -> 6.0 pull_requests: +18006 pull_request: https://github.com/python/cpython/pull/18640 ___ Python tracker ___

[issue31718] some methods of uninitialized io.IncrementalNewlineDecoder objects raise SystemError

Cheryl Sabella added the comment: The patch for this issue had some outstanding questions/changes to be made before being merged, but now a new PR needs to be opened to replace the original one. Anyone who is interested can pick this up, but please only open one PR for this and please also

[issue31718] some methods of uninitialized io.IncrementalNewlineDecoder objects raise SystemError

Change by Serhiy Storchaka : -- nosy: +benjamin.peterson, stutzbach versions: +Python 2.7, Python 3.6 ___ Python tracker

[issue31718] some methods of uninitialized io.IncrementalNewlineDecoder objects raise SystemError

Oren Milman added the comment: With regard to refleaks in __init__() methods, i started looking for similar refleaks in the codebase, and hope to open an issue to fix them soon. -- ___ Python tracker

[issue31718] some methods of uninitialized io.IncrementalNewlineDecoder objects raise SystemError

Change by Oren Milman : -- keywords: +patch pull_requests: +3886 stage: -> patch review ___ Python tracker ___

[issue31718] some methods of uninitialized io.IncrementalNewlineDecoder objects raise SystemError

Serhiy Storchaka added the comment: There is other issues with IncrementalNewlineDecoder.__init__ -- it leaks references when called repeatedly. The simplest solution of both issues will be moving the initialization to the new method. But this class looks

[issue31718] some methods of uninitialized io.IncrementalNewlineDecoder objects raise SystemError

Oren Milman added the comment: Yes, although i don't know if there are usecases for that. -- ___ Python tracker ___

[issue31718] some methods of uninitialized io.IncrementalNewlineDecoder objects raise SystemError

Serhiy Storchaka added the comment: Is IncrementalNewlineDecoder subclassable? -- nosy: +serhiy.storchaka ___ Python tracker

[issue31718] some methods of uninitialized io.IncrementalNewlineDecoder objects raise SystemError

New submission from Oren Milman : Given an uninitialized IncrementalNewlineDecoder: uninitialized = io.IncrementalNewlineDecoder.__new__(io.IncrementalNewlineDecoder) each of the following calls would raise a SystemError ('null argument to internal routine'):