[issue34463] Discrepancy between traceback.print_exception and sys.__excepthook__

Change by Irit Katriel : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue34463] Discrepancy between traceback.print_exception and sys.__excepthook__

Łukasz Langa added the comment: New changeset 727bed675f1a47d12492efba0ca118707502d988 by Irit Katriel in branch '3.8': [3.8] bpo-34463: Make python tracebacks identical to C tracebacks for (#23899) https://github.com/python/cpython/commit/727bed675f1a47d12492efba0ca118707502d988 --

[issue34463] Discrepancy between traceback.print_exception and sys.__excepthook__

Change by Irit Katriel : -- pull_requests: +22754 pull_request: https://github.com/python/cpython/pull/23899 ___ Python tracker ___

[issue34463] Discrepancy between traceback.print_exception and sys.__excepthook__

miss-islington added the comment: New changeset 8e5c61a075f3a60272a7dcdc48db200090d76309 by Miss Islington (bot) in branch '3.9': bpo-34463: Make python tracebacks identical to C tracebacks for SyntaxErrors without a lineno (GH-23427)

[issue34463] Discrepancy between traceback.print_exception and sys.__excepthook__

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +22750 pull_request: https://github.com/python/cpython/pull/23895 ___ Python tracker

[issue34463] Discrepancy between traceback.print_exception and sys.__excepthook__

Tal Einat added the comment: New changeset 069560b1171eb6385121ff3b6331e8814a4e7454 by Irit Katriel in branch 'master': bpo-34463: Make python tracebacks identical to C tracebacks for SyntaxErrors without a lineno (GH-23427)

[issue34463] Discrepancy between traceback.print_exception and sys.__excepthook__

Change by Irit Katriel : -- keywords: +patch pull_requests: +22318 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23427 ___ Python tracker ___

[issue34463] Discrepancy between traceback.print_exception and sys.__excepthook__

Irit Katriel added the comment: After debugging the default excepthook code (C version), I see that the difference is because the SyntaxError's lineno is None. It doesn't mind that the filename is None (it defaults it to ) but when it can't get the lineno it gives up here:

[issue34463] Discrepancy between traceback.print_exception and sys.__excepthook__

Irit Katriel added the comment: Reproduced on 3.10: Running Release|Win32 interpreter... Python 3.10.0a1+ (heads/exceptionGroup-stage1-dirty:928c211ad8, Oct 28 2020, 14:36:37) [MSC v.1916 32 bit (Intel)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>>

[issue34463] Discrepancy between traceback.print_exception and sys.__excepthook__

New submission from Timothy McCurrach : If you have set sys.excepthook to some function which calls traceback.print_exception, then I would expect to get identical traceback/exception messages. If you run raise SyntaxError("some message"), then print_exception has the extra line `File "",