[issue42620] documentation on `getsockname()` wrong for AF_INET6

2020-12-22 Thread miss-islington
miss-islington added the comment: New changeset 7fe7d83c26b02c8a65c8a9633cc4251f5cd97ebf by Miss Islington (bot) in branch '3.9': bpo-42620: Improve socket.getsockname doc string (GH-23742) https://github.com/python/cpython/commit/7fe7d83c26b02c8a65c8a9633cc4251f5cd97ebf --

[issue42620] documentation on `getsockname()` wrong for AF_INET6

2020-12-22 Thread miss-islington
miss-islington added the comment: New changeset b20494618c6ac6ebcd354e0b16a6645fe47acbee by Miss Islington (bot) in branch '3.8': bpo-42620: Improve socket.getsockname doc string (GH-23742) https://github.com/python/cpython/commit/b20494618c6ac6ebcd354e0b16a6645fe47acbee --

[issue42620] documentation on `getsockname()` wrong for AF_INET6

2020-12-22 Thread miss-islington
Change by miss-islington : -- pull_requests: +22760 pull_request: https://github.com/python/cpython/pull/23907 ___ Python tracker ___

[issue42620] documentation on `getsockname()` wrong for AF_INET6

2020-12-22 Thread miss-islington
Change by miss-islington : -- pull_requests: +22759 pull_request: https://github.com/python/cpython/pull/23906 ___ Python tracker ___

[issue42620] documentation on `getsockname()` wrong for AF_INET6

2020-12-22 Thread miss-islington
miss-islington added the comment: New changeset cf3565ca9a7ed0f7decd000e41fa3de400986e4d by Christian Heimes in branch 'master': bpo-42620: Improve socket.getsockname doc string (GH-23742) https://github.com/python/cpython/commit/cf3565ca9a7ed0f7decd000e41fa3de400986e4d -- nosy:

[issue42620] documentation on `getsockname()` wrong for AF_INET6

2020-12-11 Thread Rick van Rein
Rick van Rein added the comment: Excellent, thanks. I personally would appreciate if a remark about IPv6 would also be made. -- ___ Python tracker ___

[issue42620] documentation on `getsockname()` wrong for AF_INET6

2020-12-11 Thread Christian Heimes
Christian Heimes added the comment: Good point. The address info depends on the address family, https://docs.python.org/3/library/socket.html#socket-families . I have updated the doc string: >>> import socket >>> print(socket.socket.getsockname.__doc__) getsockname() -> address info Return

[issue42620] documentation on `getsockname()` wrong for AF_INET6

2020-12-11 Thread Christian Heimes
Change by Christian Heimes : -- keywords: +patch nosy: +christian.heimes nosy_count: 1.0 -> 2.0 pull_requests: +22600 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23742 ___ Python tracker

[issue42620] documentation on `getsockname()` wrong for AF_INET6

2020-12-11 Thread Rick van Rein
New submission from Rick van Rein : Shown in the session below is unexpected output of a 4-tuple from an AF_INET6 socket along with documentation that *suggests* to expect a 2-tuple. The phrasing "IP" might have to be toned down to "IPv4" or "AF_INET" to be accurate enough to avoid