[issue8677] Modules needing PY_SSIZE_T_CLEAN

Serhiy Storchaka added the comment: Thank you for doing this Inada-san! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue8677] Modules needing PY_SSIZE_T_CLEAN

STINNER Victor added the comment: > Let's close this long living issue. Thanks INADA-san for fixing last issues and for creating the deprecation issue! -- ___ Python tracker

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Inada Naoki added the comment: > Would it be possible to emit a deprecation warning, maybe at runtime, when > PY_SSIZE_T_CLEAN is not defined? I created bpo-36381 for it. Let's close this long living issue. -- resolution: -> fixed stage: patch review -> resolved status: open ->

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Change by Inada Naoki : -- pull_requests: +12425 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Inada Naoki added the comment: New changeset cc60cdd9c44dd15e441603ee5f78e09ea3e76929 by Inada Naoki in branch 'master': bpo-8677: use PY_DWORD_MAX instead of INT_MAX (GH-12469) https://github.com/python/cpython/commit/cc60cdd9c44dd15e441603ee5f78e09ea3e76929 --

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Change by Inada Naoki : -- pull_requests: +12421 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8677] Modules needing PY_SSIZE_T_CLEAN

STINNER Victor added the comment: PC/winreg.c: if (value_length >= INT_MAX) { PyErr_SetString(PyExc_OverflowError, "the value is too long"); return NULL; } PY_DWORD_MAX should be used here. It's twice larger than INT_MAX ;-) --

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Inada Naoki added the comment: New changeset d5f18a63cc2dfe8d0adec8bce384a8c569b0f3dc by Inada Naoki in branch 'master': bpo-8677: use PY_SSIZE_T_CLEAN in PC/winreg.c (GH-12466) https://github.com/python/cpython/commit/d5f18a63cc2dfe8d0adec8bce384a8c569b0f3dc --

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Inada Naoki added the comment: New changeset e9a1dcb4237cb2be71ab05883d472038ea9caf62 by Inada Naoki in branch 'master': bpo-8677: use PY_SSIZE_T_CLEAN in socketmodule.c (GH-12467) https://github.com/python/cpython/commit/e9a1dcb4237cb2be71ab05883d472038ea9caf62 --

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Inada Naoki added the comment: New changeset c5a216e0b97712bf19b4a6b7655c6bf22a367edd by Inada Naoki in branch 'master': bpo-8677: use PY_SSIZE_T_CLEAN in Modules/_gdbmodule.c (GH-12464) https://github.com/python/cpython/commit/c5a216e0b97712bf19b4a6b7655c6bf22a367edd --

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Change by Inada Naoki : -- pull_requests: +12419 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Change by Inada Naoki : -- pull_requests: +12418 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Inada Naoki added the comment: > Also PC/winreg.c. In this case winreg.SetValue() needs a length of size DWORD > instead of ssize_t. As MSDN, cbData is ignored. https://docs.microsoft.com/en-us/windows/desktop/api/winreg/nf-winreg-regsetvaluew Can I skip overflow check? If I can not, what

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Change by Inada Naoki : -- pull_requests: +12416 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8677] Modules needing PY_SSIZE_T_CLEAN

STINNER Victor added the comment: Would it be possible to emit a deprecation warning, maybe at runtime, when PY_SSIZE_T_CLEAN is not defined? -- ___ Python tracker ___

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Serhiy Storchaka added the comment: Also PC/winreg.c. In this case winreg.SetValue() needs a length of size DWORD instead of ssize_t. -- nosy: +serhiy.storchaka ___ Python tracker

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Inada Naoki added the comment: Modules/_gdbmmodule.c Modules/socketmodule.c They use '#' without PY_SSIZE_T_CLEAN yet. -- versions: +Python 3.8 -Python 3.2 ___ Python tracker

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Inada Naoki added the comment: New changeset 29198ea1c6d58f87389136b0ac0b8b2318dbac24 by Inada Naoki in branch 'master': bpo-8677: use PY_SSIZE_T_CLEAN in sqlite (GH-12434) https://github.com/python/cpython/commit/29198ea1c6d58f87389136b0ac0b8b2318dbac24 -- nosy: +inada.naoki

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Change by Inada Naoki : -- pull_requests: +12389 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Roundup Robot added the comment: New changeset 691ca1694fe7 by Victor Stinner in branch '3.4': Issue #8677: make the zlib module ssize_t clean for parsing parameters http://hg.python.org/cpython/rev/691ca1694fe7 New changeset 45dcdd8f3211 by Victor Stinner in branch 'default': (Merge 3.4) Issue

[issue8677] Modules needing PY_SSIZE_T_CLEAN

STINNER Victor added the comment: zlibmodule_ssize_t_clean.patch: Patch to make the zlib module ssize_t clean. The patch just defines PY_SSIZE_T_CLEAN, no # format is used. ./python -m test -v test_zlib test pass on my 64-bit Linux. -- keywords: +patch nosy: +haypo Added file:

[issue8677] Modules needing PY_SSIZE_T_CLEAN

STINNER Victor added the comment: I just created the issue #21780 to make the unicodedata module 64-bit safe. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8677 ___

[issue8677] Modules needing PY_SSIZE_T_CLEAN

STINNER Victor added the comment: I created the issue #21781 to make the _ssl module 64-bit clean. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8677 ___

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Mark Lawrence added the comment: Given the rise of the 64 bit machine I'd guess that this needs completing sooner rather than later. I'd volunteer myself but I've never heard of the '#' format codes, let alone know anything about them :-( -- nosy: +BreamoreBoy

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Terry J. Reedy tjre...@udel.edu added the comment: Mark just fixed audioop in #8675 -- nosy: +tjreedy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8677 ___

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Mark Dickinson dicki...@gmail.com added the comment: And the curses module was made PY_SSIZE_T_CLEAN in r81085 (a very simple change). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8677

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Terry J. Reedy tjre...@udel.edu added the comment: Is there any reason why you reported zlibmodule.c separately in #8650 (other than maybe finding that first), and for 4 versions there versus 1 here? Should this supersede that? -- ___ Python

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Antoine Pitrou pit...@free.fr added the comment: Is there any reason why you reported zlibmodule.c separately in #8650 (other than maybe finding that first), Because zlibmodule.c has more 64-bitness issues than just PY_SSIZE_T_CLEAN (see bug description). Should this supersede that? No.

[issue8677] Modules needing PY_SSIZE_T_CLEAN

New submission from Antoine Pitrou pit...@free.fr: This is a list of extension modules making use of one of the # format codes (s#, y#, etc.) without defining PY_SSIZE_T_CLEAN, and therefore being 64-bit unclean: Modules/audioop.c Modules/_cursesmodule.c Modules/_elementtree.c

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Changes by Antoine Pitrou pit...@free.fr: -- dependencies: +audioop module needs an int - Py_ssize_t upgrade nosy: +mark.dickinson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8677 ___

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Antoine Pitrou pit...@free.fr added the comment: The documentation says that sometimes in the future Py_ssize_t will be the default, so we may also need some kind of transition period for non-complying third-party extensions; first with warnings and then with errors perhaps. -- nosy:

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Martin v. Löwis mar...@v.loewis.de added the comment: I personally don't think that a transition period would be a useful thing to have, in particular not if it goes like this: - in version A, require use of PY_SSIZE_T_CLEAN - in version A+1, make use of PY_SSIZE_T_CLEAN redundant So I'd

[issue8677] Modules needing PY_SSIZE_T_CLEAN

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8677 ___