[Python-Dev] Re: Requesting PR review on locale module

2019-11-17 Thread Stéphane Wirtel
Hi Cedric, It’s my fault, I am going to check your PR for this week. I am really sorry because I am busy with the preparation of my black belt in Karate and I have a training every day. Have a nice day, Stéphane > Le 17 nov. 2019 à 14:06, Tal Einat a écrit : > >  > Hi Cédric, > >

[Python-Dev] thes mapping data type and thescfg cfg file module - review and suggestion request

2019-11-17 Thread Dave Cinege
If you are not aware: - Thesaurus is a mapping data type with recursive keypath map and attribute aliasing. It is a subclass of dict() and is mostly compatible as a general use dictionary replacement. - ThesaurusExtended is a subclass of Thesaurus providing additional usability methods such

[Python-Dev] Re: Pass the Python thread state to internal C functions

2019-11-17 Thread Nathaniel Smith
On Sun, Nov 17, 2019 at 1:58 PM Nick Coghlan wrote: > On Sat., 16 Nov. 2019, 8:26 am Nathaniel Smith, wrote: >> >> As you know, I'm skeptical that PEP 554 will produce benefits that are >> worth the effort, but let's assume for the moment that it is, and >> we're all 100% committed to moving all

[Python-Dev] Re: Implementation of PEP-0604

2019-11-17 Thread Nick Coghlan
On Mon., 18 Nov. 2019, 6:52 am MRAB, wrote: > On 2019-11-17 20:09, Ivan Levkivskyi wrote: > > To add some more input about forward references, here are couple of > > thoughts: > > > > 1. I think ideally we should support forward references to the same > > extent they are currently supported: > >

[Python-Dev] Re: Pass the Python thread state to internal C functions

2019-11-17 Thread Nick Coghlan
On Sat., 16 Nov. 2019, 8:26 am Nathaniel Smith, wrote: > As you know, I'm skeptical that PEP 554 will produce benefits that are > worth the effort, but let's assume for the moment that it is, and > we're all 100% committed to moving all globals into the threadstate. > Even given that, the

[Python-Dev] Re: Implementation of PEP-0604

2019-11-17 Thread MRAB
On 2019-11-17 20:09, Ivan Levkivskyi wrote: To add some more input about forward references, here are couple of thoughts: 1. I think ideally we should support forward references to the same extent they are currently supported: i.e. Union[None, "ForwardRef"], Union["OtherForwardRef", None],

[Python-Dev] Re: Implementation of PEP-0604

2019-11-17 Thread Ivan Levkivskyi
To add some more input about forward references, here are couple of thoughts: 1. I think ideally we should support forward references to the same extent they are currently supported: i.e. Union[None, "ForwardRef"], Union["OtherForwardRef", None], and Union["ForwardRef", "OtherForwardRef"] should

[Python-Dev] Re: Requesting PR review on locale module

2019-11-17 Thread Tal Einat
Hi Cédric, Thanks for writing and sorry that you've experienced such a delay. Such occurrences are unfortunately rather common right now, though we're working on improving the situation. Stéphane Wirtel self-assigned that PR to himself a couple of months ago, but indeed hasn't followed it up

[Python-Dev] Requesting PR review on locale module

2019-11-17 Thread Cédric Krier via Python-Dev
Hi, Few months ago, I submitted a PR [1] for the bpo [2] about locale.format casting Decimal into float. Has someone some times to finish the review? This change is blocking a bugfix on Tryton [3]. [1] https://github.com/python/cpython/pull/15275 [2] https://bugs.python.org/issue34311 [3]