Re: [Python-Dev] Does Python/Python-ast.c need to be checked in?

2007-02-12 Thread Martin v. Löwis
Martin v. Löwis schrieb: Guido van Rossum schrieb: Is this documented somewhere? It wouldn't hurt if there was a pointer to that documentation right next to the line in Python-ast.c that gets modified by the regeneration. (I've been wondering about this a few times myself.) Done! I didn't

[Python-Dev] Does Python/Python-ast.c need to be checked in?

2007-02-11 Thread skip
Someone checked in Parser/Python.asdl. After rebuilding Subversion tells me that Python/Python-ast.c has been modified. I assume the two are related. Did whoever checked in the former need to check in the latter (and maybe add a note to Misc/NEWS)? Skip

Re: [Python-Dev] Does Python/Python-ast.c need to be checked in?

2007-02-11 Thread Brett Cannon
On 2/11/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Someone checked in Parser/Python.asdl. After rebuilding Subversion tells me that Python/Python-ast.c has been modified. I assume the two are related. Did whoever checked in the former need to check in the latter Yeah, sorry about that.

Re: [Python-Dev] Does Python/Python-ast.c need to be checked in?

2007-02-11 Thread Martin v. Löwis
Brett Cannon schrieb: On 2/11/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Someone checked in Parser/Python.asdl. After rebuilding Subversion tells me that Python/Python-ast.c has been modified. I assume the two are related. Did whoever checked in the former need to check in the latter

Re: [Python-Dev] Does Python/Python-ast.c need to be checked in?

2007-02-11 Thread Guido van Rossum
On 2/11/07, Martin v. Löwis [EMAIL PROTECTED] wrote: Actually, the regenerating should happen immediately after commit, as this bumps the revision number of the asdl file. This means you have to make two commits per AST grammar change: one to change the grammar, and the other to update the

Re: [Python-Dev] Does Python/Python-ast.c need to be checked in?

2007-02-11 Thread Anthony Baxter
On Monday 12 February 2007 13:57, Brett Cannon wrote: On 2/11/07, Guido van Rossum [EMAIL PROTECTED] wrote: On 2/11/07, Martin v. Löwis [EMAIL PROTECTED] wrote: Actually, the regenerating should happen immediately after commit, as this bumps the revision number of the asdl file. This

Re: [Python-Dev] Does Python/Python-ast.c need to be checked in?

2007-02-11 Thread Martin v. Löwis
Guido van Rossum schrieb: Is this documented somewhere? It wouldn't hurt if there was a pointer to that documentation right next to the line in Python-ast.c that gets modified by the regeneration. (I've been wondering about this a few times myself.) Done! Martin

Re: [Python-Dev] Does Python/Python-ast.c need to be checked in?

2007-02-11 Thread Martin v. Löwis
Brett Cannon schrieb: /* File automatically generated by %s. This module must be committed separately from each AST grammar change; the __version__ number is set to the revision number of the commit containing the grammar change. */ It doesn't completely show up in svn diff (when

Re: [Python-Dev] Does Python/Python-ast.c need to be checked in?

2007-02-11 Thread Martin v. Löwis
Anthony Baxter schrieb: This module must be committed separately from each AST grammar change; the __version__ number is set to the revision number of the commit containing the grammar change. */ Note that the welease.py script that builds the releases does a touch on the relevant