[Python-Dev] Re: Changing exception text in micro releases

2021-09-25 Thread Serhiy Storchaka
24.09.21 16:51, Eric V. Smith пише: > This is clearly an improvement. My question is: is it okay to backport > this to 3.9 and 3.10? I think we have a rule that it's okay to change > the exception text, but I'm not sure how that applies to micro releases > (3.9.x, 3.10.1). I am sure that it will

[Python-Dev] Re: Changing exception text in micro releases

2021-09-24 Thread Eric V. Smith
On 9/24/2021 4:53 PM, Guido van Rossum wrote: In this case I am inclined not to backport. I agree. I decided not to backport it. In general we should look at existing usage before making changes. Somebody’s code might break — but does it matter? That depends on a lot of factors. E.g. if

[Python-Dev] Re: Changing exception text in micro releases

2021-09-24 Thread Guido van Rossum
In this case I am inclined not to backport. In general we should look at existing usage before making changes. Somebody’s code might break — but does it matter? That depends on a lot of factors. E.g. if parsing an error message has become a common way to get useful info out of the error that is

[Python-Dev] Re: Changing exception text in micro releases

2021-09-24 Thread Terry Reedy
On 9/24/2021 10:46 AM, Eric V. Smith wrote: On 9/24/2021 10:39 AM, Ethan Furman wrote: On 9/24/21 6:51 AM, Eric V. Smith wrote: > This is clearly an improvement. My question is: is it okay to backport this to 3.9 and 3.10? I > think we have a rule that it's okay to change the exception text,

[Python-Dev] Re: Changing exception text in micro releases

2021-09-24 Thread Eric V. Smith
On 9/24/2021 10:39 AM, Ethan Furman wrote: On 9/24/21 6:51 AM, Eric V. Smith wrote: > This is clearly an improvement. My question is: is it okay to backport this to 3.9 and 3.10? I > think we have a rule that it's okay to change the exception text, but I'm not sure how that > applies to

[Python-Dev] Re: Changing exception text in micro releases

2021-09-24 Thread Ethan Furman
On 9/24/21 6:51 AM, Eric V. Smith wrote: > This is clearly an improvement. My question is: is it okay to backport this to 3.9 and 3.10? I > think we have a rule that it's okay to change the exception text, but I'm not sure how that > applies to micro releases (3.9.x, 3.10.1). "better" !=

[Python-Dev] Re: Changing exception text in micro releases

2021-09-24 Thread Filipe Laíns
On Fri, 2021-09-24 at 09:51 -0400, Eric V. Smith wrote: > This PR https://github.com/python/cpython/pull/28310 changes the message > for some exceptions. > > Currently: > >  >>> format('', '%M') > Traceback (most recent call last): >    File "", line 1, in > ValueError: Invalid format