[Python-Dev] Re: Procedure for trivial PRs

2020-08-13 Thread Stephen J. Turnbull
Jeff Allen writes: > It will seem odd that I should know or care about this, not having > any relevant rights over CPython, but I'm trying to adopt it in the > projects where I do. But you do have a relevant right: to state your opinion about the governance of the project, both the values and

[Python-Dev] Re: Procedure for trivial PRs

2020-08-13 Thread Jeff Allen
On 13/08/2020 21:32, Facundo Batista wrote: El jue., 13 de ago. de 2020 a la(s) 16:55, Mariatta (maria...@python.org) escribió: On Thu, Aug 13, 2020 at 12:51 PM Facundo Batista wrote: It's waiting for a "core review", which is a good thing (and by all means welcomed). But as we're saturated

[Python-Dev] Re: Procedure for trivial PRs

2020-08-13 Thread Facundo Batista
El jue., 13 de ago. de 2020 a la(s) 18:42, Terry Reedy (tjre...@udel.edu) escribió: > The backport bot occasionally fails, sometimes for external reasons. If > you hit a problem, you can ask me for help as I have probably hit all > the failure modes by now. Thanks! One of the backport failed so

[Python-Dev] Re: Procedure for trivial PRs

2020-08-13 Thread Terry Reedy
On 8/13/2020 4:56 PM, Mariatta wrote:  when landed remove the "need backport tags" you added... If done correctly, the "needs backport .." labels got removed automatically. We have detailed info here: https://devguide.python.org/committing/#backporting-changes-to-an-older-version

[Python-Dev] Re: Procedure for trivial PRs

2020-08-13 Thread Steve Dower
On 8/13/2020 9:56 PM, Mariatta wrote:  a) is it ok to touch 3.9, as it's in rc1? Yeah bug fixes are accepted to the maintenance branches. I think your PR does count as documentation bug fix, so it should be ok to backport to 3.9 At this stage, changes to the 3.9 branch won't go into

[Python-Dev] Re: Procedure for trivial PRs

2020-08-13 Thread Mariatta
> > when landed remove the > "need backport tags" you added... If done correctly, the "needs backport .." labels got removed automatically. We have detailed info here: https://devguide.python.org/committing/#backporting-changes-to-an-older-version a) is it ok to touch 3.9, as it's in rc1?

[Python-Dev] Re: Procedure for trivial PRs

2020-08-13 Thread Facundo Batista
El jue., 13 de ago. de 2020 a la(s) 17:41, Facundo Batista (facundobati...@gmail.com) escribió: > > El jue., 13 de ago. de 2020 a la(s) 17:32, Facundo Batista > (facundobati...@gmail.com) escribió: > > > >> > > > > > > As a core dev you can still merge it yourself without needing to wait for > >

[Python-Dev] Re: Procedure for trivial PRs

2020-08-13 Thread Facundo Batista
El jue., 13 de ago. de 2020 a la(s) 17:32, Facundo Batista (facundobati...@gmail.com) escribió: > >> > > > > As a core dev you can still merge it yourself without needing to wait for > > review, even when it has the "awaiting core review" label. > > Awesome, thanks for the help. I'll create two

[Python-Dev] Re: Procedure for trivial PRs

2020-08-13 Thread Facundo Batista
El jue., 13 de ago. de 2020 a la(s) 16:55, Mariatta (maria...@python.org) escribió: > > > On Thu, Aug 13, 2020 at 12:51 PM Facundo Batista > wrote: >> >> It's waiting for a "core review", which is a good thing (and by all >> means welcomed). But as we're saturated of PRs, the fix is small, and

[Python-Dev] Re: Procedure for trivial PRs

2020-08-13 Thread Mariatta
On Thu, Aug 13, 2020 at 12:51 PM Facundo Batista wrote: > It's waiting for a "core review", which is a good thing (and by all > means welcomed). But as we're saturated of PRs, the fix is small, and > I'm a core developer myself... shall I wait for a review from another > core developer, or