[Python-Dev] c99 comments in the 2.6 code base?

2008-10-02 Thread Fredrik Lundh
http://drj11.wordpress.com/2008/10/02/python-and-bragging-about-c89/ mentions that Objects/frameobject.c contains a C99-style comment, which means that Python 2.6 won't build on AIX. shouldn't we use a suitable gcc option for the buildbots to prevent that from happening? /F

Re: [Python-Dev] c99 comments in the 2.6 code base?

2008-10-02 Thread Christian Heimes
Fredrik Lundh wrote: http://drj11.wordpress.com/2008/10/02/python-and-bragging-about-c89/ mentions that Objects/frameobject.c contains a C99-style comment, which means that Python 2.6 won't build on AIX. shouldn't we use a suitable gcc option for the buildbots to prevent that from

Re: [Python-Dev] c99 comments in the 2.6 code base?

2008-10-02 Thread Antoine Pitrou
Christian Heimes lists at cheimes.de writes: Ouch! This shouldn't have happend. I'm going to discuss the matter on #python-dev. Perhaps --with-pydebug could add more restrict error checking to the Makefile like -std=c89 -pedantic -Werror As discussed on python-dev, I think it should also

Re: [Python-Dev] c99 comments in the 2.6 code base?

2008-10-02 Thread Christian Heimes
Fredrik Lundh wrote: http://drj11.wordpress.com/2008/10/02/python-and-bragging-about-c89/ I've found several more occasions of // comments and one usage of inline. We *really* should have some way to compile Python with C89 checks Python doesn't compile with the -pedantic option but it

Re: [Python-Dev] c99 comments in the 2.6 code base?

2008-10-02 Thread Christian Heimes
Martin v. Löwis wrote: shouldn't we use a suitable gcc option for the buildbots to prevent that from happening? Which one specifically? I suggest we add -std=c89 to CFLAGS. We could also add a new target called buildbot to the Makefile that appends -std=c89 -Werror to CFLAGS. I don't think

Re: [Python-Dev] c99 comments in the 2.6 code base?

2008-10-02 Thread Martin v. Löwis
shouldn't we use a suitable gcc option for the buildbots to prevent that from happening? Which one specifically? I suggest we add -std=c89 to CFLAGS. That needs thorough testing, in particular across many old Linux distributions. It might be that some sets of Linux header files rely on GNU

Re: [Python-Dev] c99 comments in the 2.6 code base?

2008-10-02 Thread skip
shouldn't we use a suitable gcc option for the buildbots to prevent that from happening? Which one specifically? I suggest we add -std=c89 to CFLAGS. Martin That needs thorough testing, in particular across many old Linux Martin distributions. It might be