[Python-Dev] fileinput module tests

2006-12-09 Thread Anthony Roy
Hi all, I have a patch for the fileinput.FileInput class, adding a parameter to the __init__ method called write_mode in order to specify the write mode when using the class with the inplace parameter set to True. Before I submit the patch, I've added a test to the test module, and noticed that

Re: [Python-Dev] fileinput module tests

2006-12-09 Thread Brett Cannon
On 12/8/06, Anthony Roy [EMAIL PROTECTED] wrote: Hi all, I have a patch for the fileinput.FileInput class, adding a parameter to the __init__ method called write_mode in order to specify the write mode when using the class with the inplace parameter set to True. Before I submit the patch,

Re: [Python-Dev] fileinput module tests

2006-12-09 Thread Martin v. Löwis
Anthony Roy schrieb: Any thought? In addition to what Brett said: please make functionality changes and refactoring separate patches (specify the order of application if one depends on the other). When reading commit message, or performing svn blame, it's important to know whether a change is