Re: [Python-Dev] zipimport.c broken with implicit namespace packages

2016-01-04 Thread Phil Thompson
On 3 Jan 2016, at 5:33 pm, Brett Cannon wrote: > > > > On Sun, 3 Jan 2016 at 02:55 Phil Thompson wrote: > On 3 Jan 2016, at 3:41 am, Guido van Rossum wrote: > > > > On Sat, Jan 2, 2016 at 3:26 PM,

Re: [Python-Dev] zipimport.c broken with implicit namespace packages

2016-01-04 Thread mike . romberg
> " " == Brett Cannon writes: ... > It's a reasonable thing to consider, but it would be better to > get zipimport fixed for you, then rewritten To that end, I've added a patch to the issue tracker: https://bugs.python.org/issue17633 My patch is

Re: [Python-Dev] zipimport.c broken with implicit namespace packages

2016-01-03 Thread mike . romberg
> " " == Brett Cannon writes: ... > So it's possible that some abstraction might be possible, but > up to this point there hasn't been a motivating factor for > importlib to do this as zipimport is written in C and thus > won't benefit from any

Re: [Python-Dev] zipimport.c broken with implicit namespace packages

2016-01-03 Thread Phil Thompson
On 3 Jan 2016, at 3:41 am, Guido van Rossum wrote: > > On Sat, Jan 2, 2016 at 3:26 PM, wrote: > > -- > > "Brett" == Brett Cannon writes: > > > I opened > > https://bugs.python.org/issue25711 to specifically try to >

Re: [Python-Dev] zipimport.c broken with implicit namespace packages

2016-01-03 Thread Brett Cannon
On Sun, 3 Jan 2016 at 02:55 Phil Thompson wrote: > On 3 Jan 2016, at 3:41 am, Guido van Rossum wrote: > > > > On Sat, Jan 2, 2016 at 3:26 PM, wrote: > > > > -- > > > "Brett" == Brett Cannon writes:

Re: [Python-Dev] zipimport.c broken with implicit namespace packages

2016-01-03 Thread Brett Cannon
On Sat, 2 Jan 2016 at 21:31 wrote: > > " " == Brett Cannon writes: > > > I just wanted to quickly say that Guido's observation as to how > > a VFS is overkill is right. Imagine implementing a loader using > > sqlite and you quickly

[Python-Dev] zipimport.c broken with implicit namespace packages

2016-01-02 Thread mike . romberg
BRIEF INTRODUCTION: I've been using python since the early 1.X releases. Mostly for application development. On occasion I've contributed bits to the core: > grep Romberg Misc/ACKS Mike Romberg I've recently ported a large application to python3 (it started life as using 1.1 so it has

Re: [Python-Dev] zipimport.c broken with implicit namespace packages

2016-01-02 Thread mike . romberg
-- > "Brett" == Brett Cannon writes: > I opened > https://bugs.python.org/issue25711 to specifically try to > fix this issue once and for all and along the way modernize > zipimport by rewriting it from scratch to be more > maintainable Every time I

Re: [Python-Dev] zipimport.c broken with implicit namespace packages

2016-01-02 Thread Brett Cannon
FIrst off, Mike, sorry about the bug. We have unfortunately let zipimport get into a sorry state that has made no one want to work on the code anymore. That being said, I opened https://bugs.python.org/issue25711 to specifically try to fix this issue once and for all and along the way modernize

Re: [Python-Dev] zipimport.c broken with implicit namespace packages

2016-01-02 Thread Brett Cannon
I just wanted to quickly say that Guido's observation as to how a VFS is overkill is right. Imagine implementing a loader using sqlite and you quickly realize that doing a dull VFS is more than necessary to implement what import needs to function. On Sat, 2 Jan 2016, 19:42 Guido van Rossum

Re: [Python-Dev] zipimport.c broken with implicit namespace packages

2016-01-02 Thread mike . romberg
> " " == Brett Cannon writes: > I just wanted to quickly say that Guido's observation as to how > a VFS is overkill is right. Imagine implementing a loader using > sqlite and you quickly realize that doing a dull VFS is more > than necessary to implement

Re: [Python-Dev] zipimport.c broken with implicit namespace packages

2016-01-02 Thread Brett Cannon
On Sat, 2 Jan 2016, 20:42 Brett Cannon wrote: > I just wanted to quickly say that Guido's observation as to how a VFS is > overkill is right. Imagine implementing a loader using sqlite and you > quickly realize that doing a dull VFS is more > "dull" -> "full" than necessary to

Re: [Python-Dev] zipimport.c broken with implicit namespace packages

2016-01-02 Thread Nick Coghlan
On 3 January 2016 at 16:32, Nick Coghlan wrote: > For folks that are interested in that, folks that aren't following > import-sig in addition to python-dev may want to take a look at > Brett's design for the importlib.resources API: >

Re: [Python-Dev] zipimport.c broken with implicit namespace packages

2016-01-02 Thread Guido van Rossum
On Sat, Jan 2, 2016 at 3:26 PM, wrote: > > -- > > "Brett" == Brett Cannon writes: > > > I opened > > https://bugs.python.org/issue25711 to specifically try to > > fix this issue once and for all and along the way modernize > >

Re: [Python-Dev] zipimport.c broken with implicit namespace packages

2016-01-02 Thread Nick Coghlan
On 3 January 2016 at 15:29, wrote: >> " " == Brett Cannon writes: > > > I just wanted to quickly say that Guido's observation as to how > > a VFS is overkill is right. Imagine implementing a loader using > > sqlite and you quickly