Serhiy Storchaka added the comment:
I see yet one possible bug, using PyBytes_FromString() in list_join() on 3.2.
But I can't demonstrate an example.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16922
brian-cameron-oracle added the comment:
Since Modules/ossaudiodev.c has the following line (which is not surrounded by
any conditional #ifdef sort of things):
#include sys/soundcard.h
This means that the OSS plugin will only build on a system that has this header
file, so it is safe to check
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8145
___
___
R. David Murray added the comment:
I believe that the complete list of test files still located outside of
Lib/test are:
tkinter/test
distutils/tests
ctypes/tests
lib2to3/tests
sqlite3/test
unittest/test
That last is somewhat ironic since Michael opened the issue :).
I'm
Serhiy Storchaka added the comment:
Some general notes. Nitpick: check foo() 0 is more used than foo() == 0. An
exception raised after failed close() can hide original exception raised
before. I left more specific comments on Rietveld.
Only a small part of the proposed changes may be
Guido van Rossum added the comment:
I am sticking with my opinion from before: the code should be fixed. It
doesn't look like assignment to me.
I am fine with making this a feature only fixed in 3.4. (You can even fix
the docs in 3.3 as long as you fix them back for 3.4.)
Minor note for
Marek Šuppa added the comment:
Thanks for the review.
Do you think I should split it into multiple patches to make it easier to look
through?
It might be that some changes are completely wrong. This is the first time I
did something with cpython core code.
--
R. David Murray added the comment:
Talked to Michael in IRC. He isn't particularly in favor of the move of the
unittest tests, but doesn't object if someone else wants to do it. So,
unassigning the issue from him.
--
assignee: michael.foord -
Alexander Belopolsky added the comment:
ctypes/tests is within my area of interests and may prove to be one of the
harder pieces. I'll try to move it and report the results. I have not worked
with the rest, so unless it is truly trivial this will have to wait for another
volunteer.
Benjamin Peterson added the comment:
I honestly don't see the point of moving tests around.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10572
___
Antoine Pitrou added the comment:
Indeed, SSLSocket.__del__ doesn't seem to have a point.
--
nosy: +pitrou
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16900
___
Frank Wierzbicki added the comment:
Switched to unittest style away from doctests and created patch against 3.3.
Note that at this time test_dictcomp.py is identical in 3.3 and 3.4 so merging
should be pretty easy :)
--
Added file: http://bugs.python.org/file28676/dictcomp3.3.patch
Frank Wierzbicki added the comment:
This patch of test_dict_comp.py was made against 2.7. It differs from the 3.3
version only one line from test import test_support as support
--
Added file: http://bugs.python.org/file28677/dictcomp2.7.patch
___
New submission from Benjamin Peterson:
Now #16900 is fixed, we get gunk like this:
$ ./python -Wall Lib/test/regrtest.py -uall test_ssl
[1/1] test_ssl
/home/benjamin/dev/python/3.3/Lib/unittest/case.py:385: ResourceWarning:
unclosed ssl.SSLSocket object, fd=6, family=2, type=1, proto=0
Roundup Robot added the comment:
New changeset c8105251cc1f by Benjamin Peterson in branch '3.3':
remove __del__ because it's evil and also prevents the ResourceWarning on the
socket from happening (closes #16900)
http://hg.python.org/cpython/rev/c8105251cc1f
New changeset e23d51f17cce by
Serhiy Storchaka added the comment:
Well, here is a patch which add short_empty_elements flag (as for XMLGenerator)
to write(), tostring() and tostringlist() methods of ElementTree.
--
stage: needs patch - patch review
___
Python tracker
Brett Cannon added the comment:
Two reasons for collecting all of the tests in a single location:
1) Facilitates test discovery
2) It makes packaging of CPython easier for Linux distros that prefer to leave
the tests out of the core package
--
___
Serhiy Storchaka added the comment:
Oh, I forgot press Push All My Drafts button.
Actually only patch for _cursesmodule.c looks safe at first glance (but curses
maintainer can decide better). You can split the patch on several patches, but
be very careful. You should research the entire
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file28678/etree_short_empty_elements.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14377
___
Marek Šuppa added the comment:
That is probably right.
I was way too foolish to start with this but won't stop now.
I'll try to iterate on your feedback.
Thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15948
py.user added the comment:
Andrew Svetlov wrote:
LoadError is inherited from OSError
the comment for the function doesn't tell it
today it's inherited from OSError and tomorrow it may inherit from ANYError
--
___
Python tracker
Sven Brauch added the comment:
Here's another version now which I think could be used like this. All tests
have been adjusted. I'll append two patches, one just containing the changes to
the parser for ease of review, and one full diff which also contains changes to
the generated files and
Sven Brauch added the comment:
Attached is the full diff this time.
--
Added file: http://bugs.python.org/file28680/full.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16795
___
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16923
___
___
Python-bugs-list mailing
STINNER Victor added the comment:
./Python/traceback.c:write(fd, c, 1);
./Python/traceback.c:write(fd, \, 1);
./Python/traceback.c:write(fd, \, 1);
./Python/traceback.c:write(fd, \n, 1);
./Python/traceback.c:write(fd, \n, 1);
Oh, I wrote these ones.
STINNER Victor added the comment:
diff -r 0acc5626a578 Modules/faulthandler.c
@@ -445,7 +445,10 @@
-write(thread.fd, thread.header, thread.header_len);
+if (write(thread.fd, thread.header, thread.header_len) == -1) {
+PyErr_SetFromErrno(PyExc_IOError);
+
Sven Brauch added the comment:
The patch review tool currently throws errors on submitting any form
(http://pastie.org/pastes/5665048/text) so please forgive me for answering here
once more. I'll copy this information (patch + message) to the review as soon
as the website is working again.
Benjamin Peterson added the comment:
Could you post an example of the error, please?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16795
___
Sven Brauch added the comment:
The above post has an example for trying to add a patch, here's what happens
when I try to post a reply: http://pastie.org/pastes/5665144/text
I also tried with another web browser, so it's unlikely that it's the browser's
fault (but maybe the user's? ;)
Benjamin Peterson added the comment:
Ah, sorry, I was talking about the failure of optional arguments.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16795
___
Sven Brauch added the comment:
Ah, whops, I misunderstood that.
The error is rather generic:
Traceback (most recent call last):
File ./Lib/test/test_ast.py, line 796, in test_lambda
self._check_arguments(fac, self.expr)
File ./Lib/test/test_ast.py, line 596, in _check_arguments
Vladimir Rutsky added the comment:
Yes, I managed to pass and operate with matrices of complex numbers to pure C
and Fortran programs by using Numpy and their ctype adapters (only for whole
matrices, they don't provide c_complex type; in general see
http://www.scipy.org/Cookbook/Ctypes for
Richard Oudkerk added the comment:
Why are you connecting to a multiprocessing listener with a raw socket? You
should be using multiprocessing.connection.Client to create a client connection.
Connection.send(obj) writes a 32 bit unsigned int (in network order) to the
socket representing the
Roundup Robot added the comment:
New changeset b8b26feb3e1a by R David Murray in branch '3.2':
#13934: document sqlite version strings, use correct one in test.
http://hg.python.org/cpython/rev/b8b26feb3e1a
New changeset cdf9142a0c84 by R David Murray in branch '3.3':
merge #13934: document
R. David Murray added the comment:
These patches are small enough a contributor agreement is not required, but it
would still be great if you would submit one, poq.
--
nosy: +r.david.murray
stage: patch review - committed/rejected
status: open - closed
New submission from Justin Eittreim:
When running multiple nested loops (to emulate the circumstances of a program
running multiple different modules at once,) each with their own try: except:
block (in this case for KeyboardInterrupt,) the order of operations seems to
fall out of place. As
Roundup Robot added the comment:
New changeset 2a417ad8bfbf by R David Murray in branch '2.7':
#15109: revert '%'-'format' changes in 4b105d328fe7 to fix regression.
http://hg.python.org/cpython/rev/2a417ad8bfbf
--
nosy: +python-dev
___
Python
Changes by R. David Murray rdmur...@bitdance.com:
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15109
Todd Rovito added the comment:
I think getting this issue fixed makes sense, it would save time and remove
duplication.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16893
___
R. David Murray added the comment:
Print b happens when the interpreter is processing the loop condition for loop
c. print c happens when it is processing the body of the loop (ie: is inside
the try/except in the body of the loop). Presumably if you set your keyboard
autorepeat interval
Roundup Robot added the comment:
New changeset 15ddd683c321 by Ezio Melotti in branch '3.3':
#16919: test_crypt now works with unittest test discovery. Patch by Zachary
Ware.
http://hg.python.org/cpython/rev/15ddd683c321
New changeset 5345f515e03b by Ezio Melotti in branch 'default':
#16919:
Ezio Melotti added the comment:
Fixed, thanks for the patch!
I tested it with and without crypt and with and without test discovery and all
the combinations seem to work fine.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
Changes by Zachary Ware zachary.w...@gmail.com:
--
components: Tests
files: test_configparser_discovery.diff
keywords: patch
nosy: brett.cannon, ezio.melotti, zach.ware
priority: normal
severity: normal
status: open
title: Fix test discovery for test_configparser.py
type: behavior
Zachary Ware added the comment:
I was just about to test it at home and couldn't find it in my list of open
issues.
Thanks, Ezio :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16919
Ezio Melotti added the comment:
FTR, the failure you saw while switching to unittest.main() seems to be caused
by a broken test that wasn't run. Unittest test discovery simply revealed the
problem -- I'm working on it.
--
___
Python tracker
Benjamin Peterson added the comment:
Ah, yes. This is part of the annoying inconsistency in our asdl framework.
Here's what I think should happen:
- on arguments, vararg and kwarg should get the arg type, killing some of the
numerous fields on arguments
- asdl needs to be hacked, so arg can
Roundup Robot added the comment:
New changeset 11e7d0936fa2 by Ezio Melotti in branch '3.3':
#16918: test_codecs now works with unittest test discovery. Patch by Zachary
Ware.
http://hg.python.org/cpython/rev/11e7d0936fa2
New changeset 02180599a99f by Ezio Melotti in branch 'default':
#16918:
Ezio Melotti added the comment:
Fixed, thanks for the patch!
Apparently the broken test was ported from Python 2 to Python 3 in 4747ef9640ae
(back in the SVN days), but the name of the test class was not added to the
list of tests in test_main. Without the test class in the list, the test was
New submission from Chris Jerdonek:
$ python setup.py --dry-run register --repository
http://testpypi.python.org/pypi
...
Registering Foo to http://pypi.python.org/pypi
Server response (200): OK
This is with a .pypirc file with a [server-login] section.
It seems like this can cause unintended
New submission from Roundup Robot:
New changeset 7dbdd7204d0a by Ezio Melotti in branch '3.3':
#16925: test_configparser now works with unittest test discovery. Patch by
Zachary Ware.
http://hg.python.org/cpython/rev/7dbdd7204d0a
New changeset 680a855ec91e by Ezio Melotti in branch 'default':
Éric Araujo added the comment:
I think this is a duplicate, could you check?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16926
___
___
Ezio Melotti added the comment:
Fixed, thanks for the patch!
--
assignee: - ezio.melotti
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16925
Chris Jerdonek added the comment:
I did before and double-checked again. I searched for setup repository and
register repository, for example. Issue 16926 seemed the most similar, but
appears to be different.
--
___
Python tracker
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
versions: +Python 3.3, Python 3.4 -Python 2.6, Python 2.7, Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8840
___
Chris Jerdonek added the comment:
This is in part because register.run() calls self._set_config() after calling
self.finalize_options():
http://hg.python.org/cpython/file/680a855ec91e/Lib/distutils/command/register.py#l43
And _set_config() doesn't seem to look at already-finalized options.
Chris Jerdonek added the comment:
Issue 16926 seemed the most similar, but appears to be different.
I meant issue 13615. It is different but is also about --repository.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16926
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
type: - enhancement
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12901
___
Chris Jerdonek added the comment:
I will take care of this (formatting issue).
--
assignee: eric.araujo - chris.jerdonek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16874
___
New submission from Ezio Melotti:
http://docs.python.org/3/library/functions.html currently lists all the builtin
objects.
This include two main groups that should be separated in two different
sections: built-in types and functions.
In addition, similar/related functions should be grouped
Chris Jerdonek added the comment:
I asked on the Mercurial tracker about suppressing git-style diffs when git is
configured on, and there is a work-around:
http://bz.selenic.com/show_bug.cgi?id=3761
We could mention this in the devguide somewhere (e.g. in a FAQ about how to use
Rietveld with
Changes by Chris Jerdonek chris.jerdo...@gmail.com:
--
nosy: +chris.jerdonek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16851
___
___
Ezio Melotti added the comment:
There are tests outside of Lib/test/ hierarchy.
See #10572.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16748
___
Chris Jerdonek added the comment:
There are lots of modules to change here. I wonder if some or most of this
couldn't be automated.
For example, is there any reason we couldn't write a script to check for the
type of test duplication fixed documentation-wise in issue 16835? We could use
Chris Jerdonek added the comment:
The attached patch applies to all branches.
--
Added file: http://bugs.python.org/file28684/issue-16874-1-27.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16874
Roundup Robot added the comment:
New changeset 2bc04449fd8c by Ezio Melotti in branch '2.7':
#13899: \A, \Z, and \B now correctly match the A, Z, and B literals when used
inside character classes (e.g. [A]). Patch by Matthew Barnett.
http://hg.python.org/cpython/rev/2bc04449fd8c
New changeset
Ezio Melotti added the comment:
Fixed, thanks for the report John, and for the patch Matthew!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset a30c36fbefcf by Chris Jerdonek in branch '2.7':
Issue #16874: fix formatting of setup.py upload options in documentation.
http://hg.python.org/cpython/rev/a30c36fbefcf
New changeset dcb645b9de4c by Chris Jerdonek in branch '3.2':
Issue #16874
Changes by Chris Jerdonek chris.jerdo...@gmail.com:
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16874
Roundup Robot added the comment:
New changeset 9b3d0bdb9256 by Ezio Melotti in branch '2.7':
#16154: fix some doctests in Doc/library. Patch by Ravi Sinha.
http://hg.python.org/cpython/rev/9b3d0bdb9256
New changeset 5b405df8518d by Ezio Melotti in branch '3.2':
#16154: fix some doctests in
Ezio Melotti added the comment:
Fixed, thanks for the report and the patch!
--
assignee: docs@python - ezio.melotti
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Ezio Melotti added the comment:
The fix introduced some refleaks:
$ ./python -m test -R3:2 test_xml_etree_c
test_xml_etree_c leaked [56, 56] references, sum=112
One seems to be in __getstate__:
diff --git a/Modules/_elementtree.c b/Modules/_elementtree.c
--- a/Modules/_elementtree.c
+++
New submission from Chris Jerdonek:
Some spurious e-mails are sent to python-checkins, e.g.
Subject: [Python-checkins] Cron docs at dinsdale /home/docs/build-devguide
From: Cron Daemon root at python.org
To: d...@dinsdale.python.org
/home/docs/devguide/documenting.rst:766: WARNING: term not
101 - 172 of 172 matches
Mail list logo
