Re: [PATCH v15 1/6] qmp: add QMP command x-query-virtio

On 12/7/22 08:22, Markus Armbruster wrote: Jonah Palmer writes: On 12/2/22 10:21, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 2/12/22 13:23, Jonah Palmer wrote: On 11/30/22 11:16, Philippe Mathieu-Daudé wrote: Hi, On 11/8/22 14:24, Jonah Palmer wrote: From: Laurent

Re: [PATCH v15 1/6] qmp: add QMP command x-query-virtio

On 12/2/22 10:21, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 2/12/22 13:23, Jonah Palmer wrote: On 11/30/22 11:16, Philippe Mathieu-Daudé wrote: Hi, On 11/8/22 14:24, Jonah Palmer wrote: From: Laurent Vivier This new command lists all the instances of VirtIODevices

Re: [PATCH v15 1/6] qmp: add QMP command x-query-virtio

On 11/30/22 11:16, Philippe Mathieu-Daudé wrote: Hi, On 11/8/22 14:24, Jonah Palmer wrote: From: Laurent Vivier This new command lists all the instances of VirtIODevices with their canonical QOM path and name. [Jonah: @virtio_list duplicates information that already exists in   the QOM

Re: [PATCH v15 0/6] hmp,qmp: Add commands to introspect virtio devices

Hey Michael, when you get the chance, could you review these patches for me? Specifically patch 3/6, as that has the majority of the changes made for this series. Thanks! Jonah From: Jonah Palmer Sent: Thursday, August 11, 2022 8:26 AM To: qemu-de...@nongnu.org

[PATCH v15 6/6] hmp: add virtio commands

From: Laurent Vivier This patch implements the HMP versions of the virtio QMP commands. [Jonah: Adjusted hmp monitor output format for features / statuses with their descriptions.] Signed-off-by: Laurent Vivier Signed-off-by: Jonah Palmer --- hmp-commands-info.hx | 70

[PATCH v15 2/6] qmp: add QMP command x-query-virtio-status

status bits of a VirtIODevice. [Jonah: From patch v12; added a check to @virtio_device_find to ensure synchronicity between @virtio_list and the devices in the QOM composition tree.] Signed-off-by: Laurent Vivier Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 5 + hw/virtio/virtio.c

[PATCH v15 4/6] qmp: add QMP commands for virtio/vhost queue-status

From: Laurent Vivier These new commands show the internal status of a VirtIODevice's VirtQueue and a vhost device's vhost_virtqueue (if active). Signed-off-by: Laurent Vivier Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 14 +++ hw/virtio/virtio.c | 103

[PATCH v15 5/6] qmp: add QMP command x-query-virtio-queue-element

. By doing this we get (1) simpler schema, (2) smaller generated code, and (3) less maintenance burden for when new things are added (e.g. devices, device features, etc.).] Signed-off-by: Laurent Vivier Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 9 ++ hw/virtio/virtio.c | 154

[PATCH v15 3/6] qmp: decode feature & status bits in virtio-status

ned-off-by: Jonah Palmer --- As mentioned in the cover letter, there's a bit of confusion for me here regarding a 30 feature bit that I've been seeing in all of the PCI virtio devices that I've defined when bringing up a guest. The only 30 feature bits that are defi

[PATCH v15 0/6] hmp,qmp: Add commands to introspect virtio devices

This series introduces new QMP/HMP commands to dump the status of a virtio device at different levels. [Jonah: Rebasing from previous patchset from Apr. 1 (v14). Original patches are by Laurent Vivier from May 2020. I sincerely apologize for the *massive* delay in getting this latest v15

[PATCH v15 1/6] qmp: add QMP command x-query-virtio

-by: Jonah Palmer --- hw/virtio/meson.build | 2 ++ hw/virtio/virtio-stub.c| 14 hw/virtio/virtio.c | 44 include/hw/virtio/virtio.h | 1 + qapi/meson.build | 1 + qapi/qapi-schema.json | 1 + qapi/virtio.json | 68

Re: [PATCH v14 5/8] qmp: decode feature & status bits in virtio-status

On 6/10/22 01:41, Michael S. Tsirkin wrote: On Thu, May 19, 2022 at 02:30:43AM -0400, Jonah Palmer wrote: On 5/16/22 16:26, Michael S. Tsirkin wrote: On Fri, Apr 01, 2022 at 09:23:22AM -0400, Jonah Palmer wrote: From: Laurent Vivier Display feature names instead

Re: [PATCH v14 5/8] qmp: decode feature & status bits in virtio-status

On 5/16/22 16:26, Michael S. Tsirkin wrote: On Fri, Apr 01, 2022 at 09:23:22AM -0400, Jonah Palmer wrote: From: Laurent Vivier Display feature names instead of bitmaps for host, guest, and backend for VirtIODevices. Display status names instead of bitmaps for VirtIODevices. Display feature

[PATCH v14 5/8] qmp: decode feature & status bits in virtio-status

red in a separate field. Signed-off-by: Jonah Palmer --- hw/block/virtio-blk.c | 29 hw/char/virtio-serial-bus.c| 11 ++ hw/display/virtio-gpu.c| 18 ++ hw/input/virtio-input.c| 10 ++ hw/net/virtio-net.c| 47 + hw/scsi/virtio-scsi.c |

[PATCH v14 3/8] qmp: add QMP command x-query-virtio

composition tree). Also, the QMP command @x-query-virtio is redundant as @qom-list and @qom-get are sufficient to search '/machine/' for realized virtio devices. However, @x-query-virtio is much more convenient in listing realized virtio devices.] Signed-off-by: Jonah Palmer --- hw/virtio

[PATCH v14 8/8] hmp: add virtio commands

From: Laurent Vivier This patch implements the HMP versions of the virtio QMP commands. [Jonah: Fixed virtio hmp command output format (e.g. use PRI types).] Signed-off-by: Jonah Palmer --- hmp-commands-info.hx | 70 ++ include/monitor/hmp.h | 5 + monitor/hmp-cmds.c| 311

[PATCH v14 0/8] hmp,qmp: Add commands to introspect virtio devices

fix odd indentation for qapi/virtio.json device features support for virtio-mem move HMP sub-commands under 'virtio' top level to 'info' top level v8: add assert in virtio_id_to_name() to make sure we're not returning NULL minor documentation additions to qapi/virtio.json a

[PATCH v14 7/8] qmp: add QMP command x-query-virtio-queue-element

. By doing this we get (1) simpler schema, (2) smaller generated code, and (3) less maintenance burden for when new things are added (e.g. devices, device features, etc.).] Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 9 ++ hw/virtio/virtio.c | 154

[PATCH v14 6/8] qmp: add QMP commands for virtio/vhost queue-status

From: Laurent Vivier These new commands show the internal status of a VirtIODevice's VirtQueue and a vhost device's vhost_virtqueue (if active). Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 14 +++ hw/virtio/virtio.c | 103 qapi/virtio.json| 252

[PATCH v14 2/8] virtio: add vhost support for virtio devices

vhost device was active or not. Signed-off-by: Jonah Palmer --- hw/block/vhost-user-blk.c | 7 +++ hw/display/vhost-user-gpu.c| 7 +++ hw/input/vhost-user-input.c| 7 +++ hw/net/virtio-net.c| 9 + hw/scsi/vhost-scsi.c | 8 hw/virtio

[PATCH v14 1/8] virtio: drop name parameter for virtio_init()

in the virtio_init function. Signed-off-by: Jonah Palmer --- hw/9pfs/virtio-9p-device.c | 2 +- hw/block/vhost-user-blk.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/char/virtio-serial-bus.c| 3 +- hw/display/virtio-gpu-base.c | 2

[PATCH v14 4/8] qmp: add QMP command x-query-virtio-status

status bits of a VirtIODevice. [Jonah: From patch v12; added a check to @virtio_device_find to ensure synchronicity between @virtio_list and the devices in the QOM composition tree.] Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 5 + hw/virtio/virtio.c | 104

Re: [PATCH v13 0/8] hmp,qmp: Add commands to introspect virtio devices

My apologies for not notifying earlier but I have been looking into these errors. Hopefully should be able to get a fix sent out within the week. Thanks Jonah On 3/7/22 17:46, Michael S. Tsirkin wrote: On Mon, Mar 07, 2022 at 08:08:33AM -0500, Jonah Palmer wrote: This series introduces new

[PATCH v13 6/8] qmp: add QMP commands for virtio/vhost queue-status

From: Laurent Vivier These new commands show the internal status of a VirtIODevice's VirtQueue and a vhost device's vhost_virtqueue (if active). Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 14 +++ hw/virtio/virtio.c | 103 qapi/virtio.json| 252

[PATCH v13 1/8] virtio: drop name parameter for virtio_init()

in the virtio_init function. Signed-off-by: Jonah Palmer --- hw/9pfs/virtio-9p-device.c | 2 +- hw/block/vhost-user-blk.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/char/virtio-serial-bus.c| 3 +- hw/display/virtio-gpu-base.c | 2

[PATCH v13 7/8] qmp: add QMP command x-query-virtio-queue-element

. By doing this we get (1) simpler schema, (2) smaller generated code, and (3) less maintenance burden for when new things are added (e.g. devices, device features, etc.).] Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 9 +++ hw/virtio/virtio.c | 154

[PATCH v13 2/8] virtio: add vhost support for virtio devices

vhost device was active or not. Signed-off-by: Jonah Palmer --- hw/block/vhost-user-blk.c | 7 +++ hw/display/vhost-user-gpu.c| 7 +++ hw/input/vhost-user-input.c| 7 +++ hw/net/virtio-net.c| 9 + hw/scsi/vhost-scsi.c | 8 hw/virtio

[PATCH v13 8/8] hmp: add virtio commands

From: Laurent Vivier This patch implements the HMP versions of the virtio QMP commands. [Jonah: Fixed virtio hmp command output format (e.g. use PRI types).] Signed-off-by: Jonah Palmer --- hmp-commands-info.hx | 70 include/monitor/hmp.h | 5 + monitor/hmp-cmds.c| 311

[PATCH v13 5/8] qmp: decode feature & status bits in virtio-status

red in a separate field. Signed-off-by: Jonah Palmer --- hw/block/virtio-blk.c | 29 hw/char/virtio-serial-bus.c| 11 ++ hw/display/virtio-gpu-base.c | 18 ++- hw/input/virtio-input.c| 10 ++ hw/net/virtio-net.c| 47 +++ hw/scsi/virtio-scsi.c |

[PATCH v13 3/8] qmp: add QMP command x-query-virtio

composition tree). Also, the QMP command @x-query-virtio is redundant as @qom-list and @qom-get are sufficient to search '/machine/' for realized virtio devices. However, @x-query-virtio is much more convenient in listing realized virtio devices.] Signed-off-by: Jonah Palmer --- hw/virtio

[PATCH v13 4/8] qmp: add QMP command x-query-virtio-status

status bits of a VirtIODevice. [Jonah: From patch v12; added a check to @virtio_device_find to ensure synchronicity between @virtio_list and the devices in the QOM composition tree.] Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 5 ++ hw/virtio/virtio.c | 104

[PATCH v13 0/8] hmp,qmp: Add commands to introspect virtio devices

atures support for virtio-mem move HMP sub-commands under 'virtio' top level to 'info' top level v8: add assert in virtio_id_to_name() to make sure we're not returning NULL minor documentation additions to qapi/virtio.json add virtio introspection support for vhost-user-rng v7: re

[PATCH v12 2/8] virtio: add vhost support for virtio devices

vhost device was active or not. Signed-off-by: Jonah Palmer --- hw/block/vhost-user-blk.c | 7 +++ hw/display/vhost-user-gpu.c| 7 +++ hw/input/vhost-user-input.c| 7 +++ hw/net/virtio-net.c| 9 + hw/scsi/vhost-scsi.c | 8 hw/virtio

[PATCH v12 8/8] hmp: add virtio commands

From: Laurent Vivier This patch implements the HMP versions of the virtio QMP commands. [Jonah: Fixed virtio hmp command output format (e.g. use PRI types).] Signed-off-by: Jonah Palmer --- hmp-commands-info.hx | 70 include/monitor/hmp.h | 5 + monitor/hmp-cmds.c| 311

[PATCH v12 7/8] qmp: add QMP command x-query-virtio-queue-element

. By doing this we get (1) simpler schema, (2) smaller generated code, and (3) less maintenance burden for when new things are added (e.g. devices, device features, etc.).] Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 9 +++ hw/virtio/virtio.c | 154

[PATCH v12 5/8] qmp: decode feature & status bits in virtio-status

red in a separate field. Signed-off-by: Jonah Palmer --- hw/block/virtio-blk.c | 29 hw/char/virtio-serial-bus.c| 11 ++ hw/display/virtio-gpu-base.c | 18 ++- hw/input/virtio-input.c| 10 ++ hw/net/virtio-net.c| 47 +++ hw/scsi/virtio-scsi.c |

[PATCH v12 3/8] qmp: add QMP command x-query-virtio

composition tree). Also, the QMP command @x-query-virtio is redundant as @qom-list and @qom-get are sufficient to search '/machine/' for realized virtio devices. However, @x-query-virtio is much more convenient in listing realized virtio devices.] Signed-off-by: Jonah Palmer --- hw/virtio

[PATCH v12 0/8] hmp,qmp: Add commands to introspect virtio devices

evice features support for virtio-mem move HMP sub-commands under 'virtio' top level to 'info' top level v8: add assert in virtio_id_to_name() to make sure we're not returning NULL minor documentation additions to qapi/virtio.json add virtio introspection support for vhost-user-rn

[PATCH v12 6/8] qmp: add QMP commands for virtio/vhost queue-status

From: Laurent Vivier These new commands show the internal status of a VirtIODevice's VirtQueue and a vhost device's vhost_virtqueue (if active). Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 14 +++ hw/virtio/virtio.c | 103 qapi/virtio.json| 252

[PATCH v12 4/8] qmp: add QMP command x-query-virtio-status

status bits of a VirtIODevice. [Jonah: Similar to previous patch, added a check to @virtio_device_find to ensure synchronicity between @virtio_list and the devices in the QOM composition tree.] Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 5 ++ hw/virtio/virtio.c | 104

[PATCH v12 1/8] virtio: drop name parameter for virtio_init()

in the virtio_init function. [Jonah: added new virtio IDs to virtio device list from rebase]. Signed-off-by: Jonah Palmer --- hw/9pfs/virtio-9p-device.c | 2 +- hw/block/vhost-user-blk.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/char/virtio-serial-bus.c

[PATCH v11 5/8] qmp: decode feature & status bits in virtio-status

red in a separate field. Signed-off-by: Jonah Palmer --- hw/block/virtio-blk.c | 29 hw/char/virtio-serial-bus.c| 11 ++ hw/display/virtio-gpu-base.c | 18 ++- hw/input/virtio-input.c| 10 ++ hw/net/virtio-net.c| 47 +++ hw/scsi/virtio-scsi.c |

[PATCH v11 3/8] qmp: add QMP command x-query-virtio

composition tree). Also, the QMP command @x-query-virtio is redundant as @qom-list and @qom-get are sufficient to search '/machine/' for realized virtio devices. However, @x-query-virtio is much more convenient in listing realized virtio devices.] Signed-off-by: Jonah Palmer --- hw/virtio

[PATCH v11 7/8] qmp: add QMP command x-query-virtio-queue-element

. By doing this we get (1) simpler schema, (2) smaller generated code, and (3) less maintenance burden for when new things are added (e.g. devices, device features, etc.).] Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 9 +++ hw/virtio/virtio.c | 154

[PATCH v11 8/8] hmp: add virtio commands

From: Laurent Vivier This patch implements the HMP versions of the virtio QMP commands. Signed-off-by: Jonah Palmer --- hmp-commands-info.hx | 70 include/monitor/hmp.h | 5 + monitor/hmp-cmds.c| 311 ++ 3 files changed, 386

[PATCH v11 2/8] virtio: add vhost support for virtio devices

vhost device was active or not. Signed-off-by: Jonah Palmer --- hw/block/vhost-user-blk.c | 7 +++ hw/display/vhost-user-gpu.c| 7 +++ hw/input/vhost-user-input.c| 7 +++ hw/net/virtio-net.c| 9 + hw/scsi/vhost-scsi.c | 8 hw/virtio

[PATCH v11 1/8] virtio: drop name parameter for virtio_init()

in the virtio_init function. [Jonah: added new virtio IDs to virtio device list from rebase]. Signed-off-by: Jonah Palmer --- hw/9pfs/virtio-9p-device.c | 2 +- hw/block/vhost-user-blk.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/char/virtio-serial-bus.c

[PATCH v11 0/8] hmp,qmp: Add commands to introspect virtio devices

ry-virtio' add 'unstable' feature to all 'x-query-virtio' prefixed QMP commands fix odd indentation for qapi/virtio.json device features support for virtio-mem move HMP sub-commands under 'virtio' top level to 'info' top level v8: add assert in virtio_id_to_name() to make su

[PATCH v11 6/8] qmp: add QMP commands for virtio/vhost queue-status

From: Laurent Vivier These new commands show the internal status of a VirtIODevice's VirtQueue and a vhost device's vhost_virtqueue (if active). Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 14 +++ hw/virtio/virtio.c | 103 qapi/virtio.json| 252

[PATCH v11 4/8] qmp: add QMP command x-query-virtio-status

status bits of a VirtIODevice. [Jonah: Similar to previous patch, added a check to @virtio_device_find to ensure synchronicity between @virtio_list and the devices in the QOM composition tree.] Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 5 ++ hw/virtio/virtio.c | 104

Re: [PATCH v10 0/8] hmp,qmp: Add commands to introspect virtio devices

On 12/6/21 08:50, Christian Schoenebeck wrote: On Montag, 6. Dezember 2021 13:43:18 CET Jonah Palmer wrote: This series introduces new QMP/HMP commands to dump the status of a virtio device at different levels. [Jonah: Rebasing previous patchset from Nov. 10 (v9). Original patches

[PATCH v10 5/8] qmp: decode feature & status bits in virtio-status

red in a separate field. Signed-off-by: Jonah Palmer --- hw/block/virtio-blk.c | 29 + hw/char/virtio-serial-bus.c| 11 ++ hw/display/virtio-gpu-base.c | 18 ++- hw/input/virtio-input.c| 10 ++ hw/net/virtio-net.c| 47 +++ hw/scsi/virtio-scs

[PATCH v10 4/8] qmp: add QMP command x-query-virtio-status

status bits of a VirtIODevice. Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 5 ++ hw/virtio/virtio.c | 84 ++ qapi/virtio.json| 220 3 files changed, 309 insertions(+) diff --git a/hw/virtio/virtio-stub.c b

[PATCH v10 1/8] virtio: drop name parameter for virtio_init()

in the virtio_init function. Signed-off-by: Jonah Palmer --- hw/9pfs/virtio-9p-device.c | 2 +- hw/block/vhost-user-blk.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/char/virtio-serial-bus.c | 3 +- hw/display/virtio-gpu-base.c

[PATCH v10 8/8] hmp: add virtio commands

From: Laurent Vivier This patch implements the HMP versions of the virtio QMP commands. Signed-off-by: Jonah Palmer --- hmp-commands-info.hx | 70 include/monitor/hmp.h | 5 + monitor/hmp-cmds.c| 311 ++ 3 files changed, 386

[PATCH v10 7/8] qmp: add QMP command x-query-virtio-queue-element

From: Laurent Vivier This new command shows the information of a VirtQueue element. Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 9 +++ hw/virtio/virtio.c | 154 qapi/virtio.json| 183

[PATCH v10 2/8] virtio: add vhost support for virtio devices

vhost device was active or not. Signed-off-by: Jonah Palmer --- hw/block/vhost-user-blk.c | 7 +++ hw/display/vhost-user-gpu.c| 7 +++ hw/input/vhost-user-input.c| 7 +++ hw/net/virtio-net.c| 9 + hw/scsi/vhost-scsi.c | 8 hw/virtio

[PATCH v10 6/8] qmp: add QMP commands for virtio/vhost queue-status

From: Laurent Vivier These new commands show the internal status of a VirtIODevice's VirtQueue and a vhost device's vhost_virtqueue (if active). Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 14 +++ hw/virtio/virtio.c | 103 qapi/virtio.json| 252

[PATCH v10 3/8] qmp: add QMP command x-query-virtio

From: Laurent Vivier This new command lists all the instances of VirtIODevices with their canonical QOM path and name. Signed-off-by: Jonah Palmer --- hw/virtio/meson.build | 2 ++ hw/virtio/virtio-stub.c| 14 ++ hw/virtio/virtio.c | 27 ++ include/hw

[PATCH v10 0/8] hmp,qmp: Add commands to introspect virtio devices

eature to all 'x-query-virtio' prefixed QMP commands fix odd indentation for qapi/virtio.json device features support for virtio-mem move HMP sub-commands under 'virtio' top level to 'info' top level v8: add assert in virtio_id_to_name() to make sure we're not returning

Re: [PATCH v9 8/8] hmp: add virtio commands

On 11/10/21 08:30, Markus Armbruster wrote: Jonah Palmer writes: From: Laurent Vivier This patch implements the HMP versions of the virtio QMP commands. Signed-off-by: Jonah Palmer --- hmp-commands-info.hx | 218 ++ include/monitor/hmp.h | 5 + monitor

Re: [PATCH v9 7/8] qmp: add QMP command x-query-virtio-queue-element

On 11/10/21 08:52, Markus Armbruster wrote: Jonah Palmer writes: From: Laurent Vivier This new command shows the information of a VirtQueue element. Signed-off-by: Jonah Palmer [...] diff --git a/qapi/virtio.json b/qapi/virtio.json index 0f65044..c57fbc5 100644 --- a/qapi/virtio.json

Re: [PATCH v9 5/8] qmp: decode feature & status bits in virtio-status

On 11/10/21 08:49, Markus Armbruster wrote: Jonah Palmer writes: From: Laurent Vivier Display feature names instead of bitmaps for host, guest, and backend for VirtIODevice. Display status names instead of bitmaps for VirtIODevice. Display feature names instead of bitmaps for backend

Re: [PATCH v9 4/8] qmp: add QMP command x-query-virtio-status

On 11/10/21 08:08, Markus Armbruster wrote: Jonah Palmer writes: From: Laurent Vivier This new command shows the status of a VirtIODevice, including its corresponding vhost device status (if active). Next patch will improve output by decoding feature bits, including vhost device's feature

Re: [PATCH v9 3/8] qmp: add QMP command x-query-virtio

On 11/10/21 07:03, Markus Armbruster wrote: Jonah Palmer writes: From: Laurent Vivier This new command lists all the instances of VirtIODevice with their QOM paths and virtio type/name. Signed-off-by: Jonah Palmer [...] diff --git a/qapi/qapi-schema.json b/qapi/qapi-schema.json index

[PATCH v9 7/8] qmp: add QMP command x-query-virtio-queue-element

From: Laurent Vivier This new command shows the information of a VirtQueue element. Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 9 +++ hw/virtio/virtio.c | 154 + qapi/virtio.json| 177

[PATCH v9 5/8] qmp: decode feature & status bits in virtio-status

red in a separate field. Vhost device field wont show if there's no vhost active for a given VirtIODevice. Signed-off-by: Jonah Palmer --- hw/block/virtio-blk.c | 28 ++ hw/char/virtio-serial-bus.c| 11 + hw/display/virtio-gpu-base.c | 18 +- hw/input/virtio-input.c| 11 +- hw/

[PATCH v9 4/8] qmp: add QMP command x-query-virtio-status

bits of a VirtIODevice. Next patch will also suppress the vhost device field from displaying if no vhost device is active for a given VirtIODevice. Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 5 + hw/virtio/virtio.c | 96 +++ qapi/virtio.json| 246

[PATCH v9 8/8] hmp: add virtio commands

From: Laurent Vivier This patch implements the HMP versions of the virtio QMP commands. Signed-off-by: Jonah Palmer --- hmp-commands-info.hx | 218 ++ include/monitor/hmp.h | 5 + monitor/hmp-cmds.c| 358 ++ 3

[PATCH v9 2/8] virtio: add vhost support for virtio devices

device was active or not. Signed-off-by: Jonah Palmer --- hw/block/vhost-user-blk.c | 7 +++ hw/display/vhost-user-gpu.c| 7 +++ hw/input/vhost-user-input.c| 7 +++ hw/net/virtio-net.c| 9 + hw/scsi/vhost-scsi.c | 8 hw/virtio

[PATCH v9 1/8] virtio: drop name parameter for virtio_init()

in virtio_init(). Signed-off-by: Jonah Palmer --- hw/9pfs/virtio-9p-device.c | 2 +- hw/block/vhost-user-blk.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/char/virtio-serial-bus.c | 4 +-- hw/display/virtio-gpu-base.c

[PATCH v9 0/8] hmp,qmp: Add commands to introspect virtio devices

so I just left it as this.] v9: rebased for upstream (Qemu 6.3) change QMP command prefixes from 'x-debug-virtio' to 'x-query-virtio' add 'unstable' feature to all 'x-query-virtio' prefixed QMP commands fix odd indentation for qapi/virtio.json device features support for vi

[PATCH v9 3/8] qmp: add QMP command x-query-virtio

From: Laurent Vivier This new command lists all the instances of VirtIODevice with their QOM paths and virtio type/name. Signed-off-by: Jonah Palmer --- hw/virtio/meson.build | 2 ++ hw/virtio/virtio-stub.c| 14 hw/virtio/virtio.c | 27

[PATCH v9 6/8] qmp: add QMP commands for virtio/vhost queue-status

From: Laurent Vivier These new commands show the internal status of a VirtIODevice's VirtQueue and a vhost device's vhost_virtqueue (if active). Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 14 +++ hw/virtio/virtio.c | 103 qapi/virtio.json| 250

Re: [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices

On 11/5/21 03:26, Markus Armbruster wrote: Daniel P. Berrangé writes: On Wed, Oct 27, 2021 at 07:41:41AM -0400, Jonah Palmer wrote: This series introduces new QMP/HMP commands to dump the status of a virtio device at different levels. [Jonah: Rebasing previous patchset from Oct. 5 (v7

Re: [PATCH v8 8/8] hmp: add virtio commands

On 11/5/21 03:23, Markus Armbruster wrote: Jonah Palmer writes: From: Laurent Vivier This patch implements the HMP versions of the virtio QMP commands. Signed-off-by: Jonah Palmer --- docs/system/monitor.rst | 2 + hmp-commands-virtio.hx | 250 ++ hmp

Re: [PATCH v8 4/8] qmp: add QMP command x-debug-virtio-status

On 11/4/21 11:37, Markus Armbruster wrote: Jonah Palmer writes: From: Laurent Vivier This new command shows the status of a VirtIODevice, including its corresponding vhost device status (if active). Next patch will improve output by decoding feature bits, including vhost device's feature

Re: [PATCH v8 3/8] qmp: add QMP command x-debug-query-virtio

On 11/4/21 11:15, Markus Armbruster wrote: Jonah Palmer writes: From: Laurent Vivier This new command lists all the instances of VirtIODevice with their QOM paths and virtio type/name. Signed-off-by: Jonah Palmer --- hw/virtio/meson.build | 2 ++ hw/virtio/virtio-stub.c| 14

Re: [PATCH v8 5/8] qmp: decode feature & status bits in virtio-status

On 10/27/21 08:18, Laurent Vivier wrote: On 27/10/2021 13:59, David Hildenbrand wrote: On 27.10.21 13:41, Jonah Palmer wrote: From: Laurent Vivier Display feature names instead of bitmaps for host, guest, and backend for VirtIODevice. Display status names instead of bitmaps for VirtIODevice

Re: [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices

On 10/27/21 07:55, Daniel P. Berrangé wrote: On Wed, Oct 27, 2021 at 07:41:41AM -0400, Jonah Palmer wrote: This series introduces new QMP/HMP commands to dump the status of a virtio device at different levels. [Jonah: Rebasing previous patchset from Oct. 5 (v7). Original patches are from

[PATCH v8 8/8] hmp: add virtio commands

From: Laurent Vivier This patch implements the HMP versions of the virtio QMP commands. Signed-off-by: Jonah Palmer --- docs/system/monitor.rst | 2 + hmp-commands-virtio.hx | 250 ++ hmp-commands.hx | 10 ++ hw/virtio/virtio.c | 355

[PATCH v8 6/8] qmp: add QMP commands for virtio/vhost queue-status

From: Laurent Vivier These new commands show the internal status of a VirtIODevice's VirtQueue and a vhost device's vhost_virtqueue (if active). Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 14 +++ hw/virtio/virtio.c | 103 +++ qapi/virtio.json| 268

[PATCH v8 4/8] qmp: add QMP command x-debug-virtio-status

bits of a VirtIODevice. Next patch will also suppress the vhost device field from displaying if no vhost device is active for a given VirtIODevice. Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 5 + hw/virtio/virtio.c | 96 ++ qapi/virtio.json| 255

[PATCH v8 3/8] qmp: add QMP command x-debug-query-virtio

From: Laurent Vivier This new command lists all the instances of VirtIODevice with their QOM paths and virtio type/name. Signed-off-by: Jonah Palmer --- hw/virtio/meson.build | 2 ++ hw/virtio/virtio-stub.c| 14 ++ hw/virtio/virtio.c | 27 +++ include

[PATCH v8 0/8] hmp,qmp: Add commands to introspect virtio devices

asterisk gives a similar error telling me to change it back to the former representation... so I just left it as this.] v8: add assert in virtio_id_to_name() to make sure we're not returning NULL minor documentation additions to qapi/virtio.json add virtio introspection support for vho

[PATCH v8 7/8] qmp: add QMP command x-debug-virtio-queue-element

From: Laurent Vivier This new command shows the information of a VirtQueue element. Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 9 +++ hw/virtio/virtio.c | 154 qapi/virtio.json| 204

[PATCH v8 2/8] virtio: add vhost support for virtio devices

device was active or not. Signed-off-by: Jonah Palmer --- hw/block/vhost-user-blk.c | 7 +++ hw/display/vhost-user-gpu.c| 7 +++ hw/input/vhost-user-input.c| 7 +++ hw/net/virtio-net.c| 9 + hw/scsi/vhost-scsi.c | 8 hw/virtio

[PATCH v8 5/8] qmp: decode feature & status bits in virtio-status

red in a separate field. Vhost device field wont show if there's no vhost active for a given VirtIODevice. Signed-off-by: Jonah Palmer --- hw/block/virtio-blk.c | 28 ++ hw/char/virtio-serial-bus.c| 11 + hw/display/virtio-gpu-base.c | 18 +- hw/input/virtio-input.c| 11 +- hw/

[PATCH v8 1/8] virtio: drop name parameter for virtio_init()

in virtio_init(). Signed-off-by: Jonah Palmer --- hw/9pfs/virtio-9p-device.c | 2 +- hw/block/vhost-user-blk.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/char/virtio-serial-bus.c | 4 +-- hw/display/virtio-gpu-base.c

Re: [PATCH v7 7/8] qmp: add QMP command x-debug-virtio-queue-element

On 10/7/21 9:27 AM, Eric Blake wrote: On Tue, Oct 05, 2021 at 12:45:52PM -0400, Jonah Palmer wrote: From: Laurent Vivier This new command shows the information of a VirtQueue element. Signed-off-by: Jonah Palmer --- +++ b/qapi/virtio.json +## +# @VirtioRingAvail: +# +# @flags: VRingAvail

Re: [PATCH v7 1/8] virtio: drop name parameter for virtio_init()

On 10/5/21 5:18 PM, Eric Blake wrote: On Tue, Oct 05, 2021 at 12:45:46PM -0400, Jonah Palmer wrote: This patch drops the name parameter for the virtio_init function. The pair between the numeric device ID and the string device ID (name) of a virtio device already exists, but not in a way

[PATCH v7 3/8] qmp: add QMP command x-debug-query-virtio

From: Laurent Vivier This new command lists all the instances of VirtIODevice with their QOM paths and virtio type/name. Signed-off-by: Jonah Palmer --- hw/virtio/meson.build | 2 ++ hw/virtio/virtio-stub.c| 14 ++ hw/virtio/virtio.c | 27 +++ include

[PATCH v7 5/8] qmp: decode feature & status bits in virtio-status

red in a separate field. Vhost device field wont show if there's no vhost active for a given VirtIODevice. Signed-off-by: Jonah Palmer --- hw/block/virtio-blk.c | 28 ++ hw/char/virtio-serial-bus.c| 11 + hw/display/virtio-gpu-base.c | 18 +- hw/input/virtio-input.c| 11 +- hw/

[PATCH v7 8/8] hmp: add virtio commands

From: Laurent Vivier This patch implements the HMP versions of the virtio QMP commands. Signed-off-by: Jonah Palmer --- docs/system/monitor.rst | 2 + hmp-commands-virtio.hx | 250 ++ hmp-commands.hx | 10 ++ hw/virtio/virtio.c | 355

[PATCH v7 2/8] virtio: add vhost support for virtio devices

device was active or not. Signed-off-by: Jonah Palmer --- hw/block/vhost-user-blk.c | 7 +++ hw/display/vhost-user-gpu.c| 7 +++ hw/input/vhost-user-input.c| 7 +++ hw/net/virtio-net.c| 9 + hw/scsi/vhost-scsi.c | 8 hw/virtio

[PATCH v7 4/8] qmp: add QMP command x-debug-virtio-status

bits of a VirtIODevice. Next patch will also suppress the vhost device field from displaying if no vhost device is active for a given VirtIODevice. Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 5 + hw/virtio/virtio.c | 96 +++ qapi/virtio.json| 245

[PATCH v7 6/8] qmp: add QMP commands for virtio/vhost queue-status

From: Laurent Vivier These new commands show the internal status of a VirtIODevice's VirtQueue and a vhost device's vhost_virtqueue (if active). Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 14 +++ hw/virtio/virtio.c | 103 +++ qapi/virtio.json| 262

[PATCH v7 7/8] qmp: add QMP command x-debug-virtio-queue-element

From: Laurent Vivier This new command shows the information of a VirtQueue element. Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 9 +++ hw/virtio/virtio.c | 154 ++ qapi/virtio.json| 191

[PATCH v7 0/8] hmp,qmp: Add commands to introspect virtio devices

x": 2936, "flags": 0 } } } [Jonah - Comments: Note: for patch 8/8, checkpatch.pl gives the following error: ERROR: spaces required around that '*' (ctx:WxV) #374: FILE: hw/virtio/virtio.c:4107: type##Feature

[PATCH v7 1/8] virtio: drop name parameter for virtio_init()

in virtio_init(). Signed-off-by: Jonah Palmer --- hw/9pfs/virtio-9p-device.c | 2 +- hw/block/vhost-user-blk.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/char/virtio-serial-bus.c | 4 +-- hw/display/virtio-gpu-base.c

<    1   2   3   >