malc av1...@comtv.ru writes:
On Mon, 7 Dec 2009, Markus Armbruster wrote:
malc av1...@comtv.ru writes:
On Mon, 30 Nov 2009, Markus Armbruster wrote:
Commit a7d27b53 made zero-sized allocations a fatal error, deviating
from ISO C's malloc() friends. Revert that, but take care never
Anthony Liguori anth...@codemonkey.ws writes:
Markus Armbruster wrote:
Commit a7d27b53 made zero-sized allocations a fatal error, deviating
from ISO C's malloc() friends. Revert that, but take care never to
return a null pointer, like malloc() friends may do (it's
implementation defined),
Split out pci device initialization from pc_init1() into pc_pci_device_init().
and removed unnecessary braces.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 35 +++
1 files changed, 19 insertions(+), 16 deletions(-)
diff --git a/hw/pc.c
This time, I fixed up the patch series.
- fixed up copyright notice.
- make rtc_xxx functions accept/return ISADevice.
- move up ioapic initalization patch.
Although Gerd suggested to use DeviceState, I used ISADevice.
Gerd, do you want me to use DeviceState instead of ISADevice?
patch
By introducing a registering function, make pc_init1() not refer to
ferr_irq directly in order to make ferr_irq piix independent.
Later pc_init1() will be split out into another file keeping ferr_irq
static.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c |8 +++-
add acpi constants from linux header files and
replace the old constants with them.
The acpi constants will be used by other file.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/acpi.c | 56 +++
hw/acpi.h | 78
Remove unnecessary reference to a global variable, RTCState *rtc_state,
by passing it as function argument.
Only the cmos_set_s3_resume_init() needs it global.
So introduce a registering function and use it.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Cc: Paolo Bonzini bonz...@gnu.org
make cpu_smm_update() generic to be independent on i440fx by
registering a callback.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 18 +++---
hw/pc.h |8 +++-
hw/piix_pci.c |5 -
3 files changed, 26 insertions(+), 5 deletions(-)
Move rtc_xxx declarations from pc.h into mc146818rtc.h.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/mc146818rtc.h | 10 ++
hw/pc.h | 10 ++
2 files changed, 12 insertions(+), 8 deletions(-)
create mode 100644 hw/mc146818rtc.h
diff --git
remove unnecessary global static variables, pit.
Make it local.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index fc7ee8a..c728486 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -66,7 +66,6 @@
Introduce a function, pc_allocate_cpu_irq(), to allocate cpu irq
in order to make pic_irq_request() piix independent.
Later piix code will be split out to another file keeping pic_irq_request()
static.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c |7 ++-
1 files
Split out memory allocation and rom/bios loading which doesn't depend
on piix from pc_init1() into pc_memory_init().
Later it will be used.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 67 +++---
1 files changed, 42
The changeset of 2c8d9340203c7f19265fd4cb2341f568217a3af6
prevents isa_irq_handler() from NULL refering of IsaIrqState::ioapic.
However it would be better to initialize the member before reference.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c |6 +++---
1 files changed, 3
remove unused variable in get_pmsts().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/acpi_piix4.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index 53efa2a..887c82f 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@
split out cpu initialization which is piix independent from pc_init1()
into pc_cpus_init(). Later it will be used.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 32 +++-
1 files changed, 19 insertions(+), 13 deletions(-)
diff --git a/hw/pc.c
To match rtc_xxx with qdev, make rtc_xxx accept and return ISADevice
instead of RTCState.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/mc146818rtc.c | 26 +++---
hw/mc146818rtc.h |8
hw/mips_jazz.c |1 +
hw/mips_malta.c |3 ++-
Split out basic device, i.e. legacy devices like floppy, initialization
from pc_init1() into pc_basic_device_init().
Later it will be used.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 89 +++---
1 files changed, 50
On 12/07/2009 04:06 PM, Anthony Liguori wrote:
For GPFS-like shared filesystems (:-P) we would always use lock=off. It
wouldn't protect us from a non-cluster aware writer.
Management tools can always do this the right way---even with
partition-grained locking if needed.
Paolo
Split out pc smbus routines from acpi.c into pc_smbus.c and
use it.
The split out smbus emulation will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Makefile.target |2 +
hw/acpi.c | 164 +++
hw/pc_smbus.c |
Split acpi.c into the common part and the piix4 specific part.
The common part will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Makefile.target |4 +-
hw/acpi.c | 557 ---
hw/{acpi.c =
Am 07.12.2009 18:09, schrieb malc:
On Mon, 7 Dec 2009, Anthony Liguori wrote:
malc wrote:
Does anyone object to this moving forward?
Yeah, i object to the split production/development qemu_malloc[z].
It's clear to me that there are still improper callers of qemu_malloc() in
Hi,
Doesn't make sense. The list is not about *creating* default devices, but
about *not* creating them.
Why do we need a negative list? Wouldn't it be a lot more useful to have
positive lists? Maybe I'm just missing the whole point of your patchset though.
Probably the latter ;)
The
Am 07.12.2009 15:53, schrieb Anthony Liguori:
Daniel P. Berrange wrote:
It is safe if you assume that no one else has tried to modify the disk
since you opened it, otherwise you'd be commiting changes against a
base state which no longer exists.
1) first user opens cow1.qcow, acquires
Rusty Russell ru...@rustcorp.com.au wrote on 12/08/2009 07:48:00 AM:
Avishay; this would be the total sectors in an I/O, as separate from
SIZE_MAX
(maximum size of any single scatterlist entry) and SEG_MAX (maximum
number of
scatterlist entries)?
Correct. In the guest virtblk driver, it
On 12/08/2009 11:44 AM, Avishay Traeger1 wrote:
Thanks!
Rusty.
Sure. Avi - do you want me to resubmit the kvm and qemu patches?
You mean the virtio and qemu patches. That's up to their maintainers
(Rusty and Anthony).
--
error compiling committee.c: too many arguments to
Am 07.12.2009 15:16, schrieb Richard W.M. Jones:
Here's a second go at this patch. The only change is that we add a
second parameter (backinglock=none|shared|exclusive) which can be used
to control locking on the first level (only) of backing disk.
And what about the backing file of the
Am 07.12.2009 15:31, schrieb Richard W.M. Jones:
On Mon, Dec 07, 2009 at 08:22:24AM -0600, Anthony Liguori wrote:
Richard W.M. Jones wrote:
On Mon, Dec 07, 2009 at 07:39:11AM -0600, Anthony Liguori wrote:
Richard W.M. Jones wrote:
Also if we only acquire the lock during the commit
On Tue, Dec 08, 2009 at 10:48:17AM +0100, Kevin Wolf wrote:
Am 07.12.2009 15:31, schrieb Richard W.M. Jones:
So to be clear, the use case is that all the other VMs must be shut
down, then the VM which wants to commit will upgrade its lock and
commit, and then all the other VMs will restart?
On Tue, 8 Dec 2009, Markus Armbruster wrote:
malc av1...@comtv.ru writes:
[..snip..]
glibc frees since 1999. From glibc/ChangeLog.10:
1999-04-28 Andreas Jaeger a...@arthur.rhein-neckar.de
* malloc/malloc.c (REALLOC_ZERO_BYTES_FREES): Define it to follow
ISO C9x and
On Tue, Dec 08, 2009 at 11:00:17AM +0100, Kevin Wolf wrote:
Am 07.12.2009 15:16, schrieb Richard W.M. Jones:
Here's a second go at this patch. The only change is that we add a
second parameter (backinglock=none|shared|exclusive) which can be used
to control locking on the first level
On 12/07/09 19:34, Daniel P. Berrange wrote:
On Sun, Dec 06, 2009 at 04:43:03PM -0600, Anthony Liguori wrote:
It can be downloaded from Savannah at:
http://download.savannah.gnu.org/releases/qemu/qemu-0.12.0-rc1.tar.gz
Please send testing feedback (positive or negative) to qemu-devel and
On 12/07/09 22:54, Anthony Liguori wrote:
Daniel P. Berrange wrote:
SCSI controllers have no trouble existing without any attached
disks. This could be achieved with the (legacy) monitor syntax
pci_add pci_addr=auto storage if=scsi
This is now denied with
scsi requires a backing file/device.
On Tue, Dec 08, 2009 at 11:40:54AM +0100, Gerd Hoffmann wrote:
On 12/07/09 19:34, Daniel P. Berrange wrote:
On Sun, Dec 06, 2009 at 04:43:03PM -0600, Anthony Liguori wrote:
It can be downloaded from Savannah at:
http://download.savannah.gnu.org/releases/qemu/qemu-0.12.0-rc1.tar.gz
On Mon, 7 Dec 2009 21:36:58 +0100
Markus Armbruster arm...@redhat.com wrote:
This patch series converts monitor commands eject, change, closefd,
getfd to QError.
Thanks a lot for this work.
Although the series is already merged, I have some comments and will
reply the patches.
On Mon, 7 Dec 2009 21:37:10 +0100
Markus Armbruster arm...@redhat.com wrote:
+#define QERR_FD_NOT_FOUND \
+{ 'class': 'fd_not_found', 'data': { 'name': %s } }
+
I think this came from your previous series of not using CamelCase?
Also happens in next patches..
On Mon, 7 Dec 2009 21:37:16 +0100
Markus Armbruster arm...@redhat.com wrote:
-{ error: { class: json-string, data: json-value }, id: json-value }
+{ error: { class: json-string, data: json-value, desc: json-string },
+ id: json-value }
Where,
- The class member contains the error
Hi,
Qemu creates a bunch of default devices (serial, parallel, vga, ...) if
the user didn't specify one on the command line. Unfortunaly this
doesn't work well with the qdev way of doing things because this logic
is tied to the -serial, -parallel, ... command line switches. Devices
created
i.e. -global PCI.property=value will set a default property for all
PCI devices. Also works for the compat properties used by machine
types.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/qdev-properties.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git
The patch decuples the -chardev switch and the actual chardev
initialization. Without this patch qemu ignores chardev entries
coming via -readconfig.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
vl.c | 16 +---
1 files changed, 13 insertions(+), 3 deletions(-)
diff --git
This patch renames the compat properties into global properties and
makes them more generic. The compatibility stuff is only one of
multiple possible users now.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/boards.h |2 +-
hw/pc.c |2 +-
Make the 'vc' chardev backend print a title line with the chardev name
after initialization, using CharDriverState-label.
This replaces the banner printing code in vl.c.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
console.c |8
vl.c | 24
2
This reverts commit 93d434b4aec0702b87ebf52449a3cdf2c3596825.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
vl.c | 26 --
1 files changed, 0 insertions(+), 26 deletions(-)
diff --git a/vl.c b/vl.c
index 11eda45..172828a 100644
--- a/vl.c
+++ b/vl.c
@@ -4720,20
This patch adds infrastructure and command line option for setting
global defaults for device properties, i.e. you can for example use
-global virtio-blk-pci.vectors=0
to turn off msi by default for all virtio block devices. The config
file syntax is:
[global]
driver = virtio-blk-pci
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
console.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/console.c b/console.c
index 2aeb5b3..8086bd6 100644
--- a/console.c
+++ b/console.c
@@ -1388,8 +1388,10 @@ static void text_console_do_init(CharDriverState *chr,
Qemu creates a default serial line for you in case you didn't specify
one on the command line. Right now this is tied to the '-serial
chardev' command line switch, which in turn causes trouble if you are
creating your serial line via '-device isa-serial,props'.
This patch adds a variable
Add global command line option to disable default devices.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
qemu-options.hx |5 +
vl.c|6 ++
2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 420b7d8..e05b2a0
Qemu creates a default parallel port for you in case you didn't specify
one on the command line. Right now this is tied to the '-parallel
chardev' command line switch, which in turn causes trouble if you are
creating your parallel port via '-device isa-parallel,props'.
This patch adds a variable
The logic in this code obviously predates the multiple monitor
capability of qemu and looks increasingly silly these days.
I think the intention of this piece of code is to get a reasonable
default for the -nographic case: have monitor and serial line muxed
on stdio.
With the new default_serial
This patch makes the monitor default device configuration work like the
default serial and parallel port devices. It adds a variable
default_monitor which says whenever a default monitor should be added.
It is enabled by default. It is cleared when qemu finds '-monitor' on
the command line.
Qemu creates a vga display for you in case you didn't specify one on the
command line. Right now this is tied to the '-vga type' command line
switch, which in turn causes trouble if you are creating your gfx card
using '-device VGA,props'.
This patch adds a variable default_vga which says
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
qemu-char.c |2 +-
qemu-char.h |1 +
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index da5c15c..c6008c3 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2231,7 +2231,7 @@ static CharDriverState
Add -mon switch which maps pretty straight forward into the QemuOpts
internal representation:
-mon chardev=name[,mode=[control|readline]][,[no]default]
Via config file:
[mon]
chardev = name
mode = readline
default = on
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
Add a default_net variable which specified whenever a default network
should be created. It is cleared in case any -net option is specified
and it is also added to the new -nodefaults switch.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
net.c |5 -
net.h |1 +
vl.c |1 +
This patch adds a variable default_virtcon which says whenever a default
virtio console should be added. It is disabled by default, followup
patch will enable it for s390. It is cleared when qemu finds
'-virtiocon', '-device virtio-console-s390' or '-device
virtio-console-pci' on the command
All normal system emulation targets in qemu I'm aware of display
output on either VGA or serial output.
Our S390x virtio machine doesn't have such kind of legacy hardware. So
instead we need to default to a virtio console.
Add flags to QEMUMachine to indicate which kind of default devices make
Acts like -monitor but switched into qmp mode.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
qemu-options.hx |2 ++
vl.c| 14 +-
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 7234447..b8cc375 100644
---
Add a default_drive variable which specified whenever the default drives
(cdrom, floppy, sd) should be created. It is cleared when the new
-nodefaults switch is specified on the command line.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
vl.c | 16 ++--
1 files changed, 10
This patch reworks the -monitor handling:
- It adds a new mon QemuOpts list for the monitor(s).
- It adds a monitor_parse() function to parse the -monitor switch.
- It adds a mon_init function to initialize the monitor(s) from the
mon QemuOpts list.
- It winds up everything and removes the
On Tue, Dec 08, 2009 at 10:11:48AM -0200, Luiz Capitulino wrote:
On Mon, 7 Dec 2009 21:37:16 +0100
Markus Armbruster arm...@redhat.com wrote:
-{ error: { class: json-string, data: json-value }, id: json-value }
+{ error: { class: json-string, data: json-value, desc: json-string
},
+
Luiz Capitulino lcapitul...@redhat.com writes:
On Mon, 7 Dec 2009 21:37:10 +0100
Markus Armbruster arm...@redhat.com wrote:
+#define QERR_FD_NOT_FOUND \
+{ 'class': 'fd_not_found', 'data': { 'name': %s } }
+
I think this came from your previous series of not using CamelCase?
Also
Commits c7c338c4, 41471a23, 7a046f5f and a488be27 used
lower_case_with_underscores for class values. Existing usage
CamelCase. ChangeToThatForConsistency.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
qerror.h |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff
On 12/08/2009 01:11 PM, Luiz Capitulino wrote:
Not to mention that those strings can't be modified when the protocol
becomes stable and we're probably talking about dozens if not a hundred
of strings.
I would say that there is _explicitly no promise_ of keeping these
stable. You can serve
On 12/07/2009 01:42 PM, Gerd Hoffmann wrote:
Add global command line option to disable default devices.
Should -readconfig imply this?
Paolo
Luiz Capitulino lcapitul...@redhat.com writes:
On Mon, 7 Dec 2009 21:37:16 +0100
Markus Armbruster arm...@redhat.com wrote:
-{ error: { class: json-string, data: json-value }, id: json-value }
+{ error: { class: json-string, data: json-value, desc: json-string
},
+ id: json-value }
On 12/08/09 11:52, Daniel P. Berrange wrote:
On Tue, Dec 08, 2009 at 11:40:54AM +0100, Gerd Hoffmann wrote:
worked as in guest actually sees the new device (without reboot) or
worked as in qemu didn't abort ?
The latter. The guest does not see it, but it at least does not abort.
It is the
Paolo Bonzini pbonz...@redhat.com writes:
On 12/08/2009 01:11 PM, Luiz Capitulino wrote:
Not to mention that those strings can't be modified when the protocol
becomes stable and we're probably talking about dozens if not a hundred
of strings.
I would say that there is _explicitly no
On 12/08/09 13:52, Gerd Hoffmann wrote:
The latter. The guest does not see it, but it at least does not abort.
It is the 'does not abort' behaviour I'm interested in - quite OK with
this returning an error to the monitor client when acpi is disabled.
Does the attached patch fix it for you?
Luiz Capitulino wrote:
On Mon, 7 Dec 2009 21:37:16 +0100
Markus Armbruster arm...@redhat.com wrote:
-{ error: { class: json-string, data: json-value }, id: json-value }
+{ error: { class: json-string, data: json-value, desc: json-string },
+ id: json-value }
Where,
- The class
On hosts without high-res timers it is impossible to inject rtc interrupt
faster then 1kHz. Windows sometimes configures RTC to generate 1kHz
interrupts, so we can't inject missed interrupts when running on such
hosts. Always injecting an interrupt on REG_C read is also not an option
since Windows
The disk image I created from my old laptop disk with VBoxManage
internalcommand converthd obviously was not a multiple of 1MB as when
created from scratch. This fixes QEMU refusing it. We still require the
size to be a multiple of sector size though.
It then boots correctly.
Signed-off-by:
Luiz Capitulino lcapitul...@redhat.com writes:
On Tue, 8 Dec 2009 12:25:13 +
Daniel P. Berrange berra...@redhat.com wrote:
On Tue, Dec 08, 2009 at 10:11:48AM -0200, Luiz Capitulino wrote:
On Mon, 7 Dec 2009 21:37:16 +0100
Markus Armbruster arm...@redhat.com wrote:
-{ error: {
Am 07.12.2009 16:00, schrieb Kevin Wolf:
Am 07.12.2009 15:16, schrieb Jan Kiszka:
Likely not. What I did was nothing special, and I did not noticed such a
crash in the last months.
And now it happened again (qemu-kvm head, during kernel installation
from network onto local qcow2-disk). Any
On Tue, 8 Dec 2009 12:25:13 +
Daniel P. Berrange berra...@redhat.com wrote:
On Tue, Dec 08, 2009 at 10:11:48AM -0200, Luiz Capitulino wrote:
On Mon, 7 Dec 2009 21:37:16 +0100
Markus Armbruster arm...@redhat.com wrote:
-{ error: { class: json-string, data: json-value }, id:
On 12/08/09 13:46, Paolo Bonzini wrote:
On 12/07/2009 01:42 PM, Gerd Hoffmann wrote:
Add global command line option to disable default devices.
Should -readconfig imply this?
Hmm, not sure. Why do you think this would be useful?
cheers,
Gerd
This patchset adds MIPS16 support to the MIPS backend. MIPS16 is a
compact encoding of a subset of the MIPS integer instructions, similar
to ARM's Thumb mode. Mode switching occurs when either a special
instruction (JALX) is executed, or when a jump-to-register instruction
is executed; the
As promised, here is my small writeup on which setups I feel
are important in the long run for server-type guests. This
does not cover -net user, which is really for desktop kinds
of applications where you do not want to connect into the
guest from another IP address.
I can see four separate
On Wed, Nov 25, 2009 at 12:33:03AM +0100, Jan Kiszka wrote:
This patch extends the qemu-kvm state sync logic with support for
KVM_GET/SET_VCPU_EVENTS, giving access to yet missing exception,
interrupt and NMI states.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
kvm-all.c
Add global command line option to disable default devices.
Should -readconfig imply this?
Hmm, not sure. Why do you think this would be useful?
Here is my thinking: if you used -writeconfig, your machine description
is (at least in theory) entirely included in the config file including
Signed-off-by: Nathan Froyd froy...@codesourcery.com
---
target-mips/translate_init.c | 27 ++-
1 files changed, 18 insertions(+), 9 deletions(-)
diff --git a/target-mips/translate_init.c b/target-mips/translate_init.c
index c950eab..6f50555 100644
---
We need to stash the operating mode into the low bit of the error PC and
restore it on return from interrupts.
Signed-off-by: Nathan Froyd froy...@codesourcery.com
---
target-mips/helper.c| 51 +++---
target-mips/op_helper.c | 17 --
2
The only thing to do here is to expose the current processor mode to GDB
and to set the processor mode properly when we change the PC.
Signed-off-by: Nathan Froyd froy...@codesourcery.com
---
gdbstub.c | 18 +++---
1 files changed, 15 insertions(+), 3 deletions(-)
diff --git
Marcelo Tosatti wrote:
On Wed, Nov 25, 2009 at 12:33:03AM +0100, Jan Kiszka wrote:
This patch extends the qemu-kvm state sync logic with support for
KVM_GET/SET_VCPU_EVENTS, giving access to yet missing exception,
interrupt and NMI states.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
The following fixes a class of long-standing bugs in qemu:
when kvm is enabled, guest might access device structures
in memory while they are updated by qemu on another CPU.
In this scenario, memory barriers are necessary to prevent
host CPU from reordering memory accesses, which might confuse
the
With qemu-kvm and with iothread, guest might read in-memory structures
on one host CPU while it is being updated on another one, and vice
versa. Therefore we must use memory barriers to ensure proper memory
read/write ordering.
The following implements memory barriers with API matching
that of
include barriers.h and remove a non-portable
wmb implementation from virtio.c (it will work
for intel but not for other architectures).
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/virtio.c | 10 +-
1 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/hw/virtio.c
Add missing memory barriers in virtio:
- before checking interrupt enabled bit, make sure
data has been written to memory
- make sure ring index has been read before reading ring data
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/virtio.c |8 +++-
1 files changed, 7
On Tue, Dec 08, 2009 at 11:11:29AM -0500, Paolo Bonzini wrote:
Add global command line option to disable default devices.
Should -readconfig imply this?
Hmm, not sure. Why do you think this would be useful?
Here is my thinking: if you used -writeconfig, your machine description
On 12/08/09 17:11, Paolo Bonzini wrote:
Add global command line option to disable default devices.
Should -readconfig imply this?
Hmm, not sure. Why do you think this would be useful?
Here is my thinking: if you used -writeconfig, your machine description
is (at least in theory) entirely
Here is my thinking: if you used -writeconfig, your machine description
is (at least in theory) entirely included in the config file including
(again in theory) the default devices.
The default devices are *not* included by in the file created by
-writeconfig.
Yes, that's why I wrote
We create separate masks for the basic branch hflags and the
extended branch hflags and define MIPS_HFLAG_BMASK as the logical or
of those two. This is done to avoid churning the codebase in lots of
different places.
We also make the execution mode an hflag under MIPS_HFLAG_TMASK
Signed-off-by:
There's no good way to add this incrementally, so we do it all at once.
The only changes to shared code are in handle_delay_slot. We need to
flip ISAMode when doing a jump-and-exchange. We also need to set
ISAMode the low bit of the target address for jump-to-register.
Also, since we're now
As KVM now makes use of exception_index to keep pending exceptions, we
have to saverestore this field as well.
NOTE: We have to nail the arch-independent exception_index down to a
certain bit width for proper vmstate processing, namely to 32 bit.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
This is a common pattern in existing code. We'll also use it to
implement the mips16 SAVE/RESTORE instructions.
Signed-off-by: Nathan Froyd froy...@codesourcery.com
---
target-mips/translate.c | 40
1 files changed, 16 insertions(+), 24 deletions(-)
Also cross off mips16 ASE in TODO.
Signed-off-by: Nathan Froyd froy...@codesourcery.com
---
target-mips/TODO|1 -
target-mips/translate.c |1 +
2 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-mips/TODO b/target-mips/TODO
index 4769e2a..9101881 100644
---
In order to support macvtap, we need a way to select the actual
tap endpoint. While it would be nice to pass it by network interface
name, passing the character device is more flexible, and we can
easily do both in the long run.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
diff --git a/net.c
This is a common pattern in existing code. We'll also use it to
implement the mips16 SAVE/RESTORE instructions.
Signed-off-by: Nathan Froyd froy...@codesourcery.com
---
Argh, please use this one instead; the arguments passed to
gen_op_addr_add in gen_base_offset_addr are in the proper order.
Signed-off-by: Nathan Froyd froy...@codesourcery.com
---
target-mips/translate.c | 15 ---
1 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/target-mips/translate.c b/target-mips/translate.c
index d403c56..3751516 100644
--- a/target-mips/translate.c
+++
migrating between hosts which have different features
might break silently, if the migration destination
does not support some features supported by source.
Prevent this from happening by comparing acked feature
bits with the mask supported by the device.
Signed-off-by: Michael S. Tsirkin
On Tue, 8 Dec 2009 13:11:32 +0100
Gerd Hoffmann kra...@redhat.com wrote:
New in v4:
* Rebased against latest master.
* Moved the included fixes from (yesterdays) staging to the head
of this series.
* Fixed segfault without -monitor switch.
* Killed noisy debug leftover.
* Replaced
On Tue, Dec 8, 2009 at 4:35 PM, Pierre Riteau pierre.rit...@irisa.fr wrote:
On 1 oct. 2009, at 18:13, Blue Swirl wrote:
On Thu, Oct 1, 2009 at 6:30 PM, G 3 programmingk...@gmail.com wrote:
On Sep 30, 2009, at 3:16 PM, Anthony Liguori wrote:
G 3 wrote:
This patch fixes a problem in the file
1 - 100 of 108 matches
Mail list logo
