[Qemu-devel] KVM call agenda for Mar 16

2010-03-16 Thread Chris Wright
Please send in any agenda items you are interested in covering. thanks, -chris

[Qemu-devel] [trivial one-liner] be more specific in -mem-path error messages

2010-03-16 Thread Michael Tokarev
The error message qemu gives when hugetlbfs is not accessible is cryptic at best: mkstemp: Permission denied Make it a bit more specific instead: unable to create backing store for hugepages: Permission denied Thanks! /mjt diff --git a/exec.c b/exec.c index 891e0ee..985bdde 100644 ---

[Qemu-devel] Re: [PATCH, RFC] Replace assert(0) with abort() or cpu_abort()

2010-03-16 Thread Paolo Bonzini
On 03/15/2010 07:36 PM, Markus Armbruster wrote: Please don't tell me that user emulators make abort() return. abort() is declared __noreturn__, and the optimizer may well rely on that. If the user programs make a signal (SIGABRT, SIG_IGN) call, I suppose abort() will return. Paolo

Re: [Qemu-devel] Re: [PATCH, RFC] Replace assert(0) with abort() or cpu_abort()

2010-03-16 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: On 03/15/2010 07:36 PM, Markus Armbruster wrote: Please don't tell me that user emulators make abort() return. abort() is declared __noreturn__, and the optimizer may well rely on that. If the user programs make a signal (SIGABRT, SIG_IGN) call, I

[Qemu-devel] [PATCH -v2 02/22] vrtio-9p: Implement P9_TVERSION for 9P

2010-03-16 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com [ki...@linux.vnet.ibm.com: malloc to qemu_malloc coversion] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 263

[Qemu-devel] [PATCH -v2 01/22] vitio-9p: Add a virtio 9p device to qemu

2010-03-16 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com This patch doesn't implement the 9p protocol handling code. It add a simple device which dump the protocl data Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- Makefile.target |

[Qemu-devel] [PATCH -V2 00/22] virtio-9p: paravirtual file system passthrough

2010-03-16 Thread Aneesh Kumar K.V
Hi, This patch series adds a paravirtual file system passthrough mechanism to QEMU based on the 9P protocol. With the current implementation, all I/O is implemented in the VCPU thread. We've modified the protocol handlers so that we can support dispatch I/O in a thread pool. The actual thread

[Qemu-devel] [PATCH -v2 03/22] virtio-9p: Implement P9_TATTACH

2010-03-16 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com [jv...@linux.vnet.ibm.com: Added qemu_vasprintf] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- Makefile.target |2 +- hw/virtio-9p-local.c | 84

[Qemu-devel] [PATCH -v2 04/22] virtio-9p: Implement P9_TSTAT

2010-03-16 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com This get the mount to work on the guest [ki...@linux.vnet.ibm.com: malloc to qemu_malloc conversion] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Gautham R Shenoy e...@in.ibm.com Signed-off-by: Aneesh Kumar K.V

[Qemu-devel] [PATCH -v2 08/22] virtio-9p: Implement P9_TCLUNK

2010-03-16 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com This patch gets ls -al to work Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH -v2 05/22] virtio-9p: Implement P9_TWALK

2010-03-16 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Gautham R Shenoy e...@in.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p-local.c | 12 +++ hw/virtio-9p.c | 219

[Qemu-devel] [PATCH -v2 09/22] virtio-9p: Implement P9_TWRITE

2010-03-16 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com This gets write to file to work Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p-local.c |7

[Qemu-devel] [PATCH -v2 06/22] virtio-9p: Implement P9_TOPEN

2010-03-16 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Gautham R Shenoy e...@in.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p-local.c | 12 hw/virtio-9p.c | 145

[Qemu-devel] [PATCH -v2 07/22] virtio-9p: Implement P9_TREAD

2010-03-16 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p-local.c | 37 hw/virtio-9p.c | 253

[Qemu-devel] [PATCH -v2 11/22] virtio-9p: Implement P9_TWSTAT

2010-03-16 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com This gets file and directory creation to work [jv...@linux.vnet.ibm.com: strdup to qemu_strdup conversion] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Gautham R Shenoy e...@in.ibm.com Signed-off-by: Aneesh Kumar K.V

[Qemu-devel] [PATCH -v2 14/22] virtio-9p: Add multiple mount point support

2010-03-16 Thread Aneesh Kumar K.V
This patch add a mount tag name in 9p config space. This tag should uniquely identify the mount point and should be used in the mount command as the device name Qemu command line for specifying 9p share directory now becomes -device virtio-9p-pci,share_path=/mnt/,mount_tag=v_mnt -device

[Qemu-devel] [PATCH -v2 18/22] virtio-9p: Fix sg usage in the code

2010-03-16 Thread Aneesh Kumar K.V
sg list contain more than one element and we need to use the right element when we are doing the marshaling and unmarshaling of data. This patch also abstract out the pack/unpack interface and make sure we use one function for doing both. Signed-off-by: Aneesh Kumar K.V

[Qemu-devel] [PATCH -v2 12/22] virtio-9p: Implement P9_TREMOVE

2010-03-16 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com This gets file deletion to work [mo...@in.ibm.com: Fix truncate to use the relative path] Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Gautham R Shenoy e...@in.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com

[Qemu-devel] [PATCH -v2 17/22] Implement sync support in 9p server

2010-03-16 Thread Aneesh Kumar K.V
From: M. Mohan Kumar mo...@in.ibm.com When wstat is called with stat field values set to 'don't touch' pattern, 9p Server interprets it as a request to guarantee that the contents of the associated file are committed to stable storage before the Rwstat message is returned. Implement this feature

[Qemu-devel] [PATCH -v2 21/22] virtio-9p: Remove unnecessary definition of fid

2010-03-16 Thread Aneesh Kumar K.V
We already have fid as a part of V9fsFidState so use that instead of defining another variable Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Reviewed-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- hw/virtio-9p.c | 62

[Qemu-devel] [PATCH -v2 22/22] virtio-9p: Update existing fid path on rename

2010-03-16 Thread Aneesh Kumar K.V
We need to make sure that we update the path component of the existing fid's when we rename a file. The client is not expected to clunk these fids pointing to the old name. If we don't update any operation on the old unopened fid will point to the old name and will fail Add BUG_ON to make sure

[Qemu-devel] [PATCH -v2 15/22] virtio-9p: Use little endian format on virtio

2010-03-16 Thread Aneesh Kumar K.V
We need to use platform independent data format as part of protocol data. 9P uses little endian format on wire Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 34 +++--- 1 files changed, 23 insertions(+), 11 deletions(-) diff

[Qemu-devel] [PATCH -v2 19/22] virtio-9p: Get the correct count values from the pdu

2010-03-16 Thread Aneesh Kumar K.V
From: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com PDU contain little endian format for integer values. So we need to make sure we map them to host format. Also the count value can be in another sg offset other than 0. Use the righ functions to get the count value Signed-off-by:

[Qemu-devel] [PATCH -v2 20/22] virtio-9p: Remove BUG_ON and add proper error handling

2010-03-16 Thread Aneesh Kumar K.V
Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 106 1 files changed, 84 insertions(+), 22 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index 1237bac..3ce26ca 100644 --- a/hw/virtio-9p.c

[Qemu-devel] [PATCH -v2 13/22] virtio-9p: Implement P9_TFLUSH

2010-03-16 Thread Aneesh Kumar K.V
From: Anthony Liguori aligu...@us.ibm.com Don't do anything special for flush Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] Re: KVM call agenda for Mar 16

2010-03-16 Thread Juan Quintela
Chris Wright chr...@redhat.com wrote: Please send in any agenda items you are interested in covering. Migration: - flexible migration: I hope to sent an RFC patch on time for the call. idea is to use subsections. - callbacks. block migration introduced several callbacks: * cancel() *

Re: [Qemu-devel] [PATCH] block: add logical_block_size property

2010-03-16 Thread Christoph Hellwig
ping? On Thu, Mar 04, 2010 at 02:20:17PM +0100, Christoph Hellwig wrote: Add a logical block size attribute as various guest side tools only increase the filesystem sector size based on it, not the advisory physical block size. For scsi we already have support for a different logical

[Qemu-devel] Re: KVM call agenda for Mar 16

2010-03-16 Thread Daniel P. Berrange
On Tue, Mar 16, 2010 at 10:18:03AM +0100, Juan Quintela wrote: Chris Wright chr...@redhat.com wrote: Please send in any agenda items you are interested in covering. Migration: - flexible migration: I hope to sent an RFC patch on time for the call. idea is to use subsections. -

[Qemu-devel] Re: [PATCH 1/7] Add support for generic notifier lists (v2)

2010-03-16 Thread Avi Kivity
On 03/15/2010 10:34 PM, Anthony Liguori wrote: Notifiers are data-less callbacks and a notifier list is a list of registered notifiers that all are interested in a particular event. We'll use this in a few patches to implement mouse change notification. Looks nicer lighter! -- error

[Qemu-devel] Re: KVM call agenda for Mar 16

2010-03-16 Thread Avi Kivity
On 03/16/2010 11:29 AM, Daniel P. Berrange wrote: On Tue, Mar 16, 2010 at 10:18:03AM +0100, Juan Quintela wrote: Chris Wrightchr...@redhat.com wrote: Please send in any agenda items you are interested in covering. Migration: - flexible migration: I hope to sent an RFC

[Qemu-devel] Re: KVM call agenda for Mar 16

2010-03-16 Thread Daniel P. Berrange
On Tue, Mar 16, 2010 at 09:29:44AM +, Daniel P. Berrange wrote: On Tue, Mar 16, 2010 at 10:18:03AM +0100, Juan Quintela wrote: Chris Wright chr...@redhat.com wrote: Please send in any agenda items you are interested in covering. Migration: - flexible migration: I hope to sent an

[Qemu-devel] Re: KVM call agenda for Mar 16

2010-03-16 Thread Daniel P. Berrange
On Tue, Mar 16, 2010 at 12:38:02PM +0200, Avi Kivity wrote: On 03/16/2010 12:31 PM, Daniel P. Berrange wrote: Polling loops are an indication that something is wrong. Except when people suggest they are the right answer, qcow high watermark ;-P I liked Anthony's suggestion of an

[Qemu-devel] Re: KVM call agenda for Mar 16

2010-03-16 Thread Christoph Hellwig
On Tue, Mar 16, 2010 at 12:38:02PM +0200, Avi Kivity wrote: On 03/16/2010 12:31 PM, Daniel P. Berrange wrote: Polling loops are an indication that something is wrong. Except when people suggest they are the right answer, qcow high watermark ;-P I liked Anthony's suggestion of an

[Qemu-devel] Re: KVM call agenda for Mar 16

2010-03-16 Thread Avi Kivity
On 03/16/2010 12:31 PM, Daniel P. Berrange wrote: Polling loops are an indication that something is wrong. Except when people suggest they are the right answer, qcow high watermark ;-P I liked Anthony's suggestion of an lvm2 block format driver. No polling. -- error compiling

[Qemu-devel] Re: KVM call agenda for Mar 16

2010-03-16 Thread Daniel P. Berrange
On Tue, Mar 16, 2010 at 11:43:48AM +0200, Avi Kivity wrote: On 03/16/2010 11:29 AM, Daniel P. Berrange wrote: On Tue, Mar 16, 2010 at 10:18:03AM +0100, Juan Quintela wrote: Chris Wrightchr...@redhat.com wrote: Please send in any agenda items you are interested in covering.

[Qemu-devel] [PATCH 0/6] qemu-kvm: Introduce bit-based phys_ram_dirty, and bit-based dirty page checker.

2010-03-16 Thread Yoshiaki Tamura
The dirty and non-dirty pages are checked one by one in vl.c. When the most of the memory is not dirty, checking the dirty and non-dirty pages by multiple page size should be much faster than checking them one by one. We introduced bit-based phys_ram_dirty for VGA, CODE and MIGRATION, and

[Qemu-devel] [PATCH 5/6] qemu-kvm: Use cpu_physical_memory_set_dirty_range() to update phys_ram_dirty.

2010-03-16 Thread Yoshiaki Tamura
Modifies kvm_get_dirty_pages_log_range to use cpu_physical_memory_set_dirty_range() to update the row of the bit-based phys_ram_dirty bitmap at once. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off-by: OHMURA Kei ohmura@lab.ntt.co.jp --- qemu-kvm.c | 19

[Qemu-devel] [PATCH 6/6] qemu-kvm: Use cpu_physical_memory_get_dirty_range() to check multiple dirty pages.

2010-03-16 Thread Yoshiaki Tamura
Modifies ram_save_block() and ram_save_remaining() to use cpu_physical_memory_get_dirty_range() to check multiple dirty and non-dirty pages at once. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off-by: OHMURA Kei ohmura@lab.ntt.co.jp --- vl.c | 55

[Qemu-devel] [PATCH 2/6] qemu-kvm: Modify and introduce wrapper functions to access phys_ram_dirty.

2010-03-16 Thread Yoshiaki Tamura
Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_ram_dirty bitmap, and adds more wrapper functions to prevent direct access to the phys_ram_dirty bitmap. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off-by: OHMURA Kei

[Qemu-devel] [PATCH 3/6] qemu-kvm: Replace direct phys_ram_dirty access with wrapper functions.

2010-03-16 Thread Yoshiaki Tamura
Replaces direct phys_ram_dirty access with wrapper functions to prevent direct access to the phys_ram_dirty bitmap. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off-by: OHMURA Kei ohmura@lab.ntt.co.jp --- exec.c | 45 - 1

[Qemu-devel] [PATCH 4/6] qemu-kvm: Introduce cpu_physical_memory_get_dirty_range().

2010-03-16 Thread Yoshiaki Tamura
Introduces cpu_physical_memory_get_dirty_range(). It checks the first row and puts dirty addr in the array. If the first row is empty, it skips to the first non-dirty row or the end addr, and put the length in the first entry of the array. Signed-off-by: Yoshiaki Tamura

[Qemu-devel] Re: KVM call agenda for Mar 16

2010-03-16 Thread Avi Kivity
On 03/16/2010 12:45 PM, Daniel P. Berrange wrote: On Tue, Mar 16, 2010 at 12:38:02PM +0200, Avi Kivity wrote: On 03/16/2010 12:31 PM, Daniel P. Berrange wrote: Polling loops are an indication that something is wrong. Except when people suggest they are the right answer,

[Qemu-devel] Re: [PATCH 1/6] qemu-kvm: Introduce bit-based phys_ram_dirty for VGA, CODE and MIGRATION.

2010-03-16 Thread Avi Kivity
On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: Replaces byte-based phys_ram_dirty bitmap with three bit-based phys_ram_dirty bitmap. On allocation, it sets all bits in the bitmap. Signed-off-by: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp Signed-off-by: OHMURA Keiohmura@lab.ntt.co.jp ---

[Qemu-devel] Re: [PATCH 2/6] qemu-kvm: Modify and introduce wrapper functions to access phys_ram_dirty.

2010-03-16 Thread Avi Kivity
On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_ram_dirty bitmap, and adds more wrapper functions to prevent direct access to the phys_ram_dirty bitmap. + +static inline int

[Qemu-devel] Re: [PATCH 4/6] qemu-kvm: Introduce cpu_physical_memory_get_dirty_range().

2010-03-16 Thread Avi Kivity
On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: Introduces cpu_physical_memory_get_dirty_range(). It checks the first row and puts dirty addr in the array. If the first row is empty, it skips to the first non-dirty row or the end addr, and put the length in the first entry of the array. +/* It

[Qemu-devel] Re: [PATCH 1/6] qemu-kvm: Introduce bit-based phys_ram_dirty for VGA, CODE and MIGRATION.

2010-03-16 Thread Yoshiaki Tamura
Avi Kivity wrote: On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: Replaces byte-based phys_ram_dirty bitmap with three bit-based phys_ram_dirty bitmap. On allocation, it sets all bits in the bitmap. Signed-off-by: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp Signed-off-by: OHMURA

[Qemu-devel] Re: [PATCH 1/6] qemu-kvm: Introduce bit-based phys_ram_dirty for VGA, CODE and MIGRATION.

2010-03-16 Thread Avi Kivity
On 03/16/2010 03:01 PM, Yoshiaki Tamura wrote: -uint8_t *phys_ram_dirty; +unsigned long *phys_ram_vga_dirty; +unsigned long *phys_ram_code_dirty; +unsigned long *phys_ram_migration_dirty; Would be nice to make this an array. Thanks for pointing out. I have a question regarding the index of

[Qemu-devel] Re: [PATCH 0/6] qemu-kvm: Introduce bit-based phys_ram_dirty, and bit-based dirty page checker.

2010-03-16 Thread Avi Kivity
On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: Experimental results: Cond1: 1.9 ~ 61 times speed up Cond2: 1.9 ~ 56 times speed up Cond3: 1.9 ~ 59 times speed up Cond4: 1.7 ~ 59 times speed up Impressive results. What's the typical speedup? Closer to 1.9 or 61? Note the issue with the

[Qemu-devel] Re: [PATCH 2/6] qemu-kvm: Modify and introduce wrapper functions to access phys_ram_dirty.

2010-03-16 Thread Yoshiaki Tamura
Avi Kivity wrote: On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_ram_dirty bitmap, and adds more wrapper functions to prevent direct access to the phys_ram_dirty bitmap. + +static inline int

[Qemu-devel] Re: [PATCH 1/7] Add support for generic notifier lists (v2)

2010-03-16 Thread Juan Quintela
Anthony Liguori aligu...@us.ibm.com wrote: Notifiers are data-less callbacks and a notifier list is a list of registered notifiers that all are interested in a particular event. We'll use this in a few patches to implement mouse change notification. We could use that for migration also.

[Qemu-devel] Re: [PATCH 2/6] qemu-kvm: Modify and introduce wrapper functions to access phys_ram_dirty.

2010-03-16 Thread Avi Kivity
On 03/16/2010 03:17 PM, Yoshiaki Tamura wrote: Avi Kivity wrote: On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_ram_dirty bitmap, and adds more wrapper functions to prevent direct access to the phys_ram_dirty

[Qemu-devel] Re: [PATCH 2/6] qemu-kvm: Modify and introduce wrapper functions to access phys_ram_dirty.

2010-03-16 Thread Anthony Liguori
On 03/16/2010 07:45 AM, Avi Kivity wrote: On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_ram_dirty bitmap, and adds more wrapper functions to prevent direct access to the phys_ram_dirty bitmap. + +static

[Qemu-devel] Re: [PATCH 0/6] qemu-kvm: Introduce bit-based phys_ram_dirty, and bit-based dirty page checker.

2010-03-16 Thread Yoshiaki Tamura
Avi Kivity wrote: On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: Experimental results: Cond1: 1.9 ~ 61 times speed up Cond2: 1.9 ~ 56 times speed up Cond3: 1.9 ~ 59 times speed up Cond4: 1.7 ~ 59 times speed up Impressive results. What's the typical speedup? Closer to 1.9 or 61? To be

[Qemu-devel] Re: [PATCH 2/6] qemu-kvm: Modify and introduce wrapper functions to access phys_ram_dirty.

2010-03-16 Thread Yoshiaki Tamura
Avi Kivity wrote: On 03/16/2010 03:17 PM, Yoshiaki Tamura wrote: Avi Kivity wrote: On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_ram_dirty bitmap, and adds more wrapper functions to prevent direct access to the

[Qemu-devel] Re: [PATCH 2/6] qemu-kvm: Modify and introduce wrapper functions to access phys_ram_dirty.

2010-03-16 Thread Anthony Liguori
On 03/16/2010 08:29 AM, Avi Kivity wrote: On 03/16/2010 03:17 PM, Yoshiaki Tamura wrote: Avi Kivity wrote: On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_ram_dirty bitmap, and adds more wrapper functions to

Re: [Qemu-devel] wake-on-lan IPMI implementation; real power-off and -no-shutdown

2010-03-16 Thread Luiz Capitulino
On Mon, 15 Mar 2010 15:55:26 + Daniel P. Berrange berra...@redhat.com wrote: On Mon, Mar 15, 2010 at 04:01:27PM +0100, Fran?ois Revol wrote: Hello, while working on a demonstrator for a green-IT project, to show scheduled machine shutdown and powering depending on various conditions,

[Qemu-devel] Re: [PATCH 2/6] qemu-kvm: Modify and introduce wrapper functions to access phys_ram_dirty.

2010-03-16 Thread Avi Kivity
On 03/16/2010 03:51 PM, Anthony Liguori wrote: On 03/16/2010 08:29 AM, Avi Kivity wrote: On 03/16/2010 03:17 PM, Yoshiaki Tamura wrote: Avi Kivity wrote: On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_ram_dirty

Re: [Qemu-devel] wake-on-lan IPMI implementation; real power-off and -no-shutdown

2010-03-16 Thread François Revol
Also, it seems -no-shutdown doesn't actually stop the emulation as said in the manual, it actually keeps the vm running (and using cpu), despite the OS trying to shutdown via ACPI. At least I tested so with Haiku (and acpi=true in kernel config), which properly exits QEMU

[Qemu-devel] Re: [PATCH 2/6] qemu-kvm: Modify and introduce wrapper functions to access phys_ram_dirty.

2010-03-16 Thread Anthony Liguori
On 03/16/2010 08:57 AM, Avi Kivity wrote: On 03/16/2010 03:51 PM, Anthony Liguori wrote: On 03/16/2010 08:29 AM, Avi Kivity wrote: On 03/16/2010 03:17 PM, Yoshiaki Tamura wrote: Avi Kivity wrote: On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: Modifies wrapper functions for byte-based

[Qemu-devel] [PULL] e100/pci fixes

2010-03-16 Thread Michael S. Tsirkin
The following changes since commit cb66ffcf9e298dc1bfc11682172ff9472bcd4495: Kevin Wolf (1): qemu-img rebase: Document -f option are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git pci Michael S. Tsirkin (2): eepro100: address pci

[Qemu-devel] Re: KVM call agenda for Mar 16

2010-03-16 Thread Anthony Liguori
On 03/16/2010 05:45 AM, Daniel P. Berrange wrote: On Tue, Mar 16, 2010 at 12:38:02PM +0200, Avi Kivity wrote: On 03/16/2010 12:31 PM, Daniel P. Berrange wrote: Polling loops are an indication that something is wrong. Except when people suggest they are the right answer,

[Qemu-devel] Re: [PATCHv4 09/12] vhost: vhost net support

2010-03-16 Thread Michael S. Tsirkin
On Mon, Mar 08, 2010 at 11:50:23AM +0530, Amit Shah wrote: On (Sat) Mar 06 2010 [21:06:35], Michael S. Tsirkin wrote: +r = vhost_virtqueue_set_addr(dev, vq, idx, dev-log_enabled); +if (r 0) { +r = -errno; +goto fail_alloc; +} +if

[Qemu-devel] [PATCH 0/4] tcg-hppa git it working, v2

2010-03-16 Thread Richard Henderson
Changes since v2: * Fix cpu_signal_handler. At this point the port passes all of the integer gcc tests for i386-linux-uclibc. Many of the fp tests fail because target-i386 is horribly confused about how to represent the fpu when not being built on a i386 host. I briefly tried to force the use

[Qemu-devel] [PATCH 1/4] tcg-hppa: Fix const errors in hppa-dis.c.

2010-03-16 Thread Richard Henderson
--- hppa-dis.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hppa-dis.c b/hppa-dis.c index 9d96d72..49f99c8 100644 --- a/hppa-dis.c +++ b/hppa-dis.c @@ -576,7 +576,7 @@ struct pa_opcode const char *name; unsigned long int match; /* Bits that must be

[Qemu-devel] [PATCH 4/4] tcg-hppa: Compute is_write in cpu_signal_handler.

2010-03-16 Thread Richard Henderson
--- cpu-exec.c | 38 +++--- 1 files changed, 31 insertions(+), 7 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index bcfcda2..14204f4 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -1193,15 +1193,39 @@ int cpu_signal_handler(int host_signum, void *pinfo, {

[Qemu-devel] [PATCH 2/4] tcg-hppa: Fix 64-bit argument ordering.

2010-03-16 Thread Richard Henderson
--- tcg/tcg.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 1818868..d753149 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -596,7 +596,17 @@ void tcg_gen_callN(TCGContext *s, TCGv_ptr func, unsigned int flags,

[Qemu-devel] Re: KVM call agenda for Mar 16

2010-03-16 Thread Anthony Liguori
On 03/16/2010 10:23 AM, Daniel P. Berrange wrote: In the context of the RHEV management application, iSCSI/SCSI Fibre are providing the raw storage, with LVM VGs on top and the carving LVs for the guests. In the common case the admin/app would monitor VG usage LV rate of increase to ensure

[Qemu-devel] [PATCH 0/5] target-alpha improvements

2010-03-16 Thread Richard Henderson
The major thing here is the addition of the CONST/PURE markers to the helper functions. In the process of studying the helper implmentations to see how each ought to get marked, there were several follow-on improvements that caught my eye. r~ Richard Henderson (5): target-alpha: Add flags

[Qemu-devel] [PATCH 1/5] target-alpha: Add flags markups to helpers.h.

2010-03-16 Thread Richard Henderson
Almost all alpha helpers are at least TCG_CALL_CONST and a fair few are also TCG_CALL_PURE. Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/helper.h | 184 1 files changed, 92 insertions(+), 92 deletions(-) diff --git

[Qemu-devel] [PATCH 2/5] target-alpha: Implement cpys{, n, e} inline.

2010-03-16 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/helper.h|4 -- target-alpha/op_helper.c | 18 -- target-alpha/translate.c | 78 +++-- 3 files changed, 74 insertions(+), 26 deletions(-) diff --git

[Qemu-devel] [PATCH 4/5] target-alpha: Implement cvtql inline.

2010-03-16 Thread Richard Henderson
It's a simple mask and shift sequence. Also, fix a typo in the actual masks used. Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/helper.h|4 target-alpha/op_helper.c | 20 target-alpha/translate.c | 45

[Qemu-devel] [PATCH 3/5] target-alpha: Implement rs/rc properly.

2010-03-16 Thread Richard Henderson
This is a per-cpu flag; there's no need for a spinlock of any kind. We were also failing to manipulate the flag with $31 as a target reg and failing to clear the flag on execution of a return-from-interrupt instruction. Signed-off-by: Richard Henderson r...@twiddle.net --- linux-user/main.c

[Qemu-devel] [PATCH 5/5] target-alpha: Implement cvtlq inline.

2010-03-16 Thread Richard Henderson
It's a simple shift and mask sequence. Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/helper.h|1 - target-alpha/op_helper.c |7 --- target-alpha/translate.c | 21 - 3 files changed, 20 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCH 0/4] tcg-hppa get it working, v2.1

2010-03-16 Thread Richard Henderson
Gah. Left out --thread and -s options to format-patch. Sorry about that. r~ Richard Henderson (4): tcg-hppa: Fix const errors in hppa-dis.c. tcg-hppa: Fix 64-bit argument ordering. tcg-hppa: Finish the port. tcg-hppa: Compute is_write in cpu_signal_handler. configure |

[Qemu-devel] [PATCH 1/4] tcg-hppa: Fix const errors in hppa-dis.c.

2010-03-16 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- hppa-dis.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hppa-dis.c b/hppa-dis.c index 9d96d72..49f99c8 100644 --- a/hppa-dis.c +++ b/hppa-dis.c @@ -576,7 +576,7 @@ struct pa_opcode const char *name;

[Qemu-devel] [PATCH 2/4] tcg-hppa: Fix 64-bit argument ordering.

2010-03-16 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tcg.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 1818868..d753149 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -596,7 +596,17 @@ void tcg_gen_callN(TCGContext *s, TCGv_ptr

[Qemu-devel] [PATCH 4/4] tcg-hppa: Compute is_write in cpu_signal_handler.

2010-03-16 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- cpu-exec.c | 38 +++--- 1 files changed, 31 insertions(+), 7 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index bcfcda2..14204f4 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -1193,15 +1193,39 @@ int

[Qemu-devel] [PATCH QEMU] Transparent Hugepage Support #2

2010-03-16 Thread Andrea Arcangeli
From: Andrea Arcangeli aarca...@redhat.com This will allow proper alignment so NPT/EPT can take advantage of linux host backing the guest memory with hugepages. It also ensures that when KVM isn't used the first 2M of guest physical memory are backed by a large TLB. To complete it, it will also

[Qemu-devel] Re: [PATCH] pcnet: make subsystem vendor id match hardware

2010-03-16 Thread Jan Kiszka
Michael S. Tsirkin wrote: Real pcnet device (AT2450) apparently has subsystem device and vendor id set to 0, this is out of spec (which requires that vendor id is obtained from PCI SIG) but windows xp driver seems to need this in order to associate. qemu sets pci subsystem id to

Re: [Qemu-devel] [PATCH QEMU] Transparent Hugepage Support #2

2010-03-16 Thread Jamie Lokier
Andrea Arcangeli wrote: + * take advantage of hugepages with NPT/EPP or to Spelling: NPT/EPT? -- Jamie

[Qemu-devel] [PATCHv5 00/11] vhost-net: upstream integration

2010-03-16 Thread Michael S. Tsirkin
Here's a patchset with vhost support for upstream qemu, rebased to latest bits, and with all comments I'm aware of addressed. Please consider for merging. Anthony, if you are still deliberating some issues, maybe the series can be merged partially? This will at least reduce the amount of noise

[Qemu-devel] [PATCHv5 01/11] tap: add interface to get device fd

2010-03-16 Thread Michael S. Tsirkin
Will be used by vhost to attach/detach to backend. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- net/tap.c |7 +++ net/tap.h |2 ++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index 7a7320c..fc59fd4 100644 --- a/net/tap.c +++

[Qemu-devel] [PATCHv5 03/11] notifier: event notifier implementation

2010-03-16 Thread Michael S. Tsirkin
event notifiers are slightly generalized eventfd descriptors. Current implementation depends on eventfd because vhost is the only user, and vhost depends on eventfd anyway, but a stub is provided for non-eventfd case. We'll be able to further generalize this when another user comes along and we

[Qemu-devel] [PATCHv5 04/11] virtio: notifier support + APIs for queue fields

2010-03-16 Thread Michael S. Tsirkin
vhost needs physical addresses for ring and other queue fields, so add APIs for these. In particular, add binding API to set host/guest notifiers. Will be used by vhost. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.c | 80

[Qemu-devel] [PATCHv5 05/11] virtio: add set_status callback

2010-03-16 Thread Michael S. Tsirkin
vhost net backend needs to be notified when frontend status changes. Add a callback, similar to set_features. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/s390-virtio-bus.c |2 +- hw/syborg_virtio.c |2 +- hw/virtio-pci.c |5 +++-- hw/virtio.h |9

[Qemu-devel] [PATCHv5 06/11] virtio: move typedef to qemu-common

2010-03-16 Thread Michael S. Tsirkin
make it possible to use type without header include, simplifying header dependencies. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.h |1 - qemu-common.h |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio.h b/hw/virtio.h index

[Qemu-devel] [PATCHv5 07/11] virtio-pci: fill in notifier support

2010-03-16 Thread Michael S. Tsirkin
Support host/guest notifiers in virtio-pci. The last one only with kvm, that's okay because vhost relies on kvm anyway. Note on kvm usage: kvm ioeventfd API is implemented on non-kvm systems as well, this is the reason we don't need if (kvm_enabled()) around it. Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PATCHv5 09/11] tap: add vhost/vhostfd options

2010-03-16 Thread Michael S. Tsirkin
This adds vhost binary option to tap, to enable vhost net accelerator. Default is off for now, we'll be able to make default on long term when we know it's stable. vhostfd option can be used by management, to pass in the fd. Assigning vhostfd implies vhost=on. Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PATCHv5 10/11] tap: add API to retrieve vhost net header

2010-03-16 Thread Michael S. Tsirkin
will be used by virtio-net for vhost net support Signed-off-by: Michael S. Tsirkin m...@redhat.com --- net/tap.c |7 +++ net/tap.h |3 +++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index 19c4fa2..35c05d7 100644 --- a/net/tap.c +++

[Qemu-devel] [PATCHv5 11/11] virtio-net: vhost net support

2010-03-16 Thread Michael S. Tsirkin
This connects virtio-net to vhost net backend. The code is structured in a way analogous to what we have with vnet header capability in tap. We start/stop backend on driver start/stop as well as on save and vm start (for migration). Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PATCHv5 08/11] vhost: vhost net support

2010-03-16 Thread Michael S. Tsirkin
This adds vhost net device support in qemu. Will be tied to tap device and virtio by following patches. Raw backend is currently missing, will be worked on/submitted separately. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Makefile.target |2 + configure | 36 +++

[Qemu-devel] [PATCHv5 02/11] kvm: add API to set ioeventfd

2010-03-16 Thread Michael S. Tsirkin
Comment on kvm usage: rather than require users to do if (kvm_enabled()) and/or ifdefs, this patch adds an API that, internally, is defined to stub function on non-kvm build, and checks kvm_enabled for non-kvm run. While rest of qemu code still uses if (kvm_enabled()), I think this approach is

Re: [Qemu-devel] wake-on-lan IPMI implementation; real power-off and -no-shutdown

2010-03-16 Thread Jamie Lokier
The semantics of -no-shutdown are awful. I'd personally prefer to see the option deprecated and a new set of options introduced with clearer semantics. Currently, -no-shutdown does too many things. It affects reboot behaviour, shutdown behaviour, the behavior of the SDL close button.

Re: [Qemu-devel] wake-on-lan IPMI implementation; real power-off and -no-shutdown

2010-03-16 Thread Daniel P. Berrange
On Tue, Mar 16, 2010 at 05:28:51PM +, Jamie Lokier wrote: The semantics of -no-shutdown are awful. I'd personally prefer to see the option deprecated and a new set of options introduced with clearer semantics. Currently, -no-shutdown does too many things. It affects reboot

Re: [Qemu-devel] Re: [PATCH, RFC] Replace assert(0) with abort() or cpu_abort()

2010-03-16 Thread Jamie Lokier
Paolo Bonzini wrote: On 03/15/2010 07:36 PM, Markus Armbruster wrote: Please don't tell me that user emulators make abort() return. abort() is declared __noreturn__, and the optimizer may well rely on that. If the user programs make a signal (SIGABRT, SIG_IGN) call, I suppose abort() will

Re: [Qemu-devel] Re: [PATCH, RFC] Replace assert(0) with abort() or cpu_abort()

2010-03-16 Thread Jamie Lokier
Markus Armbruster wrote: Paolo Bonzini pbonz...@redhat.com writes: On 03/15/2010 07:36 PM, Markus Armbruster wrote: Please don't tell me that user emulators make abort() return. abort() is declared __noreturn__, and the optimizer may well rely on that. If the user programs make a

[Qemu-devel] [PATCH] qemu-io: fix aio help texts

2010-03-16 Thread Christoph Hellwig
Fix a few typos in the helptexts for the various aio commands. Signed-off-by: Christoph Hellwig h...@lst.de Index: qemu/qemu-io.c === --- qemu.orig/qemu-io.c 2010-03-16 19:07:43.089009269 +0100 +++ qemu/qemu-io.c 2010-03-16

[Qemu-devel] [PATCH] [Also for STABLE-0.12] Don't check for bus master for old guests

2010-03-16 Thread Alexander Graf
Older Linux guests don't activate the bus master enable bit. So for those we can just try to be clever and track if they set the DEVICE_OK bit even though bus mastering is still disabled. Under that condition we can disable the windows safety check. With that logic in place both guests should

Re: [Qemu-devel] wake-on-lan IPMI implementation; real power-off and -no-shutdown

2010-03-16 Thread François Revol
I use -no-reboot so that when the guest does a reboot during installation, as they invariably do one or more times, QEMU exits, my scripts does things eject the CD/floppy, or change it for the next in sequence, and modify the guest's installed files to add virtio drivers, install extra fiels,

[Qemu-devel] [PULL v2] Convert device_add to QObject / QError

2010-03-16 Thread Markus Armbruster
Anthony ran into conflicts and asked me to rebase and send out a pull request. Complete list of conflicts: * qdev: Improve diagnostics for bad property values commit 6bf38816df80a3b50529119c5458b151b3e2c728 Adds two new errors to qdev_prop_parse(), which need conversion to QError.

  1   2   >