Re: [Qemu-devel] [PATCH] monitor: properly handle invalid fd/vhostfd from command line

2010-10-12 Thread jason wang
On 10/09/2010 01:40 AM, Luiz Capitulino wrote: On Tue, 28 Sep 2010 16:57:44 +0200 Michael S. Tsirkinm...@redhat.com wrote: On Tue, Sep 28, 2010 at 11:53:43AM -0300, Luiz Capitulino wrote: On Mon, 27 Sep 2010 15:52:44 +0800 Jason Wangjasow...@redhat.com wrote:

Re: [Qemu-devel] [PATCH] net: provide a friendly message when a user passes a bad -net tap, fd=X (v2)

2010-10-12 Thread Jason Wang
- Anthony Liguori aligu...@us.ibm.com wrote: A lot of people copy libvirt's command line from ps -ef and then wonder why the VM isn't working correctly. Let's be kind and tell them what they should do instead. Without this patch, if you run with an invalid -net tap,fd=X, the guest

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-12 Thread Gleb Natapov
On Mon, Oct 11, 2010 at 02:15:26PM -0700, H. Peter Anvin wrote: I don't disagree. I think the best thing to do is to let SeaBIOS create a boot order table that contains descriptive information and then advertise that to QEMU. QEMU can then try to associate the list of bootable

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-12 Thread Kevin Wolf
Am 11.10.2010 19:14, schrieb Anthony Liguori: On 10/11/2010 11:18 AM, Anthony Liguori wrote: On 10/11/2010 10:46 AM, Stefan Hajnoczi wrote: On Mon, Oct 11, 2010 at 05:39:01PM +0200, Avi Kivity wrote: On 10/11/2010 05:30 PM, Stefan Hajnoczi wrote: It was discussed before, but I don't think

Re: [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-12 Thread Stefan Hajnoczi
On Mon, Oct 11, 2010 at 6:04 PM, Gleb Natapov g...@redhat.com wrote: On Mon, Oct 11, 2010 at 12:01:58PM -0500, Anthony Liguori wrote: On 10/11/2010 10:52 AM, Stefan Hajnoczi wrote: 2010/10/11 Gleb Natapovg...@redhat.com: On Mon, Oct 11, 2010 at 01:48:09PM +0100, Stefan Hajnoczi wrote: On Mon,

[Qemu-devel] snapshots

2010-10-12 Thread chandra shekar
Hi,everyone i have applied this patch http://lists.nongnu.org/archive/html/qemu-devel/2010-09/msg01662.html to qemu source and compiled my qemu source and now i like to bring the snapshot out of the image file so i used qemu-img convert -f qcow2 -O qcow2 -s one guest1.img where: one - is the

Re: [Qemu-devel] snapshots

2010-10-12 Thread Stefan Hajnoczi
On Tue, Oct 12, 2010 at 10:13 AM, chandra shekar chandrashekar...@gmail.com wrote: Hi,everyone i have applied this  patch http://lists.nongnu.org/archive/html/qemu-devel/2010-09/msg01662.html  to qemu source and compiled my qemu source and now i like to bring the snapshot out of the image

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-12 Thread Avi Kivity
On 10/11/2010 06:10 PM, Anthony Liguori wrote: On 10/11/2010 11:02 AM, Avi Kivity wrote: On 10/11/2010 05:49 PM, Anthony Liguori wrote: On 10/11/2010 09:58 AM, Avi Kivity wrote: A leak is unacceptable. It means an image can grow to an unbounded size. If you are a server provider offering

[Qemu-devel] [PATCH 1/4] Introduce strtosz() library function to convert a string to a byte count.

2010-10-12 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com strtosz() returns -1 on error. It now supports human unit formats in eg. 1.0G, with better error handling. This version lets strtod() do the actual parsing instead of relying on strspn, as well as catches NaN input. The following suffixes are

[Qemu-devel] [PATCH 2/4] Add support for 'o' octet (bytes) format as monitor parameter.

2010-10-12 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Octet format relies on strtosz which supports K/k, M/m, G/g, T/t suffixes and unit support for humans, like 1.3G Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- monitor.c | 29 + 1 files changed, 29 insertions(+),

[Qemu-devel] [PATCH 4/4] Remove obsolete 'f' double parameter type

2010-10-12 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com 'f' double is no longer used, and we should be using floating point variables to store byte sizes. Remove it. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- monitor.c | 18 +- 1 files changed, 1 insertions(+), 17 deletions(-)

[Qemu-devel] [PATCH 3/4] Switch migrate_set_speed() to take an 'o' argument rather than a float.

2010-10-12 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Clarify default value of MB in migration speed argument in monitor, if no suffix is specified. This differ from previous default of bytes, but is consistent with the rest of the places where we accept a size argument. Signed-off-by: Jes Sorensen

Re: [Qemu-devel] virtio_cleanup() missing in virtio-{blk, balloon, 9p}-pci

2010-10-12 Thread M. Mohan Kumar
Pattern: FOO's PCIDeviceInfo method exit is virtio_FOO_exit_pci(), which calls virtio_FOO_exit() and virtio_exit_pci(). virtio_{net,serial}_exit() call virtio_cleanup(). virtio_blk_exit() doesn't. Why? virtio-balloon-pci uses virtio_exit_pci() as exit method. No virtio_cleanup()?

[Qemu-devel] Re: qdev SUNW,fdtwo is unusable with -device

2010-10-12 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: On Sat, Oct 9, 2010 at 10:09 AM, Markus Armbruster arm...@redhat.com wrote: Commit 12a71a02 created qdev SUNW,fdtwo.  It can't be named in -device, because the name contains a comma: -device SUNW,fdtwo gets parsed as driver SUNW with property fdtwo.

Re: [Qemu-devel] virtio_cleanup() missing in virtio-{blk, balloon, 9p}-pci

2010-10-12 Thread Markus Armbruster
M. Mohan Kumar mo...@in.ibm.com writes: Pattern: FOO's PCIDeviceInfo method exit is virtio_FOO_exit_pci(), which calls virtio_FOO_exit() and virtio_exit_pci(). virtio_{net,serial}_exit() call virtio_cleanup(). virtio_blk_exit() doesn't. Why? virtio-balloon-pci uses

[Qemu-devel] Where's gpxe-eepro100-80862449.rom ?

2010-10-12 Thread Markus Armbruster
Commit db667a12 added a reference to ROM file gpxe-eepro100-80862449.rom, but no such file. Intentional?

[Qemu-devel] isa-applesmc doesn't handle second instantiation gracefully

2010-10-12 Thread Markus Armbruster
When I try -device isa-applesmc -device isa-applesmc, I get WARNING: Using AppleSMC with invalid key qemu: hardware error: register_ioport_read: invalid opaque [...] and a core dump. I know nothing about this device. Instantiating twice may well make no sense. But hw_error() is

[Qemu-devel] [Bug 643465] Re: Crash at network boot

2010-10-12 Thread Jes Sorensen
That is really odd, it sounds like memory corruption in the vmware video driver. -- Crash at network boot https://bugs.launchpad.net/bugs/643465 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New Bug description: When

[Qemu-devel] Re: isa-applesmc doesn't handle second instantiation gracefully

2010-10-12 Thread Alexander Graf
On 12.10.2010, at 14:50, Markus Armbruster wrote: When I try -device isa-applesmc -device isa-applesmc, I get WARNING: Using AppleSMC with invalid key qemu: hardware error: register_ioport_read: invalid opaque [...] and a core dump. I know nothing about this device.

[Qemu-devel] [PATCH 0/2] usb-ccid device (v2)

2010-10-12 Thread Alon Levy
This patch adds a new device, it is described in full in the second patch intro and also in the documentation in docs. In brief it provides a standard smart card reader device. The first patch is the configure change and docs. The second patch contains the actual device, I couldn't figure out a

[Qemu-devel] [PATCH 1/2] usb-ccid: add CCID device. add configure option.

2010-10-12 Thread Alon Levy
This patch adds the configure option --enable-smartcard, adds hw/usb-ccid.c to Makefile.objs, and adds the documentation. Only an empty hw/usb-ccid.c is provided (couldn't add an empty file so added initial comment only). Signed-off-by: Alon Levy al...@redhat.com --- Makefile.objs |1 +

[Qemu-devel] [PATCH 2/2] usb-ccid: add CCID device (device itself)

2010-10-12 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [2]. The usb-ccid device expects a chardev option and uses the VSCARD protocol defined in vscard_common.h. It starts as an unattached device unless auto_attach=1. The utility vscclient, bundled with libcac_card, provides the

[Qemu-devel] [PATCH 01/39] default compilation tools to environment variables

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 20 +++- 1 files changed, 7 insertions(+), 13 deletions(-) diff --git a/configure b/configure index d303061..d9f4805 100755 --- a/configure +++ b/configure @@ -74,19 +74,13 @@ interp_prefix=/usr/gnemul/qemu-%M

[Qemu-devel] qdev: Some ISA devices don't handle second instantiation gracefully (was: isa-applesmc doesn't handle second instantiation gracefully)

2010-10-12 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: When I try -device isa-applesmc -device isa-applesmc, I get WARNING: Using AppleSMC with invalid key qemu: hardware error: register_ioport_read: invalid opaque [...] and a core dump. I know nothing about this device. Instantiating

[Qemu-devel] [PATCH 02/39] default make and install to environment variables

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/configure b/configure index d9f4805..598d943 100755 --- a/configure +++ b/configure @@ -79,8 +79,6 @@ audio_card_list=ac97 es1370 sb16

[Qemu-devel] [PATCH 03/39] move feature variables to the top

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 160 ++-- 1 files changed, 80 insertions(+), 80 deletions(-) diff --git a/configure b/configure index 598d943..9e2ae71 100755 --- a/configure +++ b/configure @@ -85,6 +85,86

[Qemu-devel] [PATCH 00/39] Make configure command line autoconf-compatible

2010-10-12 Thread Paolo Bonzini
Here is the patch series implementing the idea I mentioned a while ago. The first 14 introduce small changes to group pieces of code together and help understanding/reviewing the next changes. Most of them are just cosmetic changes, though some of them have small behavioral changes. After these

[Qemu-devel] [PATCH 04/39] fix sparse support (?)

2010-10-12 Thread Paolo Bonzini
I didn't test with sparse, but the old code using += before a variable was set was wrong. Sparse support should probably be ripped out or redone, but this at least keeps some sanity. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 10 +- 1 files changed, 5

[Qemu-devel] [PATCH 12/39] move --srcdir detection earlier

2010-10-12 Thread Paolo Bonzini
This will help getting config.guess and config.sub from the srcdir. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 28 +++- 1 files changed, 15 insertions(+), 13 deletions(-) diff --git a/configure b/configure index f61c5b8..e059525 100755 ---

[Qemu-devel] [PATCH 06/39] include failed source file in config.log

2010-10-12 Thread Paolo Bonzini
Also clean config.log from distclean. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile |2 +- configure | 21 + 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index d9971c3..34c2a6c 100644 --- a/Makefile +++ b/Makefile

[Qemu-devel] [PATCH 13/39] properly detect compiler in tests/Makefile

2010-10-12 Thread Paolo Bonzini
`make speed' only makes sense if not cross-compiling, so sha1 can use the CC for the system that is hosting qemu. sha1-i386 is also wrong, since there is usually no variable for the target CC; guess some plausible values. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- tests/Makefile |

[Qemu-devel] [PATCH 05/39] test cc with the complete set of chosen flags

2010-10-12 Thread Paolo Bonzini
The test the C compiler works ok comes before a bunch of flags are added for --cpu or just depending on the host. It helps debugging if the test is done after these flags are (unconditionally) added. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 50

[Qemu-devel] [PATCH 07/39] do not pass bogus $(SRC_PATH) include paths to cc during configure

2010-10-12 Thread Paolo Bonzini
Non-existent -I paths are dropped silently by the compiler, but still it is not polite to pass bogus options. Configure-time tests do not need any include files from the source path, so only include -I flags at make time (when they're properly expanded). Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 18/39] add autoconfy alias CC= for --cc

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 7f2e2a4..1ea56f7 100755 --- a/configure +++ b/configure @@ -180,7 +180,7 @@ for opt do case $opt in --cross-prefix=*)

[Qemu-devel] [PATCH 17/39] introduce CPPFLAGS configure variable

2010-10-12 Thread Paolo Bonzini
Be consistent with Autoconf-generated scripts. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |8 rules.mak |8 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 2a2f64e..7f2e2a4 100755 --- a/configure +++

[Qemu-devel] [PATCH 20/39] add autoconfy aliases MAKE=/INSTALL= for --make and --install

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/configure b/configure index 8273f84..547f8e9 100755 --- a/configure +++ b/configure @@ -526,9 +526,9 @@ for opt do ;; --host-cc=*) ;; -

[Qemu-devel] [PATCH 09/39] fix spelling of $pkg_config, move default together with other cross tools

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 34 +- 1 files changed, 17 insertions(+), 17 deletions(-) diff --git a/configure b/configure index 873e4a6..ac11d4e 100755 --- a/configure +++ b/configure @@ -216,6 +216,7 @@

[Qemu-devel] [PATCH 11/39] reorganize sdl-config tests

2010-10-12 Thread Paolo Bonzini
This also allows overriding it with SDL_CONFIG, and warning in suspicious cross-compilation scenarios. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 30 +- 1 files changed, 17 insertions(+), 13 deletions(-) diff --git a/configure b/configure

[Qemu-devel] [PATCH 26/39] add libtooly alias --enable-static for --static

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 86b1835..d677b53 100755 --- a/configure +++ b/configure @@ -546,7 +546,7 @@ for opt do ;; --enable-gprof) gprof=yes ;; -

[Qemu-devel] [PATCH 21/39] add autoconfy aliases --with-* for audio library options

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/configure b/configure index 547f8e9..76626a4 100755 --- a/configure +++ b/configure @@ -564,11 +564,11 @@ for opt do ;; --enable-sdl)

[Qemu-devel] [PATCH 10/39] do not default to non-prefixed pkg-config when cross compiling

2010-10-12 Thread Paolo Bonzini
This can still be requested with PKG_CONFIG=/path/to/pkg-config. Just do not use it as a default, and print a warning. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index

[Qemu-devel] [PATCH 14/39] remove HOST_CC mention from roms/{sea, vga}bios/config.mak

2010-10-12 Thread Paolo Bonzini
Not used in the submodules. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure b/configure index e059525..068b40a 100755 --- a/configure +++ b/configure @@ -3129,7 +3129,6 @@ for rom in seabios vgabios

[Qemu-devel] [PATCH 29/39] add autoconfy alias --enable-targets for --target-list

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index b439bc2..e1eeda2 100755 --- a/configure +++ b/configure @@ -538,7 +538,7 @@ for opt do ;; --cpu=*) ;; -

[Qemu-devel] [PATCH 22/39] make trace options use autoconfy names

2010-10-12 Thread Paolo Bonzini
These are not in any release, so I am just renaming them. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 76626a4..5786729 100755 --- a/configure +++ b/configure @@ -540,9

[Qemu-devel] [PATCH 08/39] provide portable sizeof(long) test

2010-10-12 Thread Paolo Bonzini
Do not hardcode the list of 64-bit CPUs. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/configure b/configure index cb76177..873e4a6 100755 --- a/configure +++ b/configure @@ -1088,12 +1088,14

[Qemu-devel] [PATCH 16/39] introduce CFLAGS= and LDFLAGS= configure command-line options

2010-10-12 Thread Paolo Bonzini
Also, run checks with -O2. Some headers may provide different code based on __OPTIMIZE__, so it's good to be consistent. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 31 +-- 1 files changed, 21 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH 34/39] add autoconfy --host= option deprecating --cross-prefix

2010-10-12 Thread Paolo Bonzini
Unlike --cross-prefix, if you specify a tool by environment variables --host will not affect it. This allows SDL_CONFIG=/usr/.../bin/sdl-config ./configure --host=i686-pc-mingw32 to work. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 41

[Qemu-devel] [PATCH 15/39] let --host-cc slide into oblivion

2010-10-12 Thread Paolo Bonzini
It is not really needed anymore since dyngen's death, and the previous patches removed the last occurrences. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |8 +--- create_config |3 --- 2 files changed, 1 insertions(+), 10 deletions(-) diff --git a/configure

[Qemu-devel] [PATCH 19/39] add CPP variable

2010-10-12 Thread Paolo Bonzini
There is already a CPP makefile variable, treat it consistently with every other tool. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 1ea56f7..8273f84 100755 ---

[Qemu-devel] [PATCH 32/39] rename SRC_PATH to srcdir

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile | 52 ++-- Makefile.dis |6 ++-- Makefile.hw|8 +++--- Makefile.objs |4 +- Makefile.target| 32

[Qemu-devel] [PATCH 23/39] deprecate --audio-card-list

2010-10-12 Thread Paolo Bonzini
We have config files now which provide fine-grained control. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 5786729..efebaa9 100755 --- a/configure +++ b/configure @@ -856,8

[Qemu-devel] [PATCH 24/39] add autoconfy alias --enable-audio-drivers alias for --audio-drv-list

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index efebaa9..b144b21 100755 --- a/configure +++ b/configure @@ -572,7 +572,7 @@ for opt do ;; --audio-card-list=*)

[Qemu-devel] [PATCH 37/39] make more options standard

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/configure b/configure index 99de45b..27fc67a 100755 --- a/configure +++ b/configure @@ -806,6 +806,14 @@ EOF echo Standard options: echo

[Qemu-devel] Re: qdev: Some ISA devices don't handle second instantiation gracefully (was: isa-applesmc doesn't handle second instantiation gracefully)

2010-10-12 Thread Alexander Graf
On 12.10.2010, at 15:00, Markus Armbruster wrote: Markus Armbruster arm...@redhat.com writes: When I try -device isa-applesmc -device isa-applesmc, I get WARNING: Using AppleSMC with invalid key qemu: hardware error: register_ioport_read: invalid opaque [...] and a core

[Qemu-devel] [PATCH 31/39] add autoconfy alias --srcdir= for --source-path

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 39a7119..44b5be9 100755 --- a/configure +++ b/configure @@ -182,7 +182,7 @@ for opt do ;; CC=*|--cc=*) CC=$optarg ;; -

[Qemu-devel] [PATCH 27/39] add autoconfy alias --with-sysroot for --interp-prefix

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/configure b/configure index d677b53..581b91e 100755 --- a/configure +++ b/configure @@ -514,7 +514,7 @@ for opt do ;; --prefix=*) prefix=$optarg

[Qemu-devel] [PATCH 25/39] add autoconfy alias --enable-block-drivers for --block-drv-whitelist

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index b144b21..86b1835 100755 --- a/configure +++ b/configure @@ -574,7 +574,7 @@ for opt do ;;

[Qemu-devel] [PATCH 28/39] rename interp_prefix to sysroot

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- bsd-user/main.c| 10 +- configure | 14 +++--- darwin-user/machload.c | 12 ++-- darwin-user/main.c |6 +++--- darwin-user/syscall.c |2 +- linux-user/main.c | 10 +-

[Qemu-devel] [PATCH 38/39] provide a more gnuish default sysroot

2010-10-12 Thread Paolo Bonzini
the default sys-root already hads gnemul in it, so I do not feel ashamed to follow the GNU conventions completely. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 20 ++-- create_config |2 +- 2 files changed, 19 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH 30/39] add autoconfy alias --with-headers for --kerneldir

2010-10-12 Thread Paolo Bonzini
This name is already used by glibc. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index e1eeda2..39a7119 100755 --- a/configure +++ b/configure @@ -726,7 +726,7 @@ for opt do ;;

[Qemu-devel] [PATCH 33/39] rename source_path to srcdir

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 48 1 files changed, 24 insertions(+), 24 deletions(-) diff --git a/configure b/configure index 432bd3b..8ed9736 100755 --- a/configure +++ b/configure @@ -182,8 +182,8 @@ for opt

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-12 Thread Stefan Hajnoczi
On Tue, Oct 12, 2010 at 10:07:53AM +0200, Kevin Wolf wrote: Am 11.10.2010 19:14, schrieb Anthony Liguori: On 10/11/2010 11:18 AM, Anthony Liguori wrote: On 10/11/2010 10:46 AM, Stefan Hajnoczi wrote: On Mon, Oct 11, 2010 at 05:39:01PM +0200, Avi Kivity wrote: On 10/11/2010 05:30 PM,

Re: [Qemu-devel] qdev: Some ISA devices don't handle second instantiation gracefully

2010-10-12 Thread Anthony Liguori
On 10/12/2010 08:00 AM, Markus Armbruster wrote: Markus Armbrusterarm...@redhat.com writes: When I try -device isa-applesmc -device isa-applesmc, I get WARNING: Using AppleSMC with invalid key qemu: hardware error: register_ioport_read: invalid opaque [...] and a core

Re: [Qemu-devel] [PATCH 00/39] Make configure command line autoconf-compatible

2010-10-12 Thread malc
On Tue, 12 Oct 2010, Paolo Bonzini wrote: On 10/12/2010 03:22 PM, malc wrote: 19 files changed, 3729 insertions(+), 456 deletions(-) I don't think the explanation above justified net plus of 3273 lines of new code. The part you forgot to quote is: Yes, failed to notice that,

[Qemu-devel] [PATCH 36/39] add autoconfy --with-arch= option, compatible with --sparc-cpu

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Please test this on SPARC. :) configure | 72 + 1 files changed, 39 insertions(+), 33 deletions(-) diff --git a/configure b/configure index d6f472b..99de45b 100755 ---

[Qemu-devel] [PATCH] e1000: Handle IO Port.

2010-10-12 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com This patch introduces the two IOPorts on e1000, IOADDR and IODATA. The IOADDR is used to specify which register we want to access when we read or write on IODATA. It also check the RDLEN register when a packet is received, if the value is 0, the

Re: [Qemu-devel] qdev: Some ISA devices don't handle second instantiation gracefully

2010-10-12 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 10/12/2010 08:00 AM, Markus Armbruster wrote: Markus Armbrusterarm...@redhat.com writes: When I try -device isa-applesmc -device isa-applesmc, I get WARNING: Using AppleSMC with invalid key qemu: hardware error:

Re: [Qemu-devel] [PATCH 00/39] Make configure command line autoconf-compatible

2010-10-12 Thread malc
On Tue, 12 Oct 2010, Paolo Bonzini wrote: Here is the patch series implementing the idea I mentioned a while ago. The first 14 introduce small changes to group pieces of code together and help understanding/reviewing the next changes. Most of them are just cosmetic changes, though some of

Re: [Qemu-devel] Re: [PATCH v2 3/7] docs: Add QED image format specification

2010-10-12 Thread Anthony Liguori
On 10/12/2010 08:16 AM, Stefan Hajnoczi wrote: Well, the protocol is currently encoded in the file name, separated by a colon. Of course, we want to get rid of that, but we still don't know what we want instead. It's completely unrelated to the backing file format, though, it's about the

[Qemu-devel] [PATCH 39/39] use host triplets for feature detection

2010-10-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 64 - 1 files changed, 21 insertions(+), 43 deletions(-) diff --git a/configure b/configure index 0340cfe..69b3406 100755 --- a/configure +++ b/configure @@ -290,49

Re: [Qemu-devel] [PATCH 00/39] Make configure command line autoconf-compatible

2010-10-12 Thread Paolo Bonzini
On 10/12/2010 03:22 PM, malc wrote: 19 files changed, 3729 insertions(+), 456 deletions(-) I don't think the explanation above justified net plus of 3273 lines of new code. The part you forgot to quote is: Makefile | 54 +- Makefile.dis |6 +-

Re: [Qemu-devel] [PATCH 08/39] provide portable sizeof(long) test

2010-10-12 Thread malc
On Tue, 12 Oct 2010, Paolo Bonzini wrote: Do not hardcode the list of 64-bit CPUs. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/configure b/configure index cb76177..873e4a6 100755

Re: [Qemu-devel] [PATCH 23/39] deprecate --audio-card-list

2010-10-12 Thread malc
On Tue, 12 Oct 2010, Paolo Bonzini wrote: We have config files now which provide fine-grained control. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 5786729..efebaa9

Re: [Qemu-devel] [PATCH 08/39] provide portable sizeof(long) test

2010-10-12 Thread Paolo Bonzini
On 10/12/2010 03:47 PM, malc wrote: # host long bits test -hostlongbits=32 -case $cpu in - x86_64|alpha|ia64|sparc64|ppc64|s390x) -hostlongbits=64 - ;; -esac +cat $TMPC EOF +int sizeof_long_is_8[sizeof(long) == 8 ? 1 : -1]; +EOF +if compile_object; then +hostlongbits=64 +else

[Qemu-devel] Invitación a conectarnos en LinkedIn

2010-10-12 Thread Ernesto Domato via LinkedIn
LinkedIn Ernesto Domato requested to add you as a connection on LinkedIn: -- Jiajun, Me gustaría añadirte a mi red profesional en LinkedIn. -Ernesto Accept invitation from Ernesto Domato

Re: [Qemu-devel] [PATCH 23/39] deprecate --audio-card-list

2010-10-12 Thread Paolo Bonzini
On 10/12/2010 03:49 PM, malc wrote: On Tue, 12 Oct 2010, Paolo Bonzini wrote: We have config files now which provide fine-grained control. Signed-off-by: Paolo Bonzinipbonz...@redhat.com --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure

Re: [Qemu-devel] [PATCH 00/39] Make configure command line autoconf-compatible

2010-10-12 Thread Paolo Bonzini
On 10/12/2010 04:30 PM, Anthony Liguori wrote: I think there's a fair bit of value in looking like autoconf but a 39 patch series is a bit to digest at once. I'll try to do a thorough review but I'd suggest keeping patch series down to about 20 patches whenever possible and do multiple rounds

Re: [Qemu-devel] [PATCH 00/39] Make configure command line autoconf-compatible

2010-10-12 Thread Anthony Liguori
On 10/12/2010 08:32 AM, malc wrote: On Tue, 12 Oct 2010, Paolo Bonzini wrote: On 10/12/2010 03:22 PM, malc wrote: 19 files changed, 3729 insertions(+), 456 deletions(-) I don't think the explanation above justified net plus of 3273 lines of new code. The part

Re: [Qemu-devel] [PATCH 08/39] provide portable sizeof(long) test

2010-10-12 Thread malc
On Tue, 12 Oct 2010, Paolo Bonzini wrote: On 10/12/2010 03:47 PM, malc wrote: # host long bits test -hostlongbits=32 -case $cpu in - x86_64|alpha|ia64|sparc64|ppc64|s390x) -hostlongbits=64 - ;; -esac +cat $TMPC EOF +int sizeof_long_is_8[sizeof(long) == 8 ? 1

[Qemu-devel] Re: [Bug 638955] Re: emulated netcards don't work with recent sunos kernel

2010-10-12 Thread Stefan Hajnoczi
On Sat, Oct 2, 2010 at 8:23 PM, daniel pecka 638...@bugs.launchpad.net wrote: well, i did some more investigations and here come a results .. this patch http://patchwork.ozlabs.org/patch/65137/raw/ solves problem partially .. NICs are working with that but after a deeper look, connection is

[Qemu-devel] Re: qdev: Some ISA devices don't handle second instantiation gracefully

2010-10-12 Thread Gerd Hoffmann
Hi, They call register_ioport_write(), which aborts via hw_error() when the port is already in use. This is okay for non-configurable parts of a board emulation, but not okay for a qdev device, unless it has no_user set. Related: when isa_init_irq() finds the requested IRQ already in use,

Re: [Qemu-devel] [PATCH 08/39] provide portable sizeof(long) test

2010-10-12 Thread Paolo Bonzini
On 10/12/2010 04:38 PM, malc wrote: On Tue, 12 Oct 2010, Paolo Bonzini wrote: On 10/12/2010 03:47 PM, malc wrote: # host long bits test -hostlongbits=32 -case $cpu in - x86_64|alpha|ia64|sparc64|ppc64|s390x) -hostlongbits=64 - ;; -esac +cat $TMPC EOF +int

[Qemu-devel] Re: [PATCH v2 5/7] qed: Table, L2 cache, and cluster functions

2010-10-12 Thread Kevin Wolf
Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: This patch adds code to look up data cluster offsets in the image via the L1/L2 tables. The L2 tables are writethrough cached in memory for performance (each read/write requires a lookup so it is essential to cache the tables). With cluster

Re: [Qemu-devel] [PATCH 08/39] provide portable sizeof(long) test

2010-10-12 Thread Paolo Bonzini
On 10/12/2010 04:41 PM, malc wrote: Gives wrong results on Win64. Then it's not HOST_LONG_BITS, it's HOST_POINTER_BITS. Not quite, [s]size_t/ptrdiff_t are 64 bits wide udner Win64, little to do with pointers. Before (on Win64): sizeof(long) == 4, HOST_LONG_BITS == 64 After:

Re: [Qemu-devel] [PATCH 08/39] provide portable sizeof(long) test

2010-10-12 Thread malc
On Tue, 12 Oct 2010, Paolo Bonzini wrote: On 10/12/2010 04:38 PM, malc wrote: On Tue, 12 Oct 2010, Paolo Bonzini wrote: On 10/12/2010 03:47 PM, malc wrote: # host long bits test -hostlongbits=32 -case $cpu in - x86_64|alpha|ia64|sparc64|ppc64|s390x) -

Re: [Qemu-devel] qdev: Some ISA devices don't handle second instantiation gracefully

2010-10-12 Thread Anthony Liguori
On 10/12/2010 08:54 AM, Markus Armbruster wrote: I think the proper thing to do is remove all exit(1)s and propagate errors instead. exit() is good enough during startup, i.e. -device. It's wrong for hot plug; anything to be used in a hot plug path must propagate errors. We could keep

[Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-12 Thread Anthony Liguori
On 10/12/2010 10:08 AM, Kevin Wolf wrote: Otherwise we might destroy data that isn't even touched by the guest request in case of a crash. The failure scenarios are either that the cluster is leaked in which case, the old version of the data is still present or the cluster is orphaned

Re: [Qemu-devel] [PATCH 08/39] provide portable sizeof(long) test

2010-10-12 Thread Paolo Bonzini
On 10/12/2010 05:12 PM, malc wrote: Bottom line: QEMU assumes that long is large enough to hold a pointer, this assumption is wrong, and your patch is wrong (not because it miscalculates size of ABI long) but because of the assumptions current code has. Whether two wrongs makes right is an open

Re: [Qemu-devel] [PATCH 08/39] provide portable sizeof(long) test

2010-10-12 Thread malc
On Tue, 12 Oct 2010, Paolo Bonzini wrote: On 10/12/2010 04:41 PM, malc wrote: Gives wrong results on Win64. Then it's not HOST_LONG_BITS, it's HOST_POINTER_BITS. Not quite, [s]size_t/ptrdiff_t are 64 bits wide udner Win64, little to do with pointers. Before (on Win64):

[Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-12 Thread Kevin Wolf
Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: This patch implements the read/write state machine. Operations are fully asynchronous and multiple operations may be active at any time. Allocating writes lock tables to ensure metadata updates do not interfere with each other. If two

[Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-12 Thread Kevin Wolf
Am 12.10.2010 17:22, schrieb Anthony Liguori: On 10/12/2010 10:08 AM, Kevin Wolf wrote: Otherwise we might destroy data that isn't even touched by the guest request in case of a crash. The failure scenarios are either that the cluster is leaked in which case, the old version of the

[Qemu-devel] [Bug 659276] [NEW] Accessing Century byte via RTC

2010-10-12 Thread Ian Seyler
Public bug reported: With the RTC configure for Binary instead of BCD I am getting the incorrect result for Century. mov al, 0x0B; Set RTC to binary mode out 0x70, al in al, 0x71 bts ax, 2 mov bl, al mov al, 0x0B out

Re: [Qemu-devel] [RFT] qemu 0.13.0-rc3

2010-10-12 Thread Rick Vernam
I encountered two issues with 0.13.0-rc1, not sure how to tell if the patches have been applied? one is this patch: http://patchwork.ozlabs.org/patch/62420/ discussed here: http://lists.nongnu.org/archive/html/qemu-devel/2010-09/msg01114.html the other was

Re: [Qemu-devel] [PATCH 1/4] Introduce strtosz() library function to convert a string to a byte count.

2010-10-12 Thread Markus Armbruster
Still not entirely happy, but maybe we can commit it as is, and fix it up later. jes.soren...@redhat.com writes: From: Jes Sorensen jes.soren...@redhat.com strtosz() returns -1 on error. It now supports human unit formats in eg. 1.0G, with better error handling. This version lets strtod()

[Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-12 Thread Stefan Hajnoczi
On Tue, Oct 12, 2010 at 05:39:48PM +0200, Kevin Wolf wrote: Am 12.10.2010 17:22, schrieb Anthony Liguori: On 10/12/2010 10:08 AM, Kevin Wolf wrote: Otherwise we might destroy data that isn't even touched by the guest request in case of a crash. The failure scenarios are either

Re: [Qemu-devel] [PATCH 0/2] usb-ccid device (v2)

2010-10-12 Thread Alon Levy
- Anthony Liguori anth...@codemonkey.ws wrote: On 10/12/2010 07:58 AM, Alon Levy wrote: This patch adds a new device, it is described in full in the second patch intro and also in the documentation in docs. In brief it provides a standard smart card reader device. The first

[Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-12 Thread Avi Kivity
On 10/12/2010 06:16 PM, Anthony Liguori wrote: It's fairly simple to add a sync to this path. It's probably worth checking the prefill/postfill for zeros and avoiding the write/sync if that's the case. That should optimize the common cases of allocating new space within a file. My

Re: [Qemu-devel] [PATCH 0/2] usb-ccid device (v2)

2010-10-12 Thread Anthony Liguori
On 10/12/2010 11:03 AM, Alon Levy wrote: - Anthony Liguorianth...@codemonkey.ws wrote: On 10/12/2010 07:58 AM, Alon Levy wrote: This patch adds a new device, it is described in full in the second patch intro and also in the documentation in docs. In brief it

Re: [Qemu-devel] [RFT] qemu 0.13.0-rc3

2010-10-12 Thread Stefan Weil
Am 12.10.2010 00:15, schrieb Anthony Liguori: After suffering from a prolonged maintainer softlockup, I'm attempting to get 0.13.0 release process back on track. I've tagged qemu-0.13.0-rc3 in git which only carries a few changes since 0.13.0-rc1. Most notably, a series of updates from Kevin

[Qemu-devel] Re: Where's gpxe-eepro100-80862449.rom ?

2010-10-12 Thread Stefan Weil
Am 12.10.2010 14:41, schrieb Markus Armbruster: Commit db667a12 added a reference to ROM file gpxe-eepro100-80862449.rom, but no such file. Intentional? Yes. See http://lists.nongnu.org/archive/html/qemu-devel/2010-05/msg00418.html Citation from my former mail: Yes, it is missing. I did

  1   2   >