Re: [Qemu-devel] [PATCH 1/3] Introduce threadlets

2010-10-22 Thread Balbir Singh
* Arun R B a...@linux.vnet.ibm.com [2010-10-21 17:40:45]: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch creates a generic asynchronous-task-offloading infrastructure named threadlets. The core idea has been borrowed from the threading framework that is being used by

[Qemu-devel] [Bug 663713] Re: Mouse frozen under an emulated ubuntu

2010-10-22 Thread FredBezies
Well, looks like the patch was added on 20 october. http://git.qemu.org/qemu.git/commit/?id=cd496926155afcb3b6323e70dd720dc118b3a255 With a little luck, it would be in Qemu 0.13.1. Thanks for the URL and the patch. Have a good day. -- Mouse frozen under an emulated ubuntu

Re: [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it

2010-10-22 Thread Jes Sorensen
On 10/22/10 09:59, Markus Armbruster wrote: jes.soren...@redhat.com writes: From: Jes Sorensen jes.soren...@redhat.com This patch introduces cutils.c: strtosz() and gets rid of the multiple custom hacks for parsing byte sizes. In addition it adds supports for specifying human style sizes such

Re: [Qemu-devel] [PATCH 2/2] v2 Fix Block Hotplug race with drive_unplug()

2010-10-22 Thread Daniel P. Berrange
On Thu, Oct 21, 2010 at 04:37:46PM -0500, Ryan Harper wrote: * Daniel P. Berrange berra...@redhat.com [2010-10-21 08:29]: On Tue, Oct 19, 2010 at 09:32:29AM -0500, Ryan Harper wrote: Block hot unplug is racy since the guest is required to acknowlege the ACPI unplug event; this may not

Re: [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it

2010-10-22 Thread Markus Armbruster
jes.soren...@redhat.com writes: From: Jes Sorensen jes.soren...@redhat.com This patch introduces cutils.c: strtosz() and gets rid of the multiple custom hacks for parsing byte sizes. In addition it adds supports for specifying human style sizes such as 1.5G. Last it eliminates the horrible

[Qemu-devel] Re: VM with two interfaces

2010-10-22 Thread Stefan Hajnoczi
On Thu, Oct 21, 2010 at 11:49 PM, Nirmal Guhan vavat...@gmail.com wrote: On Thu, Oct 21, 2010 at 9:23 AM, Nirmal Guhan vavat...@gmail.com wrote: Hi, Am trying to create a VM using qemu-kvm with two interfaces(fedora12 is the host and vm) and running into an issue. Given below is the command

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Kevin Wolf
Am 21.10.2010 21:32, schrieb Laurent Vivier: Le jeudi 21 octobre 2010 à 10:07 -0500, Anthony Liguori a écrit : On 10/21/2010 09:07 AM, Kevin Wolf wrote: Hi all, I'm currently looking into adding a return value to qemu's bdrv_flush function and I noticed that your block drivers (nbd, rbd and

Re: Fwd: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Kevin Wolf
[ Adding qemu-devel to CC again ] Am 21.10.2010 20:59, schrieb Sage Weil: On Thu, 21 Oct 2010, Christian Brunner wrote: Hi, is there a flush operation in librados? - I guess the only way to handle this, would be waiting until all aio requests are finished? That's not the semantics of

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Kevin Wolf
Am 22.10.2010 07:43, schrieb MORITA Kazutaka: At Thu, 21 Oct 2010 16:07:28 +0200, Kevin Wolf wrote: Hi all, I'm currently looking into adding a return value to qemu's bdrv_flush function and I noticed that your block drivers (nbd, rbd and sheepdog) don't implement bdrv_flush at all.

Re: [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it

2010-10-22 Thread Markus Armbruster
Jes Sorensen jes.soren...@redhat.com writes: On 10/22/10 09:59, Markus Armbruster wrote: jes.soren...@redhat.com writes: From: Jes Sorensen jes.soren...@redhat.com This patch introduces cutils.c: strtosz() and gets rid of the multiple custom hacks for parsing byte sizes. In addition it adds

[Qemu-devel] Re: [PATCH v6 08/12] pcie/aer: helper functions for pcie aer capability

2010-10-22 Thread Michael S. Tsirkin
On Fri, Oct 22, 2010 at 08:53:15AM +0900, Isaku Yamahata wrote: On Thu, Oct 21, 2010 at 10:07:01AM +0200, Michael S. Tsirkin wrote: On Thu, Oct 21, 2010 at 02:15:24PM +0900, Isaku Yamahata wrote: Thank you for detailed review. On Wed, Oct 20, 2010 at 11:56:16AM +0200, Michael S.

Re: [Qemu-devel] v6: [PATCH 0/3]: Threadlets: A generic task offloading framework

2010-10-22 Thread Amit Shah
On (Wed) Oct 20 2010 [08:18:51], Anthony Liguori wrote: On 10/20/2010 07:05 AM, Stefan Hajnoczi wrote: On Wed, Oct 20, 2010 at 12:57 PM, Amit Shahamit.s...@redhat.com wrote: On (Tue) Oct 19 2010 [23:12:20], Arun R Bharadwaj wrote: Hi, This is the v6 of the patch-series to have a generic

[Qemu-devel] Re: [PATCH 2/2] Replace remaining gcc format attributes by macro GCC_FMT_ATTR (format checking)

2010-10-22 Thread Stefan Weil
Am 13.10.2010 20:54, schrieb Stefan Weil: Replace the remaining format attribute printf by macro GCC_FMT_ATTR which uses gnu_printf (if supported). v2 * Removal of dyngen specific code is now done in a separate patch. * Handle attribute in new ui/spice-display.c, too. Cc: Blue

Re: [Qemu-devel] [PATCH 2/2] v2 Fix Block Hotplug race with drive_unplug()

2010-10-22 Thread Kevin Wolf
Am 21.10.2010 23:37, schrieb Ryan Harper: * Daniel P. Berrange berra...@redhat.com [2010-10-21 08:29]: On Tue, Oct 19, 2010 at 09:32:29AM -0500, Ryan Harper wrote: Block hot unplug is racy since the guest is required to acknowlege the ACPI unplug event; this may not happen synchronously with

Re: [Qemu-devel] Re: [PATCH v6 08/12] pcie/aer: helper functions for pcie aer capability

2010-10-22 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Wed, Oct 20, 2010 at 05:18:57PM +0900, Isaku Yamahata wrote: This patch implements helper functions for pcie aer capability which will be used later. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp Some style comments and a couple of

Re: [Qemu-devel] [PATCH]: VNC: set listener socket to non-blocking mode

2010-10-22 Thread Gianni Tedesco
On Thu, 2010-10-21 at 17:44 +0100, Anthony Liguori wrote: On 10/21/2010 11:18 AM, Gianni Tedesco wrote: This prevents qemu from hanging waiting for a client to connect. I have reproduced this when doing a loadvm but it may be a more general problem in that poll/accept may race if a client

Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce pushing attention button command

2010-10-22 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Wed, Oct 20, 2010 at 05:18:56PM +0900, Isaku Yamahata wrote: glue pcie_push_attention_button command. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp So as a high level command, I think we need to think about how to tie this into

[Qemu-devel] Re: [RESEND PATCH] monitor: properly handle illegal fd/vhostfd from command line

2010-10-22 Thread Luiz Capitulino
On Thu, 21 Oct 2010 19:29:02 +0800 Jason Wang jasow...@redhat.com wrote: When hanlding fd/vhostfd form command line through net_handle_fd_param(), we need to check mon and return value of strtol() other than we could get segmentation fault or invalid fd when user type an illegal fd/vhostfd.

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Luiz Capitulino
On Thu, 21 Oct 2010 15:27:23 +0200 Alon Levy al...@redhat.com wrote: On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: On 10/21/10 08:36, Alon Levy wrote: v2-v3 changes: * add configure parameter * fix docs v2

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Luiz Capitulino
On Fri, 22 Oct 2010 07:55:02 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 10/22/2010 07:48 AM, Luiz Capitulino wrote: On Thu, 21 Oct 2010 15:27:23 +0200 Alon Levyal...@redhat.com wrote: On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: On

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Anthony Liguori
On 10/22/2010 07:48 AM, Luiz Capitulino wrote: On Thu, 21 Oct 2010 15:27:23 +0200 Alon Levyal...@redhat.com wrote: On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: On 10/21/10 08:36, Alon Levy wrote:

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Anthony Liguori
On 10/22/2010 03:29 AM, Kevin Wolf wrote: I agree. Of course, as Laurent said a while ago, there is no specification for NBD, so it's hard to say what the intended semantics is. However, I did have a look at the nbdserver code and it looks as if it implements something similar to

Re: [Qemu-devel] [PATCH 0/6] First part of autoconfy series: cleanup tests/

2010-10-22 Thread Luiz Capitulino
On Thu, 21 Oct 2010 10:18:34 +0200 Paolo Bonzini pbonz...@redhat.com wrote: This is a small start from the autoconfy configure series. Actually, this part is almost completely new. It cleans up the tests Makefile so that the i386-linux-user testsuite's Makefile targets are more easily

Re: [Qemu-devel] [PATCH 0/7] [PULL] qemu-kvm.git uq/master queue

2010-10-22 Thread Anthony Liguori
On 10/21/2010 01:25 PM, Marcelo Tosatti wrote: The following changes since commit 633aa0acfe2c4d3e56acfe28c912796bf54de6d3: Fix pci hotplug to generate level triggered interrupt. (2010-10-20 17:23:28 -0500) Pulled. Thanks. Regards, Anthony Liguori are available in the git

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Kevin Wolf
Am 22.10.2010 14:58, schrieb Anthony Liguori: On 10/22/2010 03:29 AM, Kevin Wolf wrote: I agree. Of course, as Laurent said a while ago, there is no specification for NBD, so it's hard to say what the intended semantics is. However, I did have a look at the nbdserver code and it looks

Re: [Qemu-devel] [PATCH 0/6] First part of autoconfy series: cleanup tests/

2010-10-22 Thread Paolo Bonzini
On 10/22/2010 03:26 PM, Luiz Capitulino wrote: On Thu, 21 Oct 2010 10:18:34 +0200 Paolo Bonzinipbonz...@redhat.com wrote: This is a small start from the autoconfy configure series. Actually, this part is almost completely new. It cleans up the tests Makefile so that the i386-linux-user

[Qemu-devel] [PULL 00/11] Block patches

2010-10-22 Thread Kevin Wolf
The following changes since commit d03703c81a202cea156811e5dbc8e88627c19986: curses: Fix contro...@[\]^_} and ESC (2010-10-21 18:31:28 +0200) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Christoph Hellwig (1): ide: set WCACHE supported in

[Qemu-devel] [PATCH 02/11] qcow2: Simplify image creation

2010-10-22 Thread Kevin Wolf
Instead of doing lots of magic for setting up initial refcount blocks and stuff create a minimal (inconsistent) image, open it and initialize the rest with regular qcow2 functions. This is a complete rewrite of the image creation function. The old implementating is #ifdef'd out and will be

[Qemu-devel] [PATCH 03/11] qcow2: Remove old image creation function

2010-10-22 Thread Kevin Wolf
They have been #ifdef'd out by the previous patch. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c | 224 - 1 files changed, 0 insertions(+), 224 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 3b2e38c..45ed073

[Qemu-devel] [PATCH 04/11] ide: set WCACHE supported in IDENTIFY data

2010-10-22 Thread Kevin Wolf
From: Christoph Hellwig h...@lst.de ATA does not only have the WCACHE enabled bit in identify word 85, but also a WCACHE supported bit in word 82. While the Linux kernel is fine with the latter at least hdparm also needs the former before correctly displaying the cache settings. There's also a

[Qemu-devel] [PATCH 01/11] qcow2: Support exact L1 table growth

2010-10-22 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com The L1 table grow operation includes a size calculation that bumps up the new L1 table size in order to anticipate the size needs of vmstate data. This helps reduce the number of times that the L1 table has to be grown when vmstate data is

[Qemu-devel] [PATCH 05/11] Copy snapshots out of QCOW2 disk

2010-10-22 Thread Kevin Wolf
From: edison edi...@cloud.com In order to backup snapshots, created from QCOW2 iamge, we want to copy snapshots out of QCOW2 disk to a seperate storage. The following patch adds a new option in qemu-img: qemu-img convert -f qcow2 -O qcow2 -s snapshot_name src_img bck_img. Right now, it only

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Anthony Liguori
On 10/22/2010 08:17 AM, Luiz Capitulino wrote: You and Gerd asked about the purpose of this command, turns out that it's only useful for developing new USB devices for QEMU, so I thought it would be better to restrict it, so that people don't start using this the wrong way or worse, we can't

[Qemu-devel] [PATCH 06/11] qemu-io: New command map

2010-10-22 Thread Kevin Wolf
The new map command in qemu-io lists all allocated/unallocated areas in an image file. Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-io.c | 39 +++ 1 files changed, 39 insertions(+), 0 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index

[Qemu-devel] [PATCH 10/11] ide: Handle flush failure

2010-10-22 Thread Kevin Wolf
Instead of always assuming success for bdrv_aio_flush, actually do something with the error. This respects the werror option and accordingly ignores the error, reports it to the guest or stops the VM and retries after cont. Ignoring the error is trivial, obviously. For stopping the VM and

[Qemu-devel] [PATCH 09/11] ide: Factor ide_flush_cache out

2010-10-22 Thread Kevin Wolf
The next patch reuses this code, so put it in its own function. Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/ide/core.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 5ccb09c..6d8606e 100644 --- a/hw/ide/core.c +++

[Qemu-devel] [PATCH 07/11] block: Use GCC_FMT_ATTR and fix a format error

2010-10-22 Thread Kevin Wolf
From: Stefan Weil w...@mail.berlios.de Adding the gcc format attribute detects a format bug which is fixed here. v2: Don't use type cast. BDRV_SECTOR_SIZE is unsigned long long, so %lld should be the correct format specifier. Cc: Blue Swirl blauwir...@gmail.com Cc: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Anthony Liguori
On 10/22/2010 08:35 AM, Kevin Wolf wrote: Am 22.10.2010 14:58, schrieb Anthony Liguori: On 10/22/2010 03:29 AM, Kevin Wolf wrote: I agree. Of course, as Laurent said a while ago, there is no specification for NBD, so it's hard to say what the intended semantics is.

[Qemu-devel] [PATCH 08/11] qemu-img: Fix qemu-img convert -obacking_file

2010-10-22 Thread Kevin Wolf
The old -B option caused a backing file to be used for the converted image and to avoid copying clusters from the old backing file. When replaced with -obacking_file, qemu-img convert does assign the backing file to the new image, but it doesn't realize that it should avoid copying clusters from

Re: [Qemu-devel] [PATCH 1/2] usb-ccid: add CCID bus

2010-10-22 Thread Markus Armbruster
Alon Levy al...@redhat.com writes: A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1]

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Anthony Liguori
On 10/22/2010 08:57 AM, Kevin Wolf wrote: Am 22.10.2010 15:45, schrieb Anthony Liguori: On a physical system, if you don't have a battery backed disk and you enable the WC on your disk, then even with cache=writethrough we're unsafe. I don't think that's right. O_SYNC should

[Qemu-devel] [PATCH 1/4] Trivial fix for QMP/qmp-events.txt

2010-10-22 Thread Luiz Capitulino
From: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Fix example of STOP event that was just copy-and-pasted. Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-events.txt |2 +- 1 files changed, 1 insertions(+), 1

Re: [Qemu-devel] [PATCH 0/6] First part of autoconfy series: cleanup tests/

2010-10-22 Thread Luiz Capitulino
On Fri, 22 Oct 2010 15:38:34 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 10/22/2010 03:26 PM, Luiz Capitulino wrote: On Thu, 21 Oct 2010 10:18:34 +0200 Paolo Bonzinipbonz...@redhat.com wrote: This is a small start from the autoconfy configure series. Actually, this part is

Re: [Qemu-devel] [PATCH 0/6] First part of autoconfy series: cleanup tests/

2010-10-22 Thread Luiz Capitulino
On Fri, 22 Oct 2010 15:53:39 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 10/22/2010 03:44 PM, Luiz Capitulino wrote: We could also have check-i386, check-qmp, etc. and check would simply call all of them. That would be perfect, I think. I mean, if we could stick only to check

[Qemu-devel] [PATCH 2/4] Silence compiler warning in json test case

2010-10-22 Thread Luiz Capitulino
From: Jan Kiszka jan.kis...@web.de This avoids error: zero-length gnu_printf format string Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- check-qjson.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 3/4] Fix test suite build with tracing enabled

2010-10-22 Thread Luiz Capitulino
From: Jan Kiszka jan.kis...@siemens.com qemu_malloc instrumentations require linking against the trace objects. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Acked-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- Makefile | 12

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Luiz Capitulino
On Fri, 22 Oct 2010 08:43:39 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 10/22/2010 08:17 AM, Luiz Capitulino wrote: You and Gerd asked about the purpose of this command, turns out that it's only useful for developing new USB devices for QEMU, so I thought it would be better to

[Qemu-devel] [PATCH 11/11] virtio-blk: Respect werror option for flushes

2010-10-22 Thread Kevin Wolf
The werror option now affects not only write requests, but also flush requests. Previously, it was not possible to stop a VM on a failed flush. Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/virtio-blk.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PULL 0/4]: Monitor queue

2010-10-22 Thread Luiz Capitulino
Anthony, The following patches have been sent to the list and look good to me. I've also tested them. The changes (since d03703c81a202cea156811e5dbc8e88627c19986) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git for-anthony Hidetoshi Seto (1): Trivial

Re: [Qemu-devel] [PATCH 0/6] First part of autoconfy series: cleanup tests/

2010-10-22 Thread Paolo Bonzini
On 10/22/2010 03:44 PM, Luiz Capitulino wrote: We could also have check-i386, check-qmp, etc. and check would simply call all of them. That would be perfect, I think. I mean, if we could stick only to check to do all our unit-testing Well, the current make test is more integration testing

[Qemu-devel] [PATCH 4/4] monitor: Ignore . and .. when completing file name.

2010-10-22 Thread Luiz Capitulino
From: Kusanagi Kouichi sl...@ac.auone-net.jp Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 260cc02..61607c5 100644

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Kevin Wolf
Am 22.10.2010 15:45, schrieb Anthony Liguori: On a physical system, if you don't have a battery backed disk and you enable the WC on your disk, then even with cache=writethrough we're unsafe. I don't think that's right. O_SYNC should guarantee that the volatile disk cache is flushed.

Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce pushing attention button command

2010-10-22 Thread Michael S. Tsirkin
On Fri, Oct 22, 2010 at 01:35:47PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Wed, Oct 20, 2010 at 05:18:56PM +0900, Isaku Yamahata wrote: glue pcie_push_attention_button command. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp So as a high

Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce pushing attention button command

2010-10-22 Thread Anthony Liguori
On 10/22/2010 09:38 AM, Michael S. Tsirkin wrote: On Fri, Oct 22, 2010 at 01:35:47PM +0200, Markus Armbruster wrote: Michael S. Tsirkinm...@redhat.com writes: On Wed, Oct 20, 2010 at 05:18:56PM +0900, Isaku Yamahata wrote: glue pcie_push_attention_button command.

[Qemu-devel] (no subject)

2010-10-22 Thread Stefan Hajnoczi
QEMU Enhanced Disk format is a disk image format that forgoes features found in qcow2 in favor of better levels of performance and data integrity. Due to its simpler on-disk layout, it is possible to safely perform metadata updates more efficiently. Installations, suspend-to-disk, and other

[Qemu-devel] [PATCH v3 5/5] qed: Consistency check support

2010-10-22 Thread Stefan Hajnoczi
This patch adds support for the qemu-img check command. It also introduces a dirty bit in the qed header to mark modified images as needing a check. This bit is cleared when the image file is closed cleanly. If an image file is opened and it has the dirty bit set, a consistency check will run

[Qemu-devel] [PATCH v3 1/5] docs: Add QED image format specification

2010-10-22 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- docs/specs/qed_spec.txt | 128 +++ 1 files changed, 128 insertions(+), 0 deletions(-) create mode 100644 docs/specs/qed_spec.txt diff --git a/docs/specs/qed_spec.txt

[Qemu-devel] [PATCH v3 4/5] qed: Read/write support

2010-10-22 Thread Stefan Hajnoczi
This patch implements the read/write state machine. Operations are fully asynchronous and multiple operations may be active at any time. Allocating writes lock tables to ensure metadata updates do not interfere with each other. If two allocating writes need to update the same L2 table they will

[Qemu-devel] [PATCH v3 2/5] qed: Add QEMU Enhanced Disk image format

2010-10-22 Thread Stefan Hajnoczi
This patch introduces the qed on-disk layout and implements image creation. Later patches add read/write and other functionality. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- Makefile.objs |1 + block/qed.c | 546 +

[Qemu-devel] [PATCH v3 3/5] qed: Table, L2 cache, and cluster functions

2010-10-22 Thread Stefan Hajnoczi
This patch adds code to look up data cluster offsets in the image via the L1/L2 tables. The L2 tables are writethrough cached in memory for performance (each read/write requires a lookup so it is essential to cache the tables). With cluster lookup code in place it is possible to implement

Re: [Qemu-devel] [PATCH v3 0/5] qed: Add QEMU Enhanced Disk format

2010-10-22 Thread Stefan Hajnoczi
Subject line fixed. Stefan

[Qemu-devel] Re: [PATCH] sparc32: convert debug printf statements to tracepoints

2010-10-22 Thread Stefan Hajnoczi
On Thu, Oct 21, 2010 at 08:13:51PM +, Blue Swirl wrote: Replace debug printf statements with tracepoints. Signed-off-by: Blue Swirl blauwir...@gmail.com --- There were problems with tracetool if the tracepoint string contained parentheses or brackets, so I removed those. hw/cs4231.c

[Qemu-devel] Re: [RFC][PATCH 4/5] trace-event

2010-10-22 Thread Stefan Hajnoczi
On Thu, Oct 21, 2010 at 03:10:18PM +0530, Prerna Saxena wrote: trace-event : QMP interface to change state of a trace-event. (Analogous to hmp command : trace-event ) Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- qmp-commands.hx | 32 1

Re: [Qemu-devel] [PATCH 2/2] v3 Fix Block Hotplug race with drive_unplug()

2010-10-22 Thread Luiz Capitulino
On Thu, 21 Oct 2010 21:55:53 -0500 Ryan Harper ry...@us.ibm.com wrote: Block hot unplug is racy since the guest is required to acknowlege the ACPI unplug event; this may not happen synchronously with the device removal command This series aims to close a gap where by mgmt applications that

Re: [Qemu-devel] [PATCH 0/2] v3 Decouple block device removal from device removal

2010-10-22 Thread Luiz Capitulino
On Thu, 21 Oct 2010 21:55:51 -0500 Ryan Harper ry...@us.ibm.com wrote: This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires the guest to respond before qemu tears down the block device. In some

Re: [Qemu-devel] [PATCH 1/2] v2 Add drive_get_by_id

2010-10-22 Thread Luiz Capitulino
On Thu, 21 Oct 2010 21:55:52 -0500 Ryan Harper ry...@us.ibm.com wrote: Add a function to find a drive by id string. Changes since v1: -Coding Style fix Signed-off-by: Ryan Harper ry...@us.ibm.com --- blockdev.c | 13 + blockdev.h |1 + 2 files changed, 14

Re: [Qemu-devel] [PATCH 0/2] v3 Decouple block device removal from device removal

2010-10-22 Thread Kevin Wolf
Am 22.10.2010 17:48, schrieb Luiz Capitulino: On Thu, 21 Oct 2010 21:55:51 -0500 Ryan Harper ry...@us.ibm.com wrote: This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires the guest to respond

[Qemu-devel] [PATCH] usb-linux: allow multiple devices with matching IDs

2010-10-22 Thread Grazvydas Ignotas
Right now if we pass through multiple USB devices with matching vendor and product IDs, only first one is passed to guest, as the code thinks second device is already attached. The only way to get those devices working is to specify bus.addr which is inconvenient if devices are frequently

Re: [Qemu-devel] [PATCH 0/2] v3 Decouple block device removal from device removal

2010-10-22 Thread Ryan Harper
* Kevin Wolf kw...@redhat.com [2010-10-22 11:12]: Am 22.10.2010 17:48, schrieb Luiz Capitulino: On Thu, 21 Oct 2010 21:55:51 -0500 Ryan Harper ry...@us.ibm.com wrote: This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of

Re: Fwd: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Sage Weil
On Fri, 22 Oct 2010, Kevin Wolf wrote: [ Adding qemu-devel to CC again ] Am 21.10.2010 20:59, schrieb Sage Weil: On Thu, 21 Oct 2010, Christian Brunner wrote: Hi, is there a flush operation in librados? - I guess the only way to handle this, would be waiting until all aio requests

Re: [Qemu-devel] [PATCH 2/4] Silence compiler warning in json test case

2010-10-22 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: From: Jan Kiszka jan.kis...@web.de This avoids error: zero-length gnu_printf format string Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- check-qjson.c |4 +++- 1 files

Re: [Qemu-devel] KVM call minutes for Oct 19

2010-10-22 Thread Anthony Liguori
On 10/22/2010 12:29 PM, Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: The first step is just identifying what interfaces we need in a guest agent. So far, I think we can get away with a very small number of interfaces (mainly read/write files, execute command).

Re: [Qemu-devel] [PATCH 2/4] Silence compiler warning in json test case

2010-10-22 Thread Luiz Capitulino
On Fri, 22 Oct 2010 19:15:07 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: From: Jan Kiszka jan.kis...@web.de This avoids error: zero-length gnu_printf format string Signed-off-by: Jan Kiszka jan.kis...@siemens.com

Re: [Qemu-devel] KVM call minutes for Oct 19

2010-10-22 Thread Chris Wright
* Anthony Liguori (anth...@codemonkey.ws) wrote: The first step is just identifying what interfaces we need in a guest agent. So far, I think we can get away with a very small number of interfaces (mainly read/write files, execute command). Could you elaborate here? I can't imagine you mean:

[Qemu-devel] Re: [PATCH] sparc32: convert debug printf statements to tracepoints

2010-10-22 Thread Blue Swirl
On Fri, Oct 22, 2010 at 3:22 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: On Thu, Oct 21, 2010 at 08:13:51PM +, Blue Swirl wrote: Replace debug printf statements with tracepoints. Signed-off-by: Blue Swirl blauwir...@gmail.com --- There were problems with tracetool if the

Re: [Qemu-devel] [PATCH 3/3] Add helper functions to enable virtio-9p make use of the threadlets

2010-10-22 Thread Venkateswararao Jujjuri (JV)
On 10/21/2010 5:10 AM, Arun R Bharadwaj wrote: From: Gautham R Shenoy e...@in.ibm.com infrastructure for offloading blocking tasks such as making posix calls on to the helper threads and handle the post_posix_operations() from the context of the iothread. This frees the vcpu thread to

[Qemu-devel] Chandra invites you to MySpace

2010-10-22 Thread Myspace
Hello, I'm a member of the MySpace community and thought you'd like to join too. Join MySpace and you will

Re: [Qemu-devel] KVM call minutes for Oct 19

2010-10-22 Thread Chris Wright
* Anthony Liguori (anth...@codemonkey.ws) wrote: On 10/22/2010 12:29 PM, Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: The first step is just identifying what interfaces we need in a guest agent. So far, I think we can get away with a very small number of interfaces

[Qemu-devel] Re: [PATCH 2/2] Replace remaining gcc format attributes by macro GCC_FMT_ATTR (format checking)

2010-10-22 Thread Blue Swirl
Thanks, applied both. On Fri, Oct 22, 2010 at 10:33 AM, Stefan Weil w...@mail.berlios.de wrote: Am 13.10.2010 20:54, schrieb Stefan Weil: Replace the remaining format attribute printf by macro GCC_FMT_ATTR which uses gnu_printf (if supported). v2 * Removal of dyngen specific code is now

[Qemu-devel] [PATCH] Use '_raw' memory access primitives

2010-10-22 Thread Lluís
Using a pointer on the host should not go through lduw. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- linux-user/signal.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 77683f7..097da9d 100644 ---

[Qemu-devel] [PATCH] Allow generation of helpers with 5 arguments

2010-10-22 Thread Lluís
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- def-helper.h | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/def-helper.h b/def-helper.h index 8a822c7..7abaf76 100644 --- a/def-helper.h +++ b/def-helper.h @@ -118,6 +118,8 @@

[Qemu-devel] [PATCH] [arm m68k] Move helpers.h to helper.h

2010-10-22 Thread Lluís
This provides a consistent naming scheme across all targets. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- target-arm/helper.c|2 +- target-arm/helper.h| 450 target-arm/helpers.h | 450

[Qemu-devel] [PATCH] Refactor flush of per-CPU virtual TB cache

2010-10-22 Thread Lluís
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- exec-all.h |2 ++ exec.c |9 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/exec-all.h b/exec-all.h index 3a53fe6..2ae09c5 100644 --- a/exec-all.h +++ b/exec-all.h @@ -182,6 +182,8 @@ static inline

[Qemu-devel] [RFC][PATCH 02/15] virtproxy: qemu-vp, standalone daemon skeleton

2010-10-22 Thread Michael Roth
Daemon to be run in guest, or on host in standalone mode. (re-)implements some qemu utility functions used by core virtproxy.c code via wrapper functions. For built-in virtproxy code we will define these wrapper functions in terms of qemu's built-in implementations. Main logic will come in a

[Qemu-devel] [RFC][PATCH 09/15] virtproxy: add handler for data packets

2010-10-22 Thread Michael Roth
Process VPPackets coming in from channel and send them to the appropriate server/client connections. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [RFC][PATCH 08/15] virtproxy: interfaces to set/remove/handle VPOForwards

2010-10-22 Thread Michael Roth
Functions to add listener FDs (oforwards) which set up proxied connections to associated service, and the corresponding handler function to process to new connections to said FDs and initialize new client connections to the associated remote server over the channel Signed-off-by: Michael Roth

[Qemu-devel] [RFC][PATCH 06/15] virtproxy: add read handler for communication channel

2010-10-22 Thread Michael Roth
Handle data coming in over the channel as VPPackets: Process control messages and forward data from remote client/server connections to the appropriate server/client FD on our end. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 83

[Qemu-devel] [RFC][PATCH 11/15] virtproxy: add vp_handle_packet()

2010-10-22 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 4f56aba..5ec4e77 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -431,6 +431,29 @@ static int

[Qemu-devel] [RFC][PATCH 03/15] virtproxy: add debug functions for virtproxy core

2010-10-22 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index f30b859..2f8996c 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -13,6 +13,23 @@ #include virtproxy.h

[Qemu-devel] [RFC][PATCH 07/15] virtproxy: add vp_new() VPDriver constructor

2010-10-22 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 23 +++ virtproxy.h |3 +++ 2 files changed, 26 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index c9c3022..cc0ac9a 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -313,3

[Qemu-devel] [RFC][PATCH 10/15] virtproxy: add handler for control packet

2010-10-22 Thread Michael Roth
Process control packets coming in over the channel. This entails setting up/tearing down connections to local services initiated from the other end of the channel. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 154

[Qemu-devel] [RFC][PATCH 00/15] virtproxy: host/guest communication layer

2010-10-22 Thread Michael Roth
OVERVIEW: Virtproxy proxies and multiplexes socket streams over a data channel between a host and a guest (currently network connections, emulated serial, or virtio-serial channels are supported). This allows for services such as guest data collection agents, host/guest file transfer, and

[Qemu-devel] [RFC][PATCH 01/15] virtproxy: base data structures and constants

2010-10-22 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 134 +++ virtproxy.h | 34 +++ 2 files changed, 168 insertions(+), 0 deletions(-) create mode 100644 virtproxy.c create mode 100644 virtproxy.h diff

[Qemu-devel] [PATCH 00/17] [RFC] static instrumentation

2010-10-22 Thread Lluís
Here's a set of patches with the current state of static instrumentation. Hope that this organization will help understanding the point of it. Patch 9 describes the taken approach for instrumenting during code generation, which is the main point of this. Code can also be reached at:

[Qemu-devel] [RFC][PATCH 12/15] virtproxy: interfaces to set/remove VPIForwards

2010-10-22 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 59 +++ virtproxy.h |2 ++ 2 files changed, 61 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 5ec4e77..86a8e5b 100644 ---

[Qemu-devel] [RFC][PATCH 02/10] virtagent: base definitions for host/guest RPC daemon

2010-10-22 Thread Michael Roth
Basic skeleton code for RPC daemon loop. This is shared by both the guest-side RPC server as well as the host-side one (the advertised RPCs for each by guest/host-specific arrays). Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtagent-daemon.c | 118

[Qemu-devel] [RFC][PATCH 14/15] virtproxy: Makefile/configure changes to build qemu-vp

2010-10-22 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- .gitignore |1 + Makefile |4 +++- configure |1 + 3 files changed, 5 insertions(+), 1 deletions(-) diff --git a/.gitignore b/.gitignore index a43e4d1..da307d2 100644 --- a/.gitignore +++ b/.gitignore @@ -31,6 +31,7 @@

[Qemu-devel] [RFC][PATCH 01/10] virtagent: add common rpc transport defs

2010-10-22 Thread Michael Roth
Common code for sending/recieving RPCs via http over virtproxy channel. Eventually these will all be switched to asynchronous handlers to avoid deadlocks between qemu and the guest. For now we can usually get away with just doing asynchronous reads for http/RPC responses if we don't send large RPC

[Qemu-devel] [RFC][PATCH 05/15] virtproxy: add accept handler for communication channel

2010-10-22 Thread Michael Roth
This accept()'s connections to the socket we told virt-proxy to listen for the channel connection on and sets the appropriate read handler for the resulting FD. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 37 + 1 files changed, 37

[Qemu-devel] [RFC][PATCH 08/10] virtagent: add agent_viewdmesg command

2010-10-22 Thread Michael Roth
Add commands to view guest dmesg output. Currently it is a 16K buffer. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- hmp-commands.hx | 16 + qmp-commands.hx | 35 +++ virtagent.c | 100 +++

  1   2   >