Re: [Qemu-devel] [Bug 722311] [NEW] Segmentation fault if started without -enable-kvm parameter

2011-02-21 Thread Markus Armbruster
Bug Reporter 722...@bugs.launchpad.net writes: Public bug reported: I start qemu (Linux) from the same USB memory stick on several computers. Up to and including qemu 0.12.5, I could use or not use qemu's -enable-kvm command line parameter as appropriate for the hardware, and qemu would

[Qemu-devel] Re: [PATCH 2/7] implement win32 dynticks timer

2011-02-21 Thread Paolo Bonzini
On 02/20/2011 10:15 PM, Blue Swirl wrote: On Thu, Feb 10, 2011 at 7:37 PM, Paolo Bonzinipbonz...@redhat.com wrote: Signed-off-by: Paolo Bonzinipbonz...@redhat.com Cc: Stefan Weilw...@mail.berlios.de Cc: Blue Swirlblauwir...@gmail.com --- qemu-timer.c |6 +- 1 files changed, 5

[Qemu-devel] Re: qemu-0.14.0 doesn't compile on ppc32

2011-02-21 Thread Paolo Bonzini
On 02/20/2011 06:32 PM, Peter Maydell wrote: On 20 February 2011 16:56, Aurelien Jarnoaurel...@aurel32.net wrote: On Sun, Feb 20, 2011 at 03:01:12PM +0100, nello martuscielli wrote: CCx86_64-softmmu/translate.o {standard input}: Assembler messages: {standard input}:11903788: Warning:

[Qemu-devel] Re: [PATCH] scripts: add a guard macro in generated .h files

2011-02-21 Thread Paolo Bonzini
On 02/21/2011 07:42 AM, Tristan Gingold wrote: Mostly a style issue. It is common to always protect header files against multiple inclusion, unless the header is meant to be included several times (which is not the case for these config files). I think this is a good practice. Traditionally,

[Qemu-devel] Re: How can I understand CONFIG_IO_THREAD ?

2011-02-21 Thread Paolo Bonzini
On 02/21/2011 04:13 AM, wang sheng wrote: What is the purpose of io_thread desigment in qemu ? There was a lengthy thread recently explaining how it helps fixing a possibly delay in handling I/O. It is also useful for KVM, where you have one I/O thread and multiple CPU threads. This way,

Re: [Qemu-devel] [RFC][PATCH v6 00/23] virtagent: host/guest RPC communication agent

2011-02-21 Thread Jes Sorensen
On 02/18/11 15:57, Anthony Liguori wrote: On 02/18/2011 08:30 AM, Jes Sorensen wrote: However if there's an agent connection, it could be arranged in a way allowing the host to reconnect to the guest agent. In that way it really shouldn't be a big deal as long as our agent commands aren't too

[Qemu-devel] Re: GSOC 2011 (KVM for MIPS)

2011-02-21 Thread Jan Kiszka
On 2011-02-21 02:09, yajin wrote: On Sun, Feb 20, 2011 at 9:16 AM, Jan Kiszka jan.kis...@web.de wrote: On 2011-02-20 14:08, Aurelien Jarno wrote: On Wed, Feb 16, 2011 at 07:32:31PM -0500, yajin wrote: Hi all, Hi, I have proposed an idea of GSOC 2011 about adding KVM support to MIPS

[Qemu-devel] [PATCH 01/21] unlock iothread during WaitForMultipleObjects

2011-02-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- os-win32.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/os-win32.c b/os-win32.c index b214e6a..c971d92 100644 --- a/os-win32.c +++ b/os-win32.c @@ -140,7 +140,9 @@ void os_host_main_loop_wait(int *timeout)

[Qemu-devel] [PATCH uq/master 00/21] Win32 iothread support

2011-02-21 Thread Paolo Bonzini
After gathering the comments about the two series I sent separately, here is the full series for Win32 iothread support, ready to be applied to uq/master. Patches 1 to 5 are generic Win32 improvements, including the qemu-thread implementation. Because of complex dependencies, I think it's better

[Qemu-devel] [PATCH 12/21] always signal pause_cond after stopping a VCPU

2011-02-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/cpus.c b/cpus.c index 912e0d8..670a42d 100644 --- a/cpus.c +++ b/cpus.c @@ -1012,8 +1012,10 @@ void qemu_notify_event(void) void cpu_stop_current(void) { if

[Qemu-devel] [PATCH 05/21] add win32 qemu-thread implementation

2011-02-21 Thread Paolo Bonzini
For now, qemu_cond_timedwait and qemu_mutex_timedlock are left as POSIX-only functions. They can be removed later, once the patches that remove their uses are in. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile.objs|4 +- qemu-thread.c =

[Qemu-devel] [PATCH 02/21] implement win32 dynticks timer

2011-02-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index b0db780..e6b926b 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -1006,6 +1006,7 @@ static void

[Qemu-devel] [PATCH 07/21] add assertions on the owner of a QemuMutex

2011-02-21 Thread Paolo Bonzini
These are already present in the Win32 implementation, add them to the pthread wrappers as well. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-thread-posix.c | 27 +-- qemu-thread-posix.h |1 + 2 files changed, 26 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH 10/21] always qemu_cpu_kick after unhalting a cpu

2011-02-21 Thread Paolo Bonzini
This ensures env-halt_cond is broadcast, and the loop in qemu_tcg_wait_io_event and qemu_kvm_wait_io_event is exited naturally rather than through a timeout. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/apic.c |1 + hw/ppc.c |2 ++ hw/sun4m.c | 10

[Qemu-devel] [PATCH 03/21] use win32 timer queues

2011-02-21 Thread Paolo Bonzini
Multimedia timers are only useful for compatibility with Windows NT 4.0 and earlier. Plus, the implementation in Wine is extremely heavyweight. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c | 86 +++-- 1 files changed, 35

[Qemu-devel] [PATCH 04/21] replace qemu_thread_equal API with qemu_thread_is_current

2011-02-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c| 10 ++ qemu-thread.c |4 ++-- qemu-thread.h |2 +- 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/cpus.c b/cpus.c index 0f33945..aa30474 100644 --- a/cpus.c +++ b/cpus.c @@ -891,11 +891,8 @@

[Qemu-devel] [PATCH 08/21] remove CONFIG_THREAD

2011-02-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 791b71d..45a5440 100755 --- a/configure +++ b/configure @@ -2660,7 +2660,6 @@ if test $vnc_png != no ; then fi if test $vnc_thread

[Qemu-devel] [PATCH 14/21] do not use timedwait on qemu_system_cond

2011-02-21 Thread Paolo Bonzini
qemu_main_loop_start is the only place where qemu_system_ready is set to 1. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index 868857d..8c147bc 100644 --- a/cpus.c +++ b/cpus.c @@ -823,7

[Qemu-devel] [PATCH 13/21] do not use timedwait on qemu_halt_cond

2011-02-21 Thread Paolo Bonzini
The following conditions can cause cpu_has_work(env) to become true: * env-queued_work_first: run_on_cpu is already kicking the VCPU * env-stop = 1: pause_all_vcpus is already kicking the VCPU * env-stopped = 0: resume_all_vcpus is already kicking the VCPU * vm_running = 1: vm_start is calling

[Qemu-devel] [PATCH 11/21] exit round-robin vcpu loop if cpu-stopped is true

2011-02-21 Thread Paolo Bonzini
Sometimes vcpus are stopped directly without going through -stop = 1. Exit the VCPU execution loop in this case as well. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpus.c b/cpus.c index 7a9440f..912e0d8

[Qemu-devel] [PATCH 18/21] move blocking of signals to qemu_signalfd_init

2011-02-21 Thread Paolo Bonzini
This makes it easier to add a Win32 stub. The patch does that, too. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c | 87 ++- 1 files changed, 36 insertions(+), 51 deletions(-) diff --git a/cpus.c b/cpus.c index

[Qemu-devel] [PATCH 06/21] include qemu-thread.h early

2011-02-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index aa30474..7a9440f 100644 --- a/cpus.c +++ b/cpus.c @@ -32,6 +32,7 @@ #include kvm.h #include exec-all.h +#include qemu-thread.h #include

[Qemu-devel] [PATCH 19/21] provide dummy signal init functions for win32

2011-02-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c | 143 --- 1 files changed, 73 insertions(+), 70 deletions(-) diff --git a/cpus.c b/cpus.c index 5bb95d8..c2c139c 100644 --- a/cpus.c +++ b/cpus.c @@ -196,6 +196,16 @@ static

[Qemu-devel] [PATCH 15/21] do not use timedwait on qemu_pause_cond

2011-02-21 Thread Paolo Bonzini
all_vcpus_paused can start returning true after penv-stopped changes from 0 to 1. When this is done, qemu_pause_cond is always signaled. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpus.c b/cpus.c index

[Qemu-devel] [PATCH 09/21] inline cpu_halted into sole caller

2011-02-21 Thread Paolo Bonzini
All implementations are now the same except SH, which can fit in the default implementation easily. The newly added flag will not make much sense on non-SH platforms, but I left it anyway. You could be moved to common code. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Cc: Aurelien Jarno

Re: [Qemu-devel] Re: Network bridging without adding bridge with brctl, possible?

2011-02-21 Thread Jan Kiszka
On 2011-02-21 07:40, Gerhard Wiesinger wrote: On Sun, 20 Feb 2011, Arnd Bergmann wrote: On Sunday 20 February 2011, Gerhard Wiesinger wrote: qemu-system-x86_64 ... some params ... -net nic,model=e1000,macaddr=1a:46:0b:ca:bc:7c -net tap,fd=3 3/dev/tap10 Seems to me quite logically because

[Qemu-devel] [PATCH 17/21] iothread stops the vcpu thread via IPI

2011-02-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/cpus.c b/cpus.c index eeb..1b6893d 100644 --- a/cpus.c +++ b/cpus.c @@ -1086,9 +1086,11 @@ bool cpu_exec_all(void) qemu_clock_enable(vm_clock,

[Qemu-devel] [PATCH 3/4] rewrite accounting of wait time to the vm_clock

2011-02-21 Thread Paolo Bonzini
The current code is advancing qemu_icount before waiting for I/O. Instead, after the patch qemu_icount is left aside (it is a pure instruction counter) and qemu_icount_bias is changed according to the actual amount of time spent in the wait. This is more accurate, and actually works in the

[Qemu-devel] [PATCH 16/21] do not use timedwait on qemu_cpu_cond

2011-02-21 Thread Paolo Bonzini
Whenever env-created becomes true, qemu_cpu_cond is signaled by {kvm,tcg}_cpu_thread_fn. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index 66fd384..eeb 100644 --- a/cpus.c +++ b/cpus.c

[Qemu-devel] [PATCH RESEND 2/3] virtio-serial: Disallow generic ports at id 0

2011-02-21 Thread Amit Shah
It was found libvirt was using port 0 for generic ports. It has been fixed in libvirt commit 8e28c5d40200b4c5d483bd585d237b9d870372e5. Port 0 is reserved for virtconsole devices for backward compatibility with the old -virtioconsole (from qemu 0.12) device type. Ensure we don't allow

[Qemu-devel] [PATCH 0/4] Improve -icount, fix it with iothread

2011-02-21 Thread Paolo Bonzini
This series redoes the way time spent waiting for I/O is accounted to the vm_clock. The current code is advancing qemu_icount before waiting for I/O. Instead, after the patch qemu_icount is left aside (it is a pure instruction counter) and qemu_icount_bias is changed according to the actual

[Qemu-devel] [PATCH 2/4] qemu_next_deadline should not consider host-time timers

2011-02-21 Thread Paolo Bonzini
It is purely for icount-based virtual timers. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 88c7b28..06fa507 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@

[Qemu-devel] [PATCH 20/21] protect qemu_cpu_kick_self for Win32

2011-02-21 Thread Paolo Bonzini
The non-iothread version is already protected. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/cpus.c b/cpus.c index c2c139c..fd791a3 100644 --- a/cpus.c +++ b/cpus.c @@ -867,12 +867,16 @@ void

[Qemu-devel] [PATCH 4/4] inline qemu_icount_delta

2011-02-21 Thread Paolo Bonzini
In order to improve accuracy with -icount N, we inline qemu_icount_delta into qemu_calculate_timeout. This way, we can still avoid that virtual time gets too far ahead of real time when using low speeds. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c | 26

[Qemu-devel] [PATCH 21/21] add Win32 IPI service

2011-02-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c | 23 --- qemu-thread-posix.c |9 - qemu-thread-posix.h |1 - 3 files changed, 20 insertions(+), 13 deletions(-) diff --git a/cpus.c b/cpus.c index fd791a3..869ed1a 100644 --- a/cpus.c

Re: [Qemu-devel] Re: How can I understand CONFIG_IO_THREAD ?

2011-02-21 Thread Avi Kivity
On 02/21/2011 10:16 AM, Paolo Bonzini wrote: On 02/21/2011 04:13 AM, wang sheng wrote: What is the purpose of io_thread desigment in qemu ? There was a lengthy thread recently explaining how it helps fixing a possibly delay in handling I/O. It is also useful for KVM, where you have one I/O

[Qemu-devel] Re: [PATCH 04/21] replace qemu_thread_equal API with qemu_thread_is_current

2011-02-21 Thread Jan Kiszka
On 2011-02-21 09:43, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c| 10 ++ qemu-thread.c |4 ++-- qemu-thread.h |2 +- 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/cpus.c b/cpus.c index 0f33945..aa30474

[Qemu-devel] [PULL] virtio-serial: fixes, enable ioeventfd

2011-02-21 Thread Amit Shah
The following changes since commit 57a8821bc6e4457230075a5c8da5f8a083889686: w32: Remove implementation of function ffs (2011-02-20 20:18:21 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git for-anthony Amit Shah (3):

[Qemu-devel] [PATCH 1/4] do not use qemu_icount_delta in the !use_icount case

2011-02-21 Thread Paolo Bonzini
The !use_icount code is the same for iothread and non-iothread, except that the timeout is different. Since the timeout might as well be infinite and is only masking bugs, use the higher value. With this change the !use_icount code is handled equivalently in qemu_icount_delta and

[Qemu-devel] [PATCH RESEND 1/3] virtio-serial: Use a struct to pass config information from proxy

2011-02-21 Thread Amit Shah
Instead of using a single variable to pass to the virtio_serial_init function, use a struct so that expanding the number of variables to be passed on later is easier. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-pci.c| 12 ++-- hw/virtio-serial-bus.c | 16

Re: [Qemu-devel] Re: [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-02-21 Thread Yoshiaki Tamura
Hi Green, 2011/2/21 ya su suya94...@gmail.com: Yoshiaki:     I have one question about ram_save_live, during migration 3 stage(completation stage), it will call cpu_physical_memory_set_dirty_tracking(0) to stop recording ram dirty pages. at the end of migrate_ft_trans_connect function, it

Re: [Qemu-devel] Re: Strategic decision: COW format

2011-02-21 Thread Kevin Wolf
Am 20.02.2011 23:13, schrieb Aurelien Jarno: On Fri, Feb 18, 2011 at 10:57:05AM +0100, Kevin Wolf wrote: Am 18.02.2011 10:12, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 15.02.2011 20:45, schrieb Chunqiang Tang: Chunqiang Tang/Watson/IBM wrote on 01/28/2011 05:13:27 PM:

[Qemu-devel] Re: [PATCH 10/21] always qemu_cpu_kick after unhalting a cpu

2011-02-21 Thread Jan Kiszka
On 2011-02-21 09:43, Paolo Bonzini wrote: This ensures env-halt_cond is broadcast, and the loop in qemu_tcg_wait_io_event and qemu_kvm_wait_io_event is exited naturally rather than through a timeout. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/apic.c |1 +

[Qemu-devel] [PATCH RESEND 3/3] virtio-serial: Enable ioeventfd

2011-02-21 Thread Amit Shah
Enable ioeventfd for virtio-serial devices by default. Commit 25db9ebe15125deb32958c6df74996f745edf1f9 lists the benefits of using ioeventfd. Copying a file from guest to host over a virtio-serial channel didn't show much difference in time or io_exit rate. Signed-off-by: Amit Shah

[Qemu-devel] [PATCH RESEND] char: Prevent multiple devices opening same chardev

2011-02-21 Thread Amit Shah
Prevent: -chardev socket,path=/tmp/foo,server,nowait,id=c0 \ -device virtserialport,chardev=c0,id=vs0 \ -device virtserialport,chardev=c0,id=vs1 Reported-by: Mike Cao b...@redhat.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/qdev-properties.c |7 ++- qemu-char.h |

[Qemu-devel] Re: [PATCH 07/21] add assertions on the owner of a QemuMutex

2011-02-21 Thread Jan Kiszka
On 2011-02-21 09:43, Paolo Bonzini wrote: These are already present in the Win32 implementation, add them to the pthread wrappers as well. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-thread-posix.c | 27 +-- qemu-thread-posix.h |1 + 2 files

Re: [Qemu-devel] [PATCH 2/4] softfloat: add float32_set_sign(), float32_infinity, float64_half, float64_256 and float64_512.

2011-02-21 Thread Christophe Lyon
On 20.02.2011 23:20, Aurelien Jarno wrote: On Sun, Feb 20, 2011 at 10:09:46PM +, Peter Maydell wrote: On 20 February 2011 21:52, Aurelien Jarno aurel...@aurel32.net wrote: While it's probably a good idea to define the commonly used values in softfloat.h, I don't think we should have all

[Qemu-devel] Re: [PATCH 18/21] move blocking of signals to qemu_signalfd_init

2011-02-21 Thread Jan Kiszka
On 2011-02-21 09:43, Paolo Bonzini wrote: This makes it easier to add a Win32 stub. The patch does that, too. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c | 87 ++- 1 files changed, 36 insertions(+), 51

[Qemu-devel] Re: [PATCH 07/21] add assertions on the owner of a QemuMutex

2011-02-21 Thread Paolo Bonzini
On 02/21/2011 10:50 AM, Jan Kiszka wrote: +/* An EDEADLOCK would arrive after we reset the owner. So this + assert is for ease of debugging (it lets you see what is the + actual owner. */ Don't get this. Why do you want to avoid the proper error detection of pthread?

[Qemu-devel] Re: [PATCH 18/21] move blocking of signals to qemu_signalfd_init

2011-02-21 Thread Paolo Bonzini
On 02/21/2011 11:12 AM, Jan Kiszka wrote: On 2011-02-21 09:43, Paolo Bonzini wrote: This makes it easier to add a Win32 stub. The patch does that, too. Signed-off-by: Paolo Bonzinipbonz...@redhat.com --- cpus.c | 87 ++- 1 files

[Qemu-devel] Re: [PATCH 07/21] add assertions on the owner of a QemuMutex

2011-02-21 Thread Jan Kiszka
On 2011-02-21 11:15, Paolo Bonzini wrote: On 02/21/2011 10:50 AM, Jan Kiszka wrote: +/* An EDEADLOCK would arrive after we reset the owner. So this + assert is for ease of debugging (it lets you see what is the + actual owner. */ Don't get this. Why do you want to avoid

[Qemu-devel] Re: [PATCH 07/21] add assertions on the owner of a QemuMutex

2011-02-21 Thread Paolo Bonzini
On 02/21/2011 11:22 AM, Jan Kiszka wrote: That's easy, pmy_mutex will tell (the structure contains the owner's tid). And for debugging invalid mutex_unlock calls, it's more interesting to track the call path of that thread which incorrectly claimed to hold the lock. Ok, will remove. Paolo

[Qemu-devel] Re: [PATCH 18/21] move blocking of signals to qemu_signalfd_init

2011-02-21 Thread Jan Kiszka
On 2011-02-21 11:20, Paolo Bonzini wrote: On 02/21/2011 11:12 AM, Jan Kiszka wrote: On 2011-02-21 09:43, Paolo Bonzini wrote: This makes it easier to add a Win32 stub. The patch does that, too. Signed-off-by: Paolo Bonzinipbonz...@redhat.com --- cpus.c | 87

[Qemu-devel] [PATCH v2 0/2] target-arm: fix shift where src, dest overlap

2011-02-21 Thread Peter Maydell
This patchset is a replacement for the unapplied patch 10/10 of my shift-fixes series (http://patchwork.ozlabs.org/patch/83248/) which corrects the compilation failure. Since the fix involves refactoring to pull out some code into a separate function and then pulling the size check outside of the

[Qemu-devel] [PATCH v2 1/2] target-arm: Refactor to pull narrowing decode into separate function

2011-02-21 Thread Peter Maydell
Pull the code which decodes narrowing operations as being either signed/unsigned saturate or plain out into its own function. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c | 45 +++-- 1 files changed, 19 insertions(+),

[Qemu-devel] [PATCH v2 2/2] target-arm: Fix shift by immediate and narrow where src, dest overlap

2011-02-21 Thread Peter Maydell
For Neon shifts by immediate and narrow, correctly handle the case where the source registers and the destination registers overlap (the second pass should use the original register contents, not the results of the first pass). This includes a refactoring to pull the size check outside the loop

[Qemu-devel] [PATCH 3/5] target-arm: Introduce float64_256 and float64_512 constants.

2011-02-21 Thread Christophe Lyon
These two constants will be used by helper functions such as recpe_f32 and rsqrte_f32. Signed-off-by: Christophe Lyon christophe.l...@st.com --- target-arm/helper.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index

[Qemu-devel] [PATCH 5/5] target-arm: fix support for VRSQRTE.

2011-02-21 Thread Christophe Lyon
Now use the same algorithm as described in the ARM ARM. Signed-off-by: Christophe Lyon christophe.l...@st.com --- target-arm/helper.c | 121 ++ 1 files changed, 111 insertions(+), 10 deletions(-) diff --git a/target-arm/helper.c

[Qemu-devel] [PATCH 2/5] softfloat: add _set_sign(), _infinity and _half for 32 and 64 bits floats.

2011-02-21 Thread Christophe Lyon
These constants and utility function are needed to implement some helpers. Defining constants avoids the need to re-compute them at runtime. Signed-off-by: Christophe Lyon christophe.l...@st.com --- fpu/softfloat.h | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH 4/5] target-arm: fix support for VRECPE.

2011-02-21 Thread Christophe Lyon
Now use the same algorithm as described in the ARM ARM. Signed-off-by: Christophe Lyon christophe.l...@st.com --- target-arm/helper.c | 83 +++--- 1 files changed, 71 insertions(+), 12 deletions(-) diff --git a/target-arm/helper.c

[Qemu-devel] [PATCH 1/5] softfloat: move all default NaN definitions to softfloat.h.

2011-02-21 Thread Christophe Lyon
These special values are needed to implement some helper functions, which return/use these values in some cases. Signed-off-by: Christophe Lyon christophe.l...@st.com --- fpu/softfloat-specialize.h | 68 --- fpu/softfloat.h| 69

[Qemu-devel] [PATCH v5 0/5] ARM: fix Neon VRECPE and VRSQRTE instructions.

2011-02-21 Thread Christophe Lyon
These 5 patches fix the ARM Neon VRECPE and VRSQRTE instructions by matching the algorithms descibed in the ARM ARM. Patches #1 and the last two are unchanged compared to v4 (except that patches 3 and 4 are now 4 and 5). V4 patch #2 has been split into #2 and #3, to take Aurelien Jarno's

[Qemu-devel] [PATCH v3 0/2] target-arm: fix shift where src, dest overlap

2011-02-21 Thread Peter Maydell
This patchset is a replacement for the unapplied patch 10/10 of my shift-fixes series (http://patchwork.ozlabs.org/patch/83248/) which corrects the compilation failure. Since the fix involves refactoring to pull out some code into a separate function and then pulling the size check outside of the

[Qemu-devel] [PATCH v3 2/2] target-arm: Fix shift by immediate and narrow where src, dest overlap

2011-02-21 Thread Peter Maydell
For Neon shifts by immediate and narrow, correctly handle the case where the source registers and the destination registers overlap (the second pass should use the original register contents, not the results of the first pass). This includes a refactoring to pull the size check outside the loop

[Qemu-devel] Re: [PATCH 04/21] replace qemu_thread_equal API with qemu_thread_is_current

2011-02-21 Thread Paolo Bonzini
On 02/21/2011 10:41 AM, Jan Kiszka wrote: I'm now in favor of an even more consistent refactoring: qemu_thread_is_self, qemu_thread_get_self, and qemu_cpu_is_self. See [1]. Jan [1] http://git.kiszka.org/?p=qemu-kvm.git;a=commitdiff;h=f5b278f5aec06fe4d140f68caf9b1bf17b4809b2 Ok, I'll replace

[Qemu-devel] Vhost support

2011-02-21 Thread Liu Yu-B13201
Hello everyone, Does anyone know the status of vhost in upstream qemu? We would like to try vhost with kvm on powerpc e500v2 platform, but obviously, powerpc kvm only works with upstream qemu. KVM wike page says it needs to enable CONFIG_PCI_MSI for guest kernel. Is MSI a necessary? Thanks, Yu

[Qemu-devel] [PATCH v3 1/2] target-arm: Refactor to pull narrowing decode into separate function

2011-02-21 Thread Peter Maydell
Pull the code which decodes narrowing operations as being either signed/unsigned saturate or plain out into its own function. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c | 45 +++-- 1 files changed, 19 insertions(+),

[Qemu-devel] Re: Vhost support

2011-02-21 Thread Michael S. Tsirkin
On Mon, Feb 21, 2011 at 11:13:33AM +, Liu Yu-B13201 wrote: Hello everyone, Does anyone know the status of vhost in upstream qemu? We would like to try vhost with kvm on powerpc e500v2 platform, but obviously, powerpc kvm only works with upstream qemu. KVM wike page says it needs to

Re: [Qemu-devel] [PATCH v3 0/2] target-arm: fix shift where src, dest overlap

2011-02-21 Thread Peter Maydell
On 21 February 2011 11:05, Peter Maydell peter.mayd...@linaro.org wrote: Change from v3: removed two now-unnecessary uses of TCGV_UNUSED (forgot to stg refresh before sending out patch series, sorry.) ...obviously I meant Change from v2. Ah, Monday mornings :-) -- PMM

Re: [Qemu-devel] [PATCH 1/2] block/vdi: Don't ignore immediate read/write failures

2011-02-21 Thread Kevin Wolf
Am 19.02.2011 22:18, schrieb Stefan Weil: This patch is similar to 171e3d6b9997c98a97d0c525867f7cd9b640cadd which fixed qcow2: Returning -EIO is far from optimal, but at least it's an error code. Cc: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Weil w...@mail.berlios.de Thanks,

[Qemu-devel] RE: Vhost support

2011-02-21 Thread Liu Yu-B13201
-Original Message- From: Michael S. Tsirkin [mailto:m...@redhat.com] Sent: Monday, February 21, 2011 7:22 PM To: Liu Yu-B13201 Cc: qemu-devel@nongnu.org; Yoder Stuart-B08248 Subject: Re: Vhost support On Mon, Feb 21, 2011 at 11:13:33AM +, Liu Yu-B13201 wrote: Hello

[Qemu-devel] Re: Vhost support

2011-02-21 Thread Michael S. Tsirkin
On Mon, Feb 21, 2011 at 11:41:39AM +, Liu Yu-B13201 wrote: -Original Message- From: Michael S. Tsirkin [mailto:m...@redhat.com] Sent: Monday, February 21, 2011 7:22 PM To: Liu Yu-B13201 Cc: qemu-devel@nongnu.org; Yoder Stuart-B08248 Subject: Re: Vhost support On

[Qemu-devel] [PATCH] Fixing network over sockets implementation for win32

2011-02-21 Thread Pavel Dovgaluk
MSDN includes the following in WSAEALREADY error description for connect() function: To preserve backward compatibility, this error is reported as WSAEINVAL to Winsock applications that link to either Winsock.dll or Wsock32.dll. So check of this error code was added to allow network

[Qemu-devel] [PATCH] Fixing tap adapter for win32

2011-02-21 Thread Pavel Dovgaluk
This fix allows connection of internal VLAN to the external TAP interface. If tap_win32_write function always returns 0, the TAP network interface in QEMU is disabled. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@gmail.com --- net/tap-win32.c |2 +- 1 files changed, 1 insertions(+), 1

[Qemu-devel] RE: Vhost support

2011-02-21 Thread Liu Yu-B13201
-Original Message- From: Michael S. Tsirkin [mailto:m...@redhat.com] Sent: Monday, February 21, 2011 7:46 PM To: Liu Yu-B13201 Cc: qemu-devel@nongnu.org; Yoder Stuart-B08248 Subject: Re: Vhost support On Mon, Feb 21, 2011 at 11:41:39AM +, Liu Yu-B13201 wrote:

Re: [Qemu-devel] [PATCH 4/5] target-arm: fix support for VRECPE.

2011-02-21 Thread Peter Maydell
On 21 February 2011 10:59, Christophe Lyon christophe.l...@st.com wrote: +    if (float32_is_any_nan(a)) { +        if (float32_is_signaling_nan(a)) { +            float_raise(float_flag_invalid, s); +        } +        return float32_maybe_silence_nan(a); This returns the wrong answer for

Re: [Qemu-devel] [PATCH 1/5] softfloat: move all default NaN definitions to softfloat.h.

2011-02-21 Thread Peter Maydell
On 21 February 2011 10:59, Christophe Lyon christophe.l...@st.com wrote: These special values are needed to implement some helper functions, which return/use these values in some cases. Signed-off-by: Christophe Lyon christophe.l...@st.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org

Re: [Qemu-devel] [PATCH 2/5] softfloat: add _set_sign(), _infinity and _half for 32 and 64 bits floats.

2011-02-21 Thread Peter Maydell
On 21 February 2011 10:59, Christophe Lyon christophe.l...@st.com wrote: These constants and utility function are needed to implement some helpers. Defining constants avoids the need to re-compute them at runtime. Signed-off-by: Christophe Lyon christophe.l...@st.com Reviewed-by: Peter

Re: [Qemu-devel] [PATCH 3/5] target-arm: Introduce float64_256 and float64_512 constants.

2011-02-21 Thread Peter Maydell
On 21 February 2011 10:59, Christophe Lyon christophe.l...@st.com wrote: These two constants will be used by helper functions such as recpe_f32 and rsqrte_f32. Signed-off-by: Christophe Lyon christophe.l...@st.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org

[Qemu-devel] Re: [PATCH 21/21] add Win32 IPI service

2011-02-21 Thread Jan Kiszka
On 2011-02-21 09:43, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpus.c | 23 --- qemu-thread-posix.c |9 - qemu-thread-posix.h |1 - 3 files changed, 20 insertions(+), 13 deletions(-) diff --git a/cpus.c

Re: [Qemu-devel] [PATCH 5/5] target-arm: fix support for VRSQRTE.

2011-02-21 Thread Peter Maydell
On 21 February 2011 10:59, Christophe Lyon christophe.l...@st.com wrote: +    if (float32_is_any_nan(a)) { +        if (float32_is_signaling_nan(a)) { +            float_raise(float_flag_invalid, s); +        } +        return float32_maybe_silence_nan(a); Wrong answer for NaNs, fix as per

Re: [Qemu-devel] Re: Network bridging without adding bridge with brctl, possible?

2011-02-21 Thread Arnd Bergmann
On Monday 21 February 2011, Jan Kiszka wrote: Now I think I tried all useful possible combinations: 1.) macvtap0 and macvlan0 in bridged and non bridge mode 2.) macvlan0 based on eth0 or based on macvtap0 3.) Using and ip address on macvlan0 or not (tried both for 7b mac and 7c mac)

[Qemu-devel] Re: [PATCH 21/21] add Win32 IPI service

2011-02-21 Thread Paolo Bonzini
On 02/21/2011 01:00 PM, Jan Kiszka wrote: qemu_thread_* services do not truly belong here. What about defining SIG_IPI as QEMU_SIG_KICK which would be provided by qemu-thread-posix.h? Then the qemu-thread-posix.c could implement qemu_thread_kick() again. The function is really specific to

[Qemu-devel] Re: [PATCH 21/21] add Win32 IPI service

2011-02-21 Thread Jan Kiszka
On 2011-02-21 13:15, Paolo Bonzini wrote: On 02/21/2011 01:00 PM, Jan Kiszka wrote: qemu_thread_* services do not truly belong here. What about defining SIG_IPI as QEMU_SIG_KICK which would be provided by qemu-thread-posix.h? Then the qemu-thread-posix.c could implement qemu_thread_kick()

[Qemu-devel] Re: [PATCH 2/3] NBD library: add aio-compatible read/write function

2011-02-21 Thread Kevin Wolf
Am 18.02.2011 13:55, schrieb Nick Thomas: Signed-off-by: Nicholas Thomas n...@bytemark.co.uk --- nbd.c | 51 +++ nbd.h |2 ++ 2 files changed, 53 insertions(+), 0 deletions(-) diff --git a/nbd.c b/nbd.c index abe0ecb..83d3342 100644

[Qemu-devel] Re: [PATCH 1/3] NBD library: whitespace changes

2011-02-21 Thread Kevin Wolf
Am 18.02.2011 13:55, schrieb Nick Thomas: --- nbd.c | 835 + 1 files changed, 418 insertions(+), 417 deletions(-) Patch 1 and 3 are lacking a Signed-off-by. Kevin

[Qemu-devel] Re: [PATCH 3/3] block/nbd: Make the NBD block device use the AIO interface

2011-02-21 Thread Kevin Wolf
Am 18.02.2011 13:55, schrieb Nick Thomas: This preserves the previous behaviour where the NBD server is unavailable or goes away during guest execution, but switches the NBD backend to present the AIO interface instead of the sync IO interface. We also split write requests into 1 MiB blocks

Re: [Qemu-devel] [RFC][PATCH v6 00/23] virtagent: host/guest RPC communication agent

2011-02-21 Thread Michael Roth
On 02/21/2011 02:32 AM, Jes Sorensen wrote: On 02/18/11 15:57, Anthony Liguori wrote: On 02/18/2011 08:30 AM, Jes Sorensen wrote: However if there's an agent connection, it could be arranged in a way allowing the host to reconnect to the guest agent. In that way it really shouldn't be a big

Re: [Qemu-devel] [RFC][PATCH v6 00/23] virtagent: host/guest RPC communication agent

2011-02-21 Thread Jes Sorensen
On 02/21/11 14:36, Michael Roth wrote: On 02/21/2011 02:32 AM, Jes Sorensen wrote: Well that isn't really different from the current setup - if QEMU migrates, the admin tool has to connect to the new QEMU process and issue the fsthaw command there instead. Another thing to consider is that

[Qemu-devel] [PATCH 2/2] microblaze: Allow targeting little-endian mb

2011-02-21 Thread Edgar E. Iglesias
Signed-off-by: Edgar E. Iglesias edgar.igles...@petalogix.com --- configure |7 +-- default-configs/microblazeel-linux-user.mak |1 + default-configs/microblazeel-softmmu.mak|4 3 files changed, 10 insertions(+), 2 deletions(-) create

Re: [Qemu-devel] Re: Strategic decision: COW format

2011-02-21 Thread Stefan Hajnoczi
On Mon, Feb 21, 2011 at 8:59 AM, Kevin Wolf kw...@redhat.com wrote: In fact, the only area where qcow2 in performs really bad in 0.14 is cache=writethrough (which unfortunately is the default...). With cache=none it's easy to find scenarios where it provides higher throughput than QED. Yeah,

[Qemu-devel] [PATCH v5] Fix ATA SMART and CHECK POWER MODE

2011-02-21 Thread Brian Wheeler
This patch fixes two things: 1) CHECK POWER MODE The error return value wasn't always zero, so it would show up as offline. Error is now explicitly set to zero. 2) SMART The smart values that were returned were invalid and tools like skdump would not recognize that the smart data was

[Qemu-devel] [PATCH 1/2] pls3adsp1800: Base load_elf endianness on target endianness

2011-02-21 Thread Edgar E. Iglesias
Signed-off-by: Edgar E. Iglesias edgar.igles...@petalogix.com --- hw/petalogix_s3adsp1800_mmu.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/petalogix_s3adsp1800_mmu.c b/hw/petalogix_s3adsp1800_mmu.c index 42de459..6ef4e65 100644 ---

Re: [Qemu-devel] Re: Strategic decision: COW format

2011-02-21 Thread Kevin Wolf
Am 21.02.2011 14:44, schrieb Stefan Hajnoczi: On Mon, Feb 21, 2011 at 8:59 AM, Kevin Wolf kw...@redhat.com wrote: In fact, the only area where qcow2 in performs really bad in 0.14 is cache=writethrough (which unfortunately is the default...). With cache=none it's easy to find scenarios where

[Qemu-devel] [Bug 697197] Re: Empty password allows access to VNC in libvirt

2011-02-21 Thread Marc Deslauriers
Nothing left to do, unsubscribing ubuntu-security-sponsors. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/697197 Title: Empty password allows access to VNC in libvirt Status in libvirt

[Qemu-devel] [PATCH] hw/irq.h: Remove unused SetIRQFunc typedef

2011-02-21 Thread Peter Maydell
Remove the typedef SetIRQFunc, as it is not used by anything. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/irq.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/irq.h b/hw/irq.h index 5daae44..f7849ed 100644 --- a/hw/irq.h +++ b/hw/irq.h @@ -3,9 +3,7

Re: [Qemu-devel] Re: Strategic decision: COW format

2011-02-21 Thread Anthony Liguori
On 02/21/2011 08:10 AM, Kevin Wolf wrote: Am 21.02.2011 14:44, schrieb Stefan Hajnoczi: On Mon, Feb 21, 2011 at 8:59 AM, Kevin Wolfkw...@redhat.com wrote: In fact, the only area where qcow2 in performs really bad in 0.14 is cache=writethrough (which unfortunately is the default...).

Re: [Qemu-devel] Re: Strategic decision: COW format

2011-02-21 Thread Kevin Wolf
Am 21.02.2011 16:16, schrieb Anthony Liguori: On 02/21/2011 08:10 AM, Kevin Wolf wrote: Am 21.02.2011 14:44, schrieb Stefan Hajnoczi: On Mon, Feb 21, 2011 at 8:59 AM, Kevin Wolfkw...@redhat.com wrote: In fact, the only area where qcow2 in performs really bad in 0.14 is

[Qemu-devel] [Bug 722311] Re: Segmentation fault if started without -enable-kvm parameter

2011-02-21 Thread Bug Reporter
It is a bit weird that www.qemu.org tells me to report my bugs on launchpad, but replies to my bug report then appear ONLY on the developer mailing list. How shall a lowly end-user know that he must look there, too? Anyway. On the developer mailing list, Markus Armbruster (Mon, 21 Feb 2011

[Qemu-devel] Re: [PATCH 3/3] block/nbd: Make the NBD block device use the AIO interface

2011-02-21 Thread Nicholas Thomas
Hi again, Thanks for looking through the patches. I'm just going through and making the suggested changes now. I've also got qemu-nbd and block/nbd.c working over IPv6 :) - hopefully I'll be able to provide patches in a couple of days. Just a few questions about some of the changes... Canceled

  1   2   >