Re: [Qemu-devel] [V2 2/2]Qemu: Add commands hostcache_set and hostcache_get

2011-05-23 Thread Supriya Kannery
On 05/20/2011 01:50 PM, Stefan Hajnoczi wrote: On Thu, May 19, 2011 at 10:38:03PM +0530, Supriya Kannery wrote: Monitor commands hostcache_set and hostcache_get added for dynamic host cache change and display of host cache setting respectively. A generic command for changing block device

[Qemu-devel] [RFC/PATCH] virtio-9p: Add Read only support for 9p export.

2011-05-23 Thread M. Mohan Kumar
A new fsdev parameter access is introduced to control accessing 9p export. access=ro|rw can be used to specify the access type. By default rw access is given to 9p export. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- fsdev/file-op-9p.h |1 + fsdev/qemu-fsdev.c | 17

Re: [Qemu-devel] [PATCH 2/3] net: Don't warn about the default network setup

2011-05-23 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: Don't warn about the default network setup that you get if no command line -net options are specified. There are two cases that we would otherwise complain about: (1) board doesn't support a NIC but the implicit -net nic requested one Maybe

Re: [Qemu-devel] [PATCH 3/3] net: Warn about -net nic options which were ignored

2011-05-23 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: Diagnose the case where the user asked for a NIC via -net nic but the board didn't instantiate that NIC (for example where the user asked for two NICs but the board only supports one). Note that this diagnostic doesn't apply to NICs created

Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix

2011-05-23 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: This patchset reverts commit f68b9d672, which was triggering spuriously for NICs created via -device rather than -net nic. It then reimplements the improved diagnostics with a different approach which only applies to '-net nic'. (It's only -net

Re: [Qemu-devel] [PATCH] Consistently use qemu_macaddr_default_if_unset

2011-05-23 Thread Markus Armbruster
Jan Kiszka jan.kis...@siemens.com writes: Drop the open-coded MAC assignment from net_init_nic and replace it with standard qemu_macaddr_default_if_unset which is also used by qdev. That avoid creating colliding MACs when instantiating NICs via different mechanisms. Should we explicitly

Re: [Qemu-devel] [RFC] Memory API

2011-05-23 Thread Gleb Natapov
On Sun, May 22, 2011 at 02:29:27PM +0300, Avi Kivity wrote: On 05/22/2011 01:53 PM, Jan Kiszka wrote: On 2011-05-22 10:41, Gleb Natapov wrote: The chipset knows about the priorities. How to communicate them to the core? - at runtime, with hierarchical dispatch of -read() and

Re: [Qemu-devel] [PATCH 2/3] net: Don't warn about the default network setup

2011-05-23 Thread Peter Maydell
On 23 May 2011 09:30, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: Don't warn about the default network setup that you get if no command line -net options are specified.  There are two cases that we would otherwise complain about: (1) board

Re: [Qemu-devel] [PATCH] block/rbd: Remove unused local variable

2011-05-23 Thread Christian Brunner
2011/5/22 Stefan Weil w...@mail.berlios.de: Am 07.05.2011 22:15, schrieb Stefan Weil: cppcheck report: rbd.c:246: style: Variable 'snap' is assigned a value that is never used Remove snap and the related code. Cc: Christian Brunnerc...@muc.de Cc: Kevin Wolfkw...@redhat.com Signed-off-by:

[Qemu-devel] [PATCH] configure: Document --disable-slirp option in --help

2011-05-23 Thread Peter Maydell
The --disable-slirp option was undocumented; add it to configure's --help output. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index d7dba5d..1f95ed7 100755 --- a/configure +++

Re: [Qemu-devel] [PATCH] sheepdog: add data preallocation support

2011-05-23 Thread Stefan Hajnoczi
On Sat, May 21, 2011 at 1:35 PM, MORITA Kazutaka morita.kazut...@lab.ntt.co.jp wrote: +static int sd_prealloc(uint32_t vid, int64_t vdi_size) +{ +    int fd, ret; +    SheepdogInode *inode; +    char *buf; +    unsigned long idx, max_idx; [...] +    max_idx = (vdi_size + SD_DATA_OBJ_SIZE -

Re: [Qemu-devel] [PATCH v2 2/2] net: Dump client type 'info network'

2011-05-23 Thread Markus Armbruster
Jan Kiszka jan.kis...@siemens.com writes: Include the client type name into the output of 'info network'. The result looks like this: (qemu) info network VLAN 0 devices: rtl8139.0: type=nic,model=rtl8139,macaddr=52:54:00:12:34:57 Devices not on any VLAN: virtio-net-pci.0:

Re: [Qemu-devel] [PATCH v2 2/2] net: Dump client type 'info network'

2011-05-23 Thread Jan Kiszka
On 2011-05-23 11:28, Markus Armbruster wrote: Jan Kiszka jan.kis...@siemens.com writes: Include the client type name into the output of 'info network'. The result looks like this: (qemu) info network VLAN 0 devices: rtl8139.0: type=nic,model=rtl8139,macaddr=52:54:00:12:34:57 Devices

Re: [Qemu-devel] [PATCH] Consistently use qemu_macaddr_default_if_unset

2011-05-23 Thread Jan Kiszka
On 2011-05-23 10:43, Markus Armbruster wrote: Jan Kiszka jan.kis...@siemens.com writes: Drop the open-coded MAC assignment from net_init_nic and replace it with standard qemu_macaddr_default_if_unset which is also used by qdev. That avoid creating colliding MACs when instantiating NICs via

[Qemu-devel] [PATCH 05/18] Bug #757654: UHCI fails to signal stall response patch

2011-05-23 Thread Gerd Hoffmann
From: Jan Vesely jano.ves...@gmail.com UHCI host controller status register indicates error and an interrupt is triggered on BABBLE and STALL errors. Signed-off-by: Jan Vesely jano.ves...@gmail.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-uhci.c |4 1 files changed, 4

[Qemu-devel] [PULL] usb patch queue: initial usb 2.0 support.

2011-05-23 Thread Gerd Hoffmann
Hi, Here is the usb patch queue, with EHCI support being the outstanding new feature. Most patches are unmodified. Patch #5 got a better commit message. The EHCI patch now lists all contributes in the commit message too (they where listed in the source code only before), I hope everybody is

[Qemu-devel] [PATCH 03/18] usb: remove fallback to bNumInterfaces if no .nif

2011-05-23 Thread Gerd Hoffmann
From: Brad Hards br...@frogmouth.net All callers have been updated. Signed-off-by: Brad Hards br...@frogmouth.net Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-desc.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/usb-desc.c b/hw/usb-desc.c index

[Qemu-devel] [PATCH 06/18] usb: Pass the packet to the device's handle_control callback

2011-05-23 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com This allows using the generic usb_generic_handle_packet function from device code which does ASYNC control requests (such as the linux host pass through code). Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/bt-hid.c |6 +++--- hw/usb-bt.c

[Qemu-devel] [PATCH 02/18] usb: update config descriptors to identify number of interfaces

2011-05-23 Thread Gerd Hoffmann
From: Brad Hards br...@frogmouth.net Previously we relied on the .bNumInterfaces, but that won't always be accurate after the introduction of grouped interfaces. Signed-off-by: Brad Hards br...@frogmouth.net Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-hid.c|3 +++

[Qemu-devel] [PATCH 11/18] usb-linux: walk async urb list in cancel

2011-05-23 Thread Gerd Hoffmann
Lookup async urbs which are to be canceled using the linked list instead of the direct opaque pointer. There are two reasons we are doing that: First, to avoid the opaque poiner to the callback, which is needed for upcoming cleanups. Second, because we might need multiple urbs per request for

[Qemu-devel] [PATCH 01/18] usb: Add Interface Association Descriptor descriptor type

2011-05-23 Thread Gerd Hoffmann
From: Brad Hards br...@frogmouth.net Signed-off-by: Brad Hards br...@frogmouth.net Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/usb.h b/hw/usb.h index 7e46141..ca06bf8 100644 --- a/hw/usb.h +++ b/hw/usb.h

[Qemu-devel] [PATCH 16/18] usb: keep track of packet owner.

2011-05-23 Thread Gerd Hoffmann
Keep track of the device which owns the usb packet for async processing. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb.c | 32 hw/usb.h | 18 +++--- 2 files changed, 35 insertions(+), 15 deletions(-) diff --git a/hw/usb.c b/hw/usb.c

[Qemu-devel] [PATCH 10/18] usb-linux: track aurbs in list

2011-05-23 Thread Gerd Hoffmann
This patch adds code to track all async urbs in a linked list, so we can find them without having to pass around a opaque pointer to them. Prerequisite for the cleanups. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- usb-linux.c | 18 +++--- 1 files changed, 11 insertions(+),

[Qemu-devel] [PATCH 07/18] usb-linux: use usb_generic_handle_packet()

2011-05-23 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Make the linux usb host passthrough code use the usb_generic_handle_packet() function, rather then the curent DYI code. This removes 200 lines of almost identical code. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb.c| 41 +-

[Qemu-devel] [PATCH 12/18] usb-linux: split large xfers

2011-05-23 Thread Gerd Hoffmann
Add support for splitting large transfers into multiple smaller ones. This is needed for the upcoming EHCI emulation which allows guests to submit requests up to 20k in size. The linux kernel allows 16k max size though. Based on a patch from David Ahern, see

[Qemu-devel] [PATCH 17/18] usb: move cancel callback to USBDeviceInfo

2011-05-23 Thread Gerd Hoffmann
Remove the cancel callback from the USBPacket struct, move it over to USBDeviceInfo. Zap usb_defer_packet() which is obsolete now. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-msd.c |8 +++- hw/usb.c |2 +- hw/usb.h | 17 + usb-linux.c |7

[Qemu-devel] [PATCH 13/18] usb-linux: fix max_packet_size for highspeed.

2011-05-23 Thread Gerd Hoffmann
Calculate the max packet size correctly. Only bits 0..11 specify the size, bits 11+12 specify the number of (highspeed) microframes the endpoint wants to use. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- usb-linux.c | 19 +-- 1 files changed, 17 insertions(+), 2

[Qemu-devel] [PATCH 08/18] usb-linux: fix device path aka physical port handling

2011-05-23 Thread Gerd Hoffmann
The device path isn't just a number. It specifies the physical port the device is connected to and in case the device is connected via usb hub you'll have two numbers there, like this: 5.1. The first specifies the root port where the hub is plugged into, the second specifies the port number of

[Qemu-devel] [PATCH 04/18] usb: add support for grouped interfaces and the Interface Association Descriptor

2011-05-23 Thread Gerd Hoffmann
From: Brad Hards br...@frogmouth.net This is used for some devices that have multiple interfaces that form a logic device. An example is Video Class, which has a Control interface and a Streaming interface. There can be additional interfaces on the same (physical) devices (e.g. a microphone), and

Re: [Qemu-devel] [PATCH] Add support for fd: protocol

2011-05-23 Thread Daniel P. Berrange
On Fri, May 20, 2011 at 02:48:23PM -0400, Corey Bryant wrote: sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image files). sVirt provides this support by labeling guests and resources with security labels that are stored in file system extended

[Qemu-devel] [PATCH 09/18] usb-linux: add hostport property

2011-05-23 Thread Gerd Hoffmann
This patch adds a hostport property which allows to specify the host usb devices to pass through by bus number and physical port. This means you can basically hand over one (or more) of the usb plugs on your host to the guest and whatever device is plugged in there will show up in the guest.

[Qemu-devel] [PATCH 14/18] usb-storage: don't call usb_packet_complete twice

2011-05-23 Thread Gerd Hoffmann
usb_msd_copy_data() may cause a recursive call to usb_msd_command_complete() which in turn may complete the packet, setting s-packet to NULL in case it does. Recheck s-packet before calling usb_packet_complete() to fix the double call. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

Re: [Qemu-devel] [PATCH] Add support for fd: protocol

2011-05-23 Thread Daniel P. Berrange
On Fri, May 20, 2011 at 02:48:23PM -0400, Corey Bryant wrote: sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image files). sVirt provides this support by labeling guests and resources with security labels that are stored in file system extended

[Qemu-devel] [PATCH 15/18] usb: add usb_handle_packet

2011-05-23 Thread Gerd Hoffmann
Add a usb_handle_packet function, put it into use everywhere. Right now it just calls dev-info-handle_packet(), that will change in future patches though. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-hub.c |2 +- hw/usb-musb.c |2 +- hw/usb-ohci.c |4 ++-- hw/usb-uhci.c

Re: [Qemu-devel] [Bug 786440] [NEW] qcow2 double free

2011-05-23 Thread Stefan Hajnoczi
On Sun, May 22, 2011 at 8:58 AM, Andrew Kroll 786...@bugs.launchpad.net wrote: Public bug reported: version 0.14.1 when using qcow2 images, after some time, glibc detects a double free or corruption. Any specific information on what the guest was doing? Was it doing heavy I/O or was it idle?

Re: [Qemu-devel] [V2 2/2]Qemu: Add commands hostcache_set and hostcache_get

2011-05-23 Thread Stefan Hajnoczi
On Mon, May 23, 2011 at 8:04 AM, Supriya Kannery supri...@in.ibm.com wrote: On 05/20/2011 01:50 PM, Stefan Hajnoczi wrote: On Thu, May 19, 2011 at 10:38:03PM +0530, Supriya Kannery wrote: Monitor commands hostcache_set and hostcache_get added for dynamic host cache change and display of host

Re: [Qemu-devel] [RFC/PATCH] virtio-9p: Add Read only support for 9p export.

2011-05-23 Thread Stefan Hajnoczi
On Mon, May 23, 2011 at 8:58 AM, M. Mohan Kumar mo...@in.ibm.com wrote: A new fsdev parameter access is introduced to control accessing 9p export. access=ro|rw can be used to specify the access type. By default rw access is given to 9p export. It would be consistent with -drive to use

Re: [Qemu-devel] [PATCH] block/rbd: Remove unused local variable

2011-05-23 Thread Stefan Hajnoczi
On Mon, May 23, 2011 at 10:01 AM, Christian Brunner c...@muc.de wrote: 2011/5/22 Stefan Weil w...@mail.berlios.de: Am 07.05.2011 22:15, schrieb Stefan Weil: cppcheck report: rbd.c:246: style: Variable 'snap' is assigned a value that is never used Remove snap and the related code. Cc:

[Qemu-devel] KVM call agenda dfor May 24th

2011-05-23 Thread Juan Quintela
Please send in any agenda items you are interested in covering. Thanks, Juan.

Re: [Qemu-devel] [PATCH] Add support for fd: protocol

2011-05-23 Thread Stefan Hajnoczi
On Mon, May 23, 2011 at 10:45 AM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, May 20, 2011 at 02:48:23PM -0400, Corey Bryant wrote: sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image files). sVirt provides this support by labeling

Re: [Qemu-devel] PCI hotplug disable

2011-05-23 Thread Gerd Hoffmann
On 05/21/11 18:11, Nikolai Zhubr wrote: Hello all, is there some simple way to disable pci hotplug support in qemu-kvm (via some command-line options or alike)? Problem is, my guest windows xp is thinking that it could attempt to remove Intel 82371SB, Cirrus Logic 5446, and other pci devices,

Re: [Qemu-devel] [PATCH] block/rbd: Remove unused local variable

2011-05-23 Thread Kevin Wolf
Am 23.05.2011 11:01, schrieb Christian Brunner: 2011/5/22 Stefan Weil w...@mail.berlios.de: Am 07.05.2011 22:15, schrieb Stefan Weil: cppcheck report: rbd.c:246: style: Variable 'snap' is assigned a value that is never used Remove snap and the related code. Cc: Christian

Re: [Qemu-devel] [PATCH] Add support for fd: protocol

2011-05-23 Thread Daniel P. Berrange
On Mon, May 23, 2011 at 11:19:15AM +0100, Stefan Hajnoczi wrote: On Mon, May 23, 2011 at 10:45 AM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, May 20, 2011 at 02:48:23PM -0400, Corey Bryant wrote: sVirt provides SELinux MAC isolation for Qemu guest processes and their

[Qemu-devel] [PATCH] block/raw-posix: get right size of partition size

2011-05-23 Thread Christoph Egger
This does 2 things: - use the correct way to get the size of a disk device or partition (from h...@netbsd.org) - if given a block device, use the character device instead. (from bou...@netbsd.org) From: Adam Hamsik h...@netbsd.org From: Manuel Bouyer bou...@netbsd.org Signed-off-by:

[Qemu-devel] [PATCH] block/raw-posix: get right partition size

2011-05-23 Thread Christoph Egger
This does 2 things: - use the correct way to get the size of a disk device or partition (from h...@netbsd.org) - if given a block device, use the character device instead. (from bou...@netbsd.org) From: Adam Hamsik h...@netbsd.org From: Manuel Bouyer bou...@netbsd.org Signed-off-by:

Re: [Qemu-devel] [PATCH] virtio: correctly initialize vm_running

2011-05-23 Thread Michael S. Tsirkin
On Mon, May 23, 2011 at 01:57:57PM +0800, Jason Wang wrote: On 05/18/2011 04:54 PM, Michael S. Tsirkin wrote: On Wed, May 18, 2011 at 01:57:37PM +0800, Jason Wang wrote: Current vm_running was not explicitly initialized and its value was changed by vm state notifier, this may confuse the

Re: [Qemu-devel] [PATCH] block/raw-posix: get right size of partition size

2011-05-23 Thread Christoph Hellwig
On Mon, May 23, 2011 at 12:34:39PM +0200, Christoph Egger wrote: This does 2 things: - use the correct way to get the size of a disk device or partition (from h...@netbsd.org) - if given a block device, use the character device instead. (from bou...@netbsd.org) Please split that

Re: [Qemu-devel] [PATCH] sheepdog: add data preallocation support

2011-05-23 Thread MORITA Kazutaka
At Mon, 23 May 2011 10:19:13 +0100, Stefan Hajnoczi wrote: On Sat, May 21, 2011 at 1:35 PM, MORITA Kazutaka morita.kazut...@lab.ntt.co.jp wrote: +static int sd_prealloc(uint32_t vid, int64_t vdi_size) +{ +    int fd, ret; +    SheepdogInode *inode; +    char *buf; +    unsigned

Re: [Qemu-devel] The process of kernel cross-compiling in arm-test-0.2.tar.gz

2011-05-23 Thread Brad Hards
On Monday 23 May 2011 19:26:45 daixiaoke wrote: 3.Compiled uClinux following steps in the attachment(Chapter 4: Building the uClinux image). “STM3210E-EVAL-jffs” was selected for Porduct while Configure uClinux for STM3210E-EVAL. So you have built the images to install into a STM3210E board.

Re: [Qemu-devel] [RFC/PATCH] virtio-9p: Add Read only support for 9p export.

2011-05-23 Thread M. Mohan Kumar
On Mon, May 23, 2011 at 11:08:34AM +0100, Stefan Hajnoczi wrote: On Mon, May 23, 2011 at 8:58 AM, M. Mohan Kumar mo...@in.ibm.com wrote: A new fsdev parameter access is introduced to control accessing 9p export. access=ro|rw can be used to specify the access type. By default rw access is

[Qemu-devel] Invitation to connect on LinkedIn

2011-05-23 Thread Paulo Cezar via LinkedIn
LinkedIn Paulo Cezar requested to add you as a connection on LinkedIn: -- Jiajun, I'd like to add you to my professional network on LinkedIn. - Paulo Accept invitation from Paulo Cezar

[Qemu-devel] [Bug 696834] Invitation to connect on LinkedIn

2011-05-23 Thread Paulo Cezar A Junior
LinkedIn Bug, I'd like to add you to my professional network on LinkedIn. - Paulo Paulo Cezar Platform Researcher and Developer at INdT São Paulo Area, Brazil Confirm that you know Paulo Cezar https://www.linkedin.com/e/-g11m92-go1e59vx-23/isd/2968180228/v_gmfnNW/ --

[Qemu-devel] [PATCH] block/raw-posix: use a character device if a block device is given

2011-05-23 Thread Christoph Egger
if given a block device, use the character device instead. From: Manuel Bouyer bou...@netbsd.org Signed-off-by: Christoph Egger christoph.eg...@amd.com diff --git a/block/raw-posix.c b/block/raw-posix.c index 6b72470..d05f373 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -136,11

Re: [Qemu-devel] [PATCH] Add support for fd: protocol

2011-05-23 Thread Anthony Liguori
On 05/23/2011 04:45 AM, Daniel P. Berrange wrote: On Fri, May 20, 2011 at 02:48:23PM -0400, Corey Bryant wrote: sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image files). sVirt provides this support by labeling guests and resources with

Re: [Qemu-devel] [V2 2/2]Qemu: Add commands hostcache_set and hostcache_get

2011-05-23 Thread Kevin Wolf
Am 23.05.2011 12:00, schrieb Stefan Hajnoczi: On Mon, May 23, 2011 at 8:04 AM, Supriya Kannery supri...@in.ibm.com wrote: On 05/20/2011 01:50 PM, Stefan Hajnoczi wrote: On Thu, May 19, 2011 at 10:38:03PM +0530, Supriya Kannery wrote: Monitor commands hostcache_set and hostcache_get added for

Re: [Qemu-devel] [PATCH] Add support for fd: protocol

2011-05-23 Thread Anthony Liguori
On 05/23/2011 05:30 AM, Daniel P. Berrange wrote: It feels to me that turning the current block driver code which just does open(2) on files, into something which issues events asynchronously waits for a file would potentially be quite complex. You also need to be much more careful from a

Re: [Qemu-devel] [RFC] live snapshot, live merge, live block migration

2011-05-23 Thread Stefan Hajnoczi
On Sun, May 22, 2011 at 10:52 AM, Dor Laor dl...@redhat.com wrote: On 05/20/2011 03:19 PM, Stefan Hajnoczi wrote: I'm interested in what the API for snapshots would look like. Specifically how does user software do the following: 1. Create a snapshot 2. Delete a snapshot 3. List snapshots

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers = 0x8000000000000000

2011-05-23 Thread Daniel P. Berrange
On Fri, May 20, 2011 at 01:11:05PM -0500, Anthony Liguori wrote: On 05/20/2011 01:03 PM, Richard W.M. Jones wrote: There seem to be a few unsafe uses of strto* functions. This patch just fixes the one that affects me :-) Sending an integer of this size is not valid JSON. Your patch

Re: [Qemu-devel] [PATCH] Add support for fd: protocol

2011-05-23 Thread Daniel P. Berrange
On Mon, May 23, 2011 at 07:50:12AM -0500, Anthony Liguori wrote: On 05/23/2011 04:45 AM, Daniel P. Berrange wrote: On Fri, May 20, 2011 at 02:48:23PM -0400, Corey Bryant wrote: sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image files). sVirt

Re: [Qemu-devel] [PATCH] block/raw-posix: get right size of partition size

2011-05-23 Thread Christoph Egger
On 05/23/11 13:06, Christoph Hellwig wrote: On Mon, May 23, 2011 at 12:34:39PM +0200, Christoph Egger wrote: This does 2 things: - use the correct way to get the size of a disk device or partition (from h...@netbsd.org) - if given a block device, use the character device instead.

Re: [Qemu-devel] [PATCH] Add support for fd: protocol

2011-05-23 Thread Stefan Hajnoczi
On Mon, May 23, 2011 at 1:50 PM, Anthony Liguori aligu...@us.ibm.com wrote: On 05/23/2011 04:45 AM, Daniel P. Berrange wrote: On Fri, May 20, 2011 at 02:48:23PM -0400, Corey Bryant wrote: sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image

Re: [Qemu-devel] [PATCHv4 0/2] libcacard.la

2011-05-23 Thread Alon Levy
On Wed, May 18, 2011 at 05:23:42PM +0300, Alon Levy wrote: Ping? Allow building standalone shared (or static, whichever libtool chooses) library out of libcacard sources, for use by ccid-card-passthru remote clients. v4: exit (return code 1) if libtool not found at any stage (for .lo rule

[Qemu-devel] [PATCH] block/raw-posix: get right partition size

2011-05-23 Thread Christoph Egger
use the correct way to get the size of a disk device or partition From: Adam Hamsik h...@netbsd.org Signed-off-by: Christoph Egger christoph.eg...@amd.com diff --git a/block/raw-posix.c b/block/raw-posix.c index 6b72470..d05f373 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -64,6

Re: [Qemu-devel] [PATCH v2 2/2] net: Dump client type 'info network'

2011-05-23 Thread Markus Armbruster
Jan Kiszka jan.kis...@siemens.com writes: On 2011-05-23 11:28, Markus Armbruster wrote: Jan Kiszka jan.kis...@siemens.com writes: Include the client type name into the output of 'info network'. The result looks like this: (qemu) info network VLAN 0 devices: rtl8139.0:

Re: [Qemu-devel] [RFC/PATCH] virtio-9p: Add Read only support for 9p export.

2011-05-23 Thread Stefan Hajnoczi
On Mon, May 23, 2011 at 12:49 PM, M. Mohan Kumar mo...@in.ibm.com wrote: On Mon, May 23, 2011 at 11:08:34AM +0100, Stefan Hajnoczi wrote: On Mon, May 23, 2011 at 8:58 AM, M. Mohan Kumar mo...@in.ibm.com wrote: A new fsdev parameter access is introduced to control accessing 9p export.

Re: [Qemu-devel] [PATCH] Add support for fd: protocol

2011-05-23 Thread Anthony Liguori
On 05/23/2011 08:09 AM, Stefan Hajnoczi wrote: On Mon, May 23, 2011 at 1:50 PM, Anthony Liguorialigu...@us.ibm.com wrote: On 05/23/2011 04:45 AM, Daniel P. Berrange wrote: On Fri, May 20, 2011 at 02:48:23PM -0400, Corey Bryant wrote: sVirt provides SELinux MAC isolation for Qemu guest

[Qemu-devel] Fedora virt status

2011-05-23 Thread Justin M. Forbes
Fedora 14 - We have 101 open bugs, 5 of which have fixes in awaiting updates. - 1 bug has been closed in the last week Fedora 15 - Release tomorrow! - We have 36 open bugs 2 of which have fixes in awaiting updates. - 6 bugs have been closed in the last week - GA images have been cleared for

Re: [Qemu-devel] [PATCH] sheepdog: add data preallocation support

2011-05-23 Thread Stefan Hajnoczi
On Mon, May 23, 2011 at 12:13 PM, MORITA Kazutaka morita.kazut...@lab.ntt.co.jp wrote: At Mon, 23 May 2011 10:19:13 +0100, Stefan Hajnoczi wrote: On Sat, May 21, 2011 at 1:35 PM, MORITA Kazutaka morita.kazut...@lab.ntt.co.jp wrote: +static int sd_prealloc(uint32_t vid, int64_t vdi_size)

Re: [Qemu-devel] [PATCH] Add support for fd: protocol

2011-05-23 Thread Stefan Hajnoczi
On Mon, May 23, 2011 at 2:21 PM, Anthony Liguori aligu...@us.ibm.com wrote: On 05/23/2011 08:09 AM, Stefan Hajnoczi wrote: On Mon, May 23, 2011 at 1:50 PM, Anthony Liguorialigu...@us.ibm.com  wrote: On 05/23/2011 04:45 AM, Daniel P. Berrange wrote: On Fri, May 20, 2011 at 02:48:23PM -0400,

Re: [Qemu-devel] [PATCHv4 0/2] libcacard.la

2011-05-23 Thread Paolo Bonzini
On 05/23/2011 03:12 PM, Alon Levy wrote: On Wed, May 18, 2011 at 05:23:42PM +0300, Alon Levy wrote: Ping? Allow building standalone shared (or static, whichever libtool chooses) library out of libcacard sources, for use by ccid-card-passthru remote clients. v4: exit (return code 1) if

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers = 0x8000000000000000

2011-05-23 Thread Anthony Liguori
On 05/23/2011 08:04 AM, Daniel P. Berrange wrote: On Fri, May 20, 2011 at 01:11:05PM -0500, Anthony Liguori wrote: On 05/20/2011 01:03 PM, Richard W.M. Jones wrote: There seem to be a few unsafe uses of strto* functions. This patch just fixes the one that affects me :-) Sending an integer

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers = 0x8000000000000000

2011-05-23 Thread Richard W.M. Jones
Just refer everyone at this point the actual standard: http://www.ietf.org/rfc/rfc4627.txt It leaves it up to the application how to interpret and store integers. It would be standard-conforming to only allow 0 and 1. While qemu is technically correct, in practice it's being very unhelpful

Re: [Qemu-devel] [PATCH] Add support for fd: protocol

2011-05-23 Thread Daniel P. Berrange
On Mon, May 23, 2011 at 02:26:05PM +0100, Stefan Hajnoczi wrote: On Mon, May 23, 2011 at 2:21 PM, Anthony Liguori aligu...@us.ibm.com wrote: On 05/23/2011 08:09 AM, Stefan Hajnoczi wrote: On Mon, May 23, 2011 at 1:50 PM, Anthony Liguorialigu...@us.ibm.com  wrote: On 05/23/2011 04:45

Re: [Qemu-devel] [PATCH] block/raw-posix: use a character device if a block device is given

2011-05-23 Thread Christoph Hellwig
+if (lstat(filename, sb) 0) { +fprintf(stderr, %s: stat failed: %s\n, filename, strerror(errno)); +return -errno; +} + +if (S_ISBLK(sb.st_mode)) +filename = raw_get_rawdevice(filename); Please move the lstat and S_ISBLK check into raw_get_rawdevice.

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers = 0x8000000000000000

2011-05-23 Thread Anthony Liguori
The actual value of the alert will surprise you :-) Integers in Javascript are actually represented as doubles internally which means that integer constants are only accurate up to 52 bits. So really, we should cap integers at 32-bit :-/ Have I mentioned recently that I really dislike JSON...

Re: [Qemu-devel] [PATCH 21/26] target-xtensa: implement unaligned exception option

2011-05-23 Thread Richard Henderson
On 05/22/2011 01:12 PM, Max Filippov wrote: This is also done by gen_load_store_alignment. Does it really worth copying part of this logic to do_unaligned_access just to use ALIGNED_ONLY framework? Yes, because it is done out-of-line, as a part of the TLB load slow path. r~

Re: [Qemu-devel] [PATCH] block/raw-posix: use a character device if a block device is given

2011-05-23 Thread Christoph Egger
On 05/23/11 15:42, Christoph Hellwig wrote: +if (lstat(filename,sb) 0) { +fprintf(stderr, %s: stat failed: %s\n, filename, strerror(errno)); +return -errno; +} + +if (S_ISBLK(sb.st_mode)) +filename = raw_get_rawdevice(filename); Please move the lstat and

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers = 0x8000000000000000

2011-05-23 Thread Luiz Capitulino
On Mon, 23 May 2011 08:50:55 -0500 Anthony Liguori anth...@codemonkey.ws wrote: The actual value of the alert will surprise you :-) Integers in Javascript are actually represented as doubles internally which means that integer constants are only accurate up to 52 bits. So really, we

Re: [Qemu-devel] [PATCH 17/18] usb: move cancel callback to USBDeviceInfo

2011-05-23 Thread Hans de Goede
Hi, Gerd, this is more or less a copy of a mail I send you directly earlier before I saw this pull request. NACK for this one, rational: While working on re-basing / re-doing my usb network redirection code for qemu, on top of your usb.12 I've hit a problem caused by the move of the async

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers = 0x8000000000000000

2011-05-23 Thread Anthony Liguori
On 05/23/2011 09:02 AM, Luiz Capitulino wrote: On Mon, 23 May 2011 08:50:55 -0500 Anthony Liguorianth...@codemonkey.ws wrote: The actual value of the alert will surprise you :-) Integers in Javascript are actually represented as doubles internally which means that integer constants are only

Re: [Qemu-devel] [PATCH] block/raw-posix: use a character device if a block device is given

2011-05-23 Thread Kevin Wolf
Am 23.05.2011 14:34, schrieb Christoph Egger: if given a block device, use the character device instead. From: Manuel Bouyer bou...@netbsd.org Signed-off-by: Christoph Egger christoph.eg...@amd.com A useful commit message would explain why you're doing that. diff --git

Re: [Qemu-devel] [PATCH v2 2/2] net: Dump client type 'info network'

2011-05-23 Thread Jan Kiszka
On 2011-05-23 15:14, Markus Armbruster wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2011-05-23 11:28, Markus Armbruster wrote: Jan Kiszka jan.kis...@siemens.com writes: Include the client type name into the output of 'info network'. The result looks like this: (qemu) info network

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers = 0x8000000000000000

2011-05-23 Thread Daniel P. Berrange
On Mon, May 23, 2011 at 08:50:55AM -0500, Anthony Liguori wrote: The actual value of the alert will surprise you :-) Integers in Javascript are actually represented as doubles internally which means that integer constants are only accurate up to 52 bits. So really, we should cap integers

Re: [Qemu-devel] [PATCH] Add support for fd: protocol

2011-05-23 Thread Kevin Wolf
Am 20.05.2011 21:53, schrieb Blue Swirl: On Fri, May 20, 2011 at 10:42 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 05/20/2011 02:25 PM, Blue Swirl wrote: On Fri, May 20, 2011 at 9:48 PM, Corey Bryantbrynt...@us.ibm.com wrote: sVirt provides SELinux MAC isolation for Qemu guest

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers = 0x8000000000000000

2011-05-23 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: The actual value of the alert will surprise you :-) Integers in Javascript are actually represented as doubles internally which means that integer constants are only accurate up to 52 bits. So really, we should cap integers at 32-bit :-/ Have

Re: [Qemu-devel] [PATCH] qemu: json: Fix parsing of integers = 0x8000000000000000

2011-05-23 Thread Daniel P. Berrange
On Mon, May 23, 2011 at 04:29:55PM +0200, Markus Armbruster wrote: Anthony Liguori anth...@codemonkey.ws writes: The actual value of the alert will surprise you :-) Integers in Javascript are actually represented as doubles internally which means that integer constants are only accurate

Re: [Qemu-devel] [PATCH 17/18] usb: move cancel callback to USBDeviceInfo

2011-05-23 Thread Gerd Hoffmann
Hi, The problem is that the USBDevice lifetime may be shorter then the USBPacket lifetime, USBPackets are created by uhci.c (for example), where as the device is managed from the monitor (for example), doing a usb_del in the monitor using the guest bus:addr will call usb_device_delete_addr,

Re: [Qemu-devel] [PATCH] Add support for fd: protocol

2011-05-23 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 05/23/2011 05:30 AM, Daniel P. Berrange wrote: It feels to me that turning the current block driver code which just does open(2) on files, into something which issues events asynchronously waits for a file would potentially be quite complex.

[Qemu-devel] [RFC][PATCH v0 6/8] Spill globals early if their next use is in call.

2011-05-23 Thread Kirill Batuzov
Spill globals early if their next use is in call. They'll be spilled anyway in this case. Signed-off-by: Kirill Batuzov batuz...@ispras.ru --- tcg/tcg.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 8ab556d..ad5bd71 100644

[Qemu-devel] [RFC][PATCH v0 4/8] Calculate NEXT_CALL liveness information.

2011-05-23 Thread Kirill Batuzov
Keep track of where is the next call for each TCG operation. Signed-off-by: Kirill Batuzov batuz...@ispras.ru --- tcg/tcg.c | 11 +++ tcg/tcg.h |2 ++ 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 61689e2..799b245 100644 --- a/tcg/tcg.c

[Qemu-devel] [RFC][PATCH v0 2/8] Propagate REG_NEXT_USE value through process of register allocation.

2011-05-23 Thread Kirill Batuzov
Propagate next use of each register through process of register allocation. This would be needed to do a better spill choice. Signed-off-by: Kirill Batuzov batuz...@ispras.ru --- tcg/tcg.c | 36 +--- 1 files changed, 33 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [RFC][PATCH v0 1/8] Compute additional liveness information for register allocator.

2011-05-23 Thread Kirill Batuzov
Compute next use for each operation argument. Signed-off-by: Kirill Batuzov batuz...@ispras.ru --- tcg/tcg.c | 73 - tcg/tcg.h |4 +++ 2 files changed, 71 insertions(+), 6 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index

[Qemu-devel] [RFC][PATCH v0 8/8] Add spill count profiling.

2011-05-23 Thread Kirill Batuzov
Gather generated spills statistics. It is useful for debugging and evaluating of new register allocator. Signed-off-by: Kirill Batuzov batuz...@ispras.ru --- tcg/tcg.c | 69 + tcg/tcg.h |6 + 2 files changed, 75

[Qemu-devel] [RFC][PATCH v0 7/8] Spill globals early if their next use is at the BB end.

2011-05-23 Thread Kirill Batuzov
Spill globals early if their next use is at the BB end. They'll be spilled anyway in this case. Signed-off-by: Kirill Batuzov batuz...@ispras.ru --- tcg/tcg.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index ad5bd71..022eef9 100644

[Qemu-devel] [RFC][PATCH v0 5/8] Track call-clobbered uses of registers

2011-05-23 Thread Kirill Batuzov
Adjust next use for call-clobbered registers. Signed-off-by: Kirill Batuzov batuz...@ispras.ru --- tcg/tcg.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 799b245..8ab556d 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2125,6 +2125,9

[Qemu-devel] [RFC][PATCH v0 0/8] Improve register allocator

2011-05-23 Thread Kirill Batuzov
This series improves register allocator by keeping track of temp's and register's live ranges, doing better spill choice and spilling early unneeded globals. The patches do need testing and performance evaluation before they will be ready for final review. I decided to preliminary post them

[Qemu-devel] [RFC][PATCH v0 3/8] Do better spill choice.

2011-05-23 Thread Kirill Batuzov
Choose register with farthest next use for spilling. Signed-off-by: Kirill Batuzov batuz...@ispras.ru --- tcg/tcg.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index c6e920e..61689e2 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@

[Qemu-devel] [PATCH 0/4] slirp: Fixes for restricted mode and more

2011-05-23 Thread Jan Kiszka
For isolating slirp-attached guests from the world, QEMU provides the restricted mode. However, its implementation suffers from bugs that makes it practically unusable. Most probablematic is broken DHCP. This series fixes that and canonicalizes the corresponding command line switch. It also

[Qemu-devel] [PATCH 1/4] slirp: Fix restricted mode

2011-05-23 Thread Jan Kiszka
This aligns the code to what the documentation claims: Allow everything but requests that would have to be routed outside of the virtual LAN. So we need to drop the unneeded IP-level filter, allow TFTP requests, and add the missing protocol-level filter to ICMP. CC: Gleb Natapov g...@redhat.com

[Qemu-devel] [PATCH 4/4] slirp: Replace m_freem with m_free

2011-05-23 Thread Jan Kiszka
Remove this pointless wrapping. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- slirp/ip_icmp.c |6 +++--- slirp/ip_input.c |8 slirp/ip_output.c |4 ++-- slirp/mbuf.h |3 --- slirp/tcp_input.c | 10 +- slirp/tcp_subr.c |2 +- slirp/udp.c

  1   2   3   >