Re: [Qemu-devel] Use getaddrinfo for migration

2012-03-05 Thread Amos Kong
On 02/03/12 18:41, Daniel P. Berrange wrote: On Fri, Mar 02, 2012 at 02:25:36PM +0400, Michael Tokarev wrote: Not a reply to the patch but a general observation. I noticed that the tcp migration uses gethostname (or getaddrinfo after this patch) from the main thread - is it really the way to

Re: [Qemu-devel] restart a coroutine?

2012-03-05 Thread Paolo Bonzini
Il 04/03/2012 21:01, Michael Tokarev ha scritto: This is all fine, except of one thing: restarting (resending) of the requests which has been sent to the remote and for which we were waiting for reply already. For these requests, they should be resent using new socket, when the connection

[Qemu-devel] [PATCH V2 0/5] VMState cleanups

2012-03-05 Thread Igor Mitsyanko
This patchset cleans up and optimizes vmstate implementation. v1-v2 PATCH 4 now moves VMSTATE_UINTTL* macros to cpu-defs.h instead of to vmstate.h. put_target_ul/get_target_ul introduction is dropped. PATCH2,PATCH3 commit messages are rewritten a little bit. But I'm still not sure whether Andrzej

[Qemu-devel] [PATCH V2 2/5] hw/pxa2xx_dma.c: drop target_phys_addr_t usage in device state

2012-03-05 Thread Igor Mitsyanko
Pxa2xx DMA controller is a 32-bit device and it has no knowledge of system's physical address size, so it should not use target_phys_addr_t in it's state. Convert variables descr, src and dest from type target_phys_addr_t to uint32_t, use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these

[Qemu-devel] [PATCH V2 3/5] hw/pxa2xx_lcd.c: drop target_phys_addr_t usage in device state

2012-03-05 Thread Igor Mitsyanko
Pxa2xx LCD controller is intended to work with 32-bit bus and it has no knowledge of system's physical address size, so it should not use target_phys_addr_t in it's state. Convert three variables in DMAChannel state from target_phys_addr_t to uint32_t, use VMSTATE_UINT32 instead of

[Qemu-devel] [PATCH V2 1/5] target-alpha/machine.c: use VMSTATE_UINT64* instead of VMSTATE_UINTTL*

2012-03-05 Thread Igor Mitsyanko
Do not use VMSTATE_UINTTL* macro for variables that are actually defined as uint64_t in CPUAlphaState. Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com --- target-alpha/machine.c | 34 +- 1 files changed, 17 insertions(+), 17 deletions(-) diff --git

[Qemu-devel] [PATCH V2 5/5] vmstate: introduce get_bufsize entry in VMStateField

2012-03-05 Thread Igor Mitsyanko
New get_bufsize field in VMStateField is supposed to help us easily add save/restore support of dynamically allocated buffers in device's states. There are some cases when information about size of dynamically allocated buffer is already presented in specific device's state structure, but in

[Qemu-devel] [PATCH V2 4/5] vmstate: move VMSTATE_UINTTL* macros definitions to cpu-defs.h

2012-03-05 Thread Igor Mitsyanko
VMSTATE_UINTTL* macros should be used only in files compiled with knowledge of virtual address size of specific CPU. Currently this is achieved by protecting VMSTATE_UINTTL* definitions with #ifndef NEED_CPU_H in hw/hw.h, but it would be more appropriate to move these macros to cpu-defs.h header.

[Qemu-devel] [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait

2012-03-05 Thread Paolo Bonzini
This is quite ugly. Two threads, one running main_loop_wait and one running qemu_aio_wait, can race with each other on running the same iohandler. The result is that an iohandler could run while the underlying socket is not readable or writable, with possibly ill effects. This shows as a

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-05 Thread Kevin Wolf
Am 01.03.2012 22:10, schrieb Anthony Liguori: On 03/01/2012 05:21 AM, Paolo Bonzini wrote: This implements all ingredients to establish mirrored writes. The drive-reopen command that is used to terminate mirrored writes is not included in this series. Tested with the following scenarios:

Re: [Qemu-devel] [PATCH 3/4] net: split hostname and service by last colon

2012-03-05 Thread Kevin Wolf
Am 02.03.2012 20:54, schrieb Laine Stump: On 03/02/2012 05:35 AM, Kevin Wolf wrote: Am 02.03.2012 10:58, schrieb Amos Kong: On 02/03/12 11:38, Amos Kong wrote: --- a/net.c +++ b/net.c @@ -84,7 +84,7 @@ static int get_str_sep(char *buf, int buf_size, const char **pp, int sep) const

Re: [Qemu-devel] [PATCH 3/4] net: split hostname and service by last colon

2012-03-05 Thread Amos Kong
- Original Message - Am 02.03.2012 20:54, schrieb Laine Stump: On 03/02/2012 05:35 AM, Kevin Wolf wrote: Am 02.03.2012 10:58, schrieb Amos Kong: On 02/03/12 11:38, Amos Kong wrote: --- a/net.c +++ b/net.c @@ -84,7 +84,7 @@ static int get_str_sep(char *buf, int buf_size,

Re: [Qemu-devel] [PATCH v2 0/4] slirp: Fix for requeuing crash, cleanups

2012-03-05 Thread Jan Kiszka
On 2012-03-02 22:05, Stefan Weil wrote: Am 02.03.2012 19:57, schrieb Jan Kiszka: Well, this requeuing bug seems to have a long breath. Previous attempts to fix it (mine included) neglected the fact that we need to walk the queue of pending packets, not just restart from the beginning after a

Re: [Qemu-devel] [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait

2012-03-05 Thread Jan Kiszka
On 2012-03-05 09:34, Paolo Bonzini wrote: This is quite ugly. Two threads, one running main_loop_wait and one running qemu_aio_wait, can race with each other on running the same iohandler. The result is that an iohandler could run while the underlying socket is not readable or writable, with

[Qemu-devel] [PATCH v2 4/5] pl031: rearm alarm timer upon load

2012-03-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/pl031.c | 39 --- 1 files changed, 24 insertions(+), 15 deletions(-) diff --git a/hw/pl031.c b/hw/pl031.c index 69abc4f..713f85d 100644 --- a/hw/pl031.c +++ b/hw/pl031.c @@ -47,21 +47,6 @@ typedef

[Qemu-devel] [PATCH v2 0/5] Make rt_clock usage configurable for ARM devices

2012-03-05 Thread Paolo Bonzini
Direct usage of rt_clock should be discouraged. For RTC devices the user cannot choose to follow the host clock with respect to NTP adjustment and daylight savings changes. For other devices it does not provide determinism together with -icount or qtest, and it also keeps ticking while the

[Qemu-devel] [PATCH v2 2/5] omap: switch omap_lpg to vm_clock

2012-03-05 Thread Paolo Bonzini
The output of the pulse generator needs to be deterministic when running in -icount mode, and to remain constant whenever the VM is stopped. So the right clock to use is vm_clock. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/omap1.c |6 +++--- 1 files changed, 3 insertions(+), 3

[Qemu-devel] [PATCH v2 1/5] rtc: add -rtc clock=rt

2012-03-05 Thread Paolo Bonzini
This will let people use backwards-compatible semantics for devices that will be affected by the following patches. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-options.hx |7 --- vl.c|2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [RFC][PATCH 00/16 v8] introducing a new, dedicated memory dump mechanism

2012-03-05 Thread Wen Congyang
At 03/02/2012 05:59 PM, Wen Congyang Wrote: Hi, all 'virsh dump' can not work when host pci device is used by guest. We have discussed this issue here: http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg00736.html The last version is here:

Re: [Qemu-devel] Add support for new image type

2012-03-05 Thread Paolo Bonzini
Il 02/03/2012 19:38, Kai Meyer ha scritto: Well, yes. I was assuming that there was potential for us to be able to distribute qemu modifications that would not require us opening up our library. The more we look at it, and some past precedence we've experienced, it looks like it's not going to

Re: [Qemu-devel] restart a coroutine?

2012-03-05 Thread Avi Kivity
On 03/04/2012 10:01 PM, Michael Tokarev wrote: On 04.03.2012 20:08, Avi Kivity wrote: On 03/04/2012 02:41 PM, Michael Tokarev wrote: Since all block (bdrv) layer is now implemented using coroutines, I thought I'd give it a try. But immediately hit a question to which I don't know a good

Re: [Qemu-devel] [PATCH v4 1/3] kvmclock: Always register type

2012-03-05 Thread Avi Kivity
On 03/04/2012 10:32 PM, Andreas Färber wrote: Currently, the kvmclock type is only registered when kvm_enabled(). This breaks when moving type registration to before command line parsing (so that QOM types can be used for CPU and machine). Since the QOM classes are lazy-initialized anyway

Re: [Qemu-devel] [PATCH 3/4] net: split hostname and service by last colon

2012-03-05 Thread Kevin Wolf
Am 05.03.2012 09:59, schrieb Amos Kong: - Original Message - Am 02.03.2012 20:54, schrieb Laine Stump: On 03/02/2012 05:35 AM, Kevin Wolf wrote: Am 02.03.2012 10:58, schrieb Amos Kong: On 02/03/12 11:38, Amos Kong wrote: --- a/net.c +++ b/net.c @@ -84,7 +84,7 @@ static int

Re: [Qemu-devel] [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 10:07, Jan Kiszka ha scritto: This is quite ugly. Two threads, one running main_loop_wait and one running qemu_aio_wait, can race with each other on running the same iohandler. The result is that an iohandler could run while the underlying socket is not readable or

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 09:53, Kevin Wolf ha scritto: I think we need some sort of introspection method too in order for clients to figure out when the command is extended. How about coupling the types with independently available commands for now? We would rename 'snapshot' to

[Qemu-devel] [PATCH v2 5/5] pl031: switch clock base to rtc_clock

2012-03-05 Thread Paolo Bonzini
This lets the user specify the desired semantics. By default, the RTC will follow adjustments from the host's NTP client, and will remain in sync when the virtual machine is stopped. The previous behavior, which provides determinism with both icount and qtest, remains available with -rtc

[Qemu-devel] [PATCH v2 3/5] arm: switch real-time clocks to rtc_clock

2012-03-05 Thread Paolo Bonzini
This lets the user specify the desired semantics. By default, the RTC will follow adjustments from the host's NTP client. -rtc clock=vm will improve determinism with both icount and qtest. Finally, the previous behavior is available with -rtc clock=rt. Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] PPC: VGA broken in git master

2012-03-05 Thread Avi Kivity
On 03/04/2012 08:06 PM, Mark Cave-Ayland wrote: Hi all, I've just done a git pull to update my local repository, and it now appears that the VGA device is broken in QEMU - rather than displaying the OpenBIOS banner in my VNC client, the framebuffer remains constantly black. A git bisect

Re: [Qemu-devel] [SeaBIOS] [Seabios] [PATCH 0/6] 64bit PCI BARs allocations (take 2)

2012-03-05 Thread Gerd Hoffmann
Hi, Hrmm. By my count, this would be the third rewrite of the PCI bar initialization in the last 14 months. Indeed. Given the churn in this area, I don't want to commit patches that do wholesale code replacement. I'd prefer to see each patch independently add some functionality and

[Qemu-devel] [PATCH v2 0/9] support to migrate with IPv6 address

2012-03-05 Thread Amos Kong
Those patches make migration of IPv6 address work, old code only support to parse IPv4 address/port, use getaddrinfo() to get socket addresses infomation. Last two patches are about spliting IPv6 host/port. Changes from v1: - split different changes to small patches, it will be easier to

[Qemu-devel] [PATCH v2 1/9] net: introduce tcp_server_start()

2012-03-05 Thread Amos Kong
Introduce tcp_server_start() by moving original code in tcp_start_incoming_migration(). Signed-off-by: Amos Kong ak...@redhat.com --- net.c | 27 +++ qemu_socket.h |2 ++ 2 files changed, 29 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index

[Qemu-devel] [PATCH v2 2/9] net: use tcp_server_start() for tcp server creation

2012-03-05 Thread Amos Kong
Use tcp_server_start in those two functions: tcp_start_incoming_migration() net_socket_listen_init() Signed-off-by: Amos Kong ak...@redhat.com --- migration-tcp.c | 21 + net/socket.c| 23 +++ 2 files changed, 8 insertions(+), 36 deletions(-)

Re: [Qemu-devel] [SeaBIOS] [Seabios] [PATCH 0/6] 64bit PCI BARs allocations (take 2)

2012-03-05 Thread Gerd Hoffmann
Hi, I can either send a patch over existing patches, or send new series or both. For testing a incremental patch is fine, for merge a new series with the fixes squashed into the buggy patches is needed. cheers, Gerd

[Qemu-devel] [PATCH v2 8/9] net: split hostname and service by last colon

2012-03-05 Thread Amos Kong
IPv6 address contains colons, parse will be wrong. [2312::8274]:5200 Signed-off-by: Amos Kong ak...@redhat.com --- net.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net.c b/net.c index 2518e5f..d6ce1fa 100644 --- a/net.c +++ b/net.c @@ -84,7 +84,7 @@ static int

Re: [Qemu-devel] [PATCH 1/6] rtl8139: limit transmission buffer size in c+ mode

2012-03-05 Thread Stefan Hajnoczi
On Mon, Mar 05, 2012 at 11:08:24AM +0800, Jason Wang wrote: The tx buffer would be re-allocated for tx descriptor with big size and without LS bit set, this would make guest driver could easily let qemu to allocate unlimited. In linux host, a glib failure were easy to be triggered:

[Qemu-devel] [PATCH v2 7/9] net: introduce parse_host_port_info()

2012-03-05 Thread Amos Kong
int parse_host_port(struct sockaddr_in *saddr, const char *str) Parsed address info will be restored into 'saddr', it only support ipv4. This function is used by net_socket_mcast_init() and net_socket_udp_init(). int parse_host_port_info(struct addrinfo *result, const char *str) Parsed address

Re: [Qemu-devel] [PATCH] usb: queue can have async packets too

2012-03-05 Thread Erik Rull
On March 2, 2012 at 3:15 PM Gerd Hoffmann kra...@redhat.com wrote: But: This + the latest GIT master causes again my problems with the With or without this one: commit 5ca2358ac895139e624881c5b3bf3095d3cc4515 Date: Wed Feb 29 09:11:00 2012 -0600 Merge remote-tracking branch

[Qemu-devel] [PATCH v2 4/9] net: use tcp_client_start for tcp client creation

2012-03-05 Thread Amos Kong
Use tcp_client_start() in those two functions: tcp_start_outgoing_migration() net_socket_connect_init() Signed-off-by: Amos Kong ak...@redhat.com --- migration-tcp.c | 41 + net/socket.c| 41 +++-- 2 files

[Qemu-devel] [PATCH v2 6/9] net: use getaddrinfo() in tcp_start_common

2012-03-05 Thread Amos Kong
Migrating with IPv6 address exists problem, gethostbyname()/inet_aton() could not translate IPv6 address/port simply, so use getaddrinfo() in tcp_start_common to translate network address and service. We can get an address list by getaddrinfo(). Userlevel IPv6 Programming Introduction:

Re: [Qemu-devel] [Qemu-ppc] PPC: VGA broken in git master

2012-03-05 Thread Alexander Graf
On 03/05/2012 10:51 AM, Avi Kivity wrote: On 03/04/2012 08:06 PM, Mark Cave-Ayland wrote: Hi all, I've just done a git pull to update my local repository, and it now appears that the VGA device is broken in QEMU - rather than displaying the OpenBIOS banner in my VNC client, the framebuffer

Re: [Qemu-devel] PPC: VGA broken in git master

2012-03-05 Thread Mark Cave-Ayland
On 05/03/12 09:51, Avi Kivity wrote: On 03/04/2012 08:06 PM, Mark Cave-Ayland wrote: Hi all, I've just done a git pull to update my local repository, and it now appears that the VGA device is broken in QEMU - rather than displaying the OpenBIOS banner in my VNC client, the framebuffer remains

Re: [Qemu-devel] [PATCH] seabios: acpi: Add _STA for PCI hotplug slots

2012-03-05 Thread Gleb Natapov
On Mon, Mar 05, 2012 at 08:26:23AM +0200, Michael S. Tsirkin wrote: On Sun, Mar 04, 2012 at 08:30:00PM -0700, Alex Williamson wrote: On Sun, 2012-03-04 at 20:53 +0200, Michael S. Tsirkin wrote: On Fri, Feb 24, 2012 at 04:21:17PM -0700, Alex Williamson wrote: When a Status method is

[Qemu-devel] [PATCH v2 3/9] net: introduce tcp_client_start()

2012-03-05 Thread Amos Kong
Introduce tcp_client_start() by moving original code in tcp_start_outgoing_migration(). Signed-off-by: Amos Kong ak...@redhat.com --- net.c | 39 +++ qemu_socket.h |1 + 2 files changed, 40 insertions(+), 0 deletions(-) diff --git a/net.c

[Qemu-devel] [PATCH v2 5/9] net: refector tcp_*_start functions

2012-03-05 Thread Amos Kong
There are some repeated code for tcp_server_start() and tcp_client_start(). Signed-off-by: Amos Kong ak...@redhat.com --- net.c | 82 - 1 files changed, 46 insertions(+), 36 deletions(-) diff --git a/net.c b/net.c index

[Qemu-devel] [PATCH v2 9/9] net: support to include ipv6 address by brackets

2012-03-05 Thread Amos Kong
That method of representing an IPv6 address with a port is discouraged because of its ambiguity. Referencing to RFC5952, the recommended format is: [2312::8274]:5200 For IPv6 brackets must be mandatory if you require a port. test status: Successed listen side: qemu-kvm -incoming

[Qemu-devel] KVM call eganda for Tuesday 6th

2012-03-05 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Cheers, Juan.

[Qemu-devel] Organic SEO Services

2012-03-05 Thread Nisha
Hello, Greetings for the day! I am Nisha and I am contacting you after looking at your website- . We are a Leading Indian Based SEO Web Development Company and one of the very few company which offer organic SEO services with a full range of supporting services such as one way themed

Re: [Qemu-devel] [PATCH] qed: do not evict in-use L2 table cache entries

2012-03-05 Thread Stefan Hajnoczi
On Thu, Mar 1, 2012 at 4:58 PM, Kevin Wolf kw...@redhat.com wrote: Am 01.03.2012 17:22, schrieb Stefan Hajnoczi: On Thu, Mar 01, 2012 at 05:10:57PM +0100, Kevin Wolf wrote: Am 27.02.2012 14:16, schrieb Stefan Hajnoczi: The L2 table cache reduces QED metadata reads that would be required when

Re: [Qemu-devel] BlockDriverState stack and BlockListeners

2012-03-05 Thread Stefan Hajnoczi
On Sun, Mar 4, 2012 at 5:14 AM, Ori Mamluk omam...@zerto.com wrote: On 03/03/2012 13:46, Stefan Hajnoczi wrote: On Wed, Feb 29, 2012 at 8:38 AM, Ori Mamlukomam...@zerto.com  wrote: I think the BlockFilter direction goes very well with our plans for a replication module. I guess it would

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-05 Thread Kevin Wolf
Am 05.03.2012 10:28, schrieb Paolo Bonzini: Il 05/03/2012 09:53, Kevin Wolf ha scritto: I think we need some sort of introspection method too in order for clients to figure out when the command is extended. How about coupling the types with independently available commands for now? We

Re: [Qemu-devel] Add support for new image type

2012-03-05 Thread Stefan Hajnoczi
On Fri, Mar 2, 2012 at 6:38 PM, Kai Meyer kai.me...@storagecraft.com wrote: From: Paolo Bonzini [pbonz...@redhat.com] Sent: Thursday, March 01, 2012 11:54 PM To: Kai Meyer Cc: Anthony Liguori; Stefan Weil; qemu-devel@nongnu.org; Nate Bushman Subject:

Re: [Qemu-devel] usb patches [v2]

2012-03-05 Thread Gerd Hoffmann
On 03/02/12 21:27, Hans de Goede wrote: Here is a series of usb patches against current qemu master, mostly consisting of a whole bunch of small ehci fixes, plus some redirection fixes. Patch added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7

2012-03-05 Thread Alon Levy
On Fri, Mar 02, 2012 at 08:44:09PM -0500, Brad Smith wrote: On 02/03/12 10:49 AM, Hans de Goede wrote: VCARD_ATR_PREFIX is used as part of an array initializer so it should not have () around it, so far this happened to work, but gcc-4.7 does not like it. Thanks for the report, my bad, used

Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7

2012-03-05 Thread Alon Levy
On Mon, Mar 05, 2012 at 02:47:13PM +0200, Alon Levy wrote: On Fri, Mar 02, 2012 at 08:44:09PM -0500, Brad Smith wrote: On 02/03/12 10:49 AM, Hans de Goede wrote: VCARD_ATR_PREFIX is used as part of an array initializer so it should not have () around it, so far this happened to work, but

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/2] Trivial MemoryRegionOps patches

2012-03-05 Thread Stefan Hajnoczi
On Sat, Feb 25, 2012 at 01:37:11PM +0100, Stefan Weil wrote: Please apply http://patchwork.ozlabs.org/patch/139660/ to the qemu-trivial patch queue. Here are two additional trivial patches which also touch MemoryRegionOps and make the code more uniform. [PATCH 1/2] ppc: Add missing 'static'

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 13:13, Kevin Wolf ha scritto: Makes sense. It would also be a good excuse to port blockdev-snapshot-sync to the new fail-safe way. I'll refresh my patches if there's consensus. Will you also replace 'blockdev-transaction' by 'transaction' to keep things generic at the

Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7

2012-03-05 Thread Michal Privoznik
On 02.03.2012 16:49, Hans de Goede wrote: VCARD_ATR_PREFIX is used as part of an array initializer so it should not have () around it, so far this happened to work, but gcc-4.7 does not like it. Neither do gcc-4.6.2.

Re: [Qemu-devel] [PATCH] Fix spelling in documentation

2012-03-05 Thread Stefan Hajnoczi
On Sat, Feb 25, 2012 at 01:47:09PM +0100, Stefan Weil wrote: This fixes a new spelling issue which was detected by codespell. Signed-off-by: Stefan Weil s...@weilnetz.de --- include/qemu/object.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial

Re: [Qemu-devel] [PATCH] block/vmdk: Fix warning from splint (comparision of unsigned value)

2012-03-05 Thread Stefan Hajnoczi
On Sat, Feb 25, 2012 at 02:01:42PM +0100, Stefan Weil wrote: l1_entry_sectors will never be less than 0. Signed-off-by: Stefan Weil s...@weilnetz.de --- block/vmdk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree:

Re: [Qemu-devel] [PATCH] Fix sign of sscanf format specifiers

2012-03-05 Thread Stefan Hajnoczi
On Sat, Feb 25, 2012 at 02:11:46PM +0100, Stefan Weil wrote: All values read by sscanf are unsigned, so replace %d by %u. This signed / unsigned mismatch was detected by splint. Signed-off-by: Stefan Weil s...@weilnetz.de --- cursor.c |3 ++- 1 files changed, 2 insertions(+), 1

[Qemu-devel] [PATCH v2 1/2] qapi-schema: fix typos and explain 'spice' auth

2012-03-05 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- qapi-schema.json | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) v1-v2: - Fixes wrong indentation for second spice channel-id - split the last part (ObjectPropertyInfo). diff --git a/qapi-schema.json b/qapi-schema.json

[Qemu-devel] [PATCH v2 2/2] qapi-schema.json: fix comment for type ObjectPropretyInfo

2012-03-05 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- qapi-schema.json |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 93ee2a4..dd9e0e5 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1256,7 +1256,7 @@ { 'command':

Re: [Qemu-devel] [PATCH] vnc: Fix packed boolean struct members

2012-03-05 Thread Stefan Hajnoczi
On Sat, Feb 25, 2012 at 02:35:47PM +0100, Stefan Weil wrote: This patch fixes warnings reported by splint: For variables which are packed in a single bit, a signed data type like 'int' does not make much sense. There is no obvious reason why the two values should be packed, so I removed

Re: [Qemu-devel] [Seabios] [PATCH 0/6] 64bit PCI BARs allocations (take 2)

2012-03-05 Thread Kevin O'Connor
On Mon, Mar 05, 2012 at 07:03:08PM +1300, Alexey Korolev wrote: On Thu, Mar 01, 2012 at 06:50:43PM +1300, Alexey Korolev wrote: In the 6th patch we clear old code. Given the churn in this area, I don't want to commit patches that do wholesale code replacement. I'd prefer to see each patch

Re: [Qemu-devel] [PATCH] libcacard: Use format specifier %u instead of %d for unsigned values

2012-03-05 Thread Stefan Hajnoczi
On Sat, Feb 25, 2012 at 02:54:17PM +0100, Stefan Weil wrote: splint reported warnings for those code statements. Signed-off-by: Stefan Weil s...@weilnetz.de --- libcacard/vscclient.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) Thanks, applied to the

Re: [Qemu-devel] [PATCH] osdep: Remove local definition of macro offsetof

2012-03-05 Thread Andreas Färber
Am 05.03.2012 07:22, schrieb Stefan Weil: The macro offsetof is defined in stddef.h. It is conforming to the standards C89, C99 and POSIX.1-2001 (see man page), so it is a sufficiently old standard. Therefore chances are very high that QEMU never needs a local definition of this macro.

Re: [Qemu-devel] [PATCH v2 1/9] net: introduce tcp_server_start()

2012-03-05 Thread Orit Wasserman
On 03/05/2012 12:03 PM, Amos Kong wrote: Introduce tcp_server_start() by moving original code in tcp_start_incoming_migration(). Signed-off-by: Amos Kong ak...@redhat.com --- net.c | 27 +++ qemu_socket.h |2 ++ 2 files changed, 29 insertions(+), 0

Re: [Qemu-devel] [PATCH v2 3/9] net: introduce tcp_client_start()

2012-03-05 Thread Orit Wasserman
On 03/05/2012 12:03 PM, Amos Kong wrote: Introduce tcp_client_start() by moving original code in tcp_start_outgoing_migration(). Signed-off-by: Amos Kong ak...@redhat.com --- net.c | 39 +++ qemu_socket.h |1 + 2 files changed, 40

Re: [Qemu-devel] [PATCH v2 2/9] net: use tcp_server_start() for tcp server creation

2012-03-05 Thread Orit Wasserman
On 03/05/2012 12:03 PM, Amos Kong wrote: Use tcp_server_start in those two functions: tcp_start_incoming_migration() net_socket_listen_init() Signed-off-by: Amos Kong ak...@redhat.com --- migration-tcp.c | 21 + net/socket.c| 23 +++ 2

Re: [Qemu-devel] [PATCH v2 3/9] net: introduce tcp_client_start()

2012-03-05 Thread Orit Wasserman
On 03/05/2012 12:03 PM, Amos Kong wrote: Introduce tcp_client_start() by moving original code in tcp_start_outgoing_migration(). Signed-off-by: Amos Kong ak...@redhat.com --- net.c | 39 +++ qemu_socket.h |1 + 2 files changed, 40

[Qemu-devel] [Bug 928676] Re: QEMU does not support Westmere (Intel Xeon) CPU model

2012-03-05 Thread Martin Salbaba
An application test with high cpu load gives the timing statistics give: bare metal virtual percent X4560 cpu50m28s 54m0s 107%

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Igor Mitsyanko
On 02/21/2012 07:33 PM, Peter Maydell wrote: On 9 February 2012 22:23, Peter Maydellpeter.mayd...@linaro.org wrote: Ping re the VMState and variable sized arrays issue. I don't see any consensus in this discussion for a different approach, so should we just commit Mitsyanko's patchset? From

[Qemu-devel] [PATCH] pcnet: Clear ERR in CSR0 on stop

2012-03-05 Thread Jan Kiszka
pcnet_stop already clears any reason (BABL, CERR, MISS, MERR) why ERR (bit 15) should be set in CRS0. So we have to clear that bit as well. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/pcnet.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pcnet.c

[Qemu-devel] [PATCH] pcnet: Properly handle TX requests during Link Fail

2012-03-05 Thread Jan Kiszka
As long as we have no link and we aren't in internal loopback mode, no packet must be sent. Instead, LCAR needs to be set in any active TX descriptor and also CERR in CSR0. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/pcnet.c | 10 ++ hw/pcnet.h |1 + 2 files changed, 11

Re: [Qemu-devel] [PATCH v2 4/9] net: use tcp_client_start for tcp client creation

2012-03-05 Thread Orit Wasserman
On 03/05/2012 12:03 PM, Amos Kong wrote: Use tcp_client_start() in those two functions: tcp_start_outgoing_migration() net_socket_connect_init() Signed-off-by: Amos Kong ak...@redhat.com --- migration-tcp.c | 41 + net/socket.c| 41

Re: [Qemu-devel] [PATCH 4/4] add qmp screendump-async

2012-03-05 Thread Alon Levy
On Tue, Feb 28, 2012 at 05:05:32PM -0300, Luiz Capitulino wrote: On Fri, 24 Feb 2012 23:22:05 +0200 Alon Levy al...@redhat.com wrote: This is an across the board change since I wanted to keep the existing (good imo) single graphic_console_init callback setter, instead of introducing a

Re: [Qemu-devel] [PATCH v2 2/9] net: use tcp_server_start() for tcp server creation

2012-03-05 Thread Amos Kong
On 05/03/12 21:27, Orit Wasserman wrote: On 03/05/2012 12:03 PM, Amos Kong wrote: Use tcp_server_start in those two functions: tcp_start_incoming_migration() net_socket_listen_init() Signed-off-by: Amos Kongak...@redhat.com --- migration-tcp.c | 21 + net/socket.c

Re: [Qemu-devel] [PATCH 4/4] add qmp screendump-async

2012-03-05 Thread Alon Levy
On Tue, Feb 28, 2012 at 05:05:32PM -0300, Luiz Capitulino wrote: On Fri, 24 Feb 2012 23:22:05 +0200 Alon Levy al...@redhat.com wrote: This is an across the board change since I wanted to keep the existing (good imo) single graphic_console_init callback setter, instead of introducing a

Re: [Qemu-devel] [SeaBIOS] [Seabios] [PATCH 0/6] 64bit PCI BARs allocations (take 2)

2012-03-05 Thread Kevin O'Connor
On Mon, Mar 05, 2012 at 10:53:25AM +0100, Gerd Hoffmann wrote: Given the churn in this area, I don't want to commit patches that do wholesale code replacement. I'd prefer to see each patch independently add some functionality and perform its related cleanup. Hardly doable, the algorithms

Re: [Qemu-devel] [PATCH v2 1/9] net: introduce tcp_server_start()

2012-03-05 Thread Amos Kong
On 05/03/12 21:25, Orit Wasserman wrote: On 03/05/2012 12:03 PM, Amos Kong wrote: Introduce tcp_server_start() by moving original code in tcp_start_incoming_migration(). Signed-off-by: Amos Kongak...@redhat.com --- net.c | 27 +++ qemu_socket.h |2 ++

Re: [Qemu-devel] [PATCH] osdep: Remove local definition of macro offsetof

2012-03-05 Thread Peter Maydell
On 5 March 2012 13:23, Andreas Färber afaer...@suse.de wrote: Am 05.03.2012 07:22, schrieb Stefan Weil: The macro offsetof is defined in stddef.h. It is conforming to the standards C89, C99 and POSIX.1-2001 (see man page), so it is a sufficiently old standard. Therefore chances are very high

Re: [Qemu-devel] [PATCH v2 0/5] Make rt_clock usage configurable for ARM devices

2012-03-05 Thread Peter Maydell
On 5 March 2012 09:08, Paolo Bonzini pbonz...@redhat.com wrote: Direct usage of rt_clock should be discouraged. For RTC devices the user cannot choose to follow the host clock with respect to NTP adjustment and daylight savings changes.   For other devices it does not provide determinism

[Qemu-devel] [PATCH v2] signrom: Rewrite as python script

2012-03-05 Thread Jan Kiszka
Now that we have a hard dependency on python anyway, we can replace the slow shell script to calculate the option ROM checksum with a fast AND portable python version. Tested both with python 2.7 and 3.1. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Changes in v2: - Switch to GPLv2+.

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Avi Kivity
On 03/05/2012 03:38 PM, Igor Mitsyanko wrote: Short summary: * switch wp groups to bitfield rather than int array * convert sd.c to use memory_region_init_ram() to allocate the wp groups (being careful to use memory_region_set_dirty() when we touch them) * we don't need variable-length

[Qemu-devel] [PATCH v2 2/2] add qmp screendump-async

2012-03-05 Thread Alon Levy
Uses a new console.h function, vga_hw_screen_dump_async. vga_hw_screen_dump_async falls back to hw_vga_screen_dump if there is no hw_vga_screen_dump_async callback provided to graphic_console_init. This is the only case right now, but the up side is that the interface is already implemented.

[Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Alon Levy
adds a handler for the following qmp screendump-async command. graphics_console_init signature change required touching every user, but no implementation of the new vga_hw_screen_dump_async_ptr is provided in this patch. Signed-off-by: Alon Levy al...@redhat.com --- console.c|4

Re: [Qemu-devel] [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait

2012-03-05 Thread Avi Kivity
On 03/05/2012 11:07 AM, Jan Kiszka wrote: On 2012-03-05 09:34, Paolo Bonzini wrote: This is quite ugly. Two threads, one running main_loop_wait and one running qemu_aio_wait, can race with each other on running the same iohandler. The result is that an iohandler could run while the

Re: [Qemu-devel] [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait

2012-03-05 Thread Jan Kiszka
On 2012-03-05 15:24, Avi Kivity wrote: Long-term, I'd like to cut out certain file descriptors from the main loop and process them completely in separate threads (for separate locking, prioritization etc.). Dunno how NBD works, but maybe it should be reworked like this already. Ideally

Re: [Qemu-devel] [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 15:24, Avi Kivity ha scritto: On 03/05/2012 11:07 AM, Jan Kiszka wrote: On 2012-03-05 09:34, Paolo Bonzini wrote: This is quite ugly. Two threads, one running main_loop_wait and one running qemu_aio_wait, can race with each other on running the same iohandler. The result is

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Anthony Liguori
On 03/05/2012 08:16 AM, Alon Levy wrote: adds a handler for the following qmp screendump-async command. graphics_console_init signature change required touching every user, but no implementation of the new vga_hw_screen_dump_async_ptr is provided in this patch. Signed-off-by: Alon

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Igor Mitsyanko
On 03/05/2012 06:13 PM, Avi Kivity wrote: On 03/05/2012 03:38 PM, Igor Mitsyanko wrote: Short summary: * switch wp groups to bitfield rather than int array * convert sd.c to use memory_region_init_ram() to allocate the wp groups (being careful to use memory_region_set_dirty() when we

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 15:47, Anthony Liguori ha scritto: How about coupling the types with independently available commands for now? We would rename 'snapshot' to 'blockdev-snapshot-sync', which does the same thing outside of transactions. The mirror patches would then introduce a 'drive-mirror'

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-05 Thread Anthony Liguori
On 03/05/2012 02:53 AM, Kevin Wolf wrote: Am 01.03.2012 22:10, schrieb Anthony Liguori: On 03/01/2012 05:21 AM, Paolo Bonzini wrote: This implements all ingredients to establish mirrored writes. The drive-reopen command that is used to terminate mirrored writes is not included in this series.

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Avi Kivity
On 03/05/2012 04:37 PM, Igor Mitsyanko wrote: Well, can't you make sd.c target dependent? It's not so nice, but it does solve the problem. OK, but it will turn qemu from it's long term path to suppress *all* target specific code :) The other alternative is to

Re: [Qemu-devel] [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait

2012-03-05 Thread Avi Kivity
On 03/05/2012 04:30 PM, Paolo Bonzini wrote: Il 05/03/2012 15:24, Avi Kivity ha scritto: On 03/05/2012 11:07 AM, Jan Kiszka wrote: On 2012-03-05 09:34, Paolo Bonzini wrote: This is quite ugly. Two threads, one running main_loop_wait and one running qemu_aio_wait, can race with each other

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Anthony Liguori
On 03/05/2012 09:10 AM, Avi Kivity wrote: On 03/05/2012 04:37 PM, Igor Mitsyanko wrote: Well, can't you make sd.c target dependent? It's not so nice, but it does solve the problem. OK, but it will turn qemu from it's long term path to suppress *all* target specific code :) The other

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Alon Levy
On Mon, Mar 05, 2012 at 08:33:06AM -0600, Anthony Liguori wrote: On 03/05/2012 08:16 AM, Alon Levy wrote: adds a handler for the following qmp screendump-async command. graphics_console_init signature change required touching every user, but no implementation of the new

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Avi Kivity
On 03/05/2012 05:15 PM, Anthony Liguori wrote: The other alternative is to s/target_phys_addr_t/uint64_t/ in the memory API. I think 32-on-32 is quite rare these days, so it wouldn't be much of a performance issue. I think this makes sense independent of other discussions regarding fixing

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Peter Maydell
On 5 March 2012 15:10, Avi Kivity a...@redhat.com wrote: I think 32-on-32 is quite rare these days, so it wouldn't be much of a performance issue. 32-on-32 will be the standard case for KVM on ARM I think... -- PMM

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Avi Kivity
On 03/05/2012 05:20 PM, Peter Maydell wrote: On 5 March 2012 15:10, Avi Kivity a...@redhat.com wrote: I think 32-on-32 is quite rare these days, so it wouldn't be much of a performance issue. 32-on-32 will be the standard case for KVM on ARM I think... Won't we be virtualizing LPAE per

  1   2   3   >