[Qemu-devel] [PATCH v11 13/14] target-mips: Add ASE DSP testcases

2012-10-19 Thread Jovanovic, Petar
diff --git a/tests/tcg/mips/mips32-dspr2/dpaqx_sa_w_ph.c b/tests/tcg/mips/mips32-dspr2/dpaqx_sa_w_ph.c new file mode 100644 index 000..65d3993 --- /dev/null +++ b/tests/tcg/mips/mips32-dspr2/dpaqx_sa_w_ph.c @@ -0,0 +1,31 @@ +#includestdio.h +#includeassert.h + +int main() +{ +

[Qemu-devel] [PATCH V3] E1000 RX ring management fix

2012-10-19 Thread Dmitry Fleytman
Following patch fixes improper RX ring management E1000 code Changes from version 2: Commit message beautification Changes from version 1: 1st patch changed so it drops check_rxov field because it is redundant and leads to race conditions See commit description for details 2nd

[Qemu-devel] [PATCH V3] e1000: drop check_rxov, always treat RX ring with RDH == RDT as empty

2012-10-19 Thread Dmitry Fleytman
Real HW always treats RX ring with RDH == RDT as empty. Emulation is supposed to behave the same. Reported-by: Chris Webb chris.w...@elastichosts.com Reported-by: Richard Davies richard.dav...@elastichosts.com Signed-off-by: Dmitry Fleytman dmi...@daynix.com --- hw/e1000.c | 7 ++- 1 file

[Qemu-devel] [PATCH v1 0/7] QOMify pflash_cfi0x + PL353 for Xilinx Zynq

2012-10-19 Thread Peter Crosthwaite
This series adds the PL353 to Xilinx Zynq with both NAND and pflashes attached. Had to QOMify the pflash_cfi0x devices to get them working with PL35x in the least hackish way. Regression tested pflash_cfi_01 using petalogix-ml605 and pflash_cfi_02 tested using zynq. Further testing by clients

[Qemu-devel] [PATCH v1 1/7] pflash_cfi0x: remove unused base field

2012-10-19 Thread Peter Crosthwaite
This field is completely unused. The base address should also be abstracted away from the device anyway. Removed. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/pflash_cfi01.c |2 -- hw/pflash_cfi02.c |4 +--- 2 files changed, 1 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PATCH v1 2/7] pflash_cfi01: remove unused total_len field

2012-10-19 Thread Peter Crosthwaite
This field is completely unused. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/pflash_cfi01.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c index 4f3f5f0..ebc8a57 100644 --- a/hw/pflash_cfi01.c +++

[Qemu-devel] [PATCH v1 4/7] sysbus/sysbus_mmio_map: parameterise mapped region

2012-10-19 Thread Peter Crosthwaite
Add a variant to sysbus_mmio_map that allow specifying a target memory region. The requested device memory region is mapped within the argument target memory region rather than the default (get_system_memory()). Behaviour of original sysbus_mmio_map remains unchanged. The will probably go away or

[Qemu-devel] [PATCH v1 5/7] hw: Model of Primecell pl35x mem controller

2012-10-19 Thread Peter Crosthwaite
Initial device model for the pl35x series of memory controllers. The SRAM interface is just implemented as a passthrough using memory regions. NAND interfaces are modelled. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- default-configs/arm-softmmu.mak |1 +

[Qemu-devel] [PATCH v1 6/7] xilinx_zynq: add pl353

2012-10-19 Thread Peter Crosthwaite
Add the pl353 memory controller with both NAND and parallel flashes attached. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/xilinx_zynq.c | 49 + 1 files changed, 41 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [PATCH v1 7/7] nand: Reset addressing after READSTATUS.

2012-10-19 Thread Peter Crosthwaite
From: Edgar E. Iglesias edgar.igles...@gmail.com Signed-off-by: Edgar E. Iglesias edgar.igles...@gmail.com --- hw/nand.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/nand.c b/hw/nand.c index 01f3ada..f931d0c 100644 --- a/hw/nand.c +++ b/hw/nand.c @@ -478,6

Re: [Qemu-devel] Building QEMU with multiple CPU targets.

2012-10-19 Thread Peter Crosthwaite
Hi All, Thanks for the responses. Ill look into further in the near future, probably starting the the Linker based approaches. Regards, Peter

[Qemu-devel] [PATCH v1 3/7] pflash_cfi0x: QOMified

2012-10-19 Thread Peter Crosthwaite
QOMified the pflash_cfi0x so machine models can connect them up in custom ways. Kept the pflash_cfi0x_register functions as is. They can still be used to create a flash straight onto system memory. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/pflash_cfi01.c | 142

Re: [Qemu-devel] [PATCH 1/6] qdev: rework device properties.

2012-10-19 Thread Markus Armbruster
Eduardo Habkost ehabk...@redhat.com writes: On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote: [...] diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c new file mode 100644 index 000..8b0d0ff --- /dev/null +++ b/hw/qdev-properties.c @@ -0,0 +1,246 @@ Gerd, could

Re: [Qemu-devel] [PATCH 1/6] qdev: rework device properties.

2012-10-19 Thread Markus Armbruster
Jan Kiszka jan.kis...@siemens.com writes: On 2012-10-17 22:14, Eduardo Habkost wrote: On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote: [...] diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c new file mode 100644 index 000..8b0d0ff --- /dev/null +++

Re: [Qemu-devel] [PATCH 03/12] qdev: separate core from the code used only by qemu-system-*

2012-10-19 Thread Markus Armbruster
Eduardo Habkost ehabk...@redhat.com writes: On Wed, Oct 17, 2012 at 01:00:55PM -0500, Anthony Liguori wrote: [...] I don't really understand the split here and the 'system' suffix really doesn't explain it for me. Could you at least add a comment to each of these files explaining what

Re: [Qemu-devel] [PATCH 4/4] net: convert NetClientState to QOM

2012-10-19 Thread Stefan Hajnoczi
On Thu, Oct 18, 2012 at 05:06:33PM +0200, Paolo Bonzini wrote: Il 18/10/2012 16:56, Stefan Hajnoczi ha scritto: -static NetClientInfo net_tap_win32_info = { -.type = NET_CLIENT_OPTIONS_KIND_TAP, -.size = sizeof(TAPState), -.receive = tap_receive, -.cleanup =

Re: [Qemu-devel] [PATCH 13/25] vnc: add error propagation to vnc_display_open

2012-10-19 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 17/10/2012 17:17, Markus Armbruster ha scritto: +fail: +if (!error_is_set(errp)) { +error_set(errp, QERR_VNC_SERVER_FAILED, display); How can we get here with no error set? 1. !vnc_display (first goto fail). This can be fixed

[Qemu-devel] [Bug 1065325] Re: qemu-system-arm hangs on SIGUSR1 on OS X 10.8.2

2012-10-19 Thread Peter Maydell
** Changed in: qemu Status: New = Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1065325 Title: qemu-system-arm hangs on SIGUSR1 on OS X 10.8.2 Status in QEMU: Invalid Bug

Re: [Qemu-devel] [PATCH V3] e1000: drop check_rxov, always treat RX ring with RDH == RDT as empty

2012-10-19 Thread Stefan Hajnoczi
On Fri, Oct 19, 2012 at 07:56:55AM +0200, Dmitry Fleytman wrote: Real HW always treats RX ring with RDH == RDT as empty. Emulation is supposed to behave the same. Reported-by: Chris Webb chris.w...@elastichosts.com Reported-by: Richard Davies richard.dav...@elastichosts.com Signed-off-by:

Re: [Qemu-devel] [PATCH v1 1/7] pflash_cfi0x: remove unused base field

2012-10-19 Thread Peter Maydell
On 19 October 2012 07:40, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: This field is completely unused. The base address should also be abstracted away from the device anyway. Removed. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH 15/25] qemu-sockets: add error propagation to inet_connect_addr

2012-10-19 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 17/10/2012 17:40, Markus Armbruster ha scritto: if (s-current_addr) { while (s-current_addr-ai_next != NULL s-fd 0) { s-current_addr = s-current_addr-ai_next; -s-fd = inet_connect_addr(s-current_addr,

Re: [Qemu-devel] [PATCH v1 2/7] pflash_cfi01: remove unused total_len field

2012-10-19 Thread Peter Maydell
On 19 October 2012 07:40, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: This field is completely unused. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH v2 31/45] mirror: add support for on-source-error/on-target-error

2012-10-19 Thread Kevin Wolf
Am 18.10.2012 16:52, schrieb Paolo Bonzini: Il 18/10/2012 15:56, Kevin Wolf ha scritto: Am 18.10.2012 15:10, schrieb Paolo Bonzini: Il 18/10/2012 15:07, Kevin Wolf ha scritto: +s-synced = false; +if (read) { +return block_job_error_action(s-common, s-common.bs, +

Re: [Qemu-devel] [PATCH v1 4/7] sysbus/sysbus_mmio_map: parameterise mapped region

2012-10-19 Thread Peter Maydell
On 19 October 2012 07:40, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Add a variant to sysbus_mmio_map that allow specifying a target memory region. The requested device memory region is mapped within the argument target memory region rather than the default (get_system_memory()).

Re: [Qemu-devel] [PATCH 20/25] qapi: add socket address types

2012-10-19 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 17/10/2012 18:43, Markus Armbruster ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Acked-by: Luiz Capitulino lcapitul...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qapi-schema.json | 53

Re: [Qemu-devel] [PATCH 22/25] qemu-sockets: add socket_listen, socket_connect, socket_parse

2012-10-19 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: These are QAPI-friendly versions of the qemu-sockets functions. They support IP sockets, Unix sockets, and named file descriptors, using a QAPI union to dispatch to the correct function. Reviewed-by: Luiz Capitulino lcapitul...@redhat.com

Re: [Qemu-devel] [PATCH 23/25] block: add close notifiers

2012-10-19 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: The first user of close notifiers will be the embedded NBD server. It is possible to use them to do some of the ad hoc processing (e.g. for block jobs and I/O limits) that is currently done by bdrv_close. Acked-by: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] nvram and boot order

2012-10-19 Thread David Gibson
On Thu, Oct 18, 2012 at 08:32:54AM +0200, Alexander Graf wrote: On 18.10.2012, at 03:18, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Thu, 2012-10-18 at 11:09 +1100, David Gibson wrote: That's horrible; if you use -boot just once it will clobber a persistent NVRAM's

Re: [Qemu-devel] [PATCH 23/25] block: add close notifiers

2012-10-19 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: The first user of close notifiers will be the embedded NBD server. It is possible to use them to do some of the ad hoc processing (e.g. for block jobs and I/O limits) that is currently done by bdrv_close. If the second sentence is an idea for future

Re: [Qemu-devel] [PATCH 1/6] qdev: rework device properties.

2012-10-19 Thread Michael S. Tsirkin
On Wed, Oct 17, 2012 at 05:14:14PM -0300, Eduardo Habkost wrote: On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote: [...] diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c new file mode 100644 index 000..8b0d0ff --- /dev/null +++ b/hw/qdev-properties.c @@ -0,0

[Qemu-devel] [PATCH v1 0/3] Xilinx Zynq QSPI support

2012-10-19 Thread Peter Crosthwaite
Support for the Quad SPI flash controller in Xilinx Zynq. Peter Crosthwaite (3): m25p80: Support for Quad SPI xilinx_spips: Generalised to model QSPI xilinx_zynq: added QSPI controller hw/m25p80.c | 61 +++- hw/xilinx_spips.c | 289

[Qemu-devel] [PATCH v1 1/3] m25p80: Support for Quad SPI

2012-10-19 Thread Peter Crosthwaite
Added the Quad mode read and write commands. Data remains serialized on a single wire, i.e. the quad mode instructions just behave the same as single mode, with the expection of modelling the varying number of dummy/mode bytes between the address bytes and the first data word. Signed-off-by:

[Qemu-devel] [PATCH v1 3/3] xilinx_zynq: added QSPI controller

2012-10-19 Thread Peter Crosthwaite
Added the QSPI controller to the Zynq. 4 SPI devices are attached to allow modelling of the different geometries. E.G. Dual parallel and dual stacked mode can both be tested with this one arrangement. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/xilinx_zynq.c | 40

Re: [Qemu-devel] [PATCH 24/25] qmp: add NBD server commands

2012-10-19 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Adding an NBD server inside QEMU is trivial, since all the logic is in nbd.c and can be shared easily between qemu-nbd and QEMU itself. The main difference is that qemu-nbd serves a single unnamed export, while QEMU serves named exports. For NBD

Re: [Qemu-devel] [Qemu-trivial] [PATCH] targphys.h: Don't define target_phys_addr_t for user-mode emulators

2012-10-19 Thread Stefan Hajnoczi
On Fri, Oct 12, 2012 at 06:59:44PM +0100, Peter Maydell wrote: Commit 4be403c accidentally defined the target_phys_addr_t type when building user-mode emulators. Since the type doesn't really make any sense except for system emulators, avoid defining it when building in user mode.

Re: [Qemu-devel] [PATCH] target-arm/neon_helper: Remove obsolete FIXME comment

2012-10-19 Thread Stefan Hajnoczi
On Fri, Oct 12, 2012 at 07:07:23PM +0100, Peter Maydell wrote: Commit 33ebc29 fixed the bugs in the implementation of VQRSHL, but forgot to remove the FIXME comment... Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/neon_helper.c |1 - 1 file changed, 1

Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands

2012-10-19 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Acked-by: Luiz Capitulino lcapitul...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hmp-commands.hx | 29 + hmp.c | 55 +++ hmp.h

Re: [Qemu-devel] [PATCH 22/25] qemu-sockets: add socket_listen, socket_connect, socket_parse

2012-10-19 Thread Paolo Bonzini
These are QAPI-friendly versions of the qemu-sockets functions. They support IP sockets, Unix sockets, and named file descriptors, using a QAPI union to dispatch to the correct function. Reviewed-by: Luiz Capitulino lcapitul...@redhat.com Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [Qemu-trivial] [PATCH 00/11] static patches

2012-10-19 Thread Stefan Hajnoczi
On Sun, Oct 14, 2012 at 07:58:48PM +, Blue Swirl wrote: I made a small tool to detect unused functions and variables. Here's some fixes. Blue Swirl (11): target-sparc: make do_unaligned_access static vl.c: add missing static vnc: add missing static and remove unused functions

[Qemu-devel] [PATCH v1 2/3] xilinx_spips: Generalised to model QSPI

2012-10-19 Thread Peter Crosthwaite
Extended the xilinx spips controller to model QSPI as well. Paremeterised the operational difference with the normal spi controller (num_ss_bits, width of the tx/rx fifo heads etc.). Multiple bus functionality is modelled (needed for QSPI dual parallel mode. LQSPI is modelled. Signed-off-by:

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Remove unused parameters from main function

2012-10-19 Thread Stefan Hajnoczi
On Mon, Oct 15, 2012 at 07:45:40AM +0200, Stefan Weil wrote: This modification is required if compiler option -Wunused-parameter is activated. Signed-off-by: Stefan Weil s...@weilnetz.de --- configure |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, applied to the

Re: [Qemu-devel] [PATCH 20/25] qapi: add socket address types

2012-10-19 Thread Paolo Bonzini
Two port members, one is 'str', the other is 'uint16'. Ugly. This is because port can be a service name. Using a union was deemed overkill. Two ways to reduce the ugliness: 1. Make @to a string, too. Yes, users don't normally want to specify the upper bound as service name,

Re: [Qemu-devel] [PATCH] net/tap-win32: Fix compiler warning caused by missing include statement

2012-10-19 Thread Stefan Hajnoczi
On Wed, Oct 17, 2012 at 07:53:50PM +0200, Stefan Weil wrote: The include file for net_init_tap was missing: net/tap-win32.c:703: warning: no previous prototype for ‘net_init_tap’ Signed-off-by: Stefan Weil s...@weilnetz.de --- net/tap-win32.c |1 + 1 file changed, 1 insertion(+)

Re: [Qemu-devel] nvram and boot order

2012-10-19 Thread Alexander Graf
On 19.10.2012, at 10:24, David Gibson d...@au1.ibm.com wrote: On Thu, Oct 18, 2012 at 08:32:54AM +0200, Alexander Graf wrote: On 18.10.2012, at 03:18, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Thu, 2012-10-18 at 11:09 +1100, David Gibson wrote: That's horrible; if

Re: [Qemu-devel] [PATCH 13/25] vnc: add error propagation to vnc_display_open

2012-10-19 Thread Paolo Bonzini
I tried to split this one into many commits, but I wasn't sure it was worth to make a mini-series out of one function. In retrospect it was. Review of a long series is unrewarding when the patches are all perfect ;) LOL, will split the patch anyway. Paolo

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] ui/vnc-jobs.c: Fix minor typos in comments

2012-10-19 Thread Stefan Hajnoczi
On Thu, Oct 18, 2012 at 05:40:53PM +0100, Peter Maydell wrote: Fix some minor typos/grammar errors in comments. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- v1-v2: reinstated carelessly dropped 'if', noted by Stefan Weil. ui/vnc-jobs.c | 16 1 file

Re: [Qemu-devel] [PATCH V3] e1000: drop check_rxov, always treat RX ring with RDH == RDT as empty

2012-10-19 Thread Dmitry Fleytman
Thanks Stefan, It was my very first idea to drop check_rxov and solve the problem, however for some reason I was sure that it required to emulate real HW behavior. I'm glad we clarified this. Regards, Dmitry Fleytman On Fri, Oct 19, 2012 at 9:52 AM, Stefan Hajnoczi stefa...@gmail.com wrote:

Re: [Qemu-devel] [PATCH 15/25] qemu-sockets: add error propagation to inet_connect_addr

2012-10-19 Thread Paolo Bonzini
If yes, but it's healed later in the series, the temporary breakage still needs to be spelled out in the commit message. No, it's not healed, which is why it's mentioned in the commit message that future work is needed. I really hate reward submissions of tons of useful work with

[Qemu-devel] [PULL 0/6] Trivial patches for 13 to 19 October 2012

2012-10-19 Thread Stefan Hajnoczi
The following changes since commit b6348f29d033d5a8a26f633d2ee94362595f32a4: target-arm/translate: Fix RRX operands (2012-10-17 19:56:46 +0200) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to

[Qemu-devel] [PATCH 3/6] target-arm/neon_helper: Remove obsolete FIXME comment

2012-10-19 Thread Stefan Hajnoczi
From: Peter Maydell peter.mayd...@linaro.org Commit 33ebc29 fixed the bugs in the implementation of VQRSHL, but forgot to remove the FIXME comment... Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- target-arm/neon_helper.c | 1 - 1

[Qemu-devel] [PATCH 5/6] net/tap-win32: Fix compiler warning caused by missing include statement

2012-10-19 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de The include file for net_init_tap was missing: net/tap-win32.c:703: warning: no previous prototype for ‘net_init_tap’ Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- net/tap-win32.c | 1 + 1 file changed, 1

[Qemu-devel] [PATCH 4/6] configure: Remove unused parameters from main function

2012-10-19 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de This modification is required if compiler option -Wunused-parameter is activated. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH 6/6] ui/vnc-jobs.c: Fix minor typos in comments

2012-10-19 Thread Stefan Hajnoczi
From: Peter Maydell peter.mayd...@linaro.org Fix some minor typos/grammar errors in comments. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- ui/vnc-jobs.c | 16 1 file

Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands

2012-10-19 Thread Paolo Bonzini
Why's nbd_server_add not needed in HMP? Oh, it's because HMP's nbd_server_start auto-adds *all* block devices, unlinke QMP's nbd-server-start. Are you sure that's a good idea? Yes. Now that we have QMP we can go back and treat HMP as (mostly) a debugging interface as it was meant to be.

Re: [Qemu-devel] [PATCH v4 24/26] qidl: add QAPI-based code generator

2012-10-19 Thread Paolo Bonzini
In general, if struct X is QIDL_DECLAREd and only has q_immutable fields, it can be taken as q_immutable. Hence for example the base class should not need any decoration; ISADevice will be seen as q_immutable, but PCIDevice will be seen as serialized. But even if a

Re: [Qemu-devel] [PATCH v1 4/7] sysbus/sysbus_mmio_map: parameterise mapped region

2012-10-19 Thread Peter Crosthwaite
On Fri, Oct 19, 2012 at 6:06 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 19 October 2012 07:40, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Add a variant to sysbus_mmio_map that allow specifying a target memory region. The requested device memory region is mapped within

[Qemu-devel] [PATCH 2/6] targphys.h: Don't define target_phys_addr_t for user-mode emulators

2012-10-19 Thread Stefan Hajnoczi
From: Peter Maydell peter.mayd...@linaro.org Commit 4be403c accidentally defined the target_phys_addr_t type when building user-mode emulators. Since the type doesn't really make any sense except for system emulators, avoid defining it when building in user mode. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH] cadence_uart: More debug information

2012-10-19 Thread Peter Crosthwaite
Add more helpful debug information to the cadence UART. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/cadence_uart.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/cadence_uart.c b/hw/cadence_uart.c index f8afc4e..483a316 100644 ---

Re: [Qemu-devel] [PATCH 2/8] block: bdrv_img_create(): add param_list argument

2012-10-19 Thread Kevin Wolf
Am 18.10.2012 19:18, schrieb Luiz Capitulino: On Thu, 18 Oct 2012 10:33:30 -0300 Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 18 Oct 2012 13:57:45 +0200 Kevin Wolf kw...@redhat.com wrote: Am 17.10.2012 21:35, schrieb Luiz Capitulino: If set returns a copy of the parameter list

[Qemu-devel] [PATCH 1/6] ui/vnc: Only report/use TIGHT_PNG encoding if enabled.

2012-10-19 Thread Stefan Hajnoczi
From: Joel Martin git...@martintribe.org If TIGHT_PNG is not enabled by the --enable-vnc-png configure flag then do not report to the client that it is supported. Also, since TIGHT_PNG is the same as the TIGHT encoding but with the filter/copy replaced with PNG data, adding it to the supported

Re: [Qemu-devel] [PATCH] qmp: handle stop/cont in INMIGRATE state

2012-10-19 Thread Paolo Bonzini
What happens is that a stop command while in INMIGRATE state will just be ignored. Actually, any stops while in a state that pauses vCPUs are ignored. Also, I don't understand what you meant by racy, care to elaborate? Case 1: Case 2: user runs qemu

Re: [Qemu-devel] [PATCH 1/4] usb: split packet result into actual_length + status

2012-10-19 Thread Gerd Hoffmann
Hi, This patch unfortunately is somewhat invasive, since makeing the qemu usb core deal with this requires changes everywhere. This patch only prepares the usb core for this, all the hcd / device changes are done in such a way that there are no functional changes. /me likes it. When

Re: [Qemu-devel] [PATCH v2 31/45] mirror: add support for on-source-error/on-target-error

2012-10-19 Thread Paolo Bonzini
Then let's break the API. Not immediately, I think we can keep some useless compatibility fields in the implementation of background jobs that would only be needed to allow the block job commands to be a wrapper (mostly 'bool is_block_job' and 'BlockDriverState bs', I think; maybe even just

Re: [Qemu-devel] [PATCH 23/25] block: add close notifiers

2012-10-19 Thread Paolo Bonzini
@@ -1098,12 +1106,13 @@ void bdrv_reopen_abort(BDRVReopenState *reopen_state) void bdrv_close(BlockDriverState *bs) { bdrv_flush(bs); -if (bs-drv) { -if (bs-job) { -block_job_cancel_sync(bs-job); -} -bdrv_drain_all(); +if

Re: [Qemu-devel] [PATCH] e1000: Don't set the Capabilities List bit

2012-10-19 Thread Philipp Hahn
Hello, On Wednesday 21 September 2011 22:06:25 dann frazier wrote: The Capabilities Pointer is NULL, so this bit shouldn't be set. The state of this bit doesn't appear to change any behavior on Linux/Windows versions we've tested, but it does cause Windows' PCI/PCI Express Compliance Test to

Re: [Qemu-devel] [PATCH v1 3/7] pflash_cfi0x: QOMified

2012-10-19 Thread Paolo Bonzini
bdrvIl 19/10/2012 08:40, Peter Crosthwaite ha scritto: QOMified the pflash_cfi0x so machine models can connect them up in custom ways. Kept the pflash_cfi0x_register functions as is. They can still be used to create a flash straight onto system memory. Signed-off-by: Peter Crosthwaite

[Qemu-devel] [PATCH] Fix missing TRACE exception

2012-10-19 Thread Julio Guerra
This patch fixes bug 1031698 : https://bugs.launchpad.net/qemu/+bug/1031698 If we look at the (truncated) translation of the conditional branch instruction in the test submitted in the bug post, the call to the exception helper is missing in the bne-false chunk of translated code : IN: bne-

Re: [Qemu-devel] [PATCH 1/4] usb: split packet result into actual_length + status

2012-10-19 Thread Hans de Goede
Hi, On 10/19/2012 11:00 AM, Gerd Hoffmann wrote: Hi, This patch unfortunately is somewhat invasive, since makeing the qemu usb core deal with this requires changes everywhere. This patch only prepares the usb core for this, all the hcd / device changes are done in such a way that there are

Re: [Qemu-devel] [PATCH v1 6/7] xilinx_zynq: add pl353

2012-10-19 Thread Peter Maydell
On 19 October 2012 07:40, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Add the pl353 memory controller with both NAND and parallel flashes attached. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/xilinx_zynq.c | 49

Re: [Qemu-devel] [PATCH] add bochs dispi interface framebuffer driver

2012-10-19 Thread Vasilis Liaskovitis
Hi, On Thu, Mar 08, 2012 at 11:13:46AM +0100, Gerd Hoffmann wrote: This patchs adds a frame buffer driver for (virtual/emulated) vga cards implementing the bochs dispi interface. Supported hardware are the bochs vga card with vbe extension and the qemu standard vga. The driver uses a fixed

Re: [Qemu-devel] [PATCH v1 3/7] pflash_cfi0x: QOMified

2012-10-19 Thread Peter Maydell
On 19 October 2012 07:40, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: QOMified the pflash_cfi0x so machine models can connect them up in custom ways. Kept the pflash_cfi0x_register functions as is. They can still be used to create a flash straight onto system memory.

Re: [Qemu-devel] [PATCH] cadence_uart: More debug information

2012-10-19 Thread Peter Maydell
On 19 October 2012 10:08, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Add more helpful debug information to the cadence UART. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH] e1000: Don't set the Capabilities List bit

2012-10-19 Thread Philipp Hahn
Hello, On Friday 19 October 2012 11:59:24 Philipp Hahn wrote: On Wednesday 21 September 2011 22:06:25 dann frazier wrote: ... -/* TODO: we have no capabilities, so why is this bit set? */ -pci_set_word(pci_conf + PCI_STATUS, PCI_STATUS_CAP_LIST); ... Since cmask[PCI_STATUS=6] =

Re: [Qemu-devel] [PATCH v4 4/4] qemu-config: Add new -add-fd command line option

2012-10-19 Thread Kevin Wolf
Am 18.10.2012 23:37, schrieb Corey Bryant: On 10/18/2012 04:43 PM, Eric Blake wrote: On 10/18/2012 01:19 PM, Corey Bryant wrote: This option can be used for passing file descriptors on the command line. It mirrors the existing add-fd QMP command which allows an fd to be passed to QEMU

[Qemu-devel] [PATCH] ui/spice: support websockets ports

2012-10-19 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- Spice package is not yet available, I assumed it will be the next version, 0.12.1, for the added API spice_server_set_ws_ports. Patches are on spice-devel and git is at http://cgit.freedesktop.org/~alon/spice master branch

Re: [Qemu-devel] [PATCH v1 7/7] nand: Reset addressing after READSTATUS.

2012-10-19 Thread Peter Maydell
On 19 October 2012 07:40, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: From: Edgar E. Iglesias edgar.igles...@gmail.com Signed-off-by: Edgar E. Iglesias edgar.igles...@gmail.com --- hw/nand.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/nand.c

Re: [Qemu-devel] [PATCH v1 7/7] nand: Reset addressing after READSTATUS.

2012-10-19 Thread Edgar E. Iglesias
On Fri, Oct 19, 2012 at 12:59:49PM +0100, Peter Maydell wrote: On 19 October 2012 07:40, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: From: Edgar E. Iglesias edgar.igles...@gmail.com Signed-off-by: Edgar E. Iglesias edgar.igles...@gmail.com --- hw/nand.c |6 ++ 1

[Qemu-devel] [PATCH 1/6] tcg/tcg.h: Duplicate global TCG variables in TCGContext

2012-10-19 Thread Evgeny
Signed-off-by: Evgeny e.voevo...@samsung.com --- tcg/tcg.h |6 ++ 1 file changed, 6 insertions(+) diff --git a/tcg/tcg.h b/tcg/tcg.h index 7bafe0e..8ba021a 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -422,6 +422,12 @@ struct TCGContext { int temps_in_use; int goto_tb_issue_mask;

[Qemu-devel] [PATCH 5/6] TCG: Use gen_opparam_buf from context instead of global variable.

2012-10-19 Thread Evgeny
Signed-off-by: Evgeny e.voevo...@samsung.com --- tcg/tcg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 3da1d83..77b15a0 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -302,7 +302,7 @@ void tcg_func_start(TCGContext *s) #endif

[Qemu-devel] [PATCH 0/6] *** TCG global variables clean-up ***

2012-10-19 Thread Evgeny
This set of patches moves global variables to tcg_ctx: gen_opc_ptr gen_opparam_ptr gen_opc_buf gen_opparam_buf Where it was possible I used s-... Where we don't have an interface to pass a pointer to tcg_ctx, I used tcg_ctx.xxx since it is a global variable too. Build tested for all targets.

[Qemu-devel] [PATCH 2/6] TCG: Use gen_opc_ptr from context instead of global variable.

2012-10-19 Thread Evgeny
Signed-off-by: Evgeny e.voevo...@samsung.com --- target-alpha/translate.c |8 ++--- target-arm/translate.c|8 ++--- target-cris/translate.c | 10 +++--- target-i386/translate.c |8 ++--- target-lm32/translate.c | 10 +++--- target-m68k/translate.c

[Qemu-devel] [PATCH 4/6] TCG: Use gen_opc_buf from context instead of global variable.

2012-10-19 Thread Evgeny
Signed-off-by: Evgeny e.voevo...@samsung.com --- target-alpha/translate.c |6 ++-- target-arm/translate.c|8 +++--- target-cris/translate.c |8 +++--- target-i386/translate.c |8 +++--- target-lm32/translate.c |8 +++--- target-m68k/translate.c

Re: [Qemu-devel] [PATCH 2/8] block: bdrv_img_create(): add param_list argument

2012-10-19 Thread Luiz Capitulino
On Fri, 19 Oct 2012 11:13:39 +0200 Kevin Wolf kw...@redhat.com wrote: Am 18.10.2012 19:18, schrieb Luiz Capitulino: On Thu, 18 Oct 2012 10:33:30 -0300 Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 18 Oct 2012 13:57:45 +0200 Kevin Wolf kw...@redhat.com wrote: Am 17.10.2012

Re: [Qemu-devel] [PATCH v3 10/16] qmp: add drive-mirror command

2012-10-19 Thread Kevin Wolf
Am 18.10.2012 16:49, schrieb Paolo Bonzini: This adds the monitor commands that start the mirroring job. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- v2-v3: bdrv_is_inserted pulled before dereference of bs-drv blockdev.c | 124

[Qemu-devel] [PATCH v2 1/2] target-arm: Use TCG operation for Neon 64 bit negation

2012-10-19 Thread Peter Maydell
Use the TCG operation to do Neon 64 bit negations rather than calling a helper routine for it. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/helper.h |1 - target-arm/neon_helper.c |6 -- target-arm/translate.c |4 +++- 3 files changed, 3

[Qemu-devel] [PATCH 6/6] TCG: Remove unused global variables

2012-10-19 Thread Evgeny
Signed-off-by: Evgeny e.voevo...@samsung.com --- tcg/tcg.c |4 tcg/tcg.h |4 translate-all.c |3 --- 3 files changed, 11 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 77b15a0..b5729f1 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -100,10 +100,6 @@ const

Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands

2012-10-19 Thread Paolo Bonzini
Il 19/10/2012 14:44, Markus Armbruster ha scritto: Apropos hotplug. The only way to unexport a block device is to stop the NBD server outright. Once the device backend has been exported, unplugging the device gets rid of the frontend, but the backend stays until you stop the NBD server, or

Re: [Qemu-devel] [PATCH v4 4/4] qemu-config: Add new -add-fd command line option

2012-10-19 Thread Corey Bryant
On 10/19/2012 07:05 AM, Kevin Wolf wrote: Am 18.10.2012 23:37, schrieb Corey Bryant: On 10/18/2012 04:43 PM, Eric Blake wrote: On 10/18/2012 01:19 PM, Corey Bryant wrote: This option can be used for passing file descriptors on the command line. It mirrors the existing add-fd QMP command

Re: [Qemu-devel] [PATCH v3 10/16] qmp: add drive-mirror command

2012-10-19 Thread Paolo Bonzini
Il 19/10/2012 14:54, Kevin Wolf ha scritto: +proto_drv = bdrv_find_protocol(target); +if (!proto_drv) { +error_set(errp, QERR_INVALID_BLOCK_FORMAT, format); This error message is still not fixed, and totally confusing, pointing at the wrong cause. No matter what changes to

[Qemu-devel] [PATCH v2 2/2] target-arm: Implement abs_i32 inline rather than as a helper

2012-10-19 Thread Peter Maydell
Implement abs_i32 inline (with movcond) rather than using a helper function. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/helper.c|5 - target-arm/helper.h|1 - target-arm/translate.c | 11 +-- 3 files changed, 9 insertions(+), 8 deletions(-)

Re: [Qemu-devel] [PATCH] qmp: handle stop/cont in INMIGRATE state

2012-10-19 Thread Luiz Capitulino
On Fri, 19 Oct 2012 05:27:29 -0400 (EDT) Paolo Bonzini pbonz...@redhat.com wrote: What happens is that a stop command while in INMIGRATE state will just be ignored. Actually, any stops while in a state that pauses vCPUs are ignored. Also, I don't understand what you meant by racy, care

[Qemu-devel] [PATCH v2 0/2] target-arm: inline abs, 64-bit negate

2012-10-19 Thread Peter Maydell
Two minor patches which inline some operations rather than using helper functions. The 64 bit negate is a no-brainer since there's a simple TCG op for it. For abs we implement in terms of movcond: movi_i32 tmp6,$0x0 neg_i32 tmp7,tmp5 movcond_i32 tmp5,tmp5,tmp6,tmp5,tmp7,gt which the x86-64

Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands

2012-10-19 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Why's nbd_server_add not needed in HMP? Oh, it's because HMP's nbd_server_start auto-adds *all* block devices, unlinke QMP's nbd-server-start. Are you sure that's a good idea? Yes. Now that we have QMP we can go back and treat HMP as (mostly) a

[Qemu-devel] [PATCH 3/6] TCG: Use gen_opparam_ptr from context instead of global variable.

2012-10-19 Thread Evgeny
Signed-off-by: Evgeny e.voevo...@samsung.com --- gen-icount.h |2 +- tcg/tcg-op.h | 254 +- tcg/tcg.c| 36 - 3 files changed, 146 insertions(+), 146 deletions(-) diff --git a/gen-icount.h b/gen-icount.h index

Re: [Qemu-devel] [PATCH 25/25] hmp: add NBD server commands

2012-10-19 Thread Luiz Capitulino
On Fri, 19 Oct 2012 04:58:45 -0400 (EDT) Paolo Bonzini pbonz...@redhat.com wrote: Why's nbd_server_add not needed in HMP? Oh, it's because HMP's nbd_server_start auto-adds *all* block devices, unlinke QMP's nbd-server-start. Are you sure that's a good idea? Yes. Now that we

[Qemu-devel] [PULL 00/29] qemu-sockets error propagation + NBD server

2012-10-19 Thread Paolo Bonzini
Anthony, The following changes since commit b6348f29d033d5a8a26f633d2ee94362595f32a4: target-arm/translate: Fix RRX operands (2012-10-17 19:56:46 +0200) are available in the git repository at: git://github.com/bonzini/qemu.git nbd-next for you to fetch changes up to

[Qemu-devel] [PATCH 04/29] qemu-sockets: add nonblocking connect for Unix sockets

2012-10-19 Thread Paolo Bonzini
This patch mostly mimics what was done to TCP sockets, but simpler because there is only one address to try. It also includes a free EINTR bug fix. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-char.c| 2 +- qemu-sockets.c | 77

[Qemu-devel] [PATCH 07/29] migration: use qemu-sockets to establish Unix sockets

2012-10-19 Thread Paolo Bonzini
This makes migration-unix.c again a cut-and-paste job from migration-tcp.c, exactly as it was in the beginning. :) Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- migration-unix.c | 94 ++-- migration.c | 4 +-- migration.h | 4

[Qemu-devel] [PATCH 11/29] nbd: ask and print error information from qemu-sockets

2012-10-19 Thread Paolo Bonzini
Before: $ qemu-system-x86_64 nbd:localhost:12345 inet_connect_opts: connect(ipv4,yakj.usersys.redhat.com,127.0.0.1,12345): Connection refused qemu-system-x86_64: could not open disk image nbd:localhost:12345: Connection refused After: $ x86_64-softmmu/qemu-system-x86_64

[Qemu-devel] [PATCH 05/29] migration: avoid using error_is_set and thus relying on errp != NULL

2012-10-19 Thread Paolo Bonzini
The migration code is using errp to detect internal errors, this means that it relies on errp being non-NULL. No impact so far because our only QMP clients (the QMP marshaller and HMP) never pass a NULL Error **. But if we had others, this patch would make sure that migration can work with a

  1   2   3   >